Commit Graph

215 Commits

Author SHA1 Message Date
Andreas Lauser
be1fd178f1 do not squelch unused argument warnings using casts to void
casts to void are not very explicit (in particular if they do not come
with a comment about their purpose). Instead, the names of unused
argument are now simply commented out or the OPM_UNUSED macro is used
for the few cases where this is not possible.
2015-09-23 12:35:45 +02:00
Andreas Lauser
9778a853e3 Merge pull request #61 from osae/fix-index-mixup
Buxfix - compressed versus cartesian index.
2015-09-23 12:34:51 +02:00
osae
4c08b6e5f4 Buxfix - compressed versus cartesian index. 2015-09-21 13:03:29 +02:00
Atgeirr Flø Rasmussen
044edeac4f Merge pull request #60 from atgeirr/silence-warning
Comment out unused argument.
2015-09-17 15:05:39 +02:00
Atgeirr Flø Rasmussen
337cf41d96 Comment out unused argument. 2015-09-17 15:04:46 +02:00
Atgeirr Flø Rasmussen
fd4b4bf6d1 Merge pull request #57 from atgeirr/silence-warnings
Silence warnings
2015-09-15 17:43:56 +02:00
Atgeirr Flø Rasmussen
1ebec84bd1 Remove unused code. 2015-09-15 17:41:09 +02:00
Atgeirr Flø Rasmussen
4768861535 Merge pull request #58 from totto82/fix_fam2
Use tabulated oil saturations directly in KROG for familyII
2015-09-15 14:37:39 +02:00
Tor Harald Sandve
ace6a25210 Use tabulated oil saturations directly in KROG for familyII
Revert bug introduced when refactoring the code in the process of
supporting two-phase simulations.
2015-09-15 13:35:09 +02:00
Atgeirr Flø Rasmussen
bba5e33973 Suppressed more warnings. 2015-09-14 17:15:04 +02:00
Atgeirr Flø Rasmussen
a5ecbd765c Silence unused argument warnings. 2015-09-11 14:32:59 +02:00
Atgeirr Flø Rasmussen
a15fa4444e Delete unused argument. 2015-09-11 14:32:36 +02:00
Atgeirr Flø Rasmussen
b3f6740a68 Silence more unused argument warnings. 2015-09-11 13:46:45 +02:00
Atgeirr Flø Rasmussen
db3d60eeae Avoid shadowing variables. 2015-09-11 13:38:09 +02:00
Atgeirr Flø Rasmussen
1f42957755 Silence some unused argument warnings. 2015-09-11 13:37:31 +02:00
Andreas Lauser
1b794a44f6 Merge pull request #55 from andlaus/wet_gas_fixes
blackoil: fix some screw ups with wet gas
2015-09-04 18:14:35 +02:00
Andreas Lauser
fb79b732d8 blackoil: fix some screw ups with wet gas 2015-09-04 14:33:19 +02:00
Andreas Lauser
ac14e53129 Merge pull request #50 from andlaus/make_twophase_ecl_satfuncs_work
Make twophase ecl satfuncs work
2015-09-03 14:53:18 +02:00
Andreas Lauser
b314ee4ba7 Merge pull request #54 from andlaus/fix_Evaluation_on_dune-2.3
Evaluation: forward declare Opm::LocalAd::abs() instead of including Math.hpp
2015-09-03 11:34:55 +02:00
Andreas Lauser
8c3db57025 Evaluation: forward declare Opm::LocalAd::abs() instead of including Math.hpp
this solves an "order of #include" problem on Dune before 2.4
2015-09-03 11:20:26 +02:00
Andreas Lauser
03129c01f6 make the ECL twophase code work
this has been tested with a real deck now.
2015-09-03 10:55:46 +02:00
Andreas Lauser
d7b5a1b2e3 EpsScalingInfo: move the code which handles individual tables to their own functions
this avoids copy-and-pasting stuff in the twophase case.
2015-09-03 10:52:32 +02:00
Andreas Lauser
820046191e Merge pull request #53 from andlaus/fix_Evaluation_with_FieldMatrix
make the Evaluation template class work better as field type for Dune::FieldMatrix/Dune::FieldVector
2015-09-02 13:21:59 +02:00
Andreas Lauser
8ef6f7bfc2 make the Evaluation template class work better as field type for Dune::FieldMatrix/Dune::FieldVector
IMO this doges the edges of the c++ specifcation quite a bit too hard,
but at least with Dune >= 2.4 it should now work unconditionally (and
for older dune versions, the #error has been demoted to a #warning)
2015-09-02 13:15:08 +02:00
Andreas Lauser
9b72e928c6 Merge pull request #52 from andlaus/fix_TableManager_fallout
fix the fallout of the TableManager
2015-09-02 12:33:35 +02:00
Andreas Lauser
e08691f90a fix the fallout of the TableManager
the problem is that the EclMaterialLawManager is currently not used in
any opm-material unit test, so the module compiled just fine without
these fixes. Mental note to myself: add such a unit test!
2015-09-02 12:29:45 +02:00
Joakim Hove
a76cb4cfc6 Merge pull request #49 from joakim-hove/table-refactor
Using TableManager class to get input tables.
2015-09-02 11:57:42 +02:00
Andreas Lauser
327c8a306d Merge pull request #51 from andlaus/blackoil_fixes
Blackoil fixes
2015-09-01 16:07:00 +02:00
Andreas Lauser
543c3cb603 fix some bugs in WetGasPvt
so far, this has never been tested on a deck which features vaporized oil.
2015-09-01 16:05:05 +02:00
Andreas Lauser
5edc12bef2 BlackOilFluidSystem: make the order of the phases identical to opm-core
this simplifies comparisons and mixing code.
2015-09-01 16:05:05 +02:00
Andreas Lauser
1eee36c9ab Merge pull request #48 from andlaus/add_twophase_multiplexer
implement a material law for twophase ECL simulations
2015-09-01 12:35:03 +02:00
Andreas Lauser
9bfc26a2d8 implement a material law for twophase ECL simulations
the basic idea is that implements the threephase API, but only
calculates the quantities for the selected fluid phases.
2015-09-01 12:33:43 +02:00
Andreas Lauser
0db938f199 Merge pull request #47 from andlaus/change_EPS_conventions
EclEpsTwoPhaseLaw: clean up the terminology it uses for variable names
2015-09-01 12:32:35 +02:00
Andreas Lauser
ee61bc00e7 EclEpsTwoPhaseLaw: clean up the terminology it uses for variable names
now all variables should contain either "scaled" or "unscaled".
2015-09-01 12:30:04 +02:00
Joakim Hove
8cf963ba3f Using TableManager class to get input tables. 2015-09-01 12:21:11 +02:00
Andreas Lauser
8c612009ac Merge pull request #46 from andlaus/implement_slgof_support
ECL satfuncs: implement support for the SLGOF keyword
2015-08-25 21:55:29 +02:00
Andreas Lauser
a58531c3de fix the satfunc family detection code in ECL scaling points class
thanks to [at]totto82 for finding this.
2015-08-25 11:38:31 +02:00
Andreas Lauser
5e447cb83a ECL satfuncs: implement support for the SLGOF keyword
if my understanding of this keyword is correct, it is identical to
SGOF except that the saturation column is specified in terms of Swco +
So instead of as Sg
2015-08-24 21:51:46 +02:00
Tor Harald Sandve
6c403d457e Merge pull request #45 from andlaus/shift_gas_saturations_again
shift the gas saturations of the oil relperm tables again
2015-08-24 15:30:12 +02:00
Andreas Lauser
c6cafe3a7a shift the gas saturations of the oil relperm tables again
it seems like this was accidentally undone while resolving conflicts in #42.
2015-08-24 13:52:09 +02:00
Andreas Lauser
086b129773 Merge pull request #43 from andlaus/fix_compile
fix compilation in debug mode
2015-08-19 16:07:59 +02:00
Andreas Lauser
6e27d1ab1d fix compilation in debug mode 2015-08-19 16:07:07 +02:00
Andreas Lauser
5490017b3f Merge pull request #42 from totto82/family2
Support for Family II saturation functions input
2015-08-19 13:06:06 +02:00
Andreas Lauser
220fe9cffa Merge pull request #38 from andlaus/SplineLaw_implement_twophase_inversion_api
SplineTwoPhaseMaterial: implement the two-phase inversion functions
2015-08-19 11:02:56 +02:00
Tor Harald Sandve
3c7a087d3d Merge pull request #41 from andlaus/ecl_satfunc_improvements
Ecl satfunc improvements
2015-08-19 10:43:26 +02:00
Tor Harald Sandve
4431ff6d7d Add function to check saturation function family
Adapt to change in the EclipseState i.e. the method
to get the saturation function family is no longer available and a
similar method is implemented in EclMaterialLawManager
2015-08-19 09:29:20 +02:00
Andreas Lauser
ef28c31368 EclHysteresisTwoPhaseLaw: use '<=' instead of '<' to decide whether to use the imbibition or the drainage curve
this does not change the results in any way, but for the Norne deck,
it improves performance (i.e., It Must Be Right (TM))...
2015-08-18 17:35:35 +02:00
Andreas Lauser
57948012a5 PiecewiseLinearTwoPhaseMaterial: remove unnecessary calls to min() and max()
it is nicer to read like this and it may improve performance a tiny
bit.
2015-08-18 17:35:22 +02:00
Andreas Lauser
0edc7b5f70 EclMaterialLawManager: shift the saturations of the oil phase the in gas-oil twophase system by the connate water saturation
for the oil phase relperm, the gas saturation column of the SGOF
keyword actually is Sg - Swco. why? it's ECL! don't ask why!
2015-08-18 17:24:28 +02:00
Tor Harald Sandve
3cffd067e3 PiecewiseLinearTwoPhaseMaterial: make the saturation columns of the quantities independent 2015-08-18 17:24:28 +02:00