Arne Morten Kvarving
1dd4500bd2
update downstream list
...
ewoms moved in the hierarchy
2016-11-22 15:24:56 +01:00
Jørgen Kvalsvik
cadb14c9e8
Ask for reference depth at timestep.
2016-11-22 14:22:09 +01:00
Atgeirr Flø Rasmussen
1e462f4c04
Merge pull request #1107 from GitPaean/fixing_findWellNode
...
Adding a flag to WellCollection whether group control active
2016-11-17 23:27:06 +01:00
Kai Bao
4427c85d77
a flag to WellCollection whether group control active
2016-11-17 16:26:19 +01:00
Atgeirr Flø Rasmussen
af874ada54
Merge pull request #1106 from atgeirr/remove-moved-tests
...
Remove tests that were moved to opm-output.
2016-11-17 10:41:06 +01:00
Atgeirr Flø Rasmussen
3c35e767d4
Remove tests that were moved to opm-output.
2016-11-17 09:47:58 +01:00
Bård Skaflestad
1429046029
Merge pull request #1105 from andlaus/fix_valgrind_errors
...
fix some valgrind errors in the init code
2016-11-16 19:08:48 +01:00
Andreas Lauser
1d98c3b8ca
fix some valgrind errors in the EQUIL code
...
this fixes some valgrind errors while doing the twophase capability
for flow_ebos: In all previously tested cases, these errors were
probably non-fatal because the memory illegally accessed here is
likely to be allocated (but after this function was finished it
contained garbage).
note that I'm not completely sure if this patch is semantically
correct, so I'd appreciate some input who understands it. (what is
"z"?)
2016-11-16 17:20:24 +01:00
Kai Bao
fda1016532
warning fixed related to petsc
2016-11-16 15:35:35 +01:00
Atgeirr Flø Rasmussen
054fa92e61
Merge pull request #1104 from GitPaean/fixing_findWellNode
...
rewriting the findWellNode function
2016-11-16 15:00:13 +01:00
Kai Bao
6e4f9e708e
rewriting the findWellNode function
...
with assuming we should always find the well in the well collection.
2016-11-16 14:27:15 +01:00
Joakim Hove
df920e4970
Merge pull request #1101 from jokva/changes-in-grouptree
...
GroupTree interface changed upstream
2016-11-16 13:26:58 +01:00
Atgeirr Flø Rasmussen
c901e2ec7c
Merge pull request #1088 from GitPaean/group_control
...
group control_updating well production targets within a group.
2016-11-16 13:20:04 +01:00
Kai Bao
c3b00dc7fd
fixing the comments.
...
No change in the functions and results.
2016-11-16 11:40:10 +01:00
Kai Bao
708bfd169b
addressing a few comments.
2016-11-16 09:51:06 +01:00
Kai Bao
bf2f9b3f06
adding target_updated_ flag to WellNode
...
to save some repeated efforts when updating Well Targets.
2016-11-16 09:43:28 +01:00
Kai Bao
55eec0b2ed
checking whehter need to update before updateWellTargets.
2016-11-15 13:56:49 +01:00
Kai Bao
f9f5bacee4
cleaning up more unused flag from WellsGroup
2016-11-11 11:29:12 +01:00
Joakim Hove
0cf4021698
Merge pull request #1102 from jokva/stack-allocd-items
...
Use new DeckItem constructor interface.
2016-11-11 11:07:34 +01:00
Kai Bao
91b8c872eb
removing a few not-used function with the new strategy.
2016-11-10 17:50:30 +01:00
Kai Bao
95997e208c
different strategy is using when updating the well targets
...
When the group has wells both under individual control and group
control, since the well rates under individual control changes each
iteration, the well targets for this kind of group need to be updated
each iteration.
When we change to use implicit well potentials later, which is supposed
to be more accurate, we probably should always (unless we decided not to)
update the well targets each iteration.
2016-11-10 17:22:25 +01:00
Kai Bao
085785bf26
adding function findWellNode() to WellCollection
...
to return the WellNode* instead of WellGroupInterface*
2016-11-10 16:28:40 +01:00
Kai Bao
b319e1a75d
cleaning up and adding more comments for better understanding.
...
No functional change.
2016-11-10 16:28:40 +01:00
Kai Bao
3e8b1bdb82
applying the efficiency factor to VREP control.
2016-11-10 16:28:40 +01:00
Kai Bao
76a2108ea9
adding VREP injection support.
...
not handling multiple injection wells for moment.
2016-11-10 16:28:40 +01:00
Kai Bao
88181f4948
using variable only_group instead of hard-coded false.
...
when applying group production control.
2016-11-10 16:28:40 +01:00
Kai Bao
06d380df51
correcting the typo in efficiency
...
It was efficicency, which causes inconvenience when searching variables
or functions.
2016-11-10 16:28:40 +01:00
Kai Bao
2b289f8964
adding basic support for group injection control.
...
more testing will be required later.
2016-11-10 16:28:40 +01:00
Kai Bao
63e5755fa9
applying efficiency factor to the group control.
2016-11-10 16:28:40 +01:00
Kai Bao
a0e1fcf89d
function for accumulative efficiency factor for WellNode
...
This is the final efficiency factor that goes to the source/sink terms
in the material balance equations.
2016-11-10 16:28:40 +01:00
Kai Bao
013c907e66
adding efficiency factor to the WellsGroupInterface.
...
The one for the WellNode should be specified with WEFAC, which we are
not handling for the moment, so we just set it to be 1.0 for the moment.
2016-11-10 16:28:40 +01:00
Kai Bao
2e135388a6
refactoring function updateWellProductionTargets()
...
To handle different types of control mode.
2016-11-10 16:28:40 +01:00
Kai Bao
b8ac674f9b
When NONE is specified, no group control enforcement.
...
NONE is specified in GCONPROD or GCONINJE.
2016-11-10 16:28:40 +01:00
Kai Bao
65d61d1c4f
output cleanining up
2016-11-10 16:28:40 +01:00
Kai Bao
352c185edf
removing the use of cast between base class and derived class
...
between WellsGroupInterface and WellsGroup, WellNode.
2016-11-10 16:28:40 +01:00
Kai Bao
32e9b26ce8
revising updateWellTargets to remove the dependency of WellState
...
avoiding template using here. It is possible we will need WellState
eventually, while only using the well_rates for the moment.
2016-11-10 16:28:40 +01:00
Kai Bao
fec53a1af5
fixing the comilation problem from rebasing.
2016-11-10 16:28:40 +01:00
Kai Bao
e183ab6ccd
revising injectionGuideRate and productionGuideRate
...
for WellNode. It gives a better logic.
2016-11-10 16:28:40 +01:00
Kai Bao
7295f26f54
adding updateWellInjectionTargets updateWellProductionTargets
...
For WellsGroup. At least for the current moment, the updation of the
well targets for injectors and producers should be handled in a
seprate way.
2016-11-10 16:28:40 +01:00
Kai Bao
46a9a62741
functions for indicating injection and production upating.
...
it is for WellCollection, which is logically wrong. It should be done in
the group level, while things will be different for multi-level groups.
The current implementation basically works for current needs, that we
only have one group.
2016-11-10 16:28:40 +01:00
Kai Bao
6942a986da
adding isProducer() and isProjector() to wellNode class.
...
Did not see type() function there, while it should still be a okay idea.
2016-11-10 16:28:40 +01:00
Kai Bao
e28715b601
parameter forced to only_group from applyInjGroup applyProdGroup
...
forced and only_group basically mean two opposite things. Having both of
them in the same context will be really confusing and error-prone.
And also, we do not do anything forcedly. We do things base on what
setup tells us to do.
Only_group may not be the final name, while deinitely a better one than
forced.
2016-11-10 16:28:40 +01:00
Kai Bao
a438680fb0
putting more things in the prototyping test.
2016-11-10 16:28:40 +01:00
Kai Bao
0d5a86cc71
keeping adding group control related in.
2016-11-10 16:28:40 +01:00
Kai Bao
f628064884
keeping putting group controlling in.
2016-11-10 16:28:40 +01:00
Kai Bao
4214cfec83
adding a non-const wellCollection() in WellsManager.
...
For the WellModel from the simulator to use. Not decided totally,
well_collection might need to be updated during the simualtion due
to the update the target of wells.
2016-11-10 16:28:40 +01:00
Kai Bao
36bedfcf67
not returning zero from double WellNode::productionGuideRate
...
Current understanding. Two ways might prevent to return the guide_rate here
1. preventing the well from group control with keyword WGRUPCON
2. the well violating some limits and working under limits. We do not have strategy
to handle this situation yet.
2016-11-10 16:28:40 +01:00
Kai Bao
3bdf0eae11
Not return from the WellNode:applyInjGroupControl
...
unless we prevent the well from group control with keyword WGRUPCON.
2016-11-10 16:28:40 +01:00
Kai Bao
c5958da6c9
To make the injection well be able to receive the target.
...
Very hacky way here. The logic of the code is that only
a well is specified under GRUP control, it is under group
control. Which is not the case observed from the result.
From the result, if we specify group control with GCONPROD
and WCONPROD for a well, it looks like the well will be
under group control. TODO: make the logic correct here
instead of using `false` here.
2016-11-10 16:28:40 +01:00
Kai Bao
a0d3ceff62
group can be both injection group and production group.
...
Change if else to two ifs.
2016-11-10 16:28:40 +01:00