OilfieldToolsNet/opm-simulators
4
0
Fork 0
mirror of https://github.com/OPM/opm-simulators.git synced 2024-12-28 02:00:59 -06:00
Code Issues Packages Projects Releases Wiki Activity

changed: measure relative error in a more standard way (knuth)

Browse Source 
|(value-expected)/expected| < tol or |(value-expected)/value| < tol
instead of
|(value-expected)/(value+expected)|

this is how boost::test defines its check
This commit is contained in:
Arne Morten Kvarving 2020-10-27 09:55:43 +01:00
parent 778f486bcc
commit 6d1f8c75d6
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/test_equil.cc
View File

@ -59,8 +59,8 @@
#define CHECK_CLOSE(value, expected, reltol) \
{ \
if (std::fabs((expected) - (value)) > 1e-14 && \
std::fabs(((expected) - (value))/((expected) + (value))) > reltol) \
if (std::fabs((expected) - (value)) > reltol*std::fabs(expected) && \
std::fabs((expected) - (value)) > reltol*std::fabs(value)) \
throw std::runtime_error("Test failed: " + std::to_string(value) + " != " + std::to_string(expected)); \
}