OilfieldToolsNet/opm-simulators
4
0
Fork 0
mirror of https://github.com/OPM/opm-simulators.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity
18,283 Commits 24 Branches 102 Tags 90 MiB
0c1ea3ee4d
Commit Graph

5854 Commits

Author SHA1 Message Date
Tobias Meyer Andersen
b905b5ec33 correct comment 2024-08-06 15:26:25 +02:00
Arne Morten Kvarving
a65ddff8f6 changed: BlackoilModel parameters moved to Opm::Parameters namespace 2024-08-06 09:50:02 +02:00
Arne Morten Kvarving
b69439aa1f changed: EclWriter parameters moved to Opm::Parameters namespace 2024-08-06 09:50:02 +02:00
Arne Morten Kvarving
917fdbedfd changed: FlowProblem parameters moved to Opm::Parameters namespace 2024-08-06 09:50:02 +02:00
Arne Morten Kvarving
2a52cf8134 changed: Damaris parameters moved to Opm::Parameters namespace 2024-08-06 09:50:02 +02:00
Arne Morten Kvarving
d75b91aaba changed: SimulatorFullyImplicitBlackoil parameters moved to Opm::Parameters namespace 2024-08-06 09:50:02 +02:00
Arne Morten Kvarving
466e26d330 changed: FlowMain parameters moved to Opm::Parameters namespace 2024-08-06 09:50:02 +02:00
Arne Morten Kvarving
4fc1487a9d changed: FlowBaseVanguard parameters moved to Opm::Parameters namespace 2024-08-06 09:50:02 +02:00
Arne Morten Kvarving
7aeaf6f216 changed: VtkTracerModule parameters moved to Opm::Parameters namespace 2024-08-06 07:38:14 +02:00
Arne Morten Kvarving
f9016b02ef changed: NonlinearSolver parameters moved to Opm::Parameters namespace 2024-08-06 07:31:57 +02:00
Arne Morten Kvarving
00d902d79f changed: OutputBlackoilModule parameters moved to Opm::Parameters namespace 2024-08-06 07:25:35 +02:00
Arne Morten Kvarving
0745a5e496 changed: FlowLinearSolver parameters moved to Opm::Parameters namespace 2024-08-06 07:18:28 +02:00
Arne Morten Kvarving
5f5697ff91 changed: AdaptiveTimeStepping parameters moved to Opm::Parameters namespace 2024-08-06 07:11:45 +02:00
Arne Morten Kvarving
6f7fcb5872 changed: EclTimeStepping parameters moved to Opm::Parameters namespace 2024-08-06 07:05:08 +02:00
Lisa Julia Nebel
8cd53ecea7 Change type of possibleFutureConnections to std::unordered_map<std::string, std::set<int>> 
Now it contains the global ids of the perforated cells for each well instead of the coordinates ijk
 2024-08-05 19:31:54 +02:00
Kjetil Olsen Lye
51e8bb7191
Merge pull request #5392 from multitalentloes/add_CuBuffer 
Add CuBuffer and CuView
 2024-08-05 15:29:59 +02:00
Tobias Meyer Andersen
30013ea9d0 remove last two unneeded size t conversions 2024-08-05 13:12:35 +02:00
Kai Bao
7803c55a88 avoiding exception from std::stoi("") 
when not setting OMP_NUM_THREADS in the environment.
 2024-08-05 11:48:54 +02:00
Tobias Meyer Andersen
62ee7bf495 fix indendation and needless conversions 2024-08-05 11:47:18 +02:00
Arne Morten Kvarving
22a116728c changed: LinearSolverVerbosity parameter moved to Opm::Parameters namespace 2024-08-02 09:04:08 +02:00
Arne Morten Kvarving
f251370a52 changed: EnableGravity parameter moved to Opm::Parameters namespace 2024-08-02 09:04:08 +02:00
Tor Harald Sandve
5d19739c8c
Merge pull request #5490 from totto82/useCellTempRESV 
Use cell temperature in perforated cell to compute reservoir rates
 2024-08-02 08:34:22 +02:00
Tobias Meyer Andersen
e8ac31da16 add CuBuffer and CuView to cuISTL 2024-08-01 16:38:16 +02:00
Atgeirr Flø Rasmussen
c26271f774
Merge pull request #5493 from akva2/move_vtk_params_to_params 
Move vtk parameters to Opm::Parameters namespace
 2024-08-01 13:01:51 +02:00
Tor Harald Sandve
f678c082de Adapt to inj prefix and cleanup 2024-08-01 11:23:00 +02:00
Tor Harald Sandve
5f8916c0c3 Use cell temperature in perforated cell to compute reservoir rates 2024-08-01 11:14:29 +02:00
Markus Blatt
03dc006b88
Merge pull request #5488 from lisajulia/fix/ACTIONX-COMPDAT 
Fix/actionx compdat
 2024-07-30 17:18:04 +02:00
Arne Morten Kvarving
c8a3729199 changed: VtkWriteTemperature parameter moved to Opm::Parameters namespace 2024-07-30 13:29:31 +02:00
Arne Morten Kvarving
ec01d7694b changed: VtkPrimaryVarsModule parameters moved to Opm::Parameters namespace 2024-07-30 13:12:54 +02:00
Arne Morten Kvarving
825540691c changed: VtkCompositionModule parameters moved to Opm::Parameters namespace 2024-07-30 13:12:54 +02:00
Arne Morten Kvarving
1759d37f89 changed: VtkBlackoilModule parameters moved to Opm::Parameters namespace 2024-07-30 13:12:54 +02:00
Arne Morten Kvarving
22794f83d1 changed: VtkDiffusionModule parameters moved to Opm::Parameters namespace 2024-07-30 13:12:54 +02:00
Arne Morten Kvarving
58bb7da544 changed: VtkMultiPhaseModule parameters moved to Opm::Parameters namespace 2024-07-30 13:12:54 +02:00
Arne Morten Kvarving
24c60e256f openclSolverBackend: fix shadowing type alias 2024-07-30 11:05:48 +02:00
Arne Morten Kvarving
405a907d63 anonymize unused parameters to quell compiler warnings 2024-07-30 10:55:53 +02:00
Arne Morten Kvarving
2a9077a45c fix macro formatting 2024-07-30 10:55:40 +02:00
Lisa Julia Nebel
efb18d0027 Add possible future connections to the grid methods that handle the well connections 2024-07-29 09:59:52 +02:00
David Landa Marban
8320a9abdf Output support for RSWSAT and RVWSAT 2024-07-17 13:00:38 +02:00
Markus Blatt
6e74fea547
Merge pull request #5477 from lisajulia/feature/metis-support 
Add the metis partitioner as a command line option as well
 2024-07-17 07:32:39 +02:00
Markus Blatt
ca2ef490aa
Merge pull request #5408 from BigDataAccelerate/cpr_rocsparse 
rocsparse CPR initial version
 2024-07-16 18:57:40 +02:00
Lisa Julia Nebel
371fbdfc03 Include <boost/version.hpp> before the macro BOOST_VERSION is checked 2024-07-16 17:39:32 +02:00
Lisa Julia Nebel
653cb28bc2 Add the metis partitioner as a command line option as well 2024-07-16 17:39:28 +02:00
Lisa Julia Nebel
e2126ae817 Use the failure flag of the tasklet runner to detect a failure while writing output and throw an error if that happens 2024-07-15 08:51:25 +02:00
Razvan Nane
a79d4aff5a fix rocalutionSolver 2024-07-12 13:31:17 +02:00
Vegard Kippe
a078eaacd3 Removing trailing 'p' 2024-07-11 18:15:16 +02:00
Vegard Kippe
dd08952967 Update after move of ThreadsPerProcess from Properties to Parameters 2024-07-11 15:55:34 +02:00
Vegard Kippe
14818028f0 Handle empty or invalied OMP_NUM_THREADS by Flow default and warn if a valid value overrides --threads-per-process 2024-07-11 15:52:20 +02:00
Markus Blatt
93e06d2187
Merge pull request #5473 from vkip/avoid_mpi_int_overflow 
Avoid buffers exceeding intmax in MPI calls
 2024-07-10 17:24:05 +02:00
Vegard Kippe
fae49636cc Addressing review comments (changed assert to throw, put chunked broadcast in private method) 2024-07-09 19:15:50 +02:00
Vegard Kippe
99d5a147b1 Fix broadcast and initialize int_pos properly.. 2024-07-09 15:02:15 +02:00
Vegard Kippe
c10695c5d5 Switch to using size_t instead of int for buffer position, and properly account for MPI using int 2024-07-09 13:48:04 +02:00
Kjetil Olsen Lye
f3b5e0d14d
Merge pull request #5433 from multitalentloes/useRecomendedBlockSize 
Autotune thread block size
 2024-07-08 14:17:39 +02:00
Tobias Meyer Andersen
844c7d9f67 use std::numerics for long max values 2024-07-05 11:07:58 +02:00
Bård Skaflestad
758a5f0dfd
Merge pull request #5450 from blattms/feature/remove-axisCentroid-copy 
[refactor] Remove unnecessary copy in axisCentroid and simply code.
 2024-07-04 23:04:21 +02:00
Markus Blatt
0caf92c6a6
Merge pull request #5448 from atgeirr/ensure-initialized-members-bdystate 
Ensure all members are initialized in FlowProblem::boundaryFluidState().
 2024-07-04 16:43:05 +02:00
Markus Blatt
3ee2830d28 Change distanceVector_ to take the element index instead of centroid 2024-07-04 14:40:28 +02:00
Bård Skaflestad
0406d199ab
Merge pull request #5465 from akva2/fix_damaris 
add missing include and damaris reference file update support
 2024-07-04 09:04:14 +02:00
Kai Bao
706fa281a1
Merge pull request #4935 from plgbrts/auto-choke 
WIP: Enabling automatic choke to model a sub-sea manifold in an extended network
 2024-07-03 21:29:50 +02:00
Paul
f9d82c6042 adressing several reviewers comments 2024-07-03 16:55:00 +02:00
Paul
6e76602e8f changed assessing safe THP range 2024-07-03 16:54:24 +02:00
Paul
393c70a83e clean up and improvements according reviewer comments 2024-07-03 16:54:05 +02:00
Paul
1ddf675cfd moved common thp calculation to updateWellControls 2024-07-03 16:53:51 +02:00
Paul
6ddf5dd01b allow individual well constraints 2024-07-03 16:53:29 +02:00
Paul
36dcf233c5 simplyfying code as some logic is moved to the parser 2024-07-03 16:52:11 +02:00
Bård Skaflestad
efa0895fcd
Merge pull request #5462 from GitPaean/handle_group_well_action_local 
make sure a well exists in the process before closing it due to group action
 2024-07-03 11:33:29 +02:00
Arne Morten Kvarving
d26ec065f3 add missing include 2024-07-03 11:02:16 +02:00
Arne Morten Kvarving
74cd10b1f2 avoid using deprecated type 2024-07-03 07:58:07 +02:00
Arne Morten Kvarving
48344facd4 add virtual destructor to class with virtual members 2024-07-02 22:41:48 +02:00
Paul
b2258dcf90 autochoke producers control mode set to THP 2024-07-02 12:13:56 +02:00
Paul
30e1f5178c Automatic choke 2024-07-02 12:13:52 +02:00
Kai Bao
ce05406483 make sure a well exists in the process 
before closing it due to group action
 2024-07-01 22:00:39 +02:00
Arne Morten Kvarving
fb6286d795 changed: PredeterminedTimeStepsFile parameter moved to Opm::Parameters namespace 2024-07-01 17:52:10 +02:00
Arne Morten Kvarving
dfcf2358fe changed: RestartTime parameter moved to Opm::Parameters namespace 2024-07-01 17:52:10 +02:00
Arne Morten Kvarving
b4c6a1a240 changed: InitialTimeStepSize parameter moved to Opm::Parameters namespace 2024-07-01 17:52:10 +02:00
Arne Morten Kvarving
1f967940f1 changed: EndTime parameter moved to Opm::Parameters namespace 2024-07-01 17:52:10 +02:00
Arne Morten Kvarving
1e0f2b61b6 changed: PrintParameters parameter moved to Opm::Parameters namespace 2024-07-01 17:52:10 +02:00
Arne Morten Kvarving
0db393fc07 changed: PrintProperties parameter moved to Opm::Parameters namespace 2024-07-01 17:52:10 +02:00
Arne Morten Kvarving
82cd3a2e01 changed: NewtonMaxIterations parameter moved to Opm::Parameters namespace 2024-07-01 14:13:48 +02:00
Arne Morten Kvarving
8def6b722b changed: NewtonTargetIterations parameter moved to Opm::Parameters namespace 2024-07-01 14:13:48 +02:00
Arne Morten Kvarving
0342566fd6 changed: NewtonMaxError parameter moved to Opm::Parameters namespace 2024-07-01 14:13:48 +02:00
Arne Morten Kvarving
514eddc950 changed: NewtonTolerance parameter moved to Opm::Parameters namespace 2024-07-01 14:13:48 +02:00
Arne Morten Kvarving
389ea1ef8b changed: NewtonWriteConvergence parameter moved to Opm::Parameters namespace 2024-07-01 14:13:48 +02:00
Arne Morten Kvarving
1a63dcdf8b changed: NewtonVerbose parameter moved to Opm::Parameters namespace 2024-07-01 14:13:48 +02:00
Bård Skaflestad
9f8075e8a0
Merge pull request #5455 from akva2/fvbasediscretization_param_split 
Adjust to to changes in fvbaseproperties.hh (moving of parameters to Opm::Parmeters namespace)
 2024-07-01 13:22:26 +02:00
Arne Morten Kvarving
d4422742a2 AquiferAnalytical: add missing include 2024-07-01 12:06:47 +02:00
Arne Morten Kvarving
5514ebf4e0 AquiferNumerical: add missing include 2024-07-01 11:20:57 +02:00
Arne Morten Kvarving
74a4ab7823 changed: EnableThermodynamicHints parameter moved to Opm::Parameters namespace 2024-06-28 15:26:30 +02:00
Arne Morten Kvarving
1f6ddb052d changed: EnableStorageCache parameter moved to Opm::Parameters namespace 2024-06-28 15:13:13 +02:00
Arne Morten Kvarving
02f1c6c230 changed: EnableIntensiveQuantitiesCache parameter moved to Opm::Parameters namespace 2024-06-28 14:59:38 +02:00
Arne Morten Kvarving
f95ec4daa1 changed: MaxTimeStepDivisions parameter moved to Opm::Parameters namespace 2024-06-28 14:43:11 +02:00
Arne Morten Kvarving
325b841771 changed: MinTimeStepSize parameter moved to Opm::Parameters namespace 2024-06-28 14:43:11 +02:00
Arne Morten Kvarving
e08b6b1163 changed: MaxTimeStepSize parameter moved to Opm::Parameters namespace 2024-06-28 14:43:11 +02:00
Arne Morten Kvarving
6a03394d5b changed: EnableVtkOutput parameter moved to Opm::Parameters namespace 2024-06-28 14:43:11 +02:00
Arne Morten Kvarving
b3fae7f0f9 changed: OutputDir parameter moved to Opm::Parameters namespace 2024-06-28 14:43:11 +02:00
Arne Morten Kvarving
da4471acfa changed: EnableGridAdaptation parameter moved to Opm::Parameters namespace 2024-06-28 14:43:11 +02:00
Arne Morten Kvarving
afa62ee428 changed: ThreadsPerProcess parameter moved to Opm::Parameters namespace 2024-06-28 14:43:11 +02:00
Tobias Meyer Andersen
0d8bf905d8 remove dead code 2024-06-28 14:38:25 +02:00
Tobias Meyer Andersen
3cb8298e3a Pick blocksize automatically for CUDA cards. 
Calibrate the best size for AMD cards.
This will be improved in a following PR
 2024-06-28 14:36:00 +02:00
Bård Skaflestad
0c71d0701c Add MPI Support to Saturation Function Consistency Checks 
This commit adds a new public member function

    SatfuncConsistencyChecks<>::collectFailures(root, comm)

which aggregates consistency check violations from all ranks in the
MPI communication object 'comm' onto rank 'root' of 'comm'.  This
amounts to summing the total number of violations from all ranks and
potentially resampling the failure points for reporting purposes.

To this end, extract the body of function processViolation() into a
general helper which performs reservoir sampling and records point
IDs and which uses a call-back function to populate the check values
associated to a single failed check.  Re-implement the original
function in terms of this helper by wrapping exportCheckValues() in
a lambda function.  Extract similar helpers for numPoints() and
anyFailedChecks(), and add a new helper function

    SatfuncConsistencyChecks<>::incorporateRankViolations()

which brings sampled points from an MPI rank into the 'root's
internal data structures.

One caveat applies here.  Our current approach to collecting check
failures implies that calling member function reportFailures() is
safe only on the 'root' process in a parallel run.  On the other
hand functions anyFailedChecks() and anyFailedCriticalChecks() are
safe, and guaranteed to return the same answer, on all MPI ranks.

On a final note, the internal helper functions are at present mostly
implemented in terms of non-owning pointers.  I intend to switch to
using 'std::span<>' once we enable C++20 mode.
 2024-06-28 11:04:53 +02:00
Bård Skaflestad
ce7d415e4d
Merge pull request #5447 from blattms/feature/hide-comp-by-dune 
[refactor] Use DUNE's dot product to hide code complexity.
 2024-06-27 15:28:55 +02:00
Bård Skaflestad
0267a3612f
Merge pull request #5446 from atgeirr/fix-uninitialized-member 
Initialize member for WellState serialization test constructor.
 2024-06-27 15:28:31 +02:00
Markus Blatt
d7c869d01a [refactor] Remove unnecessary copy in axisCentroid and simply code. 
We stored 3 copies of each cell centroid in axisCentroid. This seemed
to be a waste of memory and also made the function distanceVector_ hard
to understand.

With this change we omit this copy of information and simplify distanceVector_
 2024-06-27 15:15:33 +02:00
Kjetil Olsen Lye
9b414419e7
Merge pull request #5404 from multitalentloes/add_dilu_LU_splitting 
Add cudilu lu splitting
 2024-06-27 14:30:45 +02:00
Razvan Nane
f063f6776e remove dependency of std::thread on openmp 2024-06-27 14:06:22 +02:00
Atgeirr Flø Rasmussen
a3839aaeb8 Ensure all members are initialized in boundaryFluidState(). 
Also restructure to loop over active phases instead of all
canonical phases.
 2024-06-27 13:43:46 +02:00
Markus Blatt
f6a4d7b076 [refactor] Use DUNE's do product to hide code complexity. 
this removes some explicit loops.
 2024-06-27 13:29:55 +02:00
Atgeirr Flø Rasmussen
34d44876fb Initialize member for test constructor. 2024-06-27 11:24:54 +02:00
Tobias Meyer Andersen
65aa334313 formalize new fromMatrix 2024-06-26 15:41:42 +02:00
Tobias Meyer Andersen
605e32c54b use camelCase, remove commented code 2024-06-26 15:34:47 +02:00
Tobias Meyer Andersen
d6f8678617 use unique_ptr consistently for delayed instantiation 2024-06-26 15:31:52 +02:00
Bård Skaflestad
c3939c5444 Add New Platform for Saturation Function Consistency Checks 
The intention is that this will ultimately replace the existing
RelpermDiagnostics component which does not really work in parallel
and which does not report enough context to help diagnose underlying
issues.  For now, though, we just add the shell of a new set of
checks and hook that up to the build.

Class SatfuncConsistencyChecks<Scalar> manages a configurable set of
consistency checks, the implementations of which must publicly
derive from SatfuncConsistencyChecks<Scalar>::Check.  Client code
will configure a set of checks by first calling

    SatfuncConsistencyChecks<Scalar>::resetCheckSet()

then register individual checks by calling

    SatfuncConsistencyChecks<Scalar>::addCheck()

and finally build requisite internal structures by calling

    SatfuncConsistencyChecks<Scalar>::finaliseCheckSet()

Client code will then run the checks by calling

    SatfuncConsistencyChecks<Scalar>::checkEndpoints()

typically in a loop.  Class SatfuncConsistencyChecks<Scalar> will
count consistency check failures and attribute these to each
individual check as needed.  We also maintain separate counts for
"Standard" and "Critical" failures.  The former will typically
generate warnings while the latter will typically cause the
simulation run to stop.  Individual checks get to decide which check
is "Critical", and client code gets to decide how to respond to
"Critical" failures.

Member function SatfuncConsistencyChecks<Scalar>::reportFailures()
will generate a textual report of the known set of consistency check
failures at a give severity level.

As an internal implementation detail, SatfuncConsistencyChecks uses
"reservoir sampling"
(https://en.wikipedia.org/wiki/Reservoir_sampling) to track details
about individual failed checks.  We maintain at most a fixed number
of individual points (constructor argument).
 2024-06-26 12:17:00 +02:00
Bård Skaflestad
ac42250b25
Merge pull request #5402 from totto82/output_wetting_hyst 
Output maximum/minimum saturations directly for restart hysteresis
 2024-06-26 12:15:20 +02:00
Kai Bao
eb83fff9d5
Merge pull request #5435 from steink/updates_in_preparation_for_5157 
Minor updates in preparation for New defaults #5157.
 2024-06-26 00:24:29 +02:00
Tor Harald Sandve
230656ec31 updateInitialHystParams 2024-06-25 12:55:02 +02:00
Bård Skaflestad
26cd7ab993 Move opm/core/props to opm/simulators/utils 
The opm/core directory is no longer meaningful, and it contains only
components which might collectively be described as simulator
utilities.
 2024-06-25 12:22:09 +02:00
Stein Krogstad
fd199d2558 Rewrite to properly loop over components 2024-06-25 11:46:53 +02:00
Stein Krogstad
1efcd2c936 Fix potential for solvent + adjust perforation pressures 2024-06-25 11:46:53 +02:00
Arne Morten Kvarving
981a5f8a14 clean up some comments 
- simulator note was copied from the typetag dependent class (EclWriter)
- opm-output is no longer a separate module
 2024-06-25 10:59:57 +02:00
Kai Bao
d7d74d3a3e
Merge pull request #5424 from GitPaean/fixing_wecon 
WECON RATE limit should not be applied if the well is under zero group rate target
 2024-06-24 19:02:53 +02:00
Kai Bao
f99956c452
Merge pull request #5432 from vkip/gconprod_item11to13 
Allow GCONPROD item 11-13 to actually take effect.
 2024-06-24 18:59:29 +02:00
Kai Bao
6ac7f8fdaf not applying WECON RATE limit 
when the well is under zero group target.
 2024-06-24 14:42:10 +02:00
Razvan Nane
1477a4d76e cleanup 2024-06-24 13:36:36 +02:00
Razvan Nane
deeb8a8582 fix opencl ilu jacobi threadcopy 2024-06-24 13:18:04 +02:00
Razvan Nane
7ce693ba06 fix verbose opencl preconditioner 2024-06-24 13:18:04 +02:00
Markus Blatt
363eaaa57b
Merge pull request #5434 from blattms/bugfix/do-not-count-nan-as-errors 
[fix] Do not count experiencing nans as error in PRT file.
 2024-06-20 16:18:49 +02:00
Markus Blatt
9dbaad2b3e
Merge pull request #5423 from blattms/bugfix/mswell-exceptions-are-problems 
Only indicate problems for exceptions whem updating well potentials,
 2024-06-20 14:33:17 +02:00
Tor Harald Sandve
a419390854
Merge pull request #5407 from totto82/fix_drsdt 
avoid mass creation with drsdt
 2024-06-20 12:14:22 +02:00
Markus Blatt
238b7b2980 [fix] Do not count experiencing nans as error in PRT file. 
The simulation will just chop the time step and continue.
Note, that the error count in the PRT file is used by engineers to
decide whether a simulation was successfull. Hence the error count
should not be increased here.
 2024-06-20 10:40:37 +02:00
Bård Skaflestad
acb124bbdc
Merge pull request #5426 from totto82/output_every_timestep 
fix option for output every timestep
 2024-06-19 12:09:34 +02:00
Bård Skaflestad
46523e7cd9
Merge pull request #5430 from atgeirr/fix-damaris-logging-parallel 
Add and use DamarisOutput::handleError() helper.
 2024-06-19 11:30:08 +02:00
Vegard Kippe
ca1331fe08 Allow GCONPROD item 11-13 to actually take effect. 2024-06-19 10:47:43 +02:00
Atgeirr Flø Rasmussen
2c99a84c87 Add and use DamarisOutput::handleError() helper. 
This should improve error handling in parallel, and ensure
Damaris problems are logged properly.
 2024-06-19 10:30:38 +02:00
Tobias Meyer Andersen
82ff782d5f clang format 2024-06-18 11:42:00 +02:00
Tobias Meyer Andersen
2b9c81fe09 use getCudaRecomendedMaxPotentialBlocksize 2024-06-18 11:34:31 +02:00
Tor Harald Sandve
4f2311d1b2 Output maximum/minimum saturations directly for restart hysteresis 2024-06-18 10:39:19 +02:00
Tor Harald Sandve
366f3a2944 fix option for output every timestep 2024-06-14 15:03:43 +02:00
Vegard Kippe
683dc715e2 Do NOT delete files recursively - causes massive problems if outputdir is not specified.. 2024-06-14 13:36:15 +02:00
Tor Harald Sandve
151bba43a7
Merge pull request #5268 from svenn-t/tracer_dis_vap 
Partitioning tracers
 2024-06-14 09:08:12 +02:00
Markus Blatt
58ede5e789 Only indicate problems for exceptions whem updating well potentials, 
Nearly all exceptions throw when computing well potentoals will not
abort the simulator but result in timestep chops. Hence those should not be
counted as errors (e.g. by calling the OPM_*THROW* macros) and be
reported in the PRT file.

This change will cause at least two more  occurences (in
MSWellHelpers) to be treated as problems. For this we added a new
helper function.
 2024-06-12 14:25:37 +02:00
Svenn Tveit
87362d5037 Accumulate segment rates and minor fixes 2024-06-12 14:18:32 +02:00
David Landa Marban
80e00f4516 Fix to error in Clang: use 'template' keyword to treat 'data' ... 2024-06-11 09:31:48 +02:00
Bård Skaflestad
b0ee6b9c94
Merge pull request #5419 from GitPaean/only_trans_2 
trying to release global transmissibility earlier to flatten the peak memory usage in the function finishInit()
 2024-06-10 18:13:53 +02:00
Kai Bao
fd5e9d167f addressing reviewing comments OPM/opm-simulators#5419 2024-06-10 16:08:44 +02:00
Kai Bao
062a98b305 restruct so that we can release the global trans earlier 
in the funciton finishInit().
 2024-06-10 16:08:44 +02:00
Svenn Tveit
84cdef1135 Fix solution tracers and well output. 
-Only output or restart solution tracers for gas/oil tracers with DISGAS/VAPOIL enabled (no solution tracers in water phase!).
-Initial tracers (free/solution) will be set to zero initially if TBLK/TVDP is not given.
- Do not calculate mass transfer between free and solution tracers if it is not necessary.
-Calculate well rates using updated tracer concentrations
 2024-06-10 14:50:56 +02:00
Markus Blatt
6921db4282 omit unnescessary function parameter for EDINCC 2024-06-10 14:50:55 +02:00
Svenn Tveit
adc36d64a5 Output rates to multisegment wells 2024-06-10 14:50:55 +02:00
Markus Blatt
fc67eaeeda Prevent spurious warnings about NNCs when applying EDITNNC in parallel. 
If we use transmissibilities for loadbalancing, then we calculate
transmissibilities twice. First on the global grid before
loadbalancing and then on the local grid after that. This is the
default. In this case all warnings will be shown correctly when
calculating the global transmissibilities.

If the user requests the same weights for all faces (command line
parameter --edge-weights-method=0) then the transmissibilities are only
calculated on the loadbalanced grid. Unfortunately, in this case only
rank 0 will issue warnings for his part including the false positives
mentioned below.

Due to load balancing many NNCs might be stored on another process,
but we still use all EDITNNC entries when computing transmissibilties
locally. Hence when applying EDITNNC on the loadbalanced grid we
will issue warnings for cases where there are no problems (e.g. NNC
between two overlap cells.

With this PR we will only warn when computing the transmissibilities
for the first time. For the default settings this will remove spurious
and duplicate warnings.

Not that for --edge-weights-method=0 nothing changes and we will still
see only warnings for the first rank including spurious one.
 2024-06-10 14:50:55 +02:00
Svenn Tveit
db970d58d2 Changed to Scalar type. 
Following commit 61bfea46c7.
 2024-06-10 14:48:49 +02:00
Svenn Tveit
1645559342 Fix mass exchange term. 
Additionally, store separate well terms for free and solution tracers
 2024-06-10 14:48:45 +02:00
Svenn Tveit
050ce2de3b Fixes after rebase 2024-06-10 14:41:21 +02:00
Svenn Tveit
b00cc2c1a5 Extend tracer model to solution tracers. 
Solve an extended linear system with free and solution tracers with mass transfer coupling term.
 2024-06-10 14:41:21 +02:00
Markus Blatt
b2c06415f4
Merge pull request #5182 from lisajulia/ilu-op-in-amg 
Ghost entries skipped for ILU apply and SpMV operator in all levels of AMG/CPR hierarchy
 2024-06-10 13:06:42 +02:00
Bård Skaflestad
fcad25e26a
Merge pull request #5420 from atgeirr/avoid-uninitialized-variable 
Ensure 'mid' is always initialized.
 2024-06-07 17:14:58 +02:00
Bård Skaflestad
58edb5b9aa
Merge pull request #5417 from blattms/feature-correct-comment-parallel 
Update wrong comment about storage of transmissibilities
 2024-06-07 16:50:38 +02:00
Atgeirr Flø Rasmussen
fc906842ad
Merge pull request #5352 from jcbowden/damaris-limit-variables-v1 
Add ability to pass multiple variables to Damaris using DamarisWriter class.
 2024-06-07 15:54:59 +02:00
Markus Blatt
d80b8411b7 Fixed spelling of comments. 2024-06-07 14:58:47 +02:00
andrthu
6c62753803 Ghost entries skipped for ilu apply and GL operator in AMG/CPR hierarchy. 
This works since the ghost entries are the last entries
 2024-06-07 14:40:53 +02:00
Atgeirr Flø Rasmussen
71684bfe2c Ensure 'mid' is always initialized. 2024-06-07 14:27:02 +02:00
Markus Blatt
2f3c1b7310 Update wrong comment about storage of transmissibilities 
This is a follow up of the fix in #5414.

The comment said that the ordering of the compressed index of cells is
coherent with the cartesian index. THis is not the case in parallel
where cells in the overlap/ghost region might be ordered last (default).
 2024-06-07 06:46:18 +02:00
Markus Blatt
302503e172
Merge pull request #5414 from totto82/fix_mpi_edit_trans 
Fix modifications of TRANX/Y/Z in parallel (e.g. MULTIPLY of TRANX in EDIT)
 2024-06-07 06:28:35 +02:00
Bård Skaflestad
e3bf48541f
Merge pull request #5406 from GitPaean/only_trans 
only allocate trans_ for globalTrans_
 2024-06-06 21:50:11 +02:00
Bård Skaflestad
225bdf4595
Merge pull request #5416 from atgeirr/missing-initialization 
Initialize double member for serialization test.
 2024-06-06 21:03:03 +02:00
Kai Bao
8f67881809 using enum class to replace boolean onlyTrans for 
Transmissibility::update() for better readability, which is suggested by the reviewer.
 2024-06-06 20:09:44 +02:00
Atgeirr Flø Rasmussen
74fc1d4a67 Ensure the 'injector' member is initialized, compared etc. 2024-06-06 16:31:46 +02:00
Atgeirr Flø Rasmussen
ab4d9cb36e Initialize double member for serialization test. 2024-06-06 15:24:20 +02:00
Bård Skaflestad
9c744190eb
Merge pull request #5411 from bska/claim-basic-wtmult-support 
Enable WTMULT as an Input Operation
 2024-06-06 14:53:07 +02:00
Bård Skaflestad
bc48a2e955
Merge pull request #5342 from atgeirr/nldd-domain-solves-newton-damping 
Add Newton update damping when domain solution oscillates.
 2024-06-06 14:52:25 +02:00
Tor Harald Sandve
42702e1d50 Fix mpi for MULTIPLY TRANX in EDIT 2024-06-06 12:59:41 +02:00
Atgeirr Flø Rasmussen
f06c238753 Add damping treatment to subdomain Newton iterations. 2024-06-06 12:59:22 +02:00
josh bowden
6fcec07bab cast to remove: comparison of integer expressions of different signedness warning. 2024-06-06 10:36:25 +02:00
Bård Skaflestad
3074c0d9fd Enable WTMULT as an Input Operation 
Basic support for this keyword was added in commit

    OPM/opm-common@5e3e20c552

and this commit enables running models which use that basic support.
Advanced uses, such as including user-defined arguments for the
multipliers, will still be rejected at the input level.
 2024-06-06 09:14:01 +02:00
Bård Skaflestad
151de07fa7 Collect Well Level Control Limits/Targets for Summary Output 
This commit adds a new stage to the wellData() report function,
assignWellTargets(), which collects the numerical values of the
currently active limits/targets for summary file output purposes.
It is important that we collect these values strictly before we
start mutating the SummaryState object lest user-defined arguments
in keywords like WCONPROD be evaluated seemingly too soon.
Furthermore, it is faster to collect these values on the simulator
side and send them to the I/O rank for file output than to defer the
full calculation to the I/O rank.
 2024-06-06 09:13:57 +02:00
Tor Harald Sandve
25f6c0a1bd
Merge pull request #5405 from svenn-t/ezrokhi 
Support for CNAMES
 2024-06-06 08:44:27 +02:00
Kai Bao
303a677a81 only allocate trans_ for globalTrans_ 
others are not needed for globalTrans_ for now. It will help to flatten
the peak memory usage for rank 0 during a parallel running.
 2024-06-05 21:35:46 +02:00
josh bowden
7fc6cc0430 Other small additions from github comments and removal of compile time logic that checks for ParaView and Python - makes code more readable and alows use of Damaris libraries with differing compiled in backends to be swapped without need for recompiling opm-simulators 2024-06-05 17:26:34 +02:00
Razvan Nane
a1c238df8e last scalars 2024-06-05 15:30:08 +02:00
Razvan Nane
b51f27517b more scalars 2024-06-05 15:27:22 +02:00
Razvan Nane
40c0539bc3 update copyright and scalar 2024-06-05 15:12:12 +02:00
Razvan Nane
dcbd9be46a cleanup and run fix 2024-06-05 15:00:47 +02:00
Bård Skaflestad
4cf8a50b26
Merge pull request #5398 from atgeirr/minor-oscillation-handling-fix 
Detect oscillation in just one phase.
 2024-06-05 13:56:35 +02:00
Tobias Meyer Andersen
9b2f41ad96 Add option to split the matrix into diagonal, 
strictly lower and stricly upper part.
Add tests checking that the result matches
the CPU dilu implementation.
 2024-06-05 13:35:54 +02:00
Atgeirr Flø Rasmussen
558d888d90 Allow oscillation detection with less that two phases. 
We should not require two phases to have oscillating residuals to
start handling it.
 2024-06-05 11:50:01 +02:00
Razvan Nane
7a307fafa0 add rocsparseCPR preconditioner 2024-06-04 17:13:13 +02:00
Kai Bao
904cb7e2c4
Merge pull request #5395 from steink/consistent_vfp_interpolation 
Small fixes related to thp-control/vfp-extrapolation
 2024-06-04 15:15:41 +02:00
Razvan Nane
74b30e6bba refactor AMG creation as a class 2024-06-04 15:13:54 +02:00
Tor Harald Sandve
8b5fced909 avoid mass creation with drsdt 2024-06-04 15:10:11 +02:00
Razvan Nane
3eb87b7b04 refactor rocsparseSolverBackend to allow flexible preconditioner 2024-06-04 12:17:49 +02:00
Razvan Nane
071f009bf3 refactor preconditioner class 2024-06-04 09:47:03 +02:00
Razvan Nane
83b50f08e6 rename opencl files 2024-06-04 06:28:50 +02:00
Razvan Nane
02b76b5309 refactor rocm files 2024-06-04 06:19:28 +02:00
Svenn Tveit
912cd45182 Support for CNAMES needed with CO2STORE 2024-06-03 20:40:26 +02:00
Vegard Kippe
78cc10f620 Fix typo 2024-06-03 15:26:16 +02:00
Stein Krogstad
37c771cb5f fix bug and attempt to make code clearer 2024-05-31 14:11:10 +02:00
Stein Krogstad
d32d4419a9 fix double -> Scalar 2024-05-31 14:11:10 +02:00
Stein Krogstad
aa8516c085 Respect "global" switching logic also in local solves 2024-05-31 14:11:10 +02:00
Stein Krogstad
008fd268c5 fix bug 2024-05-31 14:11:10 +02:00
Stein Krogstad
c5f7d02bf7 Make thp-func constistent with bhp-func and add some damage prevention logic for severe extrapolation 2024-05-31 14:11:10 +02:00
Razvan Nane
988d3821cd fix compile rocsparseWellContrib 2024-05-31 11:55:53 +02:00
Arne Morten Kvarving
c92d80e0e8
Merge pull request #5399 from daavid00/fixMacOS 
[FIX]: Build issue if OpenMP is not present
 2024-05-31 09:56:39 +02:00
David Landa Marban
a6ed584ae2 [FIX]: Build issue if OpenMP is not present 2024-05-31 09:00:57 +02:00
Arne Morten Kvarving
bcbac79486
Merge pull request #5380 from akva2/linalg_template_scalar 
LinAlg classes: template Scalar type
 2024-05-31 08:40:11 +02:00
Kai Bao
e968da28bb renaming calcRates to calcResvCoeff 
and calcInjRates to calcInjResvCoeff.
 2024-05-29 22:29:12 +02:00
Bård Skaflestad
a3a2b7a978 Make SummaryState Objects Aware of Undefined UDQ Value 
This PR switches to calling the SummaryState constructor which is
aware of the value of undefined UDQs (OPM/opm-common#4052) directly.

While here, also sort headers, split some long lines, and prefer
initialisation lists to constructor body assignments.
 2024-05-29 09:16:56 +02:00
Bård Skaflestad
6e8da2309b Delay UDQ Assignments Until After Summary Output 
Commit 0aaa69c6e (PR #5330) was a little too eager in its effort to
handle UDQ ASSIGN operations after action processing[%].  In
particular, the assignments, which alter the internal structures of
the SummaryState and UDQState objects, would happen prior to writing
summary files.  In turn, this would make it appear as if the
assignment happened too early.  This commit defers UDQ assignments
triggered by action processing until FlowProblem<>::endEpisode() for
two reasons

  1. The problem originally addressed in 0aaa69c6e only presented
     when the assignment was triggered on the final time step of an
     episode (report step), so handling this situation here is a
     more targeted approach.

  2. Member function FlowProblem<>::endEpisode() is called after we
     write the summary file output so any alterations to the
     internal structures of the SummaryState will not be visible in
     the summary output until the next time step.  This is the
     expected behaviour.

[%] Insufficient testing by: [at]bska.
 2024-05-28 18:16:30 +02:00
Bård Skaflestad
03e8c7ecdc
Merge pull request #5394 from atgeirr/avoid-memory-leak 
Avoid memory leak from the *unique_ptr<X>.release() antipattern.
 2024-05-28 18:15:01 +02:00
Atgeirr Flø Rasmussen
6a7e1e08c0 Avoid memory leak from the *unique_ptr<X>.release() antipattern. 2024-05-28 16:49:08 +02:00
Bård Skaflestad
a16ef8b1c2
Merge pull request #5393 from atgeirr/avoid-out-of-scope-temporary 
Bugfix: Avoid possible use of out-of-scope temporary.
 2024-05-28 16:31:30 +02:00
Atgeirr Flø Rasmussen
0fe76f6011 Bugfix: Avoid possible use of out-of-scope temporary. 
Since std::clamp returns a reference we must be careful to not capture
the return value by reference, when there is a temporary among the input
parameters.

For the second change (adding the explicit Scalar return type to a lambda)
this is strictly speaking not necessary, as the lambda's return type is not
a reference, but that is obscure so the change is just done as to clarify.
 2024-05-28 16:01:48 +02:00
Bård Skaflestad
8199342ce9
Merge pull request #5232 from steink/check_zero_target_from_group 
When checking for zero target rates, also check wells under group control where required
 2024-05-27 22:09:26 +02:00
Arne Morten Kvarving
41885f5911 ISTLSolverBda: use Scalar type from vector 2024-05-24 14:28:10 +02:00
Arne Morten Kvarving
0e537a8ae3 ISTLSolverBda: fix indent 2024-05-24 14:21:26 +02:00
Arne Morten Kvarving
ad1d862426 BdaBridge: template Scalar type 2024-05-24 14:21:26 +02:00
Arne Morten Kvarving
3eed028978 rocsparseSolverBackend: template Scalar type 2024-05-24 14:21:25 +02:00
Arne Morten Kvarving
e620d9d044 rocaluationSolverBackend: template Scalar type 2024-05-24 14:16:36 +02:00
Arne Morten Kvarving
0b22b62205 amgclSolverBackend: template Scalar type 2024-05-24 14:16:36 +02:00
Arne Morten Kvarving
23250b87e3 cusparseSolverBackend: template Scalar type 2024-05-24 14:16:34 +02:00
Arne Morten Kvarving
18f42b51b2 openclSolverBackend: template Scalar type 2024-05-24 14:09:12 +02:00
Arne Morten Kvarving
d0773ef4f7 BdaSolver: template Scalar type 2024-05-24 14:09:12 +02:00
Arne Morten Kvarving
e03f2394b9 BdaSolver.hpp: drop indent for namespace 2024-05-24 14:09:12 +02:00
Arne Morten Kvarving
7e1f4629ed CPR: template Scalar type 2024-05-24 14:09:12 +02:00
Arne Morten Kvarving
1f39e6a9a9 BISAI: template Scalar type 2024-05-24 14:09:12 +02:00
Arne Morten Kvarving
8ea523fa68 BILU0: template Scalar type 2024-05-24 14:09:12 +02:00
Arne Morten Kvarving
b75ea188ee Preconditioner: template Scalar type 2024-05-24 14:09:12 +02:00
Arne Morten Kvarving
05a89d1e96 cuWellContributions: template Scalar type 2024-05-24 14:09:12 +02:00
Arne Morten Kvarving
d2637e53ea rocsparseWellContributions: template Scalar type 2024-05-24 14:09:12 +02:00
Arne Morten Kvarving
ddcfcf681d openclWellContributions: template Scalar type 2024-05-24 14:09:11 +02:00
Arne Morten Kvarving
ff39bc3b03 WellContribution: template Scalar type 2024-05-24 14:09:11 +02:00
Arne Morten Kvarving
216f0bea0d MultisegmentWellContribution: template Scalar type 2024-05-24 14:09:11 +02:00
Arne Morten Kvarving
ba1c6db855 OpenclKernels: template Scalar type 2024-05-24 14:09:11 +02:00
Arne Morten Kvarving
be59203179 OpenclMatrix: template Scalar type 2024-05-24 14:09:11 +02:00
Arne Morten Kvarving
5fbd7635cd Matrix: template Scalar type 2024-05-24 14:09:11 +02:00
Arne Morten Kvarving
25374b0e54 BlockMatrix: template Scalar type 2024-05-24 14:09:10 +02:00
Arne Morten Kvarving
b9ee637d78 PreconditionerFactory: use Scalar type from operator 2024-05-24 14:03:28 +02:00
Arne Morten Kvarving
b7bc7b7bf5 Pressure(Bhp)TransferPolicy: template Scalar type 2024-05-24 14:03:28 +02:00
Arne Morten Kvarving
c240df73c4 WellBhpThpCalculator: use appropriate Scalar type 2024-05-24 14:03:28 +02:00
Bård Skaflestad
6f094c558a
Merge pull request #5256 from BigDataAccelerate/overlap_copy_jacmat_gpu 
Overlap creation of jacobian matrix with GPU data transfers
 2024-05-24 13:11:27 +02:00
Stein Krogstad
427351cc12 Include checking for zero targets from groups where required 2024-05-23 14:55:37 +02:00
Stein Krogstad
2db90a92e7 include group controls for zero rate target checking 2024-05-23 14:44:26 +02:00
Arne Morten Kvarving
60e91a0fb5 amgclSolverBackend: fix for block_size == 1 2024-05-23 13:41:26 +02:00
Bård Skaflestad
9841c5d21c
Merge pull request #5377 from akva2/equil_template_scalar 
InitStateEquil: template Scalar type
 2024-05-23 10:48:04 +02:00
Arne Morten Kvarving
4bef925974 InitStateEquil: use Scalar type from FluidSystem 2024-05-23 09:39:49 +02:00
Arne Morten Kvarving
4cfb7a8566 EquilibrationHelpers: template Scalar type 2024-05-23 09:38:27 +02:00
Arne Morten Kvarving
5ed5676f32 WellGroupHelpers: use appropriate Scalar type 2024-05-23 09:08:48 +02:00
Arne Morten Kvarving
db2db4bab5 WellFilterCake: use appropriate Scalar type 2024-05-23 09:06:16 +02:00
Arne Morten Kvarving
ca6b73a6f8 VFPProdProperties: use appropriate Scalar type 2024-05-23 09:03:48 +02:00
Arne Morten Kvarving
769489f552 VFPHelpers: use appropriate Scalar type 2024-05-23 09:01:14 +02:00
Arne Morten Kvarving
e9050359db BlackoilWellModel: use appropriate Scalar type 2024-05-23 08:52:59 +02:00
Arne Morten Kvarving
600e7ea2f7 Transmissibility: consistently use Scalar type 2024-05-23 08:42:51 +02:00
Arne Morten Kvarving
27ca3ab5f7 OutputBlackoilModule: consistently use Scalar type 2024-05-23 08:34:09 +02:00