Commit Graph

16728 Commits

Author SHA1 Message Date
Markus Blatt
0cc839314e log problem if asked to continue with nonconverged nonlinear solver.
The user has explicitly asked for this behavior using
--solver-continue-on-convergence-failure=true in this rare case.
2023-11-08 17:16:21 +01:00
Markus Blatt
5531c63df6
Merge pull request #4977 from atgeirr/use-problem-not-error
Add and use OPM_DEFLOG_PROBLEM macro.
2023-11-08 16:40:23 +01:00
Atgeirr Flø Rasmussen
749ea93e24 Add and use OPM_DEFLOG_PROBLEM macro.
This should replace OPM_DEFLOG_THROW in places where the problem
category is more appropriate than the error category.

In this commit, uses of OPM_DEFLOG_THROW have been replaced whenever
the exception class used was NumericalProblem.
2023-11-08 15:16:17 +01:00
Bård Skaflestad
895074eb3b
Merge pull request #4749 from bska/trigger-actionx-in-middle-of-report-step
Update Well Topology if Triggered From ACTIONX
2023-11-07 19:55:40 +01:00
Bård Skaflestad
a2fa381877 Run ACTIONX_M1 With Shorter Time Steps
Needed for increased determinism in sensitive test (WBHP trigger).
2023-11-07 17:02:18 +01:00
Bård Skaflestad
abfb5c9d82 Update Well Topology if Triggered From ACTIONX
This commit adds a new flag data member,

    wellStructureChangedDynamically_

to the generic black-oil well model.  This flag captures the

    well_structure_changed

value from the 'SimulatorUpdate' structure in the updateEclWells()
member function.  Then, in BlackoilWellModel::beginTimeStep(), we
key a well structure update off this flag when set.  This, in turn,
enables creating or opening wells as a result of an ACTIONX block
updating the structure in the middle of a report step.
2023-11-07 17:02:18 +01:00
Bård Skaflestad
b22f9853db
Merge pull request #4969 from akva2/fbhpdef
add support for FBHPDEF keyword
2023-11-07 16:35:51 +01:00
Bård Skaflestad
a42d52e644
Merge pull request #4952 from steink/well_testing_initialize_rates
Initialize rates/previous rates before well-test
2023-11-07 13:46:41 +01:00
Stein Krogstad
0756e2d1c1 Initialize rates/previous rates before well-test 2023-11-06 11:46:44 +01:00
Bård Skaflestad
763d25541a
Merge pull request #4970 from akva2/janitoring
Quell an uninitialized variable static analyzer warning
2023-11-06 10:17:54 +01:00
Markus Blatt
11ac7375a9
Merge pull request #4971 from totto82/compdat_d
Remove warning for unsupported D factor in COMPDAT
2023-11-06 10:06:09 +01:00
Tor Harald Sandve
aa96e8fd6c Remove warning for unsupported D factor in COMPDAT 2023-11-06 09:10:34 +01:00
Arne Morten Kvarving
e3cd06c164 avoid uninitialized value static analyzer warning 2023-11-06 08:56:53 +01:00
Arne Morten Kvarving
fa45790bfb changed: rename variable
this indicates that bracketing was successfully found,
not that we are looking for a bracket
2023-11-06 08:56:53 +01:00
Bård Skaflestad
d88f2b701f
Merge pull request #4940 from akva2/udt_enable
Enable (limited) support  for UDT
2023-11-03 12:16:30 +01:00
Arne Morten Kvarving
9429870457 add regression tests for UDT 2023-11-03 10:48:55 +01:00
Arne Morten Kvarving
fb7135a424 remove UDT keywords from unsupported list
UDTDIMS is completely ignored but should not stop the simulator
2023-11-03 10:48:55 +01:00
Arne Morten Kvarving
de0b249eaa fixed: make sure we get exact match for test name
if not test names that are a substring of another might
match the wrong entry in the file
2023-11-03 10:48:55 +01:00
Arne Morten Kvarving
81182dec1d add regression test for FBHPDEF 2023-11-03 09:08:33 +01:00
Arne Morten Kvarving
29c65ef7df mark FBHPDEF keyword as supported 2023-11-03 09:07:14 +01:00
Bård Skaflestad
29579e2faa
Merge pull request #4968 from akva2/janitoring
avoid more dead stores
2023-11-02 12:30:05 +01:00
Markus Blatt
4a61d5cf71
Merge pull request #4951 from aritorto/hideFieldPropLookUp
Assign Field Property to all leaf grid view elements
2023-11-02 12:24:27 +01:00
Arne Morten Kvarving
2fcc8bddd4 avoid more dead stores 2023-11-02 12:14:10 +01:00
Antonella Ritorto
a17ae448d7 Hide Field Properties lookup 2023-11-02 07:23:13 +01:00
Bård Skaflestad
9233e32d81
Merge pull request #4826 from totto82/fixResvRates
Compute resv rates based on pressure and temperature in the well for injectors in thermal cases
2023-11-01 16:24:10 +01:00
Tor Harald Sandve
d7401e3b6b
Merge pull request #4919 from daavid00/saltprecPermFac
Multiply well trans due to perm reduction in salt prec
2023-11-01 13:29:57 +01:00
Bård Skaflestad
17886f934c
Merge pull request #4924 from GitPaean/fixing_gecon_welopen
use the WELL_SET_TO_OPEN event to open closed wells
2023-11-01 10:24:18 +01:00
Bård Skaflestad
af2bbb862b
Merge pull request #4926 from GitPaean/using_tuning_for_most_wtest_cases
using TUNING for the tests under folder wtest
2023-10-31 22:18:17 +01:00
David Landa Marban
c93d46c1be Mult well trans due to perm reduction in salt prec 2023-10-31 22:11:55 +01:00
Bård Skaflestad
bf72698310
Merge pull request #4832 from totto82/wdaccor_refactor
Implement Forchheimer term in wellIndex
2023-10-31 17:46:49 +01:00
Tor Harald Sandve
ae51c7ce82
Merge pull request #4964 from svenn-t/h2store_molefrac
Output XMF and YMF for H2STORE
2023-10-31 14:07:54 +01:00
Kai Bao
07074d551a
Merge pull request #4959 from totto82/new_linearizer_gaswater
Use new linearizer for gaswater with thermal and diffusion
2023-10-31 13:19:36 +01:00
Bård Skaflestad
fe6ea7022e
Merge pull request #4962 from aritorto/deprecatedGetCollComm
[bugfix] Deprecated getCollectiveComminication
2023-10-31 10:05:12 +01:00
Antonella Ritorto
166c31d5f8 Bugfix. Deprecated getCollectiveComminication warning 2023-10-31 08:40:46 +01:00
Tor Harald Sandve
9779b95a43 Use new linearizer for gaswater with thermal and diffusion 2023-10-30 15:15:13 +01:00
Svenn Tveit
7c0b3901da Output XMF and YMF for H2STORE 2023-10-30 14:09:54 +01:00
Atgeirr Flø Rasmussen
8aa035f174
Merge pull request #4949 from BigDataAccelerate/remove-redundant-ilu-decomp
Remove redundant CPU decomposition when done also on GPU
2023-10-27 13:38:16 +02:00
Bård Skaflestad
b3b60cd756
Merge pull request #4953 from akva2/janitoring
avoid dead stores
2023-10-27 09:15:24 +02:00
Arne Morten Kvarving
5e801bc488 avoid dead stores 2023-10-27 08:59:15 +02:00
Tor Harald Sandve
a40ede9957 Compute reservoir injection rates from well temperature and pressure for thermal cases 2023-10-26 15:57:41 +02:00
Kai Bao
86c919877e
Merge pull request #4946 from GitPaean/assertion_throw
making a few assertion to throw in StandardWellPrimaryVariables
2023-10-26 13:42:09 +02:00
Kai Bao
3e03ebbb58 making a few assertion to throw in StandardWellPrimaryVariables
to get more outputting information and also avoid harsh termination due
to assert.

They are technically numerical problem instead of programming mistakes.
2023-10-26 11:36:25 +02:00
Tor Harald Sandve
968686e7e0
Merge pull request #4943 from hakonhagland/pybind3
Get simulator time step size from Python BlackOilSimulator module
2023-10-26 11:28:42 +02:00
Razvan Nane
45d8750e93 Fix formatting and indentation 2023-10-26 09:45:48 +02:00
Bård Skaflestad
95bc3822fb
Merge pull request #4948 from GitPaean/glo_active_enter_glift
checking LIFTOPT active before gliftBeginTimeStepWellTestUpdateALQ and before attempting to optimize alq in gliftBeginTimeStepWellTestIterateWellEquations
2023-10-26 09:06:23 +02:00
Razvan Nane
cd63cc83c2 Remove redundant cpu decomposition when using gpu 2023-10-26 06:40:06 +02:00
Kai Bao
beda7a0b35 checking LIFTOPT active before trying to optimizing alq
in gliftBeginTimeStepWellTestIterateWellEquations.

otherwise, if the increment is 0 (inactive), the function
gliftBeginTimeStepWellTestIterateWellEquations
might return undesired results or enter endless loop.
2023-10-25 23:00:54 +02:00
Kai Bao
2b97c3fe1d checking LIFTOPT active before gliftBeginTimeStepWellTestUpdateALQ
to avoid meaningless message output related to GLIFT and WTEST
2023-10-25 21:45:19 +02:00
Bård Skaflestad
e5c29c768d
Merge pull request #4944 from bska/rescale-swatinit-pcow-at-restart
Apply Full SWATINIT-Like PCOW Rescaling at Restart
2023-10-25 16:44:08 +02:00
Bård Skaflestad
9fdc007c07 Apply Full SWATINIT-Like PCOW Rescaling at Restart
We switch to using the applyRestartSwatInit() member function
instead of directly mutating a data member of the EpsInfo structure.
This way we defer the rescaling to a context with a more complete
view of the changes needed to convey the information to all
components involved.
2023-10-25 11:04:51 +02:00