OilfieldToolsNet/opm-simulators
4
0
Fork 0
mirror of https://github.com/OPM/opm-simulators.git synced 2026-09-05 04:40:19 -05:00
Code Issues Packages Projects Releases Wiki Activity
20,272 Commits 31 Branches 117 Tags
2166ec6328daee0c8865bb67ffee648ba8fb6c9d
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Kai Bao f47d00c9d7 Merge pull request #5236 from hnil/no_early_exit_zero_flux 
Avoid deleting derivative i.e. getting "wrong" matrix in case of zero…
 2024-08-29 14:46:09 +02:00
Kai Bao 818f8b9ee3 Merge pull request #877 from hnil/no_early_exit_zero_flux 
Avoid deleting derivatives with zero pressure difference
 2024-08-29 14:46:00 +02:00
Kai Bao 30eb34d324 Merge pull request #5564 from GitPaean/stablizing_test 
adding --tolerance-cnv-relaxed for H2STORE regression
 2024-08-28 19:14:24 +02:00
Kai Bao e4225df6b7 adding --tolerance-cnv-relaxed for H2STORE regression 
so that the solution is converged and results in more stable regression
checking.
 2024-08-28 15:10:00 +02:00
Kai Bao 2f36034077 Merge pull request #5563 from GitPaean/stablizing_test 
hopefully stabilizing some regression test
 2024-08-28 13:59:12 +02:00
Kai Bao db62d4f914 adding --tolerance-wells=1.e-8 to regression tests 
UDQ_M1 and NORNE_ATW2013_B1H_RE-PERF
 2024-08-28 11:45:41 +02:00
Kai Bao 5866e9af84 Merge pull request #5535 from GitPaean/relocate_mixing_control 
relocating mixControls_ form FlowGenericProblem to FlowProblem
 2024-08-20 11:50:39 +02:00
Kai Bao 6f2073908c relocating mixControls_ form FlowGenericProblem to FlowProblem 
so FlowGenericProblem can be used for non-blackoil setting
 2024-08-17 00:41:28 +02:00
Kai Bao 3d794d2d80 using std::from_chars instead of std::stoi 2024-08-08 16:12:17 +02:00
Kai Bao 52da2c9dfe avoiding unnecessary exception from std::stoi("") 
in FlowMain.hpp
 2024-08-08 15:46:31 +02:00
Kai Bao 2cb471356e Merge pull request #5504 from GitPaean/avoiding_unnecessary_exception 
avoiding exception from std::stoi("")
 2024-08-07 10:36:45 +02:00
Kai Bao 7803c55a88 avoiding exception from std::stoi("") 
when not setting OMP_NUM_THREADS in the environment.
 2024-08-05 11:48:54 +02:00
Kai Bao 706fa281a1 Merge pull request #4935 from plgbrts/auto-choke 
WIP: Enabling automatic choke to model a sub-sea manifold in an extended network
 2024-07-03 21:29:50 +02:00
Kai Bao ce05406483 make sure a well exists in the process 
before closing it due to group action
 2024-07-01 22:00:39 +02:00
Kai Bao eb83fff9d5 Merge pull request #5435 from steink/updates_in_preparation_for_5157 
Minor updates in preparation for New defaults #5157.
 2024-06-26 00:24:29 +02:00
Kai Bao d7d74d3a3e Merge pull request #5424 from GitPaean/fixing_wecon 
WECON RATE limit should not be applied if the well is under zero group rate target
 2024-06-24 19:02:53 +02:00
Kai Bao f99956c452 Merge pull request #5432 from vkip/gconprod_item11to13 
Allow GCONPROD item 11-13 to actually take effect.
 2024-06-24 18:59:29 +02:00
Kai Bao 6ac7f8fdaf not applying WECON RATE limit 
when the well is under zero group target.
 2024-06-24 14:42:10 +02:00
Kai Bao a373fc004e Merge pull request #5431 from GitPaean/stablize_python_test 
Stablize python test
 2024-06-19 22:16:58 +02:00
Kai Bao 027c3ba0fc using one day time step for SPE1CASE1a/SPE1CASE1.DATA 
to avoid time stepping change causes test failures for the python tests
 2024-06-19 13:42:55 +02:00
Kai Bao fd5e9d167f addressing reviewing comments OPM/opm-simulators#5419 2024-06-10 16:08:44 +02:00
Kai Bao 062a98b305 restruct so that we can release the global trans earlier 
in the funciton finishInit().
 2024-06-10 16:08:44 +02:00
Kai Bao 8f67881809 using enum class to replace boolean onlyTrans for 
Transmissibility::update() for better readability, which is suggested by the reviewer.
 2024-06-06 20:09:44 +02:00
Kai Bao 303a677a81 only allocate trans_ for globalTrans_ 
others are not needed for globalTrans_ for now. It will help to flatten
the peak memory usage for rank 0 during a parallel running.
 2024-06-05 21:35:46 +02:00
Kai Bao 904cb7e2c4 Merge pull request #5395 from steink/consistent_vfp_interpolation 
Small fixes related to thp-control/vfp-extrapolation
 2024-06-04 15:15:41 +02:00
Kai Bao e968da28bb renaming calcRates to calcResvCoeff 
and calcInjRates to calcInjResvCoeff.
 2024-05-29 22:29:12 +02:00
Kai Bao 481c4830b5 only trying to link darmaris when requested 2024-05-28 16:16:19 +02:00
Kai Bao 0f9633b198 limiting max time step to 10 days for PYACTION_WCONPROD 
to make the regression checking more stable.
 2024-05-27 14:19:04 +02:00
Kai Bao 5fda72d24f removing unused releaseGlobalTransmissibility() 
from AluGridVanguard and CpGridVanguard.
they exist is becaluse of typo in the function name. There is another
releaseGlobalTransmissibilities() function actually gets used.
 2024-05-10 16:45:00 +02:00
Kai Bao b225ec240f removing updateKrnum_ 
which does not have effects, which was suggested by Håkon Hægland.

And also removing the following member variables from
FlowGenericProblem because they are not in use anymore.

    krnumx_, krnumy_, krnumz_;
    imbnumx_, imbnumy_, imbnumz_;
 2024-05-08 09:41:46 +02:00
Kai Bao 79236c4927 removing unused updateImbnum_ function 2024-05-08 09:33:00 +02:00
Kai Bao 702a0565a9 Merge pull request #5310 from akva2/janitoring 
FlowExp: spring cleaning
 2024-04-25 10:56:52 +02:00
Kai Bao e7f208a84a Merge pull request #5298 from GitPaean/adding_flowexp2 
Adding flowexp_blackoil
 2024-04-24 15:26:51 +02:00
Kai Bao cd14204727 changing FlowNewtonMethod to be FlowExpNewtonMethod 
as requested by reviewer.
 2024-04-23 11:39:49 +02:00
Kai Bao 729be2c658 some cleaning up related to flowexp 2024-04-23 11:39:49 +02:00
Kai Bao e2cfd0bd34 adding regression test for flowexp_blackoil 
based on SPE1CASE2
 2024-04-23 11:39:49 +02:00
Kai Bao d381d06d7a renaming ebos for flowexp usage 2024-04-23 11:39:49 +02:00
Kai Bao d2ce814eae renaming the file names 2024-04-23 11:39:49 +02:00
Kai Bao 68c202eb55 using flowexp as files names 2024-04-23 11:39:49 +02:00
Kai Bao 7cc1880196 updating due to removing of EWOMS_GET_PARAM 2024-04-23 11:39:49 +02:00
Kai Bao 98543258d9 light cleaning up for flowexperimental related 2024-04-23 11:39:49 +02:00
Kai Bao f6170ec1dd copying the ebos from opm-flowexperimental 2024-04-23 11:39:49 +02:00
Kai Bao 29358ee70b removing the including of FlowProblem in BlackoilWellModel 2024-03-27 13:12:55 +01:00
Kai Bao 1898a1681b changing including guard name for two diffusionmodule 
they used to use the same EWOMS_DIFFUSION_MODULE_HH
 2024-03-21 15:11:42 +01:00
Kai Bao 9e726f5430 Merge pull request #5245 from akva2/ebos_drop_full 
Drop ebos: Mega PR
 2024-03-08 15:07:24 +01:00
Kai Bao 75f38ca726 Merge pull request #5178 from akva2/baseaquifermodel_move 
move ebos/eclbaseaquifermodel.hh to opm/simulators/flow
 2024-03-06 12:47:51 +01:00
Kai Bao aa2fa12598 Merge pull request #5167 from akva2/drop_ebos_simulator_params 
Rename ebos_simulator parameters to simulator
 2024-03-06 11:48:03 +01:00
Kai Bao 5f2c9192d0 Merge pull request #5177 from akva2/move_collect_iorank 
ebos/collecttoiorank: move to opm/simulators/flow
 2024-03-06 11:44:46 +01:00
Kai Bao 339cc29f47 Merge pull request #5165 from akva2/drop_ebos_in_function_names 
Drop ebos in function names
 2024-03-06 10:48:13 +01:00
Kai Bao 9f13a25ebc Merge pull request #5175 from akva2/move_alugrid 
Move AluGrid files from ebos to opm/simulators/flow
 2024-03-06 00:02:12 +01:00
Kai Bao ed9876a5c4 Merge pull request #5185 from akva2/move_outputblackoilmodule 
Move BlackoilOutputModule from ebos to opm/simulators/flow
 2024-03-05 23:31:44 +01:00
Kai Bao 6f9ab6189f Merge pull request #875 from akva2/adjust_outputmodule 
adjust to output module accessor change
 2024-03-05 23:31:34 +01:00
Kai Bao cd9a208757 Merge pull request #5166 from akva2/indices_drop_ebos 
Drop ebos in index functions
 2024-03-05 23:31:27 +01:00
Kai Bao d764eb416c Merge pull request #5203 from akva2/rename_drift_parameter 
rename EclEnableDriftCompensation parameter to EnableDriftCompensation
 2024-03-05 21:10:50 +01:00
Kai Bao a9a0ae1eb0 Merge pull request #5234 from GitPaean/not_limiting_normal_segments 
not using spres_lower_limit limit non-top segments
 2024-03-04 23:28:47 +01:00
Kai Bao c61f0b104c outputting segments with pressure close to lower limit 
if the well does not get converged.
 2024-03-02 16:28:33 +01:00
Kai Bao f7ad5cb211 not using spres_lower_limit limit non-top segments 
with multi-segments, the segment pressure can be lower than the bhp, so
it is not desirable to use spres_lower_limit to limit the segment
pressure. We only use spres_lower_limit to limit the bhp, which is still
valid until we begin using bhp limit lower than 1 bar.
 2024-03-02 15:19:17 +01:00
Kai Bao 06dba324d2 Merge pull request #5221 from vkip/avoid_injector_alq_lookup 
Avoid injector alq lookup
 2024-02-28 11:40:27 +01:00
Kai Bao 60594a5e1b Merge pull request #5129 from steink/avoid_reopening_stopped_wells 
Avoid re-opening previously stopped wells
 2024-02-12 14:44:15 +01:00
Kai Bao e5e9143a2a shutting wells zero rate constraint and not allowing crossflow 2024-02-01 23:09:53 +01:00
Kai Bao 2ddba5b339 Merge pull request #5128 from steink/fix_network_convergence_issues 
Fix network convergence issues
 2024-01-30 00:17:09 +01:00
Kai Bao f0fab97bb6 Merge pull request #5124 from vkip/revert_always_open_history_wells 
Revert always open history wells
 2024-01-29 10:10:55 +01:00
Kai Bao b9131f7a63 adapting to the changes in GenericOilGasFluidSystem 2024-01-17 12:10:03 +01:00
Kai Bao aad3f10f13 adapting to std::string_view 
for componentName and phaseName
 2024-01-17 12:10:03 +01:00
Kai Bao 8b9e8aefee using GenericFluidSystem for co2ptflash problem 2024-01-17 12:10:03 +01:00
Kai Bao 75ced1df73 Merge pull request #863 from totto82/fixThermalAqu 
avoid divition by zero for case without conductivity
 2024-01-16 22:59:44 +01:00
Kai Bao e405f49def Merge pull request #5040 from steink/fix_acceleration_pressure_loss 
Include all derivatives for acceleration term in MS wells
 2024-01-09 16:35:03 +01:00
Kai Bao 3aed0b9501 not updating the connection pressure for StandardWell 
at the early stage of computeWellRatesWithBhpIterations. The perforation rates are not updated,
and it is not sensible to update based on the inconsistent well rates and perforation rates.

Better to keep the original explicit quantities for better consistency.

Furthermore, it can be dangerous to update the explicit quantities based on the
irrelevant perforation rates, since the ratios can be very undesirable due to crossflow.
 2023-11-23 09:13:57 +01:00
Kai Bao 55b8aa7ceb updating based on review comments. 2023-11-22 10:25:28 +01:00
Kai Bao 76899d3751 using EWOMS_GET_PARAM for the PTFlash related run-time arguments 2023-11-21 15:52:56 +01:00
Kai Bao 9f0fb32713 various cleaning up and refactoring for co2 ptflash simulation 2023-11-21 15:52:56 +01:00
Kai Bao df5ee732fa not dropping derivative for flux term for flashlocalresidual.hh 
it contains the derivative of the pressure from the downstream cell.
 2023-11-21 15:52:56 +01:00
Kai Bao 6ab809c69d Merge pull request #5004 from blattms/control-mode-typo 
Fixed typo: control model -> control mode.
 2023-11-20 09:13:03 +01:00
Kai Bao 3b1ef932c2 Merge pull request #5003 from vkip/check_if_closed_before_hist_open 
Check if well was closed this step before re-opening during history
 2023-11-20 09:03:06 +01:00
Kai Bao e355990ac2 Merge pull request #4999 from vkip/always_open_historic_wells 
Always check if wells on historic controls can be opened
 2023-11-15 20:29:21 +01:00
Kai Bao bbdad520d6 Merge pull request #4915 from vkip/network_multi_root 
Support computation of network pressures in networks with multiple roots
 2023-11-13 14:39:07 +01:00
Kai Bao 25b007c46e Merge pull request #4945 from vkip/network_reroute 
Network reroute - avoid looking up nonexisting nodes
 2023-11-08 19:59:40 +01:00
Kai Bao 07074d551a Merge pull request #4959 from totto82/new_linearizer_gaswater 
Use new linearizer for gaswater with thermal and diffusion
 2023-10-31 13:19:36 +01:00
Kai Bao 86c919877e Merge pull request #4946 from GitPaean/assertion_throw 
making a few assertion to throw in StandardWellPrimaryVariables
 2023-10-26 13:42:09 +02:00
Kai Bao 3e03ebbb58 making a few assertion to throw in StandardWellPrimaryVariables 
to get more outputting information and also avoid harsh termination due
to assert.

They are technically numerical problem instead of programming mistakes.
 2023-10-26 11:36:25 +02:00
Kai Bao beda7a0b35 checking LIFTOPT active before trying to optimizing alq 
in gliftBeginTimeStepWellTestIterateWellEquations.

otherwise, if the increment is 0 (inactive), the function
gliftBeginTimeStepWellTestIterateWellEquations
might return undesired results or enter endless loop.
 2023-10-25 23:00:54 +02:00
Kai Bao 2b97c3fe1d checking LIFTOPT active before gliftBeginTimeStepWellTestUpdateALQ 
to avoid meaningless message output related to GLIFT and WTEST
 2023-10-25 21:45:19 +02:00
Kai Bao 83ed0f01e5 use the REQUEST_OPEN_WELL event to open closed wells 2023-10-20 13:08:07 +02:00
Kai Bao e1018e2815 if there is no VFP table associated with the well 
we set the thp to be zero in the WellState. The previous logic related
this to THP constraints does not hold in multiple situations:
1. VFP table is specified, we need the THP value for output purpose
2. network is involved, we need the THP value for constraint check.
 2023-10-16 21:43:18 +02:00
Kai Bao b975ebff65 Merge pull request #4881 from vkip/no_network_solve_in_history 
Avoid iterating network if no network wells are in prediciton mode
 2023-10-16 14:54:36 +02:00
Kai Bao 81758cca2c using TUNING for the tests under folder wtest 2023-10-12 10:34:26 +02:00
Kai Bao 3af34e4ae6 Merge pull request #4923 from GitPaean/using_report_step 
distinguishing report step and time step
 2023-10-11 23:14:43 +02:00
Kai Bao f5d3489d23 distinguishing report step and time step 
for the funcitons related to createWellContainer() and
runWellPIScaling().

So it is not exhaustive, but we should do it gradually.
 2023-10-11 11:33:02 +02:00
Kai Bao aa07b07da1 Merge pull request #834 from GitPaean/removing_flashproperties 
removing flashproperties.hh from multiple files
 2023-10-09 13:50:08 +02:00
Kai Bao ca35fd963f removing flashproperties.hh from multiple files 
it does not looks like it is used.
 2023-10-09 12:49:06 +02:00
Kai Bao a525f0865f removing white spaces in the wells folder 2023-10-09 11:14:48 +02:00
Kai Bao fdad32a20a Merge pull request #832 from GitPaean/removing_ncpflash_flashratevector 
removing NCPFlash header file in flashratevector
 2023-10-09 10:47:24 +02:00
Kai Bao b526025b1a removing flashintensivequantities.hh from flashratevector.hh 2023-10-09 09:05:08 +02:00
Kai Bao 361f87afe4 removing NCPFlash header file in flashratevector 
it does not look like used.
 2023-10-03 16:23:02 +02:00
Kai Bao b1974bbe45 recovering the SHUT during iteration beahvoir in prepareWellBeforeAssembling 
when local_well_solver_control_switching_ is off
and incoporating commenst regarding resetting wellStatus_ in StandardWell within
the function iterateWellEqWithSwitching.
 2023-09-29 10:55:19 +02:00
Kai Bao 83bbe89342 LocalWellSolveControlSwitching default to be false 2023-09-29 10:55:19 +02:00
Kai Bao e38e557bbc cleaning up to preapre for pull request 2023-09-29 10:55:19 +02:00
Kai Bao 8bc88ec80b setting 10-day maximum time step for two regressiong tests 
3_MULTFLT_MODEL2 and 4_MINPVV_MODEL2.

Hopefully the tests will be more stable and serve better as regression
tests.
 2023-09-19 17:02:13 +02:00
Kai Bao 9d642fd7ce only outputting some network info to the rank 0 process 2023-09-19 16:17:19 +02:00
Kai Bao f4a420d2f9 reducing the bhp lower limit slightly to handle 1 bar bhp limit 
it turns out that 1bar is the default bhp constraint for some keywords,
   and some cases are depending on it.
 2023-09-19 15:30:42 +02:00