Commit Graph

1505 Commits

Author SHA1 Message Date
Tor Harald Sandve
66781e52fc Merge pull request #849 from daavid00/renamingToEnableVapwat
Renaming enableEvaporation to enableVapwat
2023-11-13 15:01:27 +01:00
Bård Skaflestad
c3de02f18f Merge pull request #848 from blattms/portable-mpi-success-test
[fix] Skip manual error checking and rely on the error default handler aborting
2023-11-08 18:26:14 +01:00
Markus Blatt
1e8b51f118 Avoid assert and rely on error handler doing the correct thing.
Checking int return types of MPI functions is inefficient. The default
error handler will abort the problem. If somebody changes that, then
they should know what they are doing.
2023-11-08 16:48:40 +01:00
David Landa Marban
c69f7f2c99 Renaming enableEvaporation to enableVapwat 2023-11-07 18:35:08 +01:00
Markus Blatt
6d70d090a8 [fix] Use return code for error detection (not uninitialized MPI_Status::ERROR
According to MPI standard the ERROR field of MPI_Status might not be initialized
unless for operations that return multiple statuses, see  Section 3.7.5
of the standard. In older OpenMPI versions (<=4.0.x) we were lucky
that ERROR was initialized to 0 always. This is not the case for 4.1.y
at least. See https://github.com/open-mpi/ompi/issues/12049.

Therefore we use the retun code to determine whether there was an
error. Note that the default error handler usually is to abort the
application if errors occur. In that case the error code will always
return success.
2023-11-07 09:44:17 +01:00
Tor Harald Sandve
b25af99362 Merge pull request #835 from daavid00/saltprecPermFac
Multiply well trans due to perm reduction in salt prec
2023-11-01 13:29:32 +01:00
David Landa Marban
d6f39954c8 Mult well trans due to perm reduction in salt prec 2023-10-26 13:43:32 +02:00
Atgeirr Flø Rasmussen
6cece6bc49 Merge pull request #841 from totto82/fixBCFree
Fix BC Free for 2p problems
2023-10-17 14:16:48 +02:00
Tor Harald Sandve
7546716a48 Fix BC Free for 2p problems 2023-10-17 12:28:48 +02:00
Arne Morten Kvarving
4b156dd124 Merge pull request #839 from blattms/missing-header
Included missing header causing compile errors with gcc-13
2023-10-13 08:25:30 +02:00
Markus Blatt
2deab0cc49 Included missing header causing compile errors with gcc-13 2023-10-12 22:16:53 +02:00
Markus Blatt
244595beef Merge pull request #836 from daavid00/vtkCO2STORE
Fix to write VTKS when THERMAL is on deck
2023-10-11 20:07:14 +02:00
David Landa Marban
d4bb923b7a Fix to write VTKS when THERMAL is on deck 2023-10-09 17:05:32 +02:00
Kai Bao
aa07b07da1 Merge pull request #834 from GitPaean/removing_flashproperties
removing flashproperties.hh from multiple files
2023-10-09 13:50:08 +02:00
Kai Bao
ca35fd963f removing flashproperties.hh from multiple files
it does not looks like it is used.
2023-10-09 12:49:06 +02:00
Kai Bao
fdad32a20a Merge pull request #832 from GitPaean/removing_ncpflash_flashratevector
removing NCPFlash header file in flashratevector
2023-10-09 10:47:24 +02:00
Kai Bao
b526025b1a removing flashintensivequantities.hh from flashratevector.hh 2023-10-09 09:05:08 +02:00
Kai Bao
361f87afe4 removing NCPFlash header file in flashratevector
it does not look like used.
2023-10-03 16:23:02 +02:00
Bård Skaflestad
0661383baa Merge pull request #828 from totto82/fixTempSwitch
Use temperature from depth in primaryvariable switching
2023-09-21 11:50:49 +02:00
Tor Harald Sandve
0719601e2b Use temperature from depth in primaryvariable switching 2023-09-18 12:34:52 +02:00
Bård Skaflestad
e6220e7563 Merge pull request #827 from vkip/bflowijk
Add support for the summary vectors BFLOW[I|J|K]
2023-09-13 13:30:30 +02:00
Vegard Kippe
06cba05a51 Store flows if any of the vectors BFLOWI|J|K are requested 2023-09-13 09:20:07 +02:00
Atgeirr Flø Rasmussen
42c399d6ff Merge pull request #826 from akva2/janitoring
anonymize unused parameters
2023-09-05 08:54:19 +02:00
Kai Bao
851dd3e2d1 Merge pull request #825 from GitPaean/tpfa_diffusion
add tpfa diffusion
2023-09-04 20:57:37 +02:00
Arne Morten Kvarving
b0ecbf58de anonymize unused parameters 2023-09-04 14:34:30 +02:00
Kai Bao
87805ba3ec removing compilation warnings and some cleaning up 2023-09-01 10:42:43 +02:00
hnil
7acecc7e57 modification to add tpfa diffusion
fixed tpfa for diffusion module

fixed type error
2023-08-31 15:14:07 +02:00
Kai Bao
7ec77ada7e Merge pull request #822 from hnil/tpfa_temp
TPFA version for energy
2023-08-31 11:17:23 +02:00
Tor Harald Sandve
63764d715c Merge pull request #816 from totto82/maximum_water_sat
add parameter to set maximum water saturation. Default is 1.0
2023-08-30 12:17:24 +02:00
Kai Bao
2813195e15 reusing ResidualNBInfo class in blackoillocalresidualtpfa
to ResidualNBInfo class in tpfalinearizer.
2023-08-30 10:45:12 +02:00
Tor Harald Sandve
da06e423d5 add parameter to set threshold for only water cells. Default is 1.0 2023-08-30 08:38:22 +02:00
hnil
406ebf7cff - Modification to include thermal in tpfalinearizer
- Some assosiated utilites for evaluation properties on globalIndex
2023-08-29 15:58:48 +02:00
Bård Skaflestad
19bde5f5ec Merge pull request #823 from atgeirr/parallel-nldd-fixes
Avoid collective operations in single-domain calls.
2023-08-25 16:17:00 +02:00
Atgeirr Flø Rasmussen
9b55bd57e7 Avoid collective operations in single-domain calls. 2023-08-25 12:25:30 +02:00
Tor Harald Sandve
60c65ec661 add parameter to set maximum water saturation. Default is 1.0 2023-08-17 09:02:16 +02:00
Bård Skaflestad
72e1bfb749 Merge pull request #820 from blattms/try-to-detect-more-paralel-exceptions
Try to detect more exceptions during parallel simulator setup.
2023-08-11 15:18:11 +02:00
Markus Blatt
79dfb6b2a6 Try to detect more exception during parallel simulator setup.
We have experienced some deadlocks lately because of programming
errors. This change will not result in a clean exit for those
but rather an abort by MPI because of non-matching communications.

Also we cannot forsee whether people will add more exceptions in
those parts that were not protected. We better play it safe here.
2023-08-11 14:08:52 +02:00
Atgeirr Flø Rasmussen
67baba967e Merge pull request #821 from akva2/move_dunefem_adaptation_to_separate_class
move the dynamic refinement part related to dune fem to separate class
2023-08-11 09:31:19 +02:00
hnil
37b87aedb1 move the dynamic refinement part related to dune fem to separate class
introduced base discretization in tagsystem to be able to change between dunefem adaptation or not
2023-08-10 15:12:12 +02:00
hnil
7e1a1b27a2 -- added missing include 2023-08-08 11:12:46 +02:00
Atgeirr Flø Rasmussen
ecfb186c38 Merge pull request #799 from hnil/geomech
added enableMech
2023-07-26 19:26:17 +02:00
Bård Skaflestad
c94ba0bde6 Merge pull request #814 from akva2/janitoring
Janitoring: add missing include
2023-07-03 15:10:39 +02:00
Arne Morten Kvarving
9eb80228a6 add missing include 2023-07-03 13:47:26 +02:00
Tor Harald Sandve
f40e7042cb Merge pull request #802 from totto82/bc_schedule
support BC in schedule
2023-06-28 16:26:59 +02:00
Tor Harald Sandve
466bdafabf support BC in schedule 2023-06-28 14:10:09 +02:00
Bård Skaflestad
a542a475c7 Merge pull request #812 from atgeirr/fix-openmp-ifdefs
Fix OPENMP ifdefs.
2023-06-16 09:46:05 +02:00
Atgeirr Flø Rasmussen
8c79af321a Fix OPENMP ifdefs. 2023-06-16 08:46:18 +02:00
Atgeirr Flø Rasmussen
630f620b18 Merge pull request #811 from blattms/allow-omp-settings-from-simulators
ThreadManager: Allow querying number of threads from OpenMP in init.
2023-06-14 13:57:57 +02:00
Markus Blatt
55fdc62ea7 ThreadManager: Allow querying number of threads from OpenMP in init.
We actually do set the number of OpenMP threads based on
OMP_NUM_THREADS or command line option ThreadsPerProcess for OpenMP already
in opm-simulators and these settings should just be used here, too. Hence
the new flag for skipping the command line parameter and use the
number of threads that OpenMP has available.

Querying it here results in different behavior as for FlowMainEbos.hpp:
In opm-simulators variable OMP_NUM_THREADS takes precedence over the
command line parameter, but here it would only be used if the command
line option was not used at all.
2023-06-14 11:24:19 +02:00
Bård Skaflestad
add55bb281 Merge pull request #810 from akva2/janitoring
Janitoring: clean up some headers
2023-06-08 15:32:38 +02:00