Commit Graph

18076 Commits

Author SHA1 Message Date
Tor Harald Sandve
5f8916c0c3 Use cell temperature in perforated cell to compute reservoir rates 2024-08-01 11:14:29 +02:00
Atgeirr Flø Rasmussen
2b147efe78
Merge pull request #5497 from atgeirr/improve-parallel-network-test
Improve parallel network test.
2024-08-01 10:01:59 +02:00
Atgeirr Flø Rasmussen
e5fd6594d2 Improve parallel network test.
The PID part of the timestep controller triggers and results in timestep
sizes depending on the state of the simulation. This can lead to different
timestepping for parallel and serial runs. Using only newton iteration count
for timestep calculations addresses this.

Also, tighten CNV tolerances to avoid solution differences that are accepted by
the simulator as within tolerances, but outside comparison tolerances.
2024-07-31 17:14:26 +02:00
Markus Blatt
03dc006b88
Merge pull request #5488 from lisajulia/fix/ACTIONX-COMPDAT
Fix/actionx compdat
2024-07-30 17:18:04 +02:00
Markus Blatt
40ae8a6c53
Merge pull request #5492 from akva2/janitoring
Some janitoring
2024-07-30 15:02:47 +02:00
Arne Morten Kvarving
c8a3729199 changed: VtkWriteTemperature parameter moved to Opm::Parameters namespace 2024-07-30 13:29:31 +02:00
Arne Morten Kvarving
ec01d7694b changed: VtkPrimaryVarsModule parameters moved to Opm::Parameters namespace 2024-07-30 13:12:54 +02:00
Arne Morten Kvarving
825540691c changed: VtkCompositionModule parameters moved to Opm::Parameters namespace 2024-07-30 13:12:54 +02:00
Arne Morten Kvarving
1759d37f89 changed: VtkBlackoilModule parameters moved to Opm::Parameters namespace 2024-07-30 13:12:54 +02:00
Arne Morten Kvarving
22794f83d1 changed: VtkDiffusionModule parameters moved to Opm::Parameters namespace 2024-07-30 13:12:54 +02:00
Arne Morten Kvarving
58bb7da544 changed: VtkMultiPhaseModule parameters moved to Opm::Parameters namespace 2024-07-30 13:12:54 +02:00
Arne Morten Kvarving
24c60e256f openclSolverBackend: fix shadowing type alias 2024-07-30 11:05:48 +02:00
Arne Morten Kvarving
405a907d63 anonymize unused parameters to quell compiler warnings 2024-07-30 10:55:53 +02:00
Arne Morten Kvarving
2a9077a45c fix macro formatting 2024-07-30 10:55:40 +02:00
Atgeirr Flø Rasmussen
125ee00336
Merge pull request #5489 from lisajulia/feature/documentation-dispatch
Feature/documentation dispatch
2024-07-29 11:18:08 +02:00
Lisa Julia Nebel
efb18d0027 Add possible future connections to the grid methods that handle the well connections 2024-07-29 09:59:52 +02:00
Lisa Julia Nebel
018e49522b Only notify opm-python-documentation when the file docstrings_simulators.json gets changed on master, not for a PR 2024-07-29 08:41:29 +02:00
Markus Blatt
9f76155312
Merge pull request #5487 from atgeirr/further-fixes-for-argument-order
BSD and macOS getopts require options first.
2024-07-26 10:15:42 +02:00
Lisa Julia Nebel
13e3cd590c Fix typos and test the automatic deployment to opm-python-documentation 2024-07-25 19:34:17 +02:00
Lisa Julia Nebel
f89be66ddd Add test to compare two runs with COMPDAT
Two data files get compared: one with ACTIONX and one with the same commands but without ACTIONX.
For sequential runs, they produce the same output, but for parallel runs they don't, because the when the COMPDAT keyword is used in an ACTIONX, well connections get created there that are not known to the grid partitioner.
2024-07-25 16:26:20 +02:00
Lisa Julia Nebel
3d8c1a11b7 Add option to compare two parallel runs 2024-07-25 16:26:20 +02:00
Atgeirr Flø Rasmussen
3e3dd7fa26 BSD and macOS getopts require options first. 2024-07-25 16:19:59 +02:00
Bård Skaflestad
ed5f371133
Merge pull request #5483 from daavid00/rswsat
Output support for RSWSAT and RVWSAT
2024-07-17 16:46:40 +02:00
David Landa Marban
8320a9abdf Output support for RSWSAT and RVWSAT 2024-07-17 13:00:38 +02:00
Markus Blatt
6e74fea547
Merge pull request #5477 from lisajulia/feature/metis-support
Add the metis partitioner as a command line option as well
2024-07-17 07:32:39 +02:00
Markus Blatt
ca2ef490aa
Merge pull request #5408 from BigDataAccelerate/cpr_rocsparse
rocsparse CPR initial version
2024-07-16 18:57:40 +02:00
Lisa Julia Nebel
371fbdfc03 Include <boost/version.hpp> before the macro BOOST_VERSION is checked 2024-07-16 17:39:32 +02:00
Lisa Julia Nebel
653cb28bc2 Add the metis partitioner as a command line option as well 2024-07-16 17:39:28 +02:00
Bård Skaflestad
6ce61a9018
Merge pull request #5478 from lisajulia/feature/add-failureFlag-to-tasklets
Use the failure flag of the tasklet runner to detect a failure while …
2024-07-16 10:05:22 +02:00
Lisa Julia Nebel
e2126ae817 Use the failure flag of the tasklet runner to detect a failure while writing output and throw an error if that happens 2024-07-15 08:51:25 +02:00
Razvan Nane
a79d4aff5a fix rocalutionSolver 2024-07-12 13:31:17 +02:00
Markus Blatt
c243620057
Merge pull request #5474 from lisajulia/feature/add-failureFlag-to-tasklets
Remove UNIFOUT keyword from python test data file SPE1CASE1.DATA
2024-07-12 13:13:47 +02:00
Markus Blatt
e95fa33f8e
Merge pull request #5475 from lisajulia/move-documentation
Move documentation
2024-07-12 12:33:22 +02:00
Razvan Nane
8963bf16f9 fix tests 2024-07-12 11:47:25 +02:00
Bård Skaflestad
7789551b74
Merge pull request #5454 from vkip/omp_num_threads
Handle empty or invalid OMP_NUM_THREADS by Flow default
2024-07-12 09:07:53 +02:00
Vegard Kippe
a078eaacd3 Removing trailing 'p' 2024-07-11 18:15:16 +02:00
Vegard Kippe
dd08952967 Update after move of ThreadsPerProcess from Properties to Parameters 2024-07-11 15:55:34 +02:00
Vegard Kippe
14818028f0 Handle empty or invalied OMP_NUM_THREADS by Flow default and warn if a valid value overrides --threads-per-process 2024-07-11 15:52:20 +02:00
Lisa Julia Nebel
70e5749a97 Change workflow: do not build documentation here but at opm-python-documentation
And notify opm-python-documentation when docstrings_simulators.json changes
2024-07-10 18:03:00 +02:00
Lisa Julia Nebel
42d79ebb97 Delete almost everything of the documentation here, this will be done in a separate repository opm-python-documentation
Keep only the file docstrings.json (renamed to docstrings_simulators.json)
2024-07-10 18:02:41 +02:00
Markus Blatt
93e06d2187
Merge pull request #5473 from vkip/avoid_mpi_int_overflow
Avoid buffers exceeding intmax in MPI calls
2024-07-10 17:24:05 +02:00
Vegard Kippe
fae49636cc Addressing review comments (changed assert to throw, put chunked broadcast in private method) 2024-07-09 19:15:50 +02:00
Lisa Julia Nebel
b4ee039f07 Remove UNIFOUT keyword from python test data file SPE1CASE1b/SPE1CASE1.DATA file as well
... just in case
2024-07-09 17:27:50 +02:00
Lisa Julia Nebel
e9d3d81ae2 Remove UNIFOUT keyword from python test data file SPE1CASE1a/SPE1CASE1.DATA
With this keyword, the SPE1CASE1.UNRST file could not be read in correctly at some point, until I've added a check in opm-models that checks this, this went unnoticed probably.
2024-07-09 17:27:43 +02:00
Vegard Kippe
99d5a147b1 Fix broadcast and initialize int_pos properly.. 2024-07-09 15:02:15 +02:00
Lisa Julia Nebel
fa3392fb7d Use generate_docstring_hpp.py of opm-common and delete the one here 2024-07-09 13:52:01 +02:00
Vegard Kippe
c10695c5d5 Switch to using size_t instead of int for buffer position, and properly account for MPI using int 2024-07-09 13:48:04 +02:00
Bård Skaflestad
eea42f7363
Merge pull request #5472 from atgeirr/test-fixes
Test fixes
2024-07-09 09:21:21 +02:00
Atgeirr Flø Rasmussen
db1be5e92b Fix Damaris test.
The h5diff program returns 1 (failure) if there are any differences at all,
even if using a relative or absolute difference tolerance and seeing no
differences above the tolerance. In that situation, the output will be empty,
but the return value 1.

To make this test behave similar to the other regression tests, we now check
if its output is empty instead.

Also: set relative tolerance to 0.01 and remove the absolute test. This test
is not meant to trigger for numerics changes, but should capture errors in
the writing of the HDF5 file.
2024-07-08 15:57:10 +02:00
Atgeirr Flø Rasmussen
874b136ce9 Enable running test on BSD/MacOS.
BSD getopts() require options first.
2024-07-08 15:55:41 +02:00