Markus Blatt
831f41c0e3
Cater for empty fipnum vectors in output code.
...
Due to loadbalancing this vector might be empty under some circumstances.
Hence the old code would dereference the end iterator which is a bug.
2019-03-22 15:14:08 +01:00
Andreas Lauser
d7e74e7c4e
fix review comment by [at]totto82
2019-03-04 13:59:50 +01:00
Andreas Lauser
b60305082d
EclBaseProblem: fix the parent type tags for the EclBaseProblem tag in the non-default cases
...
this bitrot a bit because it was never seen by the compiler. (I still
did not check if `ebos` compiles and works if `CpGrid` is replaced by
dune-alugrid or `PolyhedralGrid`.)
2019-03-04 13:58:38 +01:00
Andreas Lauser
3ca8b8f285
ebos: improve the messages printed during the run
...
the convergence behaviour can now be understood and the report step
information is printed, too. This does not affect `flow`, becase it
implements its own newton and time stepping routines.
2019-03-04 13:58:38 +01:00
Andreas Lauser
8e5f1279f3
EclWellManager: do not use parallelism
...
the speedup gained by parallelism here are simply not worth the
headaches.
note that `flow` is unaffected by this because it uses
`Opm::BlackoilWellModel`.
2019-03-04 13:58:38 +01:00
Andreas Lauser
43dd9928b4
EclNewtonMethod: Fix convergence criterion if the residual is volumetric
2019-03-04 13:58:38 +01:00
Andreas Lauser
0a9d6a0760
include missing header files
...
this makes the well model and the equil initializer header more autonomous.
2019-03-04 13:58:38 +01:00
Andreas Lauser
f36680bf3a
EclProblem: Rename NewtonRawTolerance to NewtonTolerance
...
this property is not used by `flow` because `flow` implements its own
Newton method, but it not renaming the property prevents `flow` from
building.
2019-03-01 10:48:06 +01:00
Andreas Lauser
c9dfad2a3d
prefix the ECL timestep tuning parameters with 'Ecl'
2019-02-20 12:47:12 +01:00
Andreas Lauser
148728973f
fix the output of the size of the next time step if timestepping is done externaly
2019-02-20 12:47:12 +01:00
Andreas Lauser
b1a526e5c2
ebos: remove unused deprecated function
2019-02-20 12:47:12 +01:00
Andreas Lauser
a34a8d6b9e
ebos: implement partial support for the TUNING keyword
...
this only implements the parameters that are currently supported by
`flow`.
2019-02-20 12:47:12 +01:00
Andreas Lauser
0b600cb824
Merge pull request #483 from totto82/massratebc
...
Add option for setting mass boundary rate from deck
2019-02-20 12:15:21 +01:00
Tor Harald Sandve
430e667517
Add option for setting mass boundary rate from deck
...
Usage
BCRATE
1 1 1 1 1 10 X WATER 1e-7 /
This will inject 1e-7 of water (mass/time/length/length) on the x side of the
boundary cells with cartesian index [1 1 1] to [1 1 10]
2019-02-20 10:56:53 +01:00
Tor Harald Sandve
b4382c23e8
Merge pull request #481 from andlaus/add_experimental_mode
...
introduce an "experimental mode"
2019-02-20 09:39:33 +01:00
Andreas Lauser
c80e4c40c4
fix missing semicolon
2019-02-19 11:04:40 +01:00
Andreas Lauser
10d1d5c9a7
introduce an "experimental mode"
...
this is a compile time switch with the intention to be able to more
easily turn experimental features that are not yet considered to be
production quality on and off. DUNE has a similar mechanism (i.e., the
`DUNE_GRID_EXPERIMENTAL_GRID_EXTENSIONS` macro), but it relies on
the preprocessor.
For now, the property does not have any effect.
2019-02-19 10:22:34 +01:00
Tor Harald Sandve
9de0e54b63
Merge pull request #475 from andlaus/fix_ecl_restart
...
ebos: Fix restart from ECL files
2019-02-19 10:11:02 +01:00
Andreas Lauser
7165ae246a
ebos: clarify startup message
...
this hopefully makes the purpose of `ebos` clear in its
description. this prose should be interpreted as "if you use ebos in
production, you are on your own and you should only expect a very
limited amount of support (or even sympathy) if something breaks".
2019-02-19 10:07:01 +01:00
Andreas Lauser
5b032a6a28
fix the issues found by [at]tosa82 in his review
...
in particular the missing synchronization after restarts was very
nasty to find. thanks a ton for pointing this out!
also, IIRC changing DR[SV]DT in the schedule section has been working
properly for a while, so the comment which stated the opposite is
removed as well.
2019-02-19 09:07:12 +01:00
Andreas Lauser
65d44a055f
EclProblem: fix a few minor style issues
2019-02-18 15:30:28 +01:00
Andreas Lauser
427741fe84
ebos: Fix restart from ECL files
...
Some time loop stuff was missing in the doobly-doo, the init() method
of the well model was not called and there was the slightly deeper
issue that the initial solutions where not calculated on restarts
which breaks everything that relies on them. (at the moment, that's
everything which is related to non-trivial boundary contitions.)
2019-02-18 15:29:27 +01:00
Andreas Lauser
2e75eaa0ac
Merge pull request #390 from joakim-hove/opm-rst-default-false
...
[Equinor internal]: Opm rst default false
2019-02-18 12:19:13 +01:00
Tor Harald Sandve
a86ee61bf6
Merge pull request #478 from andlaus/ebos_remove_mass_conservative_init
...
ebos: remove the code to calculate a mass conservative initial condtion if the specified condition is inconsistent
2019-02-18 11:18:12 +01:00
Andreas Lauser
3cd1252079
ebos: remove the code to calculate a mass conservative initial condtion if the specified condition is inconsistent
...
As far as I can see, this was always set to `false` anyway.
2019-02-15 13:45:23 +01:00
Andreas Lauser
0423676305
ebos: remove the DisableWells property
...
the purpose of this was a hack to be able to manipulate the Jacobian
matrix directly from outside code. Since `flow` has been converted to
the eWoms wells API, this is not required anymore.
2019-02-15 13:39:58 +01:00
Arne Morten Kvarving
c02ca868d6
Merge pull request #466 from atgeirr/handle-nnc
...
Use NNC support from CpGrid.
2019-02-14 10:22:42 +01:00
Andreas Lauser
0e761010a8
Merge pull request #472 from totto82/freeBC
...
Add support for using free boundary conditions in Flow
2019-02-08 20:50:02 +01:00
Tor Harald Sandve
a5463ed1a0
Add support for using free boundary conditions in Flow
...
The OPM spesific keywords FREEBC[XYZ[-]] can be used to specify
boundary cells that are open. Default is a closed boundary.
2019-02-07 14:56:55 +01:00
Atgeirr Flø Rasmussen
e926f557b8
Fix: indexInInside() and indexInOutside() return signed integers.
2019-02-07 12:00:49 +01:00
Atgeirr Flø Rasmussen
d087d7c41b
Use NNC support from CpGrid.
2019-02-07 12:00:49 +01:00
Andreas Lauser
51b24d33d5
EclWriter: remove obsolete writeOutput() overload
...
this has been unused for any simulator for a while. the only code
which called it was the ECL output test, but this one could be easily
ported.
2019-02-06 12:21:08 +01:00
Andreas Lauser
dc1b92521a
ebos: make it possible to account for external setup costs
2019-02-06 12:21:08 +01:00
Andreas Lauser
4ecda15b11
coding style fixes for the black-oil model and more style fixes for ebos
2019-02-01 17:33:30 +01:00
Andreas Lauser
7f27c4fb4b
fix coding style of the ECL tracer model
2019-02-01 17:33:30 +01:00
Andreas Lauser
9afa62b78b
fix some minor coding style issues in Ewoms::EclOutputBlackOilModule
2019-02-01 17:33:30 +01:00
Andreas Lauser
8b89e6ed97
unify coding style of Ewoms::AluCartesianIndexMapper
2019-02-01 17:33:30 +01:00
Andreas Lauser
c600d807b6
use the eWoms coding style conventions for Ewoms::TracerVdTable
2019-02-01 17:33:30 +01:00
Andreas Lauser
a9359602fc
fix some minor coding style inconsistencies in EclWriter
2019-02-01 17:33:30 +01:00
Andreas Lauser
80e04aa8b4
fix style issues in EclTransmissibility and make the editNnc handling a bit simpler
...
the new editNNC code might be slightly slower, but I doubt that the
difference is even measureable for real decks.
2019-02-01 17:33:30 +01:00
Andreas Lauser
0aa9a2c6b8
make the coding style of femcpgridcompat.hh consistent with the rest of eWoms/ebos
2019-02-01 17:33:30 +01:00
Tor Harald Sandve
fb34eb304c
Fix generic boundary conditions for blackoil model
...
Currently it doesn't allow for polymer or solvent influx
on the boundary with the free flow option
2019-01-31 15:41:47 +01:00
Andreas Lauser
70a7207578
Merge pull request #465 from GitPaean/fixing_single_precision_restart
...
each phase needs to be above certain value to be treated to be present
2019-01-22 16:11:53 +01:00
Kai Bao
56e829329f
each phase needs to be above certain value to be treated to be present
...
it helps to recover some RESTART running based on single precision
format.
2019-01-22 13:53:08 +01:00
Andreas Lauser
dc6de0c31a
Merge pull request #463 from totto82/convertFIPtoLAB
...
convert FIP values to LAB scale
2019-01-21 16:19:04 +01:00
Tor Harald Sandve
ee7b47e0f9
convert FIP values to LAB scale
2019-01-21 14:55:40 +01:00
Tor Harald Sandve
22097d4c10
Add trivial connection output to silence the output code
...
In this PR only trivial data is added.
2019-01-18 14:57:25 +01:00
Markus Blatt
3b8ef5f004
one line per variable as requested.
2019-01-16 13:16:45 +01:00
Markus Blatt
d87c5764b9
Use doxygen style suggested by reviewer.
2019-01-16 13:16:45 +01:00
Markus Blatt
ace49a2c22
Adhere to CamelCase for types, functions, and variables.
...
This seems to be covered for types and functions by our coding style
with room for interpretation. For variables the coding styles asks for
underlines though, but nevermind.
2019-01-16 13:16:45 +01:00