Commit Graph

20558 Commits

Author SHA1 Message Date
Bård Skaflestad
9e7c3b9254
Merge pull request #5687 from GitPaean/tyring_ecl_compositional
ecl style output for compositional simulation
2024-10-30 15:49:35 +01:00
Kai Bao
0edb5a462d checking compIdx or phaseIdx when adding entries to SolutionVector
std::vector is used instead of std::array. when compIdx is -1, the
origional code trigger array-bounds warning.
2024-10-30 15:32:39 +01:00
Kai Bao
c6201e9b6a addressing reviewing comments 2024-10-30 13:15:38 +01:00
Bård Skaflestad
78226f2819
Merge pull request #5693 from bska/private-fetch-well-pi
Make WELPI Infrastructure for ACTIONX Fully Private
2024-10-30 13:12:49 +01:00
Bård Skaflestad
70e8d25276 Make WELPI Infrastructure for ACTIONX Fully Private
This is in preparation of making the match set for ACTIONX more
general.  Having a fully private WELPI framework means we can change
the types more freely without having to rebuild all users of
ActionHandler.

While here, also add Doxygen-style documentation to the ActionHandler.
2024-10-30 12:48:02 +01:00
Kai Bao
56db6ad3fe cleaning unused headers and declarations in OutputCompositionalModule 2024-10-30 11:23:16 +01:00
Kai Bao
cd9009dc75 adding isCompositional_ variable to GenericOutputBlackoilModule
to indicate whether it is a compostional simulation.
2024-10-30 11:23:16 +01:00
Kai Bao
65e858c84c fixing all the warnings related 2024-10-30 11:23:16 +01:00
Kai Bao
51c534e6fb removing Damaris from FlowProblemComp 2024-10-30 11:23:16 +01:00
Kai Bao
8541048f83 fixing the running of co2_ptflash_ecfv 2024-10-30 11:23:16 +01:00
Kai Bao
def30fa131 recovering OutputBlackoilModule
there is not change needed for this file.
2024-10-30 11:23:16 +01:00
Kai Bao
e4d1311589 adding thresholdPressure() interface to FlowProblemComp
although we do not support it yet.
2024-10-30 11:23:16 +01:00
Kai Bao
3635132d95 making OutputModule template parameter of EclWriter 2024-10-30 11:23:16 +01:00
Kai Bao
197282ccfc cleaing up EclWriter related and DamarisWriter.hpp 2024-10-30 11:23:16 +01:00
Kai Bao
0153da2009 cleaning up OutputCompositionalModule 2024-10-30 11:23:16 +01:00
Kai Bao
a8d2c5bc2c removing GenericOutputCompositionalModule
we do the compostional related in GenericOutputBlackoilModule to minimize the code change.
there needs to be refatoring for GenericOutputBlackoilModule to split
the black oil and compostional related.
2024-10-30 11:22:04 +01:00
Kai Bao
ad587e77ad output XMF ,YMF and ZMF in UNRST file.
currently, it looks the value for ZMF is based on XMF and YMF.
ideally, the ZMF is part of the primary varialbes, it does not need to
be calculated based on XMF and YMF.

there is some refactoring that we can do here.
2024-10-30 11:15:38 +01:00
Kai Bao
4ba1cd53d7 add EclWriter to FlowProblemComp
so the FlowProblemComp can output ecl style output.
it duplicates the OutputBlackoilModule and GenericOutputBlackoilModule
for compositional related output for now.
2024-10-30 11:14:18 +01:00
Bård Skaflestad
0a128e8a17
Merge pull request #5699 from bska/log-pyaction
Add Logging for Python Actions
2024-10-30 09:15:03 +01:00
Bård Skaflestad
0d9000e7e0
Merge pull request #5697 from bska/dont-index-oob-for-welpi
Handle WELPI from ACTIONX Separately From Constraints
2024-10-30 09:14:12 +01:00
Bård Skaflestad
e8b4cfb7ef Add Logging for Python Actions
Similar to the logging facilities we have for the regular ACTIONX
keyword, although without an explicit list of "matching" wells.
2024-10-29 21:21:27 +01:00
Bård Skaflestad
0240922cf4 Handle WELPI from ACTIONX Separately From Constraints
This commit switches to using the 'welpi_wells' information from the
SimulatorUpdate structure as a basis to decide the wells for which
it is safe/sufficient to update only the CTFs in response to an
ACTIONX block running WELPI.  To this end, we split the actions of
the existing member function updateEclWells() into two parts,

  1. updateEclWellsConstraints()
  2. updateEclWellsCTFFromAction()

in which the first handles well status and well control updates
while the second deals with CTF updates in response to WELPI.  We do
not run the second part if the well structure has changed--e.g., due
to COMPDAT or WELOPEN--since the update loop depends on a static
connection topology.

We add a new member function wellUpdateLoop() which will traverse a
sequence of well names and invoke a loop body on those wells which
exist in wells_ecl_.  This collects common operations needed for
both the constraints and the CTF updates.
2024-10-29 14:06:08 +01:00
Arne Morten Kvarving
c67f39db80
Merge pull request #5692 from akva2/fix_missing_rescoup_serialization
add missing ReservoirCouplingInfo.hpp includes
2024-10-29 11:51:30 +01:00
Arne Morten Kvarving
58365df3ff add missing ReservoirCouplingInfo.hpp includes
now that Schedule(State) properly serializes the member
2024-10-28 15:51:14 +01:00
Bård Skaflestad
d8c6ebb509
Merge pull request #5691 from GitPaean/enableThresholdPressure_false
enableThresholdPressure_ initialized to be false
2024-10-25 12:45:44 +02:00
Markus Blatt
4a60c167fb
Merge pull request #5686 from vkip/bugfix_inactive_rank0
Bugfixes #5609
2024-10-25 12:00:46 +02:00
Kai Bao
6742679e48 enableThresholdPressure_ initialized to be false
in GenericThresholdPressure
2024-10-25 11:58:27 +02:00
Markus Blatt
5a350e5b3f
Merge pull request #5690 from bska/well-matcher-from-schedule
Get WellMatcher Object Directly From Schedule
2024-10-25 11:28:26 +02:00
Bård Skaflestad
7f4d787522 Get WellMatcher Object Directly From Schedule
There's no need for us to invoke the WellMatcher constructor when
the Schedule object already knows how to do that.
2024-10-25 10:55:32 +02:00
Vegard Kippe
7f6c7aec01 Info message, cmdline option and avoid splitting wells on restart (for now) 2024-10-22 20:29:24 +02:00
Atgeirr Flø Rasmussen
bf5f0c864d
Merge pull request #5605 from totto82/issue_stopped_wells
Fix issue with stopped injectors in thermal runs
2024-10-22 10:48:44 +02:00
Vegard Kippe
729d3c2a59 Use bool, not int, to also add inactive wells to rank 0... 2024-10-21 15:30:50 +02:00
Lisa Julia Nebel
5032a37283
Merge pull request #5649 from aritorto/levelsCartMappALU
Separate non-DUNE methods in LevelCartesianIndexMapper<AluGrid>
2024-10-21 15:01:22 +02:00
Bård Skaflestad
09ebfbf3e3
Merge pull request #5664 from GitPaean/make_flowexp_version_output_rst
in flowexp_blackoil, invalidate output data after solution is updated
2024-10-21 12:04:47 +02:00
Antonella Ritorto
b875ba8122 LevelCartesianIndexMapper for AluGrid 2024-10-21 11:25:27 +02:00
Kai Bao
3d04a97ff5 removing invalidateLocalData() in updateSolution() in BlackoilModel 2024-10-21 10:42:39 +02:00
Kai Bao
2d082cae42 in flowexp_blackoil, invalidate output data after solution is updated 2024-10-21 10:34:00 +02:00
Markus Blatt
afcfedb9f1
Merge pull request #5609 from vkip/use_only_active_wells_in_partitioning
In partitioning, only account for wells that will be active at some point in time
2024-10-21 07:35:28 +02:00
Arne Morten Kvarving
139088398c
Merge pull request #5682 from akva2/lambda_janitoring
Some lambda fixes
2024-10-17 12:54:55 +02:00
Arne Morten Kvarving
501ee0f818 avoid declaring t1 outside lambda
clang doesn't want us to capture t1, and g++-14 requires us
to capture t1. this workaround avoids warnings with both.
2024-10-17 12:32:59 +02:00
Arne Morten Kvarving
0af94eef27 remove unused capture 2024-10-17 11:32:04 +02:00
Bård Skaflestad
0d4b7ece0a
Merge pull request #5668 from totto82/fixGWrestart
FIX gas-water restart
2024-10-17 09:18:31 +02:00
Tor Harald Sandve
a45ad36c70 Add rsw to restart arrays and remove temperature 2024-10-17 08:53:17 +02:00
Vegard Kippe
9d9726920b Post-review update - reducing global communication and simplifying 2024-10-16 22:24:01 +02:00
Vegard Kippe
6c4512be12 Fix MPI restart issue (test failures for some oil-water cases) 2024-10-16 22:24:01 +02:00
Vegard Kippe
4bc904d941 Fix RFT output for non-root connections.. 2024-10-16 22:24:01 +02:00
Vegard Kippe
f7ac4f8a3c Avoid initializing inactive multi-segment wells + avoid direct MPI call 2024-10-16 22:24:01 +02:00
Vegard Kippe
5191271883 Add inactive wells to all partitions with connections 2024-10-16 22:24:01 +02:00
Vegard Kippe
cd26ce5568 Add inactive wells to rank 0 for output 2024-10-16 22:24:00 +02:00
Vegard Kippe
7ee218b1e2 In partitioning, only account for wells that will be active at some point in the simulation. 2024-10-16 22:24:00 +02:00