Stein Krogstad
a483839caa
return zero for powers with negative base
2023-12-05 21:28:54 +01:00
Bård Skaflestad
338c210985
Merge pull request #5034 from akva2/fix_fip_no_summary_kw
...
fixed: grab list of FIP regions from FieldPropsManager
2023-12-04 17:46:00 +01:00
Arne Morten Kvarving
d120fe1ebc
fixed: grab list of FIP regions from FieldPropsManager
...
not from SummaryConfig. the latter only holds regions with
summary keywords
2023-12-04 13:24:32 +01:00
Bård Skaflestad
7c41fea5c2
Merge pull request #5035 from akva2/janitoring
...
Janitoring: fix dead stores
2023-12-04 13:11:31 +01:00
Bård Skaflestad
bf1484995a
Merge pull request #5033 from vkip/udq_wconprod_alq
...
Allow using UDQ for WCONPROD item 12 (ALQ)
2023-12-04 13:10:49 +01:00
Arne Morten Kvarving
7da71783ba
fix dead stores
2023-12-04 12:40:55 +01:00
Vegard Kippe
55067636f4
Ensuring that the UDA is updated every time step, not just only report step.
2023-12-01 19:44:09 +01:00
Vegard Kippe
fa6697a5fa
Capture reference in lambda
2023-12-01 13:30:48 +01:00
Vegard Kippe
69f82f1104
Allow using UDQ for WCONPROD item 12 (ALQ)
2023-12-01 13:21:34 +01:00
Bård Skaflestad
b7ad5a9d29
Merge pull request #5032 from vkip/catch_welltesting
...
Catch exceptions from well testing
2023-12-01 10:33:01 +01:00
Vegard Kippe
17452e0fc6
Adding const
2023-12-01 09:34:42 +01:00
Vegard Kippe
0acb148ba7
Using std::exception
2023-11-30 16:13:40 +01:00
Vegard Kippe
2294983759
Catch exceptions from well testing (often: inf/nan in MSW matrices).
2023-11-29 09:17:53 +01:00
Markus Blatt
c6bb607cdc
Merge pull request #5029 from aritorto/cartCoord
...
CartesianCoordinateLevel added for ALUGrid
2023-11-28 17:18:12 +01:00
Antonella Ritorto
8017ff9a02
add cartesianCoordianteLevel in ALUCartIdxMapp, used in RelperDiag
2023-11-28 15:47:00 +01:00
Bård Skaflestad
5fe1eafb34
Merge pull request #5026 from totto82/fix_gpmaint2
...
Bugfix sign of gpmaint prod
2023-11-28 11:16:03 +01:00
Tor Harald Sandve
0a4cfab875
Add GPMAINT-11 to regression test
2023-11-28 08:08:58 +01:00
Tor Harald Sandve
f7323bd679
fix sign of gpmaint prod
2023-11-27 15:10:11 +01:00
Atgeirr Flø Rasmussen
cb3ab14a71
Merge pull request #5025 from blattms/expect-singular-matrices-upate-WellControl
...
[bugfix] Expect singular matrices, terminate updateWellControls/nonlinear and cut timestep
2023-11-27 08:42:11 +01:00
Markus Blatt
31ab752ae6
[fix] Parallel try-catch also added for updateWellControls for groups.
...
Not sure whether this is needed, but better safe than sorry.
2023-11-25 21:04:13 +01:00
Markus Blatt
50c25ead52
[bugfix] Expect singular matrices and terminate updateWellControls.
...
We are experiencing singular matrices when solving mulisegment wells
sometimes. In that case (here during
BlackoilModelEbos::assembleReservoir <-
BlackoilModelEbos::initialLinerization <-
BlackoilModelEbos:::nonlinearIterationNewton ) an exception is thrown
when updating the controls of a well.
The problem here is that this exception only happens on one
process. That one goes to the catch block in
NonLinearSolverEbos::step, marks the nonlinear solve as failed and
cuts the time step. The others move to the collective communication
below. Somehow and somewhen all end up in a non-matching collective
communication with different data types and we get an MPI Error that
the message was truncated.
Now all processes will throw, terminate the nonlinear solver and cut
the timestep as it should be.
2023-11-25 19:32:11 +01:00
Bård Skaflestad
a6d583b9d0
Merge pull request #5024 from blattms/not-warn-loadStep-OutputDir
...
Do not warn about OutputDir when combined with LoadStep.
2023-11-24 19:03:52 +01:00
Bård Skaflestad
6b78dd4ad4
Merge pull request #5021 from atgeirr/nldd-refinements
...
Nldd refinements
2023-11-24 16:40:39 +01:00
Atgeirr Flø Rasmussen
6945b927ec
Minor refactoring of domain ordering for NLDD.
2023-11-24 14:57:45 +01:00
Markus Blatt
fa10546c0a
Do not warn about OutputDir when combined with LoadStep.
...
Both can safely be used together.
2023-11-24 13:28:20 +01:00
Markus Blatt
24408862ff
Merge pull request #5008 from aritorto/compressedLevelZero
...
compressedLevelZero used to read relative permeability
2023-11-24 13:21:23 +01:00
Bård Skaflestad
cd94ac3a7c
Merge pull request #5023 from totto82/wpimult
...
Adapt wdfac to wpimult
2023-11-23 16:28:32 +01:00
Bård Skaflestad
7343aca2be
Merge pull request #5018 from blattms/parallel-well-fixes
...
[fix] Do parallel sums with int instead of bool.
2023-11-23 16:24:36 +01:00
Bård Skaflestad
4aa1cac099
Merge pull request #5015 from GitPaean/no_explicit_updating
...
not updating connection pressure for StandardWell early in computeWellRatesWithBhpIterations.
2023-11-23 16:20:18 +01:00
Tor Harald Sandve
e1aa233026
Adapt wdfac to wpimult
2023-11-23 15:22:51 +01:00
Atgeirr Flø Rasmussen
6f04c31c7c
Use string to enum helper.
2023-11-23 14:06:39 +01:00
Atgeirr Flø Rasmussen
7578fbf144
Change nldd default approach to gauss-seidel.
...
Also adjust local CNV tolerance scaling to 0.1 instead of 0.01.
2023-11-23 14:06:39 +01:00
Atgeirr Flø Rasmussen
94554ea4f2
Change default nldd number of domains to one per 1000 cells.
2023-11-23 14:06:39 +01:00
Atgeirr Flø Rasmussen
8acc8af2a4
Add MaxPressure NLDD domain ordering option, make it default.
2023-11-23 14:06:39 +01:00
Kai Bao
3aed0b9501
not updating the connection pressure for StandardWell
...
at the early stage of computeWellRatesWithBhpIterations. The perforation rates are not updated,
and it is not sensible to update based on the inconsistent well rates and perforation rates.
Better to keep the original explicit quantities for better consistency.
Furthermore, it can be dangerous to update the explicit quantities based on the
irrelevant perforation rates, since the ratios can be very undesirable due to crossflow.
2023-11-23 09:13:57 +01:00
Bård Skaflestad
8f6b2b99e7
Merge pull request #5014 from bska/fix_shut_in_for_non_operable_wells
...
Fix shut-in logic for wells with shut-instructions (revised)
2023-11-22 19:41:56 +01:00
Bård Skaflestad
6f64388f1e
Reduce Timestep for Certain Sensitive Tests
...
This increases the cost of those tests, but in return we get
improved determinism and stability of the tests.
2023-11-22 16:53:48 +01:00
Stein Krogstad
b08bc029e6
Fix shut-in logic for wells with shut-intructions
2023-11-22 16:53:48 +01:00
Markus Blatt
6a866ac8d2
[fix] Do parallel sums with int instead of bool.
...
Using bool here is at least frowned upon. To be honest, I have no idea
what happens underneath here if we pass a bool. In contrast to other
pod types we do not associate it with a builtin type of MPI (not even
sure what to use). Hence we probably create a custom type for sending
and receiving. That should work. But I have no idea what will be used
for summation.
BTW: I am debugging a case that previously crashed and now suddenly
works and this seems to be the only relevant change I made in the
meantime.
2023-11-22 16:50:57 +01:00
Bård Skaflestad
82a83d04e2
Merge pull request #5017 from akva2/missing_include
...
add missing include
2023-11-22 15:26:14 +01:00
Bård Skaflestad
8dca5a931e
Merge pull request #5005 from totto82/fixWDFACCOR
...
dont scale d factor from wdfaccor with connection factor
2023-11-22 14:55:51 +01:00
Tor Harald Sandve
be06132702
remove trans multiplier from dake
2023-11-22 13:59:06 +01:00
Tor Harald Sandve
5a6af752e3
Merge pull request #4912 from totto82/fix_bccon
...
fix issue when BCPROP is not set initially
2023-11-22 13:41:19 +01:00
Arne Morten Kvarving
f2a2fc2938
add missing include
2023-11-22 13:18:56 +01:00
Bård Skaflestad
3a01da0a12
Merge pull request #5010 from totto82/cgfrf
...
Add output of connection dissolved gas and vaporized oil
2023-11-22 12:54:33 +01:00
Bård Skaflestad
925d5685a1
Merge pull request #5016 from akva2/fix_gen_headers_superbuild_ninja
...
fixed: also add dependency with ninja generator
2023-11-22 12:51:05 +01:00
Arne Morten Kvarving
0157385668
fixed: also add dependency with ninja generator
2023-11-22 12:27:31 +01:00
Arne Morten Kvarving
06d0e7f877
Merge pull request #4967 from multitalentloes/parallelize_cpu_dilu
...
OpenMP parallelize DILU with matrix reordering
2023-11-22 11:19:23 +01:00
Tobias Meyer Andersen
ee95223b27
Use std::optional to only allocate reordered matrix when using multiple threads
2023-11-22 10:10:29 +01:00
Tor Harald Sandve
4879896789
adapt to refactoring of getDFactor
2023-11-22 09:17:28 +01:00