Stein Krogstad
aa8516c085
Respect "global" switching logic also in local solves
2024-05-31 14:11:10 +02:00
Stein Krogstad
008fd268c5
fix bug
2024-05-31 14:11:10 +02:00
Stein Krogstad
c5f7d02bf7
Make thp-func constistent with bhp-func and add some damage prevention logic for severe extrapolation
2024-05-31 14:11:10 +02:00
Arne Morten Kvarving
c92d80e0e8
Merge pull request #5399 from daavid00/fixMacOS
...
[FIX]: Build issue if OpenMP is not present
2024-05-31 09:56:39 +02:00
David Landa Marban
a6ed584ae2
[FIX]: Build issue if OpenMP is not present
2024-05-31 09:00:57 +02:00
Arne Morten Kvarving
bcbac79486
Merge pull request #5380 from akva2/linalg_template_scalar
...
LinAlg classes: template Scalar type
2024-05-31 08:40:11 +02:00
Bård Skaflestad
8b17c18ead
Merge pull request #5397 from GitPaean/renaming_calcRates
...
renaming calcRates to calcResvCoeff, and calcInjRates to calcInjResvCoeff.
2024-05-30 08:45:38 +02:00
Kai Bao
e968da28bb
renaming calcRates to calcResvCoeff
...
and calcInjRates to calcInjResvCoeff.
2024-05-29 22:29:12 +02:00
Bård Skaflestad
808035c9e8
Merge pull request #5396 from bska/activate-udq-undef-test
...
Add Regression Test for Undefined UDQ Variables
2024-05-29 16:03:41 +02:00
Bård Skaflestad
d0ea690cfa
Add Regression Test for Undefined UDQ Variables
...
Undefined UDQs get the value in UDQPARAM(3). The UDQ-01 test model
triggers an action block if and only if we implement that behaviour.
2024-05-29 13:30:43 +02:00
Bård Skaflestad
4df6880f91
Merge pull request #5334 from bska/udq-undef-smrystate-objects
...
Make SummaryState Objects Aware of Undefined UDQ Value
2024-05-29 09:49:41 +02:00
Bård Skaflestad
a3a2b7a978
Make SummaryState Objects Aware of Undefined UDQ Value
...
This PR switches to calling the SummaryState constructor which is
aware of the value of undefined UDQs (OPM/opm-common#4052 ) directly.
While here, also sort headers, split some long lines, and prefer
initialisation lists to constructor body assignments.
2024-05-29 09:16:56 +02:00
Bård Skaflestad
091f758b5a
Merge pull request #5379 from bska/delay-udq-asgn-until-after-smry-output
...
Delay UDQ Assignments Until After Summary Output
2024-05-29 09:13:30 +02:00
Bård Skaflestad
6e8da2309b
Delay UDQ Assignments Until After Summary Output
...
Commit 0aaa69c6e
(PR #5330 ) was a little too eager in its effort to
handle UDQ ASSIGN operations after action processing[%]. In
particular, the assignments, which alter the internal structures of
the SummaryState and UDQState objects, would happen prior to writing
summary files. In turn, this would make it appear as if the
assignment happened too early. This commit defers UDQ assignments
triggered by action processing until FlowProblem<>::endEpisode() for
two reasons
1. The problem originally addressed in 0aaa69c6e
only presented
when the assignment was triggered on the final time step of an
episode (report step), so handling this situation here is a
more targeted approach.
2. Member function FlowProblem<>::endEpisode() is called after we
write the summary file output so any alterations to the
internal structures of the SummaryState will not be visible in
the summary output until the next time step. This is the
expected behaviour.
[%] Insufficient testing by: [at]bska.
2024-05-28 18:16:30 +02:00
Bård Skaflestad
03e8c7ecdc
Merge pull request #5394 from atgeirr/avoid-memory-leak
...
Avoid memory leak from the *unique_ptr<X>.release() antipattern.
2024-05-28 18:15:01 +02:00
Bård Skaflestad
947033705d
Merge pull request #5391 from GitPaean/using_USE_DAMARIS_LIB
...
only trying to link darmaris when requested
2024-05-28 17:09:22 +02:00
Atgeirr Flø Rasmussen
6a7e1e08c0
Avoid memory leak from the *unique_ptr<X>.release() antipattern.
2024-05-28 16:49:08 +02:00
Bård Skaflestad
a16ef8b1c2
Merge pull request #5393 from atgeirr/avoid-out-of-scope-temporary
...
Bugfix: Avoid possible use of out-of-scope temporary.
2024-05-28 16:31:30 +02:00
Kai Bao
481c4830b5
only trying to link darmaris when requested
2024-05-28 16:16:19 +02:00
Atgeirr Flø Rasmussen
0fe76f6011
Bugfix: Avoid possible use of out-of-scope temporary.
...
Since std::clamp returns a reference we must be careful to not capture
the return value by reference, when there is a temporary among the input
parameters.
For the second change (adding the explicit Scalar return type to a lambda)
this is strictly speaking not necessary, as the lambda's return type is not
a reference, but that is obscure so the change is just done as to clarify.
2024-05-28 16:01:48 +02:00
Bård Skaflestad
8199342ce9
Merge pull request #5232 from steink/check_zero_target_from_group
...
When checking for zero target rates, also check wells under group control where required
2024-05-27 22:09:26 +02:00
Bård Skaflestad
c7c72f0ddb
Merge pull request #5389 from GitPaean/stablize_PYACTION_WCONPROD
...
limiting max time step to 10 days for PYACTION_WCONPROD
2024-05-27 17:01:10 +02:00
Kai Bao
0f9633b198
limiting max time step to 10 days for PYACTION_WCONPROD
...
to make the regression checking more stable.
2024-05-27 14:19:04 +02:00
Bård Skaflestad
2bb47476cb
Merge pull request #5365 from lisajulia/feature/pyAction-insert-kw-WECON-WTEST
...
Add pyaction/PYACTION_WTEST_INSERT_KW.DATA to pyactionComparisons.cma…
2024-05-27 10:45:15 +02:00
Bård Skaflestad
7175a74879
Merge pull request #5345 from lisajulia/feature/pyAction-insert-kw-GRUPTREE-WGRUPCON-WELSPECS
...
Add pyaction/PYACTION_GRUPTREE_INSERT_KW.DATA to pyactionComparisons.…
2024-05-27 10:44:37 +02:00
Lisa Julia Nebel
969ec035ec
Add pyaction/PYACTION_GRUPTREE_INSERT_KW.DATA to pyactionComparisons.cmake so it is compared with actionx/ACTIONX_GRUPTREE.DATA
2024-05-27 09:38:38 +02:00
Lisa Julia Nebel
a316264dba
Add pyaction/PYACTION_WTEST_INSERT_KW.DATA to pyactionComparisons.cmake so it is compared with actionx/ACTIONX_WTEST.DATA
2024-05-27 09:36:31 +02:00
Arne Morten Kvarving
41885f5911
ISTLSolverBda: use Scalar type from vector
2024-05-24 14:28:10 +02:00
Arne Morten Kvarving
0e537a8ae3
ISTLSolverBda: fix indent
2024-05-24 14:21:26 +02:00
Arne Morten Kvarving
ad1d862426
BdaBridge: template Scalar type
2024-05-24 14:21:26 +02:00
Arne Morten Kvarving
3eed028978
rocsparseSolverBackend: template Scalar type
2024-05-24 14:21:25 +02:00
Arne Morten Kvarving
e620d9d044
rocaluationSolverBackend: template Scalar type
2024-05-24 14:16:36 +02:00
Arne Morten Kvarving
0b22b62205
amgclSolverBackend: template Scalar type
2024-05-24 14:16:36 +02:00
Arne Morten Kvarving
23250b87e3
cusparseSolverBackend: template Scalar type
2024-05-24 14:16:34 +02:00
Arne Morten Kvarving
18f42b51b2
openclSolverBackend: template Scalar type
2024-05-24 14:09:12 +02:00
Arne Morten Kvarving
d0773ef4f7
BdaSolver: template Scalar type
2024-05-24 14:09:12 +02:00
Arne Morten Kvarving
e03f2394b9
BdaSolver.hpp: drop indent for namespace
2024-05-24 14:09:12 +02:00
Arne Morten Kvarving
7e1f4629ed
CPR: template Scalar type
2024-05-24 14:09:12 +02:00
Arne Morten Kvarving
1f39e6a9a9
BISAI: template Scalar type
2024-05-24 14:09:12 +02:00
Arne Morten Kvarving
8ea523fa68
BILU0: template Scalar type
2024-05-24 14:09:12 +02:00
Arne Morten Kvarving
b75ea188ee
Preconditioner: template Scalar type
2024-05-24 14:09:12 +02:00
Arne Morten Kvarving
05a89d1e96
cuWellContributions: template Scalar type
2024-05-24 14:09:12 +02:00
Arne Morten Kvarving
d2637e53ea
rocsparseWellContributions: template Scalar type
2024-05-24 14:09:12 +02:00
Arne Morten Kvarving
ddcfcf681d
openclWellContributions: template Scalar type
2024-05-24 14:09:11 +02:00
Arne Morten Kvarving
ff39bc3b03
WellContribution: template Scalar type
2024-05-24 14:09:11 +02:00
Arne Morten Kvarving
216f0bea0d
MultisegmentWellContribution: template Scalar type
2024-05-24 14:09:11 +02:00
Arne Morten Kvarving
ba1c6db855
OpenclKernels: template Scalar type
2024-05-24 14:09:11 +02:00
Arne Morten Kvarving
be59203179
OpenclMatrix: template Scalar type
2024-05-24 14:09:11 +02:00
Arne Morten Kvarving
5fbd7635cd
Matrix: template Scalar type
2024-05-24 14:09:11 +02:00
Arne Morten Kvarving
25374b0e54
BlockMatrix: template Scalar type
2024-05-24 14:09:10 +02:00