Bård Skaflestad
abfe4223d2
Merge pull request #6085 from bska/dont-copy-only-to-move
...
Don't Copy Only to Move Result
2025-03-17 14:36:28 +01:00
Bård Skaflestad
73fdf8f5f4
Don't Copy Only to Move Result
...
The original code here used move semantics to transfer ownership,
but commit 15cb87576 (PR #5874 ) switched to using the simpler
by-reference semantics instead. Follow through on this change by
not creating an intermediate copy only to move that copy into
another object. Instead, copy only the report objects when creating
the output requests.
2025-03-17 14:14:21 +01:00
Bård Skaflestad
8d5210e270
Merge pull request #6084 from bska/dont-store-needless-object-reference
...
Don't Store EclipseState Reference in Convergence Output Object
2025-03-17 13:16:54 +01:00
Bård Skaflestad
2fafafda24
Don't Store EclipseState Reference in Convergence Output Object
...
The EclipseState reference is used only for startThread(), so we
might as well request that the caller pass an object when calling
the startThread() function instead of keeping a reference to the
object throughout the simulation run.
While here, also rename the 'already_reported_steps_' to camel case.
2025-03-17 11:45:36 +01:00
Bård Skaflestad
c800c89674
Merge pull request #6082 from bska/log-glo-debug-to-debug-log
...
Log GLO Debug Messages to Debug Log Stream
2025-03-17 11:36:09 +01:00
Bård Skaflestad
4588240124
Merge pull request #6054 from kjetilly/nvcc_fix
...
Fixes for NVCC
2025-03-17 11:01:14 +01:00
Bård Skaflestad
1a8b288682
Log GLO Debug Messages to Debug Log Stream
...
Otherwise, we risk overrunning the INFO (PRT file) stream message
limits in runs with many timesteps.
2025-03-17 10:51:28 +01:00
Tor Harald Sandve
3603ed09a0
Merge pull request #6074 from daavid00/permFact
...
PERMFACT for each saturation region
2025-03-17 09:15:07 +01:00
Bård Skaflestad
c42c8bbc97
Merge pull request #6078 from akva2/fix_clear_events
...
fixed: clear out events before processing actions
2025-03-14 13:25:16 +01:00
Bård Skaflestad
c95c93b78f
Merge pull request #6080 from akva2/wcycle_copy_events
...
WellModel: make a copy of events at start of time step
2025-03-14 11:20:03 +01:00
Arne Morten Kvarving
787c6cf3ae
WellModel: make a copy of events at start of time step
...
these can be modified during sub-stepping, and the wcycle code
needs the original events for decision making
2025-03-14 10:49:22 +01:00
Tor Harald Sandve
0d5bb2d885
Merge pull request #6079 from daavid00/fixExplicitSolution
...
Set SOIL to 0 when readExplicitInitialCondition and 1-SGAS-SWAT=0
2025-03-14 09:17:44 +01:00
David Landa Marban
bd25c13378
Set SOIL to 0 when readExplicitInitialCondition and 1-SGAS-SWAT=0
2025-03-13 20:13:21 +01:00
Markus Blatt
14599fe3c6
Merge pull request #6053 from michal-toth/bugfix/cprw-noActiveWellPerforations
...
Prevent zero division
2025-03-13 14:49:33 +01:00
Bård Skaflestad
e4a7c869be
Merge pull request #6077 from blattms/feature/prevent-some-nan-creations-in-output
...
Prevent some nan creations during output generation.
2025-03-13 13:20:53 +01:00
Arne Morten Kvarving
0dacefc74e
fixed: clear out events before processing actions
...
these have already been processed at start of report step
and should not be executed again
2025-03-13 13:13:08 +01:00
Markus Blatt
69f39598cb
Prevent some nan creations during output generation.
...
If rate that is the nominator is zero just store zero instead of
dividing it by another rater that might also be zero.
Makes searching for other nans more easy.
2025-03-13 11:24:55 +01:00
Arne Morten Kvarving
0ef839d44a
Merge pull request #6076 from akva2/fix_serial_sins
...
Fix sequential build
2025-03-13 10:46:23 +01:00
Arne Morten Kvarving
3878aec46c
fixed: cuda/hip enabled build with no mpi
2025-03-13 10:25:09 +01:00
Arne Morten Kvarving
fdae88d115
fixed: do not try to add source to nonexisting target
2025-03-13 09:46:51 +01:00
Markus Blatt
bf52e20f31
Merge pull request #5893 from hakonhagland/tstep_test2
...
Add a first test case for reservoir coupling
2025-03-13 08:42:05 +01:00
Tor Harald Sandve
e3a7dc18b9
Merge pull request #6060 from daavid00/drsdtDryRunVtk
...
Fix to write vtk (if enabled) for dry runs in cases with drsdt
2025-03-13 08:25:08 +01:00
David Landa Marban
4104c578e0
PERMFACT for each saturation region
2025-03-12 17:02:57 +01:00
Bård Skaflestad
c13241db8e
Merge pull request #6072 from hakonhagland/fix_warn_report_step
...
Fix unused private variable warning
2025-03-12 16:28:44 +01:00
Håkon Hægland
bf0e7d5cd9
Use more descriptive function name
2025-03-12 16:05:01 +01:00
Håkon Hægland
8d69676732
Fix unused private variable warning
2025-03-12 15:28:01 +01:00
David Landa Marban
191581f302
Fix to write vtk (if enabled) for dry runs in cases with drsdt
2025-03-12 14:33:15 +01:00
Arne Morten Kvarving
f1772ba0d7
Merge pull request #6068 from kjetilly/warning_fix
...
Remove assigning to self
2025-03-12 13:22:50 +01:00
Kjetil Olsen Lye
b7cbd09afa
Remove assigning to self
2025-03-12 13:08:51 +01:00
Håkon Hægland
dd24a058a3
Update copyright year
2025-03-12 11:33:48 +01:00
Håkon Hægland
6d00912ec2
Clarify the naming of setSlaveData()
2025-03-12 11:24:24 +01:00
Bård Skaflestad
e5fce07aec
Merge pull request #6036 from bska/expose-zoltan-phg-edge-size-param
...
Make Zoltan's Hyperedge Size Threshold Runtime Controllable
2025-03-11 10:28:33 +01:00
Bård Skaflestad
fed4a3bb1c
Make Zoltan's Hyperedge Size Threshold Runtime Controllable
...
This commit introduces a new hidden runtime parameter,
ZoltanPhgEdgeSizeThreshold (--zoltan-phg-edge-size-threshold,
double, default value = 0.35)
which maps to Zoltan's low-level control parameter
PHG_EDGE_SIZE_THRESHOLD
that controls which hypergraph edges to omit/discard. We add a new
parameter to 'setupZoltanParameters()' and thread the command line
parameter through as an argument to this function.
This is to enable runtime experimentation with this aspect of the
partitioning algorithm, but end-users should typically not alter the
default value without good reason.
2025-03-11 09:55:59 +01:00
Bård Skaflestad
f16080eb21
Revise Parameter Descriptions for Partitioning Parameters
...
Slight rewording and splitting long lines for the most part.
2025-03-11 09:33:05 +01:00
Bård Skaflestad
2e62b6c1cc
Merge pull request #6065 from akva2/fix_optional_deref
...
fixed: capture as optional
2025-03-11 09:28:24 +01:00
Bård Skaflestad
c76f75f8d3
Merge pull request #6064 from akva2/tracer_avoid_alloc
...
Tracer: avoid allocations in inner loop
2025-03-11 09:27:06 +01:00
Arne Morten Kvarving
c9a104bad9
remove unused capture
2025-03-11 09:02:26 +01:00
Arne Morten Kvarving
7006799b7f
fixed: capture as optional
...
unconditional deref while creating (unused) extractor will
trigger asserts in debug iterator builds
2025-03-11 09:00:09 +01:00
Arne Morten Kvarving
137434ddf6
Tracer: avoid allocation in inner loop
2025-03-11 08:51:10 +01:00
Bård Skaflestad
1ef58b643d
Merge pull request #6061 from akva2/tracer_unify_2
...
Tracer: Unify some helper functions
2025-03-10 16:14:37 +01:00
Michal Tóth
0f4df22ea0
Correct a comment
2025-03-10 09:15:44 +01:00
Michal Tóth
847f9f496e
Prevent zero division
2025-03-10 09:07:35 +01:00
Tor Harald Sandve
98703f0c99
Merge pull request #6020 from totto82/stopMSWiter
...
modify stagnation and oscillation code for MSW
2025-03-07 15:22:03 +01:00
Bård Skaflestad
115922da59
Merge pull request #5916 from totto82/fix_gpmaint0
...
Fix gpmaint for region 0
2025-03-07 14:06:34 +01:00
Bård Skaflestad
33661ca6e9
Merge pull request #6059 from daavid00/co2h2output
...
Improving terminal/dbg output
2025-03-07 13:47:03 +01:00
Arne Morten Kvarving
7664f98537
unify computeFreeFlux_ and computeSolFlux_ in one template
2025-03-07 13:11:51 +01:00
Arne Morten Kvarving
d229083b44
unify computeFreeVolume_ and computeSolutionVolume_ in one template
2025-03-07 13:11:51 +01:00
David Landa Marban
a7ae439035
Improving terminal/dbg output
2025-03-07 12:32:35 +01:00
Bård Skaflestad
32a8c07dad
Merge pull request #6030 from akva2/processelement_blockdata_table
...
Move blockdata processing into a table
2025-03-07 11:46:29 +01:00
Arne Morten Kvarving
e7f26dd53a
move block data extractors to a table
2025-03-07 11:10:51 +01:00