Tor Harald Sandve
eb25ce1b99
clean-up comments and code
2022-08-18 08:27:38 +02:00
Tor Harald Sandve
262aead46c
fix issue with summing over ghost cells twice
2022-08-17 10:27:39 +02:00
Tor Harald Sandve
ceac9e5ad8
disable drift compensation for cases without source terms
2022-08-17 10:21:25 +02:00
Tor Harald Sandve
1f54e90f33
Restrict drift compensation by CNV tolerance
2022-08-17 10:21:25 +02:00
Arne Morten Kvarving
6ed8a38ba5
changed: consistently use std::array
2022-08-16 08:38:54 +02:00
Arne Morten Kvarving
8cc0aa24de
changed: switch to using libfmt
2022-08-15 13:48:19 +02:00
Arne Morten Kvarving
a3e46876fb
minor cosmetics
2022-08-15 12:40:13 +02:00
Arne Morten Kvarving
99090ebf72
remove unused method
...
this was previously used by the ebos simulators
2022-08-15 12:40:13 +02:00
Arne Morten Kvarving
c405d718b1
changed: move action update handling to separate class
...
clearer interface boundaries plus it allows to build code only once
2022-08-15 12:40:13 +02:00
Atgeirr Flø Rasmussen
03352ff0fc
Fix missing angle bracket.
2022-08-15 11:29:26 +02:00
Arne Morten Kvarving
4d5f6dde42
changed: move three more methods to generic problem class
2022-08-15 10:30:59 +02:00
Bård Skaflestad
27b695d0be
Fix Averaged Quantities for Non-HC Simulations
...
Commit 6d3da3d2e
introduced the notion of a "dynamic", pressure
dependent pore-volume and switched the 'PoreVolume' aggregates to
reference condition evaluation for output to the 'PORV' field in the
.PRT file. We did however fail to update all existing uses of
'PoreVolume' which introduced an inconsistency. In particular, for
simulation models without hydrocarbons-e.g., a single-phase water
run-the numerator of the volume weighted average would include
pressure effects through the rock compressibility but the
denominator would not.
Thanks to Edmund Stephens for discovering the issue and providing an
example model for analysing the underlying issue.
2022-08-11 16:07:00 +02:00
Arne Morten Kvarving
f57383f416
initstateequil: make it a private template
2022-08-11 15:34:55 +02:00
Arne Morten Kvarving
54cf35e821
equilibrationhelpers: make templates private
2022-08-11 15:34:55 +02:00
Arne Morten Kvarving
b399f72777
changed: avoid typetag dependence in equil initializer
2022-08-11 15:27:38 +02:00
Bård Skaflestad
624d7e51cd
Merge pull request #3977 from totto82/output_drsdtvon
...
output drsdtcon values to restart files
2022-08-11 14:51:12 +02:00
Bård Skaflestad
766543dd18
Merge pull request #3992 from akva2/ecl_modernization
...
Some small modernization changes in ecl classes
2022-08-10 13:26:25 +02:00
Arne Morten Kvarving
c69ee0d321
VtkEclTracerModule: some modernization
...
- typedef -> using
- use constexpr
2022-08-10 12:44:53 +02:00
Arne Morten Kvarving
8ce0f63ef6
FemCpGridCompat: some modernization
...
- typedef -> using
2022-08-10 12:44:53 +02:00
Arne Morten Kvarving
5e9610fdb9
EclThresholdPressure: some modernization
...
- typedef -> using
2022-08-10 12:44:53 +02:00
Arne Morten Kvarving
58b71c94af
EclProblem: some modernization
...
- use if constexpr
2022-08-10 12:44:53 +02:00
Arne Morten Kvarving
17dc99f3cd
EclPolyhedralGridVanguard: some modernization
...
- typedef -> using
2022-08-10 12:44:53 +02:00
Arne Morten Kvarving
c626dc7488
EclNewtonMethod: some modernization
...
- typedef -> using
- use constexpr
2022-08-10 12:44:53 +02:00
Arne Morten Kvarving
beaf8c20f4
EclGenericWriter: some modernization
...
- typedef -> using
2022-08-10 12:44:53 +02:00
Arne Morten Kvarving
834a54686c
EclGenericTracerModel: some modernization
...
- use constexpr
2022-08-10 12:44:53 +02:00
Arne Morten Kvarving
f97f29fa3a
EclFluxModule: some modernization
...
- typedef -> using
2022-08-10 12:44:53 +02:00
Arne Morten Kvarving
ef8c5962b3
EclEquilInitializer: some modernization
...
- use if constexpr
2022-08-10 12:44:53 +02:00
Arne Morten Kvarving
35fa52f0b9
EclDummyGradientCalculator: some modernization
...
- typedef -> using
2022-08-10 12:44:53 +02:00
Arne Morten Kvarving
07283aa780
EclCpGridVanguard: some modernization
...
- typedef -> using
- use constexpr
2022-08-10 12:44:53 +02:00
Arne Morten Kvarving
c2de02a04d
EclAluGridVanguard: some modernization
...
- typedef -> using
- use constexpr
- use nullptr, not 0
- fix some indents
2022-08-10 12:44:53 +02:00
Arne Morten Kvarving
d0c528a240
collecttoiorank: use constexpr
2022-08-10 12:37:04 +02:00
Arne Morten Kvarving
7b74c75f7c
eclalucartesianindexmapper: some modernization
...
- typedef -> using
- use constexpr
2022-08-10 12:37:04 +02:00
Atgeirr Flø Rasmussen
a5c8d40cfa
Remove unneeded timeIdx arguments, also silence other warnings.
2022-08-10 10:01:54 +02:00
Atgeirr Flø Rasmussen
727bf8d01f
Do not make changes to eclthresholdpressure.hh and ecltracermodel.hh.
...
Not required for first version, but should be added later.
2022-08-09 11:11:36 +02:00
Atgeirr Flø Rasmussen
5fba14373b
Modification to reduce PR to minimal changes.
2022-08-09 11:11:36 +02:00
Atgeirr Flø Rasmussen
0da2b68e0b
Adapt to changed interface.
2022-08-09 11:11:36 +02:00
Atgeirr Flø Rasmussen
55b637aedd
Remove unneded class.
...
All functionality is now in EclFluxModule.
2022-08-09 11:11:36 +02:00
Atgeirr Flø Rasmussen
0bf508daf7
Refactor EclFluxModule.
...
This makes that class have the same methods as the EclFluxModuleTpfa, so
the latter can be removed.
2022-08-09 11:11:36 +02:00
Atgeirr Flø Rasmussen
d61e578194
Remove unneeded data member.
2022-08-09 11:11:36 +02:00
Atgeirr Flø Rasmussen
8c0a8eda2c
Fix: Use correct gravity.
2022-08-09 11:11:36 +02:00
Atgeirr Flø Rasmussen
9603a1643e
Continue refactoring flux module.
...
At current commit, see differences (added this commit).
2022-08-09 11:11:36 +02:00
Atgeirr Flø Rasmussen
fb0bc3d55a
Continue cleanup of flux module.
2022-08-09 11:11:36 +02:00
Atgeirr Flø Rasmussen
fdce3e590d
WIP, now runs with just this flux module replacing original versions.
2022-08-09 11:11:36 +02:00
Atgeirr Flø Rasmussen
c48770dc5f
Remove EclProblemTpfa, folding all methods into EclProblem.
2022-08-09 11:11:36 +02:00
Atgeirr Flø Rasmussen
f19b6f723d
Refactor to avoid twin codepaths most places.
2022-08-09 11:09:48 +02:00
hnil
6d3b0a7c1f
tried to make openmp work
2022-08-09 11:09:48 +02:00
hnil
0c03e72782
fixing compilation warning
2022-08-09 11:09:48 +02:00
hnil
c5d547efff
modification for global assembly
2022-08-09 11:09:48 +02:00
hnil
d9c59efcf1
moved transCompFactor to intensive quantities
2022-08-09 11:09:48 +02:00
hnil
07a7070dc0
revert eclproblem.hh back to original
2022-08-09 11:09:48 +02:00