OilfieldToolsNet/opm-simulators
4
0 Fork 0
mirror of https://github.com/OPM/opm-simulators.git synced 2026-11-03 20:56:43 -06:00
Code Issues Packages Projects Releases Wiki Activity
23,467 Commits 31 Branches 117 Tags
c98f74a9dfdcbc650cb44ac6e41fcb6a2d201078
Commit Graph
23467 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Tor Harald Sandve c98f74a9df Start using IPR for bhp calculations during gaslift optimization 2025-12-05 09:22:25 +01:00
Tor Harald Sandve 57c31cbf42 Merge pull request #6620 from totto82/fix_glift 
Fixes for gliftopt item 3 maximum gas+alq
 2025-12-03 14:19:35 +01:00
Tor Harald Sandve b21ac4f5af Proper fix for alq_is_limited 2025-12-03 13:38:07 +01:00
Kai Bao 688e44dbd7 Merge pull request #6630 from GitPaean/small_code_adjustment 
Small code adjustment when reading the code
 2025-12-03 11:57:11 +01:00
Kai Bao 746b7d44bf making the commented argument name reflect the function declaration 2025-12-03 11:11:50 +01:00
Kai Bao 4a1b2ef487 not helpful to have included in OR operation when it is false 2025-12-03 10:22:52 +01:00
David Landa-Marbán d3fceab975 Merge pull request #6651 from daavid00/command 
Nitpicks for command line parameters descriptions
 2025-12-03 10:19:38 +01:00
David Landa Marban db0af827e6 Nitpicks for command line parameters descriptions 2025-12-03 09:56:06 +01:00
Tor Harald Sandve ad6bc9add5 Revert change where only alq_is_limited is true when increase is true 2025-12-02 12:16:35 +01:00
Tor Harald Sandve 39db862116 Store and update well potentials during gaslift optimization 2025-12-02 12:15:33 +01:00
Tor Harald Sandve f9008d07d8 Add a test for GLIFTOPT in glift1 to test interaction with group control 2025-12-02 12:15:33 +01:00
Tor Harald Sandve 59ac8cf97c Enhance glift1 test to actually test gaslift optimization 2025-12-02 12:15:33 +01:00
Tor Harald Sandve 0a7501ddac update well potential for all well after gaslift 2025-12-02 12:15:33 +01:00
Tor Harald Sandve abab405b97 Limit the rates with targets in consitent way 2025-12-02 12:15:33 +01:00
Tor Harald Sandve 6cf86b3884 Fixes for gliftopt item 3 maximum gas+alq 2025-12-02 12:15:33 +01:00
Kai Bao 57b3cfe196 Merge pull request #6645 from hakonhagland/delete_method 
Remove unused method
 2025-12-02 11:29:03 +01:00
Tor Harald Sandve 330bfc0452 Merge pull request #6641 from daavid00/concentr 
Fix BIOEFFECTS Output Units
 2025-12-02 09:06:56 +01:00
Markus Blatt 2052fceaaa Merge pull request #6644 from hakonhagland/fix_formatting 
Fix formattings issues introduced in PR #6575
 2025-12-01 13:26:26 +01:00
David Landa-Marbán 072793abec Merge pull request #6637 from daavid00/xymf 
Bringing back XMFCO2/YMFWAT output
 2025-12-01 12:42:38 +01:00
David Landa-Marbán 0608464944 Merge pull request #6646 from daavid00/voulme 
Fixing biofilm volume fraction vtk output
 2025-12-01 12:03:00 +01:00
David Landa Marban 6328e34837 Fixing biofilm voulme vtk output 2025-12-01 11:06:50 +01:00
Håkon Hægland 1e4f845548 Remove unused method 2025-12-01 06:06:04 +01:00
Håkon Hægland 36c057e839 Fix formattings issues introduced in PR #6575 2025-11-30 18:19:24 +01:00
Atgeirr Flø Rasmussen e724831c33 Merge pull request #6575 from hakonhagland/group_state_helper 
Rename WellGroupHelper to GroupStateHelper
 2025-11-28 13:29:46 +01:00
Kai Bao 1ad967ac51 Merge pull request #6640 from bska/fix-polymer-output-units 
Fix POLYMER Output Units
 2025-11-28 13:11:46 +01:00
David Landa Marban eaf12ff35e Fix BIOEFFECTS Output Units 2025-11-28 12:44:54 +01:00
Bård Skaflestad a227665ced Fix POLYMER Output Units 
The POLYMER result array should be treated as a "concentration" (PR
OPM/opm-common#4749) instead of a saturation when converted to
output units.
 2025-11-28 12:30:59 +01:00
Håkon Hægland 02e63ac1b5 Fix indentation 2025-11-28 12:23:10 +01:00
Bård Skaflestad f752319fa3 Merge pull request #6639 from GitPaean/removing_undefined_function 
removing undefined function pressureDropAutoICD() from MultisegmentWellEval.
 2025-11-28 11:45:28 +01:00
Kai Bao a95b6be43a removing undefined function pressureDropAutoICD() 
from MultisegmentWellEval.
 2025-11-28 11:25:12 +01:00
Håkon Hægland 4ce72a9aec Rename WellGroupHelper 
Rename WellGroupHelper to GroupStateHelper and make GroupState a
non-const pointer such that it is clear that the object can update
GroupState.
 2025-11-28 08:03:55 +01:00
Atgeirr Flø Rasmussen d7381f5d76 Merge pull request #6636 from SoilRos/cleanup/apple-clang-compiler-warnings 
Clean up compiler warnings
 2025-11-27 16:17:45 +01:00
Atgeirr Flø Rasmussen 64a1dc72ba Merge pull request #6631 from hakonhagland/fix_empty_group_state 
Avoid hidden dual state pattern in solveWellWithZeroRate()
 2025-11-27 15:13:30 +01:00
David Landa Marban 21f03bf643 Bringing back XMFCO2/YMFWAT output 2025-11-27 14:50:38 +01:00
Håkon Hægland 5be44f3802 Convert assert() to throw 
Convert assert() to throw to be consistent with usage elsewhere in
the code base where external interface violations should cause
thrown exceptions instead of causing assertion failures which will
not even be enforced in release builds.
 2025-11-27 14:17:29 +01:00
Håkon Hægland f9cfbf0c68 Remove default arguments 
Default arguments have maintenance issues so avoid using them
if possible.
 2025-11-27 14:02:42 +01:00
Santiago Ospina De Los Ríos fe37175c99 Clean up compiler warnings 
* Remove unused parameters
* Declare equality operator of AdaptiveTimeStepping to be const
* Remove warning on lambda captures.
 2025-11-27 14:00:07 +01:00
Atgeirr Flø Rasmussen fbdf34a1e0 Merge pull request #6634 from daavid00/clang 
Fix built in clang
 2025-11-27 10:01:01 +01:00
David Landa Marban 0c299705b1 Fix built in clang 2025-11-27 09:34:37 +01:00
Markus Blatt c0283d8023 Merge pull request #6604 from aritorto/restartVLevels 
Call extractRestartValueLevelGrids
 2025-11-26 22:27:14 +01:00
Tor Harald Sandve 4cbd07630d Merge pull request #5854 from totto82/addTEMP 
Add option for solving the energy equation sequentially
 2025-11-26 13:54:57 +01:00
Atgeirr Flø Rasmussen 8c97b7d7b7 Merge pull request #6618 from jakobtorben/fix-nldd-storage-cache 
Fix nldd storage cache
 2025-11-25 23:13:28 +01:00
Håkon Hægland 4f8af06813 Avoid hidden dual state pattern 
The solveWellWithZeroRate() method created an empty group state and pushed
it into the wgHelper object, then passed wgHelper (along with the
simulator object) to iterateWellEqWithSwitching(). Further down the
call chain in wellUnderZeroGroupRateTarget(), the real group state
was recovered by accessing the simulator object, defeating the
convention that wgHelper should be the single source of truth for
the current group state.

solveWellWithZeroRate() needs to use both an empty group state when
assembling the control equation and the real group state when querying
the well's actual operational status in wellUnderZeroGroupRateTarget()
(to check whether its parent group has a zero rate target).

We solve this by passing a flag "solving_with_zero_rate" down from
solveWellWithZeroRate() and letting the assembleWellEqWithoutIterationImpl()
method check the flag and create the empty group state locally when the
flag is set. This eliminates the need for pushing/popping group state in
wgHelper while maintaining the distinction between assembly (uses empty
group state) and queries (uses real group state).

The issue of having both simulator and wgHelper as sources for the real
group state will be addressed in a follow-up PR.
 2025-11-25 18:10:00 +01:00
Jakob Torben 62fa8610dc Fix NLDD cache corruption 2025-11-25 15:05:41 +01:00
Atgeirr Flø Rasmussen 5a8c5c4e95 Merge pull request #6627 from akva2/janitoring 
add virtual dtor to class with virtual member functions
 2025-11-25 14:40:34 +01:00
Kai Bao 902384a962 Merge pull request #6629 from atgeirr/fix-group-economic-limit-parallel 
Only call WellTestState::close_well() for local wells.
 2025-11-25 12:37:54 +01:00
Atgeirr Flø Rasmussen d9160eb351 Only call WellTestState::close_well() for local wells. 2025-11-25 11:05:35 +01:00
Kai Bao f6f8940a58 Merge pull request #6599 from michal-toth/distributed-wells/pressure-first-conn 
Avoid copying pressure_first_connection from the previous well state
 2025-11-24 15:28:45 +01:00
Arne Morten Kvarving 62315e87ea add virtual dtor to class with virtual member functions 2025-11-24 08:13:16 +01:00
Atgeirr Flø Rasmussen 53a2f30b06 Merge pull request #6624 from bska/fix-serial-build 
Include Missing Header
 2025-11-21 19:48:56 +01:00