Atgeirr Flø Rasmussen
cc6acb7722
Merge pull request #5422 from daavid00/fixingBuild
...
Fix to error in Clang: use 'template' keyword to treat 'data' ...
2024-06-11 15:17:45 +02:00
David Landa Marban
80e00f4516
Fix to error in Clang: use 'template' keyword to treat 'data' ...
2024-06-11 09:31:48 +02:00
Bård Skaflestad
b0ee6b9c94
Merge pull request #5419 from GitPaean/only_trans_2
...
trying to release global transmissibility earlier to flatten the peak memory usage in the function finishInit()
2024-06-10 18:13:53 +02:00
Bård Skaflestad
c076532fdf
Merge pull request #5351 from blattms/feature/do-not-warn-for-suprious-nnc-in-parallel
...
Prevent spurious warnings about NNCs when applying EDITNNC in parallel.
2024-06-10 16:19:22 +02:00
Kai Bao
fd5e9d167f
addressing reviewing comments OPM/opm-simulators#5419
2024-06-10 16:08:44 +02:00
Kai Bao
062a98b305
restruct so that we can release the global trans earlier
...
in the funciton finishInit().
2024-06-10 16:08:44 +02:00
Markus Blatt
6921db4282
omit unnescessary function parameter for EDINCC
2024-06-10 14:50:55 +02:00
Markus Blatt
fc67eaeeda
Prevent spurious warnings about NNCs when applying EDITNNC in parallel.
...
If we use transmissibilities for loadbalancing, then we calculate
transmissibilities twice. First on the global grid before
loadbalancing and then on the local grid after that. This is the
default. In this case all warnings will be shown correctly when
calculating the global transmissibilities.
If the user requests the same weights for all faces (command line
parameter --edge-weights-method=0) then the transmissibilities are only
calculated on the loadbalanced grid. Unfortunately, in this case only
rank 0 will issue warnings for his part including the false positives
mentioned below.
Due to load balancing many NNCs might be stored on another process,
but we still use all EDITNNC entries when computing transmissibilties
locally. Hence when applying EDITNNC on the loadbalanced grid we
will issue warnings for cases where there are no problems (e.g. NNC
between two overlap cells.
With this PR we will only warn when computing the transmissibilities
for the first time. For the default settings this will remove spurious
and duplicate warnings.
Not that for --edge-weights-method=0 nothing changes and we will still
see only warnings for the first rank including spurious one.
2024-06-10 14:50:55 +02:00
Markus Blatt
b2c06415f4
Merge pull request #5182 from lisajulia/ilu-op-in-amg
...
Ghost entries skipped for ILU apply and SpMV operator in all levels of AMG/CPR hierarchy
2024-06-10 13:06:42 +02:00
Bård Skaflestad
fcad25e26a
Merge pull request #5420 from atgeirr/avoid-uninitialized-variable
...
Ensure 'mid' is always initialized.
2024-06-07 17:14:58 +02:00
Bård Skaflestad
58edb5b9aa
Merge pull request #5417 from blattms/feature-correct-comment-parallel
...
Update wrong comment about storage of transmissibilities
2024-06-07 16:50:38 +02:00
Atgeirr Flø Rasmussen
fc906842ad
Merge pull request #5352 from jcbowden/damaris-limit-variables-v1
...
Add ability to pass multiple variables to Damaris using DamarisWriter class.
2024-06-07 15:54:59 +02:00
Markus Blatt
d80b8411b7
Fixed spelling of comments.
2024-06-07 14:58:47 +02:00
Lisa Julia Nebel
ecf7bd1e52
Test for skipping the ghost entries using Jacobi preconditioner
2024-06-07 14:40:58 +02:00
andrthu
6c62753803
Ghost entries skipped for ilu apply and GL operator in AMG/CPR hierarchy.
...
This works since the ghost entries are the last entries
2024-06-07 14:40:53 +02:00
Atgeirr Flø Rasmussen
71684bfe2c
Ensure 'mid' is always initialized.
2024-06-07 14:27:02 +02:00
Markus Blatt
2f3c1b7310
Update wrong comment about storage of transmissibilities
...
This is a follow up of the fix in #5414 .
The comment said that the ordering of the compressed index of cells is
coherent with the cartesian index. THis is not the case in parallel
where cells in the overlap/ghost region might be ordered last (default).
2024-06-07 06:46:18 +02:00
Markus Blatt
302503e172
Merge pull request #5414 from totto82/fix_mpi_edit_trans
...
Fix modifications of TRANX/Y/Z in parallel (e.g. MULTIPLY of TRANX in EDIT)
2024-06-07 06:28:35 +02:00
Bård Skaflestad
e3bf48541f
Merge pull request #5406 from GitPaean/only_trans
...
only allocate trans_ for globalTrans_
2024-06-06 21:50:11 +02:00
Bård Skaflestad
225bdf4595
Merge pull request #5416 from atgeirr/missing-initialization
...
Initialize double member for serialization test.
2024-06-06 21:03:03 +02:00
Bård Skaflestad
2f0cfe8dbd
Merge pull request #5415 from atgeirr/initialize-member
...
Ensure the 'injector' member is initialized, compared etc.
2024-06-06 21:02:26 +02:00
Kai Bao
8f67881809
using enum class to replace boolean onlyTrans for
...
Transmissibility::update() for better readability, which is suggested by the reviewer.
2024-06-06 20:09:44 +02:00
Atgeirr Flø Rasmussen
74fc1d4a67
Ensure the 'injector' member is initialized, compared etc.
2024-06-06 16:31:46 +02:00
Atgeirr Flø Rasmussen
ab4d9cb36e
Initialize double member for serialization test.
2024-06-06 15:24:20 +02:00
Bård Skaflestad
9c744190eb
Merge pull request #5411 from bska/claim-basic-wtmult-support
...
Enable WTMULT as an Input Operation
2024-06-06 14:53:07 +02:00
Bård Skaflestad
bc48a2e955
Merge pull request #5342 from atgeirr/nldd-domain-solves-newton-damping
...
Add Newton update damping when domain solution oscillates.
2024-06-06 14:52:25 +02:00
Bård Skaflestad
e876fa86e9
Merge pull request #5409 from bska/collect-well-limits-for-smry-output
...
Collect Well Level Control Limits/Targets for Summary Output
2024-06-06 14:51:22 +02:00
Tor Harald Sandve
42702e1d50
Fix mpi for MULTIPLY TRANX in EDIT
2024-06-06 12:59:41 +02:00
Atgeirr Flø Rasmussen
f06c238753
Add damping treatment to subdomain Newton iterations.
2024-06-06 12:59:22 +02:00
josh bowden
6fcec07bab
cast to remove: comparison of integer expressions of different signedness warning.
2024-06-06 10:36:25 +02:00
Bård Skaflestad
3074c0d9fd
Enable WTMULT as an Input Operation
...
Basic support for this keyword was added in commit
OPM/opm-common@5e3e20c552
and this commit enables running models which use that basic support.
Advanced uses, such as including user-defined arguments for the
multipliers, will still be rejected at the input level.
2024-06-06 09:14:01 +02:00
Bård Skaflestad
151de07fa7
Collect Well Level Control Limits/Targets for Summary Output
...
This commit adds a new stage to the wellData() report function,
assignWellTargets(), which collects the numerical values of the
currently active limits/targets for summary file output purposes.
It is important that we collect these values strictly before we
start mutating the SummaryState object lest user-defined arguments
in keywords like WCONPROD be evaluated seemingly too soon.
Furthermore, it is faster to collect these values on the simulator
side and send them to the I/O rank for file output than to defer the
full calculation to the I/O rank.
2024-06-06 09:13:57 +02:00
Tor Harald Sandve
25f6c0a1bd
Merge pull request #5405 from svenn-t/ezrokhi
...
Support for CNAMES
2024-06-06 08:44:27 +02:00
Kai Bao
303a677a81
only allocate trans_ for globalTrans_
...
others are not needed for globalTrans_ for now. It will help to flatten
the peak memory usage for rank 0 during a parallel running.
2024-06-05 21:35:46 +02:00
josh bowden
7fc6cc0430
Other small additions from github comments and removal of compile time logic that checks for ParaView and Python - makes code more readable and alows use of Damaris libraries with differing compiled in backends to be swapped without need for recompiling opm-simulators
2024-06-05 17:26:34 +02:00
Bård Skaflestad
4cf8a50b26
Merge pull request #5398 from atgeirr/minor-oscillation-handling-fix
...
Detect oscillation in just one phase.
2024-06-05 13:56:35 +02:00
Atgeirr Flø Rasmussen
558d888d90
Allow oscillation detection with less that two phases.
...
We should not require two phases to have oscillating residuals to
start handling it.
2024-06-05 11:50:01 +02:00
Kai Bao
904cb7e2c4
Merge pull request #5395 from steink/consistent_vfp_interpolation
...
Small fixes related to thp-control/vfp-extrapolation
2024-06-04 15:15:41 +02:00
Svenn Tveit
912cd45182
Support for CNAMES needed with CO2STORE
2024-06-03 20:40:26 +02:00
Arne Morten Kvarving
b6d3a83955
Merge pull request #5403 from vkip/bflowj_typo
...
Fix typo
2024-06-03 16:37:06 +02:00
Vegard Kippe
78cc10f620
Fix typo
2024-06-03 15:26:16 +02:00
Stein Krogstad
6318335d76
Update test_vfpproperties
2024-05-31 14:11:10 +02:00
Stein Krogstad
37c771cb5f
fix bug and attempt to make code clearer
2024-05-31 14:11:10 +02:00
Stein Krogstad
d32d4419a9
fix double -> Scalar
2024-05-31 14:11:10 +02:00
Stein Krogstad
aa8516c085
Respect "global" switching logic also in local solves
2024-05-31 14:11:10 +02:00
Stein Krogstad
008fd268c5
fix bug
2024-05-31 14:11:10 +02:00
Stein Krogstad
c5f7d02bf7
Make thp-func constistent with bhp-func and add some damage prevention logic for severe extrapolation
2024-05-31 14:11:10 +02:00
Arne Morten Kvarving
59aee6c56c
Merge pull request #5400 from BigDataAccelerate/fix_rocsparsewells
...
fix compile rocsparseWellContributions
2024-05-31 13:50:11 +02:00
Razvan Nane
988d3821cd
fix compile rocsparseWellContrib
2024-05-31 11:55:53 +02:00
Arne Morten Kvarving
c92d80e0e8
Merge pull request #5399 from daavid00/fixMacOS
...
[FIX]: Build issue if OpenMP is not present
2024-05-31 09:56:39 +02:00
