Commit Graph

16512 Commits

Author SHA1 Message Date
Vegard Kippe
dbd1d343e8 Avoid adding/substracting GCONSUMP values per MPI process.. 2023-09-07 14:14:56 +02:00
Kai Bao
62abbbde60
Merge pull request #4841 from GitPaean/set_bhp_update_well_state_2
setting the bhp to be bhp_limit when bhp value is not initialized with rate target control when updateWellStateWithTarget()
2023-09-07 10:48:17 +02:00
Kai Bao
529af98ce9 setting uninitialized bhp to be bhp_limit in updateWellStateWithTarget
to avoid uninitialized bhp 0. to be used.
2023-09-07 08:50:37 +02:00
Bård Skaflestad
8bf45ea86b
Merge pull request #4821 from bska/aqunum-nncs
Treat Numerical Aquifer Connections as NNCs for Output Purposes
2023-09-06 17:19:27 +02:00
Bård Skaflestad
21c897fbca Treat Numerical Aquifer Connections as NNCs for Output Purposes
Connections between reservoir cells and numerical aquifer cells, or
between numerical aquifer cells when multiple such cells define a
single numerical aquifer, should always be treated as NNCs for
output purposes and end up in the (NNC1,NNC2,TRANNNC) output arrays.
To this end, make a special purpose predicate to identify numerical
aquifer connections when forming the output NNC and transmissibility
arrays and act accordingly in member functions 'computeTrans_()' and
'exportNncStructure_()'.

While here, also pick up the NNC transmissibility value from
'globalTrans()' since multiplier operations like MULTREGT might have
affected the explicit values entered in the NNC, EDITNNC, and
EDITNNCR keywords.  This is in preparation of properly incorporating
such multipliers in follow-up work.  Finally, fix a subtle problem
caused by using 'std::abs()' to check for non-zero connections.
When accounting for explicit NNCs, it might happen that the final
transmissibility would become negative with a sufficiently large
absolute value that 'abs(t) > threshold' would be true.  This would
result in outputting a negative transmissibility value to the NNC
arrays which would confuse result processors.
2023-09-06 15:53:13 +02:00
Bård Skaflestad
c1a6fba113
Merge pull request #4835 from svenn-t/dirichlet_fix
Fix DIRICHLET option in BCPROP
2023-09-06 15:09:27 +02:00
Bård Skaflestad
f32b8e17ed
Merge pull request #4815 from plgbrts/std-netw-gaslift
Add FLO as supported option of item 6 of GRUPNET
2023-09-06 14:51:51 +02:00
Bård Skaflestad
27466bae66
Merge pull request #4834 from steink/assure_non_negative_oil_fraction
Prevent negative oil fractions in well segments
2023-09-06 12:44:21 +02:00
Atgeirr Flø Rasmussen
87b9dd3ec2
Merge pull request #4837 from bska/remove-unused-code
Remove Unused Functions
2023-09-06 09:09:54 +02:00
Bård Skaflestad
e6c2413d05 Remove Unused Functions
These functions became unused in commits 952ccf8338 and f027262ec4,
but their definitions remained in place.  We no longer need them.
2023-09-05 19:03:43 +02:00
Svenn Tveit
d76db6dee7 Support for DIRICHLET test case 2023-09-05 15:00:03 +02:00
Svenn Tveit
8da6e5fd2f Fix DIRICHLET option in BCPROP.
Additional fix: BCPROP does not need to be defined each report step.
2023-09-05 14:57:54 +02:00
Atgeirr Flø Rasmussen
8900962fd5
Merge pull request #4827 from jcbowden/damaris-fix-for-deadlock
Damaris fix for deadlock at end of simulation when run with Damaris
2023-09-05 14:28:32 +02:00
Stein Krogstad
7981253f39 prevent negative oil fractions 2023-09-05 11:18:16 +02:00
Atgeirr Flø Rasmussen
392573289f
Merge pull request #4833 from akva2/janitoring
anonymize unused parameter
2023-09-05 08:54:53 +02:00
Kai Bao
59f622f97c
Merge pull request #4825 from GitPaean/tpfa_diffusion
add tpfa as lineariser for gasoil_energy (with diffusion) and gas oil diffusion
2023-09-04 20:57:42 +02:00
Arne Morten Kvarving
e3787b1ca8 anonymize unused parameter 2023-09-04 14:35:20 +02:00
Atgeirr Flø Rasmussen
7327a6b429
Merge pull request #4260 from atgeirr/dynamic-linear-solver-choice
Support for multiple linear solvers.
2023-09-04 13:53:43 +02:00
Atgeirr Flø Rasmussen
cede2b4add Improving generality and output of hybrid approach. 2023-09-04 13:13:52 +02:00
Paul
1912faf47c Add FLO as supported option of item 6 of GRUPNET 2023-09-04 11:21:59 +02:00
Bård Skaflestad
9c58585538
Merge pull request #4823 from akva2/ecltimestepping_separate
changed: put ecl time stepping parameters in separate struct
2023-09-04 10:54:46 +02:00
Bård Skaflestad
5408f7ea12
Merge pull request #4803 from akva2/geomech_rst_output
added output writing for geomechanical module

Supersedes and closes #4588.
2023-09-04 10:11:05 +02:00
Bård Skaflestad
323574713c
Merge pull request #4831 from GitPaean/regression_valve
adding regression test for MSW-2D-VERT-02
2023-09-04 09:10:48 +02:00
Kai Bao
197b52b4c1 adding regression test for MSW-2D-VERT-02
to protect the development regarding ICD with hydrostatic and
accelerational pressure drops, which is introduced in PR OPM/opm-simulators#4824
2023-09-01 23:54:20 +02:00
Josh Bowden
6e4f3bd37e added changes as discussed in PR 4827 2023-09-01 18:28:03 +02:00
Tor Harald Sandve
80cbfe7fda
Merge pull request #4819 from hakonhagland/gecon3
Implement support for GECON keyword
2023-09-01 15:06:48 +02:00
Atgeirr Flø Rasmussen
079bf9323a
Merge pull request #4830 from jcbowden/damaris-hdf5-select-keyword
Damaris internal XML file update to support HDF5 local to global write.
2023-09-01 15:01:50 +02:00
Atgeirr Flø Rasmussen
efa50c3640 Check for multiple solvers before trying to use them. 2023-09-01 13:18:09 +02:00
Atgeirr Flø Rasmussen
758b4bbdb6 Use "hybrid" linear solver choice to get multi-option. 2023-09-01 13:18:09 +02:00
Franz Georg Fuchs
6ee90b3f8f Support for multiple linear solvers. 2023-09-01 13:18:06 +02:00
Bård Skaflestad
79b417beb5
Merge pull request #4829 from atgeirr/fix-serial-nldd-communicate
Fix serial compile
2023-09-01 12:38:19 +02:00
Josh Bowden
89d13e479c Update to the opm-flow internal Damaris XML to support the HDF5 select writing option so that local variable data is written to global variable position in HDF5 output 2023-09-01 12:02:04 +02:00
Håkon Hægland
b1274096e9 Added to partially supported keywords
Added GECON to the list of partially supported keywords
2023-09-01 11:29:18 +02:00
Atgeirr Flø Rasmussen
91c2e12a25 Document new input parameter. 2023-09-01 11:19:36 +02:00
Atgeirr Flø Rasmussen
583fb902d2 Guards communication parts inside HAVE_MPI. 2023-09-01 11:19:16 +02:00
Bård Skaflestad
c6e30fbf3c
Merge pull request #4820 from atgeirr/parallel-nldd-fixes
Fixes to enable using the NLDD nonlinear solver option in MPI parallel runs
2023-09-01 09:51:06 +02:00
Atgeirr Flø Rasmussen
99fca58dca Improvements from review. 2023-09-01 08:48:11 +02:00
Kai Bao
abe6ec2dde
Merge pull request #4824 from vkip/add_acc_and_hydro_to_icdsegs
Adding hydrostatic and acceleration pressure losses to icd segments
2023-08-31 19:58:30 +02:00
Vegard Kippe
a75f58f19a Moved two lines 2023-08-31 16:11:29 +02:00
Vegard Kippe
deeecfcd1f Fixing indent 2023-08-31 16:11:28 +02:00
Vegard Kippe
edd421ac93 Adding hydrostatic and acceleration pressure losses to icd segments 2023-08-31 16:11:28 +02:00
Josh Bowden
84d3530fd9 fix for deadlock at end of simulation when run with Damaris and test for whether Damaris can be run as Damaris requires at least 2 MPI ranks (one for simulation and the other as to run Damaris i/o) 2023-08-31 15:51:34 +02:00
hnil
8afbd49322 add tpfa as lineariser for gasoil_energy (with diffusion) and gasoildiffusion 2023-08-31 15:26:31 +02:00
Atgeirr Flø Rasmussen
06c706e7d6 Also copy flags, and helper function with test. 2023-08-31 13:01:50 +02:00
Atgeirr Flø Rasmussen
151eac9110 Copy overlap data after local solve.
Also update intensive quantities in overlap afterwards.
2023-08-31 13:01:50 +02:00
Atgeirr Flø Rasmussen
961a5fa482 Avoid collective copyParValues() call in serial run. 2023-08-31 13:01:50 +02:00
Atgeirr Flø Rasmussen
e1dd2bf148 Add forceSerial parameter to ISTLSolverEbos.
Used for single-domain solves.
2023-08-31 13:01:50 +02:00
Atgeirr Flø Rasmussen
622103a367 Avoid collective operation in single-domain context. 2023-08-31 13:01:50 +02:00
Atgeirr Flø Rasmussen
609dfd6051 Only owned cells should be part of NLDD partitions. 2023-08-31 13:01:28 +02:00
Kai Bao
3315027bcc
Merge pull request #4814 from hnil/tpfa_temp
Tpfa temp
2023-08-31 11:17:38 +02:00