OilfieldToolsNet/opm-simulators
4
0
Fork 0
mirror of https://github.com/OPM/opm-simulators.git synced 2026-08-03 04:00:16 -05:00
Code Issues Packages Projects Releases Wiki Activity
16,899 Commits 31 Branches 117 Tags
ec549df37ba42b1378bf92e88adeef1b01b03eed
Commit Graph
16899 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Bård Skaflestad ec549df37b Remove Spurious Blank Lines in PRT File Reports 
The StreamLog::addMessageUnconditionally() member function will end
each message with a newline (std::endl) so we should not add such
newlines ourselves.  The extra newline characters produce spurious
blank lines in the report sheets, e.g., for the "PRODUCTION REPORT".

This commit removes the last newline character from each report
request, thus deferring that responsibility to OpmLog::note()
instead.  Doing so, however, means we have take a little more care
with the first line of each report lest we create report sheets
which are smushed together.
 2023-12-08 10:22:43 +01:00
Bård Skaflestad 6b18cbafc6 Pull Substep Checking out of *Log() Functions 
This commit removes the 'substep' parameter from the output module's
outputProdLog(), outputInjLog(), and outputCumLog() member
functions.  This parameter was only used in the same way in internal
conditions in each member function and we can enforce that check on
the outside without losing expressivity.
 2023-12-08 10:22:43 +01:00
Bård Skaflestad 91fdded473 Merge pull request #4986 from steink/improved_local_thp_solve 
Implicit IPR for stability/operablity checks and solution of thp-wells
 2023-12-08 09:59:07 +01:00
Stein Krogstad 051f4d4eab Remove early-return functionality due to unintended consequences 2023-12-08 00:36:39 +01:00
Stein Krogstad 7c91c015cf updates according to Atgeirrs comments 2023-12-07 13:09:00 +01:00
Stein Krogstad 1fd1c5afc6 Updates according to Atgeirr's comments 2023-12-07 13:09:00 +01:00
Stein Krogstad 00bd006eb4 Fix bugs 2023-12-07 13:09:00 +01:00
Stein Krogstad 94cde80235 always set wells operable to avoid skipping linear solve/updating 2023-12-07 13:09:00 +01:00
Stein Krogstad 2121373e4f clean-up 2023-12-07 13:09:00 +01:00
Stein Krogstad 5083052a3f clean-up, fixing and add debug info 2023-12-07 13:09:00 +01:00
Stein Krogstad 743c7bd120 add argument to get proper conv for well-copies 2023-12-07 13:09:00 +01:00
Stein Krogstad 9a5aef6e5e move function for proper access to well_state 2023-12-07 13:09:00 +01:00
Stein Krogstad 88ede7b7fc revert to original 2023-12-07 13:09:00 +01:00
Stein Krogstad ee16e90ba2 fix well-convergence for well-copies 2023-12-07 13:09:00 +01:00
Stein Krogstad 73ec44d9c4 include use-implicit-ipr as paramaeter 2023-12-07 13:09:00 +01:00
Stein Krogstad 03366b92eb include thp-solve for potentials 2023-12-07 13:09:00 +01:00
Stein Krogstad 44e17fa615 cleanup thp-solve 2023-12-07 13:09:00 +01:00
Stein Krogstad 3e6732a67b rename to implicit_ipr 2023-12-07 13:09:00 +01:00
Stein Krogstad 746e05db5d Include implicit ipr for ms-wells 2023-12-07 13:09:00 +01:00
Stein Krogstad b287981e5e testing 2023-12-07 13:09:00 +01:00
Stein Krogstad 7aa50f149f updates 2023-12-07 13:09:00 +01:00
Stein Krogstad 2470b20d13 final revert 2023-12-07 13:09:00 +01:00
Stein Krogstad 94c0b49cf7 revert changes 2023-12-07 13:09:00 +01:00
Atgeirr Flø Rasmussen 446670943a Merge pull request #5042 from akva2/serializer_throw_early_no_hdf5 
changed: throw early in simulator serializer
 2023-12-07 10:42:01 +01:00
Bård Skaflestad d2ee47de7f Merge pull request #5041 from steink/prevent_nans_for_valve_models 
Guard against nans from certain expressions in the valve models
 2023-12-06 19:42:32 +01:00
Stein Krogstad 4355a94511 make reference to parameter 2023-12-06 14:45:18 +01:00
Arne Morten Kvarving 4eeefabedd changed: throw early in simulator serializer 
if HDF5 input/output is requested but no support is available
we throw early instead of just logging an error when save/load
is to be performed
 2023-12-06 10:03:29 +01:00
Markus Blatt faad3a6ee5 Merge pull request #4811 from akva2/simulator_serializer_class 
Move simulator serialization to separate class
 2023-12-06 10:02:26 +01:00
Markus Blatt abd387abba Merge pull request #5036 from blattms/comm-sigular-mat-exception 
Communicate exceptions during WellModel::updateAndCommunicate
 2023-12-06 09:54:00 +01:00
Stein Krogstad a483839caa return zero for powers with negative base 2023-12-05 21:28:54 +01:00
Arne Morten Kvarving f46b6c5a01 changed: move simulator serialization to separate class 
more separation of concerns
 2023-12-05 11:20:22 +01:00
Arne Morten Kvarving eb599af058 add missing header 2023-12-05 11:00:56 +01:00
Markus Blatt 3a9c586d19 Make sure that problems with singular matrices are logged. 
Previously, if the problem occured on an MPI process with rank other
than zero the the logging would not seen (at least in the output
files). Now together with the previous commit the problem should be
logged together with the well name and calling method.
 2023-12-04 23:15:08 +01:00
Markus Blatt 779dd74923 Communicate exceptions during WellModel::updateAndCommunicate 
For multi segment well the underlying call to
MultisegmentWell::updateWellStateWithTarget (at least if
updateWellStateWithTHPTargetProd is called for a producer under thp
control) might throw as there might be a singular matrix during the
solve needed in MultisegmentWell::iterateWellEqWithControl.

Previously, if that happened then the MPI process where it happened would
stop the nonlinear iteration as failed and try with a chopped time
step. The others might go one with the current time step and we would
see MPI errors about truncated messages.

Now we communicate any exception happening during this part of
WellModel::updateAndCommunicate and all processes will stop the
nonlinear iteration as failed and chop the time step.
 2023-12-04 22:26:55 +01:00
Bård Skaflestad 338c210985 Merge pull request #5034 from akva2/fix_fip_no_summary_kw 
fixed: grab list of FIP regions from FieldPropsManager
 2023-12-04 17:46:00 +01:00
Arne Morten Kvarving d120fe1ebc fixed: grab list of FIP regions from FieldPropsManager 
not from SummaryConfig. the latter only holds regions with
summary keywords
 2023-12-04 13:24:32 +01:00
Bård Skaflestad 7c41fea5c2 Merge pull request #5035 from akva2/janitoring 
Janitoring: fix dead stores
 2023-12-04 13:11:31 +01:00
Bård Skaflestad bf1484995a Merge pull request #5033 from vkip/udq_wconprod_alq 
Allow using UDQ for WCONPROD item 12 (ALQ)
 2023-12-04 13:10:49 +01:00
Arne Morten Kvarving 7da71783ba fix dead stores 2023-12-04 12:40:55 +01:00
Vegard Kippe 55067636f4 Ensuring that the UDA is updated every time step, not just only report step. 2023-12-01 19:44:09 +01:00
Vegard Kippe fa6697a5fa Capture reference in lambda 2023-12-01 13:30:48 +01:00
Vegard Kippe 69f82f1104 Allow using UDQ for WCONPROD item 12 (ALQ) 2023-12-01 13:21:34 +01:00
Bård Skaflestad b7ad5a9d29 Merge pull request #5032 from vkip/catch_welltesting 
Catch exceptions from well testing
 2023-12-01 10:33:01 +01:00
Vegard Kippe 17452e0fc6 Adding const 2023-12-01 09:34:42 +01:00
Vegard Kippe 0acb148ba7 Using std::exception 2023-11-30 16:13:40 +01:00
Vegard Kippe 2294983759 Catch exceptions from well testing (often: inf/nan in MSW matrices). 2023-11-29 09:17:53 +01:00
Markus Blatt c6bb607cdc Merge pull request #5029 from aritorto/cartCoord 
CartesianCoordinateLevel added for ALUGrid
 2023-11-28 17:18:12 +01:00
Antonella Ritorto 8017ff9a02 add cartesianCoordianteLevel in ALUCartIdxMapp, used in RelperDiag 2023-11-28 15:47:00 +01:00
Bård Skaflestad 5fe1eafb34 Merge pull request #5026 from totto82/fix_gpmaint2 
Bugfix sign of gpmaint prod
 2023-11-28 11:16:03 +01:00
Tor Harald Sandve 0a4cfab875 Add GPMAINT-11 to regression test 2023-11-28 08:08:58 +01:00