Håkon Hægland
eefd944e32
Add comment explaining non-const reference
...
Added a comment explaining why we cannot push a const
group state to GroupStateHelper
2025-12-12 18:17:52 +01:00
Håkon Hægland
9c5469d6ad
Refactor TargetCalculator
...
Refactor TargetCalculator::groupTarget() to
WellGroupHelper::getProductionGroupTarget(), and
don't pass Group::ProductionControls as a parameter. Since
TargetCalculator only works for a given group, passing control as a
parameter is confusing and can be error prone if being passed a control
for a different group than the TargetCalculator was constructed for.
2025-12-12 18:17:52 +01:00
Markus Blatt
461184d85e
Merge pull request #6679 from hakonhagland/push_well_state
...
Bugfix: groupStateHelper uses potentially wrong WellState
2025-12-12 17:40:19 +01:00
Bård Skaflestad
464daffc85
Merge pull request #6678 from akva2/janitoring_clang
...
Janitoring: quell clang warnings
2025-12-12 11:30:28 +01:00
Arne Morten Kvarving
57696b58de
disable unused inline methods
2025-12-12 10:36:58 +01:00
Arne Morten Kvarving
4c604277ae
remove unused variable
2025-12-12 10:36:58 +01:00
Arne Morten Kvarving
e9c37df8e1
remove useless assignment
2025-12-12 10:36:58 +01:00
Håkon Hægland
857ae931eb
Bugfix: groupStateHelper uses wrong WellState
...
When well_state is copied, groupStateHelper should be updated to use
that copy
2025-12-12 10:33:28 +01:00
Markus Blatt
8760adab72
Merge pull request #6658 from hakonhagland/rc_proxy
...
Add ReservoirCoupling::Proxy to reduce #ifdef clutter in well model
2025-12-11 21:13:58 +01:00
Håkon Hægland
5430b489eb
Add header that conditonally defines RESERVOIR_COUPLING_ENABLED
2025-12-11 15:22:28 +01:00
Håkon Hægland
23322c174f
Remove #include <config.h>
2025-12-11 15:10:28 +01:00
Håkon Hægland
86fb442452
Add ReservoirCoupling::Proxy to reduce #ifdef clutter in well model
...
Introduce a thin proxy class that encapsulates reservoir coupling
master/slave pointers and provides mode queries (isMaster/isSlave)
that work regardless of MPI availability.
Benefits:
- Mode queries can be called without #ifdef guards
- Member variables no longer need #ifdef protection
- Centralizes MPI-conditional includes in one header
- Consumer code becomes cleaner and more readable
Files changed:
- New: opm/simulators/wells/rescoup/RescoupProxy.hpp
- Modified: BlackoilWellModel.hpp, GuideRateHandler.hpp,
GroupStateHelper.hpp to use the proxy pattern
The proxy is non-owning (just holds pointers) and copyable.
Setter methods remain guarded since they use MPI-only types.
2025-12-11 14:52:49 +01:00
Bård Skaflestad
0b0036eafe
Merge pull request #6665 from akva2/freport_par
...
failure_report: add parallel execution
2025-12-11 12:05:25 +01:00
Kai Bao
9ab48e011e
Merge pull request #6672 from vkip/filtrate_xflow
...
Ensure filtrate mass balance in case of cross-flow
2025-12-10 23:04:40 +01:00
Vegard Kippe
0ae67f921c
Clamp xflow factor to be >0 0
2025-12-10 15:28:38 +01:00
Bård Skaflestad
24f85054a8
Merge pull request #6675 from atgeirr/fix-branprop-alq-rev2
...
Adapt to API change for Branch::alq_value(), fixing unit bug. (Redone)
2025-12-10 14:39:42 +01:00
Atgeirr Flø Rasmussen
02e1f9836e
Adapt to API change for Branch::alq_value(), fixing unit bug.
2025-12-10 13:51:47 +01:00
Atgeirr Flø Rasmussen
e410385cab
Merge pull request #6674 from jakobtorben/fix_template_parameter_for_non_cuda_builds
...
Fix GpuSparseMatrixWrapper template parameter for non-CUDA builds
2025-12-10 12:40:29 +01:00
Bård Skaflestad
b3997d3b49
Merge pull request #6673 from akva2/janitoring_temp_model
...
(Generic)TemperatureModel: various janitoring
2025-12-10 09:49:14 +01:00
Vegard Kippe
ee04e76c11
Move 'if' out of loop
2025-12-10 09:37:32 +01:00
Arne Morten Kvarving
927e1ea2d7
(Generic)TemperatureModel: various janitoring
...
- add/remove includes
- add braces, adjust brace placement
- various cosmetics
2025-12-10 09:26:22 +01:00
Vegard Kippe
f49dc468a0
Ensure filtrate mass balance in case of cross-flow
2025-12-09 23:46:46 +01:00
Jakob Torben
1aa1b2b9fc
Fix GpuSparseMatrixWrapper template parameter mismatch
2025-12-09 20:09:35 +01:00
Bård Skaflestad
2ab47a945a
Merge pull request #6633 from GitPaean/not_copying_well_state_from_action2
...
not copying well state from if the well was SHUT before applying action
2025-12-09 16:06:13 +01:00
Bård Skaflestad
ed6145b7f0
Merge pull request #6668 from akva2/add_run_trigger
...
add run trigger handling in jenkins build script
2025-12-09 15:54:24 +01:00
Arne Morten Kvarving
7ca8ea9c95
adjust to run trigger handling in jenkins build script
2025-12-09 15:14:24 +01:00
Bård Skaflestad
a844195399
Merge pull request #6669 from totto82/fix_warning
...
Use old bhp from thp computation for unconverged bhp solves
2025-12-09 14:03:13 +01:00
Tor Harald Sandve
48098923bd
Use old bhp from thp computation for unconverged bhp solves
2025-12-09 13:16:55 +01:00
Kai Bao
5338a36319
not copying well state from action initialization
...
if the well was SHUT before applying the action
2025-12-09 11:46:04 +01:00
Tor Harald Sandve
630e4d36fb
Merge pull request #6653 from totto82/fix_glift2
...
Using IPR in gaslift optimization
2025-12-09 10:15:57 +01:00
Arne Morten Kvarving
38e23b82bd
failure_report: add parallel execution
2025-12-09 10:04:19 +01:00
Tor Harald Sandve
f9d254a579
Clean-up based on review
2025-12-08 23:39:47 +01:00
Arne Morten Kvarving
c53088794a
Merge pull request #6666 from jakobtorben/use_legacy_gpusparsematrix_for_gpuseqilu0
...
Force legacy GpuSparseMatrix for GpuSeqILU0
2025-12-08 13:45:04 +01:00
Arne Morten Kvarving
9bb118c670
Merge pull request #6667 from akva2/janitoring_clang
...
anonymize unused parameters
2025-12-08 13:30:31 +01:00
Arne Morten Kvarving
684eb1a2da
anonymize unused parameters
2025-12-08 13:06:37 +01:00
Markus Blatt
77420a5c3a
Merge pull request #6625 from GitPaean/context_check_finite
...
adding a context to StandardWellPrimaryVariables::checkFinite
2025-12-05 18:37:13 +01:00
Markus Blatt
e614a08999
Merge pull request #6663 from totto82/fix_temp
...
Fix TEMP option in parallel
2025-12-05 18:31:00 +01:00
Markus Blatt
6aaf6ffb4c
Merge pull request #6521 from haugenlabs/mixed-pr
...
Added a serial mixed-precision solver with support for bicstab with ilu and dilu on the CPU.
2025-12-05 18:26:31 +01:00
Jakob Torben
9515a620d4
Add ForceLegacy parameter to GpuSparseMatrixWrapper for GpuSeqILU0
2025-12-05 14:57:08 +01:00
Tor Harald Sandve
da6a47ed99
Fallback on old approach for trivial rates
2025-12-05 12:43:57 +01:00
Arne Morten Kvarving
338144cf73
Merge pull request #6662 from akva2/add_missing_include
...
add missing include
2025-12-05 11:29:04 +01:00
Tor Harald Sandve
307b4d9a01
Fix TEMP option in parallel
2025-12-05 10:00:41 +01:00
Arne Morten Kvarving
734dfd544a
add missing include
2025-12-05 09:49:14 +01:00
Tor Harald Sandve
c98f74a9df
Start using IPR for bhp calculations during gaslift optimization
2025-12-05 09:22:25 +01:00
Arne Morten Kvarving
fbbcc2a156
Merge pull request #6568 from akva2/network_has_a
...
BlackoilWellModel: model network with has-a semantics
2025-12-05 08:44:48 +01:00
Arne Morten Kvarving
24b5a26f30
Merge pull request #6660 from svenn-t/blocksize_7
...
Increase block sizes to 7
2025-12-05 08:42:54 +01:00
Arne Morten Kvarving
730c642a6f
move GroupStateHelper::computeNetworkPressures to BlackoilWellModelNetworkGeneric
...
it is the only consumer
2025-12-05 08:25:47 +01:00
Arne Morten Kvarving
0e094a8e76
BlackoilWellModel: let network class handle wellTesting update
2025-12-05 08:25:33 +01:00
Arne Morten Kvarving
e0f00038ac
BlackoilWellModel: move network initialization to generic class
2025-12-05 08:25:18 +01:00
Arne Morten Kvarving
1c7701469b
changed: move network functionality to a separate class
...
and model as has-a in BlackoilWellModel
2025-12-05 08:25:16 +01:00