Arne Morten Kvarving
faa963056d
Parameters::printParamUsage can now be an implementation detail
2024-09-05 10:07:40 +02:00
Arne Morten Kvarving
77dc5ad895
Parameters::getFlattenedKeyList can now be an implementation detail
2024-09-05 10:07:40 +02:00
Arne Morten Kvarving
410039206d
add Parameters::Parameter struct
...
this holds a key-value pair for a parameter with some utility functions
for comparison and printing.
use this to move Parameters::getLists to the translation unit
2024-09-05 10:07:40 +02:00
Arne Morten Kvarving
ae8dd62fe3
Parameters::Get split out parts of implementation
...
allows putting it in translation unit
2024-09-05 10:07:40 +02:00
Arne Morten Kvarving
cfad87b41f
ParameterSystem: remove ParamFinalizer
...
this adds no extra validation and complicates refactoring
2024-09-05 10:07:40 +02:00
Arne Morten Kvarving
65158cd3fb
Parameters::SetDefault split out parts of implementation
...
allows putting it in translation unit
2024-09-05 10:07:40 +02:00
Arne Morten Kvarving
741e97da61
Parameters::IsSet split out parts of implementation
...
allows putting it in translation unit
2024-09-05 10:07:40 +02:00
Arne Morten Kvarving
98b33d582f
Parameters::Register split out parts of implementation
...
allows putting it in translation unit
2024-09-05 10:07:40 +02:00
Arne Morten Kvarving
48bcf6ac04
Parameters::Hide split out main implementation
...
allows putting it in translation unit
2024-09-05 10:07:40 +02:00
Arne Morten Kvarving
7584f588a7
parametersystem: parseKey/transformKey can now be implementation details
2024-09-05 10:07:40 +02:00
Arne Morten Kvarving
427b619ca5
parametersystem: use a std::function instead of template parameter for callback
...
allows putting implementation in translation unit and this is hardly
performance critical
2024-09-05 10:07:40 +02:00
Arne Morten Kvarving
bc83bb6e1c
parametersystem: introduce translation unit
2024-09-05 10:07:40 +02:00
Arne Morten Kvarving
05f01bf819
parametersystem.hh: rename to .hpp
2024-09-05 10:07:40 +02:00
Arne Morten Kvarving
2bdab9e518
parametersystem: pass add callback for adding keys to positional parameter handler
...
this way the backing store for the parameters can be an implementation
detail of the parameter system
2024-09-05 10:07:40 +02:00
Bård Skaflestad
329ad50e59
Don't Count Cells Unless Needed
...
If the user chooses a specific number of NLDD domains, there is no
need to compute the default number of domains based on a specific
target number of cells per domain. Defer the, potentially costly,
calculation to when we know we need it.
While here, also split/rejoin a couple of long lines.
2024-09-05 09:45:16 +02:00
Bård Skaflestad
be64ef3ef6
Add Water Phase Saturation Function Consistency Checks
...
This commit introduces a set of consistency checks for the water
phase saturation functions. These plug into the framework
introduced in commit c3939c544 (PR #5438 ). We implement the
following three checks
- 0 <= SWL < 1
- 0 < SWU <= 1
- SWL <= SWCR < SWU
which collectively enable a non-negative oil saturation in the two
phase oil/water system.
2024-09-04 13:47:33 +02:00
Arne Morten Kvarving
f4801ec787
Merge pull request #5576 from akva2/fix_build_no_float_no_mpi
...
Fix build without float simulators
2024-09-04 13:45:42 +02:00
Bård Skaflestad
d69d929d37
Merge pull request #5571 from bska/gphase-sfunc-consistency-checks-impl
...
Add Gas Phase Saturation Function Consistency Checks
2024-09-04 13:02:25 +02:00
Arne Morten Kvarving
d36fefd428
fixed: build without MPI
2024-09-04 12:51:05 +02:00
Arne Morten Kvarving
c4871367e8
fixed: building without float simulators
...
pointy hat is all mine
2024-09-04 12:51:05 +02:00
Arne Morten Kvarving
f838cb6ecf
timer: introduce translation unit
2024-09-04 12:06:52 +02:00
Arne Morten Kvarving
b3e08b4f2f
timer.hh: rename to timer.hpp
2024-09-04 12:06:35 +02:00
Arne Morten Kvarving
13b575eae9
tasklets: introduce translation unit
2024-09-04 12:06:21 +02:00
Arne Morten Kvarving
d35d80427e
tasklets.hh: rename to tasklets.hpp
2024-09-04 12:06:21 +02:00
Arne Morten Kvarving
27f9277c47
mpiutil: add translation unit
2024-09-04 12:06:21 +02:00
Arne Morten Kvarving
fcd0168691
mpiutil.hh: rename to mpiutil.hpp
2024-09-04 12:06:21 +02:00
Arne Morten Kvarving
e7a9c4cd21
threadmanager: remove unused typetag template parameter
...
and move implementation to a translation unit
2024-09-04 12:06:21 +02:00
Bård Skaflestad
9c246faefa
Add Gas Phase Saturation Function Consistency Checks
...
This commit introduces a set of consistency checks for the gas phase
saturation functions. These plug into the framework introduced in
commit c3939c544 (PR #5438 ). We implement the following three checks
- 0 <= SGL < 1
- 0 <= SGU < 1
- SGL <= SGCR < SGU
which collectively enable a non-negative oil saturation in the two
phase gas/oil system.
2024-09-04 11:34:39 +02:00
Arne Morten Kvarving
3ee5eddf48
threadmanager.hh: rename to threadmanager.hpp
2024-09-04 11:32:21 +02:00
Arne Morten Kvarving
55a0a6da54
blackoilsolventparams: introduce translation unit
...
move code for loading parameters from eclipse state into it
2024-09-04 11:17:40 +02:00
Arne Morten Kvarving
6ceeb3098e
blackoilsolventparams.hh: rename to blackoilsolventparams.hpp
2024-09-04 11:17:40 +02:00
Arne Morten Kvarving
3aed1aa7f9
blackoilpolymerparams: introduce translation unit
...
move code for loading parameters from eclipse state into it
2024-09-04 11:17:40 +02:00
Arne Morten Kvarving
85cc5ffa5f
blackoilpolymerparams.hh: rename to blackoilpolymerparams.hpp
2024-09-04 09:21:09 +02:00
Arne Morten Kvarving
5a567de3e2
blackoilmicpparams: introduce translation unit
...
move code for loading parameters from eclipse state into it
2024-09-04 09:17:26 +02:00
Arne Morten Kvarving
e1453e5a48
blackoilmicpparams.hh: rename to blackoilmicpparams.hpp
2024-09-04 09:16:34 +02:00
Arne Morten Kvarving
f6d3893093
blackoilfoamparams: introduce translation unit
...
move code for loading parameters from eclipse state into it
2024-09-04 09:13:02 +02:00
Arne Morten Kvarving
6bb6e3db43
blackoilfoamparams.hh: rename to blackoilfoamparams.hpp
2024-09-04 09:11:58 +02:00
Arne Morten Kvarving
a04d9fdd00
blackoilextboparams: introduce translation unit
...
move code for loading parameters from eclipse state into it
2024-09-04 09:08:12 +02:00
Arne Morten Kvarving
9fd99ab232
blackoilexboparams.hh: rename to blackoilextboparams.hpp
2024-09-04 09:06:59 +02:00
Arne Morten Kvarving
a51e13c244
blackoilbrineparams: introduce translation unit
...
move code for loading parameters from eclipse state into it
2024-09-04 09:02:17 +02:00
Arne Morten Kvarving
99d64ff7ec
blackoilbrineparams.hh: rename to blackoilbrineparams.hpp
2024-09-04 09:00:02 +02:00
Bård Skaflestad
2e70fc407e
Add Oil Phase Saturation Function Consistency Checks
...
This commit introduces a set of consistency checks for the oil phase
saturation functions. These plug into the framework introduced in
commit c3939c544 (PR #5438 ). We implement the following four checks
for the gas/oil two-phase system
- 0 <= SOGCR < 1
- SWL + SGU <= 1
- SOGCR < 1 - SWL - SGL
- SOGCR < 1 - SWL - SGCR
which all guarantee a non-negative (mobile) oil saturation in the
gas/oil system. Similarly, we implement the following four checks
for the oil/water two-phase system
- 0 <= SOWCR < 1
- SGL + SWU <= 1
- SOWCR < 1 - SWL - SGL
- SOWCR < 1 - SWCR - SGL
which provide the same guarantees as outlined above, but for the
oil/water system.
We add a base class, PhaseCheckBase<Scalar>, which provides a common
representation of the violated/critical predicates and implement the
specific checks as derived types of this base class.
2024-09-03 12:35:44 +02:00
Arne Morten Kvarving
bc46647aa5
Import opm-models
2024-09-02 10:55:19 +02:00
Bård Skaflestad
f5aeffc8f5
Merge pull request #896 from akva2/floats
...
Add necessary changes to build float simulators
2024-08-30 15:28:34 +02:00
Bård Skaflestad
a73cb6ee93
Fix DRVDT Initialisation Conditional
...
It does not make sense to pass
episodeIdx && maxDRv_.empty()
as an argument to drvdtActive().
2024-08-30 15:16:46 +02:00
Atgeirr Flø Rasmussen
58ce7cbc7c
Merge pull request #5556 from akva2/float_support5
...
Float support in simulators: Batch 5
2024-08-30 15:06:35 +02:00
Atgeirr Flø Rasmussen
9dd54fb11a
Avoid capturing structured bindings.
...
This is an error before C++20, and clang refuses it.
2024-08-30 13:17:07 +02:00
Kai Bao
f47d00c9d7
Merge pull request #5236 from hnil/no_early_exit_zero_flux
...
Avoid deleting derivative i.e. getting "wrong" matrix in case of zero…
2024-08-29 14:46:09 +02:00
Kai Bao
818f8b9ee3
Merge pull request #877 from hnil/no_early_exit_zero_flux
...
Avoid deleting derivatives with zero pressure difference
2024-08-29 14:46:00 +02:00
Vegard Kippe
eb869f211f
Avoid time step dependent jump in RS after restart
2024-08-28 16:28:51 +02:00