OilfieldToolsNet/shlink
4
0
Fork 0
mirror of https://github.com/shlinkio/shlink.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Removed exception catch that used to return a 500, and now returns a 404 due to a behavior change

Browse Source
This commit is contained in:
Alejandro Celaya
2017-03-24 21:58:56 +01:00
parent c3c03a3a3b
commit 7530048fbd
3 changed files with 0 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

0
data/proxies/.gitignore vendored Normal file → Executable file
View File

2
module/Core/src/Action/PreviewAction.php
View File

@@ -78,8 +78,6 @@ class PreviewAction implements MiddlewareInterface
return $this->generateImageResponse($imagePath);
} catch (InvalidShortCodeException $e) {
return $out($request, $response->withStatus(404), 'Not found');
} catch (PreviewGenerationException $e) {
return $out($request, $response->withStatus(500), 'Preview generation error');
}
}
}

20
module/Core/test/Action/PreviewActionTest.php
View File

@@ -91,24 +91,4 @@ class PreviewActionTest extends TestCase
$this->assertEquals(404, $resp->getStatusCode());
}
/**
* @test
*/
public function previewExceptionReturnsNotFound()
{
$shortCode = 'abc123';
$this->urlShortener->shortCodeToUrl($shortCode)->willThrow(PreviewGenerationException::class)
->shouldBeCalledTimes(1);
$resp = $this->action->__invoke(
ServerRequestFactory::fromGlobals()->withAttribute('shortCode', $shortCode),
new Response(),
function ($req, $resp) {
return $resp;
}
);
$this->assertEquals(500, $resp->getStatusCode());
}
}