Electron-308 Removed messages from constants and hardcoded it as per PR review

This commit is contained in:
Kiran Niranjan 2018-02-27 09:24:40 +05:30 committed by kiranniranjan
parent f8b7691fce
commit a06e17a12a
10 changed files with 13 additions and 17 deletions

View File

@ -22,12 +22,12 @@ describe('Tests for Always on top', () => {
configPath = config; configPath = config;
done(); done();
}).catch((err) => { }).catch((err) => {
console.error(constants.UNABLE_TO_GET_USER_CONFIG_PATH, err); console.error(`Unable to get user config path error: ${err}`);
expect(err).toBeNull(); expect(err).toBeNull();
done(); done();
}); });
}).catch((err) => { }).catch((err) => {
console.error(constants.UNABLE_TO_START_APPLICATION, err); console.error(`Unable to start application error: ${err}`);
expect(err).toBeNull(); expect(err).toBeNull();
done(); done();
}); });

View File

@ -13,7 +13,7 @@ describe('Tests for Bring to front', () => {
app = startedApp; app = startedApp;
done(); done();
}).catch((err) => { }).catch((err) => {
console.error(constants.UNABLE_TO_START_APPLICATION, err); console.error(`Unable to start application error: ${err}`);
expect(err).toBeNull(); expect(err).toBeNull();
done(); done();
}); });

View File

@ -14,7 +14,7 @@ describe('Tests for clipboard', () => {
app = startedApp; app = startedApp;
done(); done();
}).catch((err) => { }).catch((err) => {
console.error(constants.UNABLE_TO_START_APPLICATION, err); console.error(`Unable to start application error: ${err}`);
expect(err).toBeNull(); expect(err).toBeNull();
done(); done();
}); });

View File

@ -13,7 +13,7 @@ describe('Tests for Close', () => {
app = startedApp; app = startedApp;
done(); done();
}).catch((err) => { }).catch((err) => {
console.error(constants.UNABLE_TO_START_APPLICATION, err); console.error(`Unable to start application error: ${err}`);
expect(err).toBeNull(); expect(err).toBeNull();
done(); done();
}); });

View File

@ -21,12 +21,12 @@ describe('Tests for Full screen', () => {
configPath = config; configPath = config;
done(); done();
}).catch((err) => { }).catch((err) => {
console.error(constants.UNABLE_TO_GET_USER_CONFIG_PATH, err); console.error(`Unable to get user config path error: ${err}`);
expect(err).toBeNull(); expect(err).toBeNull();
done(); done();
}); });
}).catch((err) => { }).catch((err) => {
console.error(constants.UNABLE_TO_START_APPLICATION, err); console.error(`Unable to start application error: ${err}`);
expect(err).toBeNull(); expect(err).toBeNull();
done(); done();
}); });

View File

@ -21,12 +21,12 @@ describe('Tests for Minimize on Close', () => {
configPath = config; configPath = config;
done(); done();
}).catch((err) => { }).catch((err) => {
console.error(constants.UNABLE_TO_GET_USER_CONFIG_PATH, err); console.error(`Unable to get user config path error: ${err}`);
expect(err).toBeNull(); expect(err).toBeNull();
done(); done();
}); });
}).catch((err) => { }).catch((err) => {
console.error(constants.UNABLE_TO_START_APPLICATION, err); console.error(`Unable to start application error: ${err}`);
expect(err).toBeNull(); expect(err).toBeNull();
done(); done();
}); });

View File

@ -15,7 +15,7 @@ describe('Tests for Notification position', () => {
app = startedApp; app = startedApp;
done(); done();
}).catch((err) => { }).catch((err) => {
console.error(constants.UNABLE_TO_START_APPLICATION, err); console.error(`Unable to start application error: ${err}`);
expect(err).toBeNull(); expect(err).toBeNull();
done(); done();
}); });

View File

@ -7,8 +7,4 @@ module.exports = {
SEARCH_LIBRARY_PATH_MAC: "node_modules/electron/dist/Electron.app/Contents/library", SEARCH_LIBRARY_PATH_MAC: "node_modules/electron/dist/Electron.app/Contents/library",
SEARCH_LIBRARY_PATH_WIN: "node_modules/electron/dist/library", SEARCH_LIBRARY_PATH_WIN: "node_modules/electron/dist/library",
UNABLE_TO_START_APPLICATION: "Unable to start application error: ",
UNABLE_TO_GET_USER_CONFIG_PATH: "Unable to get user config path error: "
}; };

View File

@ -19,7 +19,7 @@ describe('Tests for spellChecker', () => {
app = startedApp; app = startedApp;
done(); done();
}).catch((err) => { }).catch((err) => {
console.error(constants.UNABLE_TO_START_APPLICATION, err); console.error(`Unable to start application error: ${err}`);
expect(err).toBeNull(); expect(err).toBeNull();
done(); done();
}); });

View File

@ -22,12 +22,12 @@ describe('Tests for Zoom in and Zoom out', () => {
configPath = config; configPath = config;
done(); done();
}).catch((err) => { }).catch((err) => {
console.error(constants.UNABLE_TO_GET_USER_CONFIG_PATH, err); console.error(`Unable to get user config path error: ${err}`);
expect(err).toBeNull(); expect(err).toBeNull();
done(); done();
}); });
}).catch((err) => { }).catch((err) => {
console.error(constants.UNABLE_TO_START_APPLICATION, err); console.error(`Unable to start application error: ${err}`);
expect(err).toBeNull(); expect(err).toBeNull();
done(); done();
}); });