ELECTRON-1070: let electron handle protocol registration (#568)

* ELECTRON-1070: add default protocol client code for windows

* ELECTRON-1070: add comments

* bump up version number
This commit is contained in:
Vishwas Shashidhar 2019-02-13 18:16:27 +05:30 committed by GitHub
parent 4943db6d13
commit c9c38605c5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 6 deletions

View File

@ -49,6 +49,10 @@ require('./mainApiMgr.js');
// monitor memory of main process // monitor memory of main process
require('./memoryMonitor.js'); require('./memoryMonitor.js');
// adds 'symphony' as a protocol in the system.
// plist file in macOS and registry entries on windows
app.setAsDefaultProtocolClient('symphony');
const windowMgr = require('./windowMgr.js'); const windowMgr = require('./windowMgr.js');
const { ContextMenuBuilder } = require('electron-spellchecker'); const { ContextMenuBuilder } = require('electron-spellchecker');
const i18n = require('./translation/i18n'); const i18n = require('./translation/i18n');
@ -225,12 +229,7 @@ app.on('activate', function () {
} }
}); });
// adds 'symphony' as a protocol in the system. plist file in macOS
// on windows, we create the protocol handler via the installer
// because electron leaves registry traces upon uninstallation
if (isMac) { if (isMac) {
app.setAsDefaultProtocolClient('symphony');
// Sets application version info that will be displayed in about app panel // Sets application version info that will be displayed in about app panel
app.setAboutPanelOptions({ applicationVersion: `${clientVersion}-${version}`, version: buildNumber }); app.setAboutPanelOptions({ applicationVersion: `${clientVersion}-${version}`, version: buildNumber });
} }

View File

@ -1,7 +1,7 @@
{ {
"name": "Symphony", "name": "Symphony",
"productName": "Symphony", "productName": "Symphony",
"version": "4.4.1", "version": "4.4.2",
"clientVersion": "1.54", "clientVersion": "1.54",
"buildNumber": "0", "buildNumber": "0",
"description": "Symphony desktop app (Foundation ODP)", "description": "Symphony desktop app (Foundation ODP)",