mirror of
https://github.com/firefly-iii/firefly-iii.git
synced 2024-12-25 16:31:15 -06:00
Removed TODO items in favour of issues, or actual fixes.
This commit is contained in:
parent
111fcd77c4
commit
71bf054ab1
@ -37,7 +37,6 @@ class BudgetController extends Controller
|
||||
}
|
||||
|
||||
/**
|
||||
* TODO expand with no budget chart.
|
||||
*
|
||||
* @param BudgetRepositoryInterface $repository
|
||||
* @param $reportType
|
||||
@ -147,7 +146,7 @@ class BudgetController extends Controller
|
||||
$last = Navigation::endOfX($last, $range, $final);
|
||||
$entries = new Collection;
|
||||
// get all expenses:
|
||||
$set = $repository->getExpensesPerMonth($budget, $first, $last); // TODO
|
||||
$set = $repository->getExpensesPerMonth($budget, $first, $last);
|
||||
|
||||
while ($first < $last) {
|
||||
$monthFormatted = $first->format('Y-m');
|
||||
@ -294,7 +293,6 @@ class BudgetController extends Controller
|
||||
}
|
||||
|
||||
/**
|
||||
* TODO expand with no budget chart.
|
||||
*
|
||||
* @param BudgetRepositoryInterface $repository
|
||||
* @param $reportType
|
||||
|
@ -250,6 +250,7 @@ class RuleController extends Controller
|
||||
$data = [
|
||||
'rule_group_id' => $ruleGroup->id,
|
||||
'title' => $request->get('title'),
|
||||
'user_id' => Auth::user()->id,
|
||||
'trigger' => $request->get('trigger'),
|
||||
'description' => $request->get('description'),
|
||||
'rule-triggers' => $request->get('rule-trigger'),
|
||||
|
@ -194,7 +194,7 @@ class RuleRepository implements RuleRepositoryInterface
|
||||
|
||||
// start by creating a new rule:
|
||||
$rule = new Rule;
|
||||
$rule->user()->associate(Auth::user()); // TODO must be $data['user']
|
||||
$rule->user()->associate($data['user_id']);
|
||||
|
||||
$rule->rule_group_id = $data['rule_group_id'];
|
||||
$rule->order = ($order + 1);
|
||||
|
@ -120,8 +120,6 @@ class Processor
|
||||
}
|
||||
|
||||
/**
|
||||
* TODO stop when stop_processing is present.
|
||||
*
|
||||
* @return bool
|
||||
*/
|
||||
protected function triggered()
|
||||
|
Loading…
Reference in New Issue
Block a user