Bug 727647 - "gncInvoiceGetTotal" is not read-only function?

The root cause is in gncRecomputeValues. This function
only alters runtime cached values so it should not
trigger a book dirty action (mark_entry).
This commit is contained in:
Geert Janssens
2015-01-28 17:00:21 +01:00
parent 5e60a23400
commit 0ff9eba94f

View File

@@ -1327,7 +1327,6 @@ gncEntryRecomputeValues (GncEntry *entry)
/* Determine the commodity denominator */
denom = get_entry_commodity_denom (entry);
gncEntryBeginEdit (entry);
/* Compute the invoice values */
gncEntryComputeValue (entry->quantity, entry->i_price,
(entry->i_taxable ? entry->i_tax_table : NULL),
@@ -1360,8 +1359,6 @@ gncEntryRecomputeValues (GncEntry *entry)
entry->b_tax_value_rounded = gnc_numeric_convert (entry->b_tax_value, denom,
GNC_HOW_RND_ROUND_HALF_UP);
entry->values_dirty = FALSE;
mark_entry (entry);
gncEntryCommitEdit (entry);
}
/* The "Int" functions below are for internal use only.