IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

double_to_gnc_numeric: Return overflow error immediately on invalid input.

Browse Source 
Which is either nan or outside the range that gnc_numeric supports.
Also extend the powten array to support the full range of gnc_numeric.
This commit is contained in:
John Ralls
2014-06-08 13:46:56 -07:00
parent 0fc71ed4c7
commit 8d723f1b1e
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/libqof/qof/gnc-numeric.c
View File

@@ -42,13 +42,15 @@
static const gint64 pten[] = { 1, 10, 100, 1000, 10000, 100000, 1000000,
10000000, 100000000, 1000000000, 10000000000,
100000000000, 1000000000000, 10000000000000,
100000000000000, 10000000000000000};
100000000000000, 10000000000000000,
100000000000000000, 1000000000000000000,
10000000000000000000};
#define POWTEN_OVERFLOW -5
static inline gint64
powten (int exp)
{
if (exp > 16 || exp < -16)
if (exp > 19 || exp < -19)
return POWTEN_OVERFLOW;
return exp < 0 ? -pten[-exp] : pten[exp];
}
@@ -1162,6 +1164,9 @@ double_to_gnc_numeric(double in, gint64 denom, gint how)
double logval;
double sigfigs;
if (isnan (in) || fabs (in) > 1e18)
return gnc_numeric_error (GNC_ERROR_OVERFLOW);
if ((denom == GNC_DENOM_AUTO) && (how & GNC_HOW_DENOM_SIGFIG))
{
if (fabs(in) < 10e-20)