gnc_import_TransInfo_delete() was defined but never called!
This led to a memory leak, and erroneous behaviour.
Bug 552275 - Cancelling OFX Import Still Adds Entries
Bug 434944 - Refused transactions from import appear in register
Patch by Alan Jenkins <alan-jenkins@tuffmail.co.uk>
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17891 57a11ea4-9604-0410-9ed3-97b8803252fd
Affects all users of the generic import: OFX, HBCI and AqBanking.
Suggested by <http://bugzilla.gnome.org/show_bug.cgi?id=139310>.
"
Assume you have a transaction that transfers money from account 1 to account 2.
Import an OFX statement from account 1 that matches the transaction. Then
import an OFX statement from account 2 that matches the same transaction.
Because each transaction can only store one online_id, when you import from
account 1 again it doesn't remember that it's already been imported.
If online_id was stored in a split slot instead of a transaction slot, it would
allow tracking the online_id of both accounts without being overwritten.
"
For backwards compatibility, we still check for online_id in transactions.
This is more of a convenience than a critical feature, however.
The compatibility code could be removed in future versions if desired.
Patch by Alan Jenkins <alan-jenkins@tuffmail.co.uk>
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17889 57a11ea4-9604-0410-9ed3-97b8803252fd
Fix typos and use of apostrophes.
Also make the status of the document clearer.
Patch by Alan Jenkins.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17888 57a11ea4-9604-0410-9ed3-97b8803252fd
Patch by Alan Jenkins.
Signed-off-by: Christian Stimming <stimming@tuhh.de>
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17880 57a11ea4-9604-0410-9ed3-97b8803252fd
This fixes the default currency and description in the new account dialog.
Patch by Alan Jenkins.
Signed-off-by: Christian Stimming <stimming@tuhh.de>
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17879 57a11ea4-9604-0410-9ed3-97b8803252fd
Most of the source tree is UTF8, but there are some latin-1 hangovers.
Apply "iconv --from-code ISO_8859-1" to these files.
This affects bullet point characters in src/optional/xsl/README, and
Benoit Grégoire's name in source files (and hence the Doxygen output).
E.g. it should fix <http://svn.gnucash.org/docs/HEAD/reference.html>
which claims to be UTF8, but encodes Benoit's name in latin-1.
Patch by Alan Jenkins.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17877 57a11ea4-9604-0410-9ed3-97b8803252fd
Whenever an XML file is opened, Gnucash creates a new template root account and
makes the old one a child of it. My main accounts file had them nested over
540 deep before I got annoyed enough to fix this. The problem is that
sxtg_book_begin creates a root account when the book is opened. Then
add_template_transaction_local tries to replace this new root account with the
one read from the file. However the code that does this is rather badly broken
and the result is that the one read from the file becomes a child of the one
created in sxtg_book_begin.
This patch avoids creating any more nested root accounts, but it doesn't get
rid of the ones that are already there. This is slightly more tricky than just
deleting them since, although most of them have no children (other than the
next root account), some do. Accounts created for template transactions will
be children of whatever root account happens to be at the top of the tree then.
As the file is saved and reopened, this will get pushed down into the tree of
accounts. In my case about 5 of the 540 or so root accounts had other
children.
Patch by Mike Alexander.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17868 57a11ea4-9604-0410-9ed3-97b8803252fd
The template root account created as part of the scheduled transaction
infrastructure should have a name. Various parts of the Gnucash engine get
upset if an account doesn't have a name.
Perhaps this name should be localized, but the name of the main root account is
not localized.
Patch by Mike Alexander.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17867 57a11ea4-9604-0410-9ed3-97b8803252fd
This patch doesn't write the commodity, the commodity SCU, or the non-standard
SCU setting for an account that has no commodity.
Patch by Mike Alexander.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17866 57a11ea4-9604-0410-9ed3-97b8803252fd
Whenever I saved my Gnucash file I would get a number of errors like
CRIT <gnc.backend.xml> text_to_dom_tree: assertion `str' failed
I tracked this down to the fact that the weekend adjust field in recurrences
read from the file was not initialized properly if a recurrence didn't have a
weekend adjustment.
Patch by Mike Alexander.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17865 57a11ea4-9604-0410-9ed3-97b8803252fd
I finally got around to looking into this some more. I think the problem is a
result of an interaction between gnc_split_register_redraw and
gnc_split_register_find_split when called from gnc_split_register_move_cursor
in split-register-control.c. As the comment says, "redrawing the register can
muck everything up". In particular calling gnc_split_register_redraw may
change the "transaction split" for some or all of the transactions if the
register is a "ledger" style register such as the one for find results. This
causes the subsequent call to gnc_split_register_find_split to find the wrong
register row if the cursor class being found is CURSOR_CLASS_TRANS. Whether
this causes a crash seems to depend on circumstances I haven't quite figured
out, but I have one test file that crashes 100% of the time in r17804.
This patch changes the way gnc_split_register_find_split works when asked to
find the transaction split for a transaction. It assumes that any transaction
can only have one such split and returns as soon as it finds a row containing
it. If you think this is wrong, let me know and I'll try something else.
Patch by Mike Alexander.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17853 57a11ea4-9604-0410-9ed3-97b8803252fd
Fixes crashes and also improves error message when no budgets exists (for all
budget reports).
Patch by Forest Bond.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17851 57a11ea4-9604-0410-9ed3-97b8803252fd
If the price DB contains the reciprocal of the exchange rate which
gnc_pricedb_convert_balance_nearest_price,
gnc_pricedb_convert_balance_latest_price, and
gnc_pricedb_convert_balance_latest_before need to do their conversion they
don't find it and return zero.
Patch by Mike Alexander.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17850 57a11ea4-9604-0410-9ed3-97b8803252fd
In Hungary the smallest Forint (HUF) coin is 5 forints, but formally we had 1,2
forint coins, and dividing FILLER coins (like cents for US, EUR, ...). They are
simply not circulated in cash usage, but the banking system still using it.
Such as the smallest transferable amount is 0.01 FORINTs (1 FILLER), and with
business it is normal to use it (as result of foreign exchange, incoming
interest rate, or many other reason).
Patch by Frank H. Ellenberger.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17849 57a11ea4-9604-0410-9ed3-97b8803252fd
The contributer, Chad V, writes:
My reason being that if you like to keep track of different
"virtual" accounts within one bank account, it is nice to see the cleared
balance for the whole bank account.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17848 57a11ea4-9604-0410-9ed3-97b8803252fd
Not for back-port because it would break existing translations and the fix
isn't really important.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17831 57a11ea4-9604-0410-9ed3-97b8803252fd
This patch adds an additional label statement date to the box below the Credits
section.
Patch by C. Ernst
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17820 57a11ea4-9604-0410-9ed3-97b8803252fd
Report names are passed through the _() macro before they are stored to the
tree list.
Patch by C. Ernst.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17819 57a11ea4-9604-0410-9ed3-97b8803252fd
gnucash-2.2.7 doesn't (IMHO) log enough (any?) information about failures to
load optional modules. It was a bit of work to debug a recent problem (#564033)
and I ended up tweaking gnc_module_load_common() a bit to coax the error
messages out. I slightly reorganized the code in this function to accomplish
two things:
1. Make the logic clearer to someone new to the code (i.e., me)
2. If an optional module is found, log any errors in loading it
I tried to maintain the original spirit of not squawking too much about unfound
optional modules while still generating messages about legitimate problems.
Patch by G. Paul Ziemba.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17818 57a11ea4-9604-0410-9ed3-97b8803252fd
.scm files must be copied on windows because linking won't work.
Note: existing build directories will be fixed only after make clean.
Patch by C. Ernst.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17817 57a11ea4-9604-0410-9ed3-97b8803252fd
Add a new action "Balance" to reconcile window. It is only sensitive if the
difference is != 0.
If activated, it creates a new transaction in the account register to adjust
the difference. The corresponding account defaults to the orphan account.
Jump to the new transaction in the register window.
Patch by C. Ernst.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17782 57a11ea4-9604-0410-9ed3-97b8803252fd
This reverts one hunk of r17747: It's not necessary because the hash
table keys are freed up in gnucash_sheet_cleer_styles.
Patch by Jonathan Kamens.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17781 57a11ea4-9604-0410-9ed3-97b8803252fd
This time, the XML element handler for the "weekend adjustment" is optional
so that old files without that element are read without error.
Patch (well, kind of) by Simon Arlott.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17751 57a11ea4-9604-0410-9ed3-97b8803252fd
The report options of multicolumn reports show in the Selected Reports the
attributes "Rows" and "Cols". If choose "Size" to edit these values a dialog
opens with "Column span" and "Row span" - just the other way around. I always
confuse this. This patch swaps the order in the dialog.
Patch by C.Ernst.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17749 57a11ea4-9604-0410-9ed3-97b8803252fd
When writing the report options to saved-reports the embedded reports (if any
exist) are stored too. This is important for saving multicolumn reports.
Patch by C. Ernst.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17748 57a11ea4-9604-0410-9ed3-97b8803252fd
Here's the problem... GnuCash uses a hash table with int keys to store
dimensions, and the key value is the number of rows in the dimension being
stored. The problem is that this key value is stored in a static int inside
the style_get_key function, which means that the key always has the same
address, and the hash functions in glib2 store the *address*, not the *value*
of the key. Unfortunately, the hash algorithm changed some time between
glib2-2.18.2 and glib2-2.19.2, such that there's a hash conflict between the
key value 1 and the key value 2, but since the value of the already hashed key
was swiped out from under it when style_get_key "created" a new key, the hash
table entry that's already there matches even when it shouldn't have.
The attached patch cleans this up by allocating memory to hold the key when
inserting it into the hash table. It also changes the way the hash table is
created to ensure that the memory is freed when a hash table entry or hash
table is destroyed. And while I was at it, I made the same fix for the cursors
hash table, which was also leaking memory when entries were removed or the
table was destroyed.
Patch by Jonathan Kamens.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17747 57a11ea4-9604-0410-9ed3-97b8803252fd
This patch introduces a new option tab "Display" with boolean options for each
column, as proposed in comment 31. The default behaviour was (and is now again)
to display only Budget and Actual.
Patch by C. Ernst.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17743 57a11ea4-9604-0410-9ed3-97b8803252fd
This seems to be a prerequisite for fixing the timezone issues discussed
in #137017 and references therein.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17731 57a11ea4-9604-0410-9ed3-97b8803252fd
The original patch doesn't seem to deal with backward compatiblity in the
XML parser well enough. This commit reverts the GUI- and XML-related
parts of r17725.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17730 57a11ea4-9604-0410-9ed3-97b8803252fd
Patch originally provided by Paul Andreassen, in bugzilla by Paul Gear.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17727 57a11ea4-9604-0410-9ed3-97b8803252fd
This patch disables hardlinks on sshfs filesystems.
Patch by dhx <bugzilla@dhx.it>
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17726 57a11ea4-9604-0410-9ed3-97b8803252fd
The RFE wanted to specify the date of a scheduled transaction like this:
At the 15th of each month but if that is a saturday or a sunday then
at the next monday after that (or the friday before)
This patch implements this. The contributer writes:
Aside from some combinations being possible that don't make sense (because I
haven't looked at how to hide the extra combo boxes for them), and some awful
code in recurrenceNextInstance to stop it trying to go backwards (it may make
more sense to store the date that was going to be used next before it's changed
back/forward, so that that can be compared instead), it seems to work ok.
Patch by Simon Arlott.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17725 57a11ea4-9604-0410-9ed3-97b8803252fd
This patch removes all the calls to check_conversion which test zero
seconds (the epoch) and it changes the check_time function to skip
any timestamps that are before noon on January 1, 1970, UTC.
Patch by Daniel Harding.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17721 57a11ea4-9604-0410-9ed3-97b8803252fd
The command substiturion by $(expression) causes configure error on solaris.
Command substitution via $() is even part of
http://www.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html
, which I regard as POSIX definition of a shell, i.e. the absolute minimum I
think a shell should be able to do. From that document, backticks are
"just as standarized" as the $() form. In that sense, this patch is simply
unifying the command substitution pattern in our scripts.
Patch by Halton Huo.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17720 57a11ea4-9604-0410-9ed3-97b8803252fd
This patch is the last in the multicurrency set : it deals with
conversions where individual invoice/bill line item accounts are
different from the "owner" currency (aka, the invoice/bill currency).
The original plan was to also have a checkbox to allow the user to use
an account that isn't usually in the owner currency, in the owner
currency, but that's more ornate and requires more time and code than I
have time for right now, so, it's a feature for future :)
I tested out "invoice currency matches the default books currency and
has some accounts that use other currencies" and "invoice currency does
not match default currency and has some stuff that does and some stuff
that doesn't".. it could probably stand to also be tested by some other
folks, but what I tried worked :)
Patch by Jamie Campbell.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17719 57a11ea4-9604-0410-9ed3-97b8803252fd
This translation has been reviewed by one of the gnuchash translators for
Dutch nl_NL. There is no need for an extra translation for Belgium, this
version aims to be 'as Dutch as possible'. This file can now be used to
translate the other templates English to Dutch.
Translation by Pander <pander@users.sourceforge.net>.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17716 57a11ea4-9604-0410-9ed3-97b8803252fd
This is fixed by inserting a wrapper function whose pointer has the
correct type as needed by g_list_find_custom.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17711 57a11ea4-9604-0410-9ed3-97b8803252fd
This patch extends the payment dialog to allow paying foreign-currency
AP with local currency, or local-currency AP with foreign currency (I
don't know if there's a use-case for the latter, but it would have been
harder to code to NOT support it).
Patch by Jamie Campbell.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17710 57a11ea4-9604-0410-9ed3-97b8803252fd
This is fixed by inserting a wrapper function whose pointer has the
correct type as needed by g_list_find_custom.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17709 57a11ea4-9604-0410-9ed3-97b8803252fd
This patch adds a new account selection filter allowing valid commodity
to be restricted, and makes use of it for bill posting. This filter is
allowed to be NULL (just as with the 'account type' filter) and when
NULL, isn't used. The patch also fixes a bug where gnc commodity copy
wasn't copying mnemonic, thus erroneously making a copy not equal to the
original when comparison happens. The behaviour is that the user isn't
able to select a post account in the wrong currency. If there is no
possible account (aka, EVERYTHING gets filtered out) they get a blank
combo box. This is consistent with what the account type filter does
when there are no valid account-type accounts.
Patch by Jamie Campbell and Mark Jenkins.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17708 57a11ea4-9604-0410-9ed3-97b8803252fd
It's part of the Gnucash multicurrency extensions project I'm working
through, see also emails Nov 4th 16:42; Nov 4 16:46; Oct 31 16:14 , as
well as the original proposal email oct 23 16:34 (It seems like we're
mostly a 16:00 kind of group)
Patch by Jamie Campbell (with one urgency_hint removed from the glade file)
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17707 57a11ea4-9604-0410-9ed3-97b8803252fd
Martin Preuss pointed out that 3.9.x might be used as a number for a stable
libaqbanking3 release sometime in the future.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17706 57a11ea4-9604-0410-9ed3-97b8803252fd
Allow to remove all elements which results in an "empty" new/refinement/...
search matching all available items. In that case grey out the match-type
combo in the upper right corner and add a label "Match all entries" where the
criteria list used to sit.
Patch by andi5.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17705 57a11ea4-9604-0410-9ed3-97b8803252fd
Patch by David Reiser. Needed in addition to r17620.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17703 57a11ea4-9604-0410-9ed3-97b8803252fd
This was caused by changing the internal structure name of the GncBudget,
in r17369 and originally in r17352. From a quick glance, the gda-dev branch
didn't introduce any further structure name changes, but those should be
reviewed in any case.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17687 57a11ea4-9604-0410-9ed3-97b8803252fd
The contributor writes:
I needed a line chart for a custom report and was surprised to find
that it is currently not supported by Gnucash. Line charts are
supported by the GOffice library, so I implemented line charts based
on the bar charts implementation (and added some new parameters for
markers and grid).
Patch by Sven Henkel <shenkel@gmail.com>.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17685 57a11ea4-9604-0410-9ed3-97b8803252fd
This bug is related to all the rest of the date-time issues, but has an
additional twist because of finance-quote.
Somewhere between the fq-helper and the price db, gnucash rolls the quote
through timespecCanonicalDayTime(), wherein it first runs localtime_r(), to
produce, presumably, "2008-11-03 19:00:00" for my Eastern US location. Having
now screwed up the date, gnucash runs gnc_tm_set_day_middle() on it to enter
the price in the pricedb as of noon on the wrong date.
Patch by David Reiser.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17680 57a11ea4-9604-0410-9ed3-97b8803252fd
Gnucash trunk (r17677) hangs on launch under Mac OS X 10.5.5. The progress bar
says "gnucash/report/standard-reports". Adding a report guid to
budget-flow.scm, budget-barchart.scm, and job-reports.scm fixes the hang.
Patch by David Reiser.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17679 57a11ea4-9604-0410-9ed3-97b8803252fd
In the patch committed in r17675 the proposed calculation of differences
was wrong for income and liabilities. This patch should fix this issue.
When back-porting, please make sure to apply this one too.
Patch by C.Ernst.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17678 57a11ea4-9604-0410-9ed3-97b8803252fd
The contributor writes:
I need a report which shows me all invoices of a job. This is similar to the
owner-report, e.g. Customer Report. I took the file of owner-report.scm,
changed it so it does the desired and saved it as job-report.scm. I also had to
patch business-core.i to export the right symbols and business-urls.c to have
access to a link to the Job in the header. A patch is attached and I would be
very pleased if this could make it into gnucash. It could be possible to unify
owner-report and job-report, but I didn't put too much effort in it.
Patch by Stefan Wolf.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17664 57a11ea4-9604-0410-9ed3-97b8803252fd
Original patch included also the fix of r16884, which was applied earlier already.
Patch by David Osguthorpe.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17663 57a11ea4-9604-0410-9ed3-97b8803252fd
The contributor writes: This report display the budgeted vs actual budget
in a barchart.
Patch by "tbic".
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17662 57a11ea4-9604-0410-9ed3-97b8803252fd
The contributor writes: I created the report to help create a "zero-based"
budget for a class I was taking. I could use the totals at the bottom to
make sure every dollar was allocated some ware. I know virtually nothing
about accounting, the reason I named the report "Budget Flow" is because
it was based off from the "Cash Flow" report.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17661 57a11ea4-9604-0410-9ed3-97b8803252fd
New Israeli Shekel: The informal abbreviation may be "NIS", but its
iso-4217 code is clearly ILS and only this! Incorrectly changed due to
bug#152755 (Nov 2004), r10331, and changed back again by bug#492417
(Oct 2008).
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17660 57a11ea4-9604-0410-9ed3-97b8803252fd
When creating a scheduled transaction from a given transaction, the
first occurence from the transaction date onwards is found by
calculating the first occurence after the day before that date. OTOH,
that "yesterday" should not be used as start date of the dense calendar.
Patch by Andreas Köhler <andi5.py@gmx.net>.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17659 57a11ea4-9604-0410-9ed3-97b8803252fd
src/app-utils/date-utilities.scm has a few typos ("set:tm-month" instead of
"set:tm-mon" and a few misplaced parens). This is at least as old as 2.2.6 and
still exists on trunk.
Patch by Wolfgang Schnerring, but the first hunk had one parentheses too many; fixed by me.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17658 57a11ea4-9604-0410-9ed3-97b8803252fd
The help files suggest that the user assign the stock ticker symbol as the
account name. There isn't any strong guidance in the tutorial about what the
description should be, but I think a good default is the full name of the
security. This patch accomplishes my proposal, as long as one navigates
to the right Stock parent account before Clicking New Account.
Patch by David Reiser.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17657 57a11ea4-9604-0410-9ed3-97b8803252fd
This patch replaces the function gnc_split_value_print_info, which returns the
print info for the currency of the split's transaction, with a new function,
gnc_split_register_print_info, which returns the print info for the split
register's default account. That way the amounts displayed in the register use
the fraction of the register's account, rather than the fraction of the
transaction's currency.
Patch by Daniel Harding.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17656 57a11ea4-9604-0410-9ed3-97b8803252fd
AM_CFLAGS is passed both to the compiler (.c -> .o) and to the linker, so it
should only have flags that are appropriate for both steps. AM_CPPFLAGS is
passed only to the compiler, so flags that are only appropriate for that step
(-I and -D flags, for example), should be in _CPPFLAGS instead of _CFLAGS.
Every gnucash-2.2.3 Makefile.am that passes -I flags gets it wrong, placing
them in _CFLAGS. It's not a functional bug (the linker ignores -I flags), but a
ton of superfluous flags makes the build output pretty verbose and hard to
debug when things do go wrong.
To make matters more confusing as a developer, the FOO_CFLAGS variable set by
PKG_CHECK_MODULES(FOO) is actually for _CPPFLAGS in the Makefile.am
('pkg-config --cflags' returns the -I flags).
A related -I bug (one that *is* functionally broken) is that sometimes a local
(build dir) -I flag is passed after a global (installed dependent library) one.
If my system happens to have a header installed from some unrelated thing,
compiler will find *that* one instead of the expected one in the source
directory. Should always pass all local -I before any global ones.
Patch by andi5 plus one manual addition in src/gnome-utils/Makefile.am
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17655 57a11ea4-9604-0410-9ed3-97b8803252fd
Patch by andi5: The logic to determine whether there is an exchange rate
dialog to be showed is complex and should not run when you user traverses
her register. This patch adds a bit more information for the user where
this logic previously silently returned without action.
Comment from i18n maintainer (cstim): The bug in question is severe enough to
justify new strings here. Just go ahead and add more explanatory messages
as needed.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17654 57a11ea4-9604-0410-9ed3-97b8803252fd
This is new patch including fix checking 'unsigned long is at least as big as
guint32' and 'guile long_long is at least as big as gint64'
Patch by Halton Huo.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17653 57a11ea4-9604-0410-9ed3-97b8803252fd
gcc gives a correct warning about a possibly uninitialised variable.
This stops compilation.
Patch by joslwah@gmail.com.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17651 57a11ea4-9604-0410-9ed3-97b8803252fd
Changes the 'Sensitive' Property to 'No' from 'Yes' in 'account.glade'
for the 'tax_related_button' widget so that the setting is displayed but
cannot be changed in the account edit dialog. Sets the Tooltip
property to "Use Edit->Tax Options to set the tax-related flag and assign
a tax code to this account." in 'account.glade'.
Patch by "J. Alex Aycinena" <alex.aycinena@gmail.com>
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17646 57a11ea4-9604-0410-9ed3-97b8803252fd
In the post screen for vendor bills, in trunk, the account combo box
initially has no entry and the user needs to pick one. This isn't a
bug, but is an extra step for the user, so the trunk patch does
defaulting. I tested the "memory" function to make sure the defaulting
doesn't smash the account the user picked for this vendor the last time
through, and it works (doesn't conflict).
Patch by aradzak <aradzak@oracleatbelfry.com>.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17644 57a11ea4-9604-0410-9ed3-97b8803252fd
Note that the up-to-date text about this should be in the wiki,
http://wiki.gnucash.org/wiki/Translation
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17633 57a11ea4-9604-0410-9ed3-97b8803252fd
Patch contributed by Martin Preuss, modified by CS.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17620 57a11ea4-9604-0410-9ed3-97b8803252fd
One template is the default one (common accounts), the other ("ry") is for a
finnish non-profit organisation.
Tuomo Kohvakka <tuomo.kohvakka@iki.fi>
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17607 57a11ea4-9604-0410-9ed3-97b8803252fd
Prints tax information sorted by Form/Schedule, tax code, account,
transaction and date instead of by account hierarchy. Allows any tax
code to be assigned to multiple accounts. No longer double counts
transactions when a parent account is not a placeholder and has
transactions posted to it. Converts non-USD accounts and transactions
to USD instead of adding across currencies. Provides an error dialog
instead of crashing gnucash when exporting a file without write
permission. Provides additional options to adjust the level of detail
shown on the report.
Patch by J. Alex Aycinena <alex.aycinena@gmail.com>.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17602 57a11ea4-9604-0410-9ed3-97b8803252fd
Mark Jenkins wrote: I would also like to give credit to Assiniboine Credit Union
(http://www.assiniboine.mb.ca Winnipeg, Canada), which has funded a good
chunk of our work on this through a grant they gave us in 2007.
Additional python binding work since between June 17 and December 31,
2008 is being funded by a second grant they gave us this year.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17291 57a11ea4-9604-0410-9ed3-97b8803252fd
Christian Stimming