Only auto-post if:
The posted_to account name is valid.
There's no currency conversion.
The invoice customer's currency matches the A/R account currency.
Tell the user what happened with a dialog.
When importing the last line of the CSV the gtk_tree_model_get() never happens
and the following compare uses the previous value of new_id, which is now = id,
so the last invoice is never posted.
Set new_id = Null before gtk_tree_model_get() to ensure processing the last line.
even if bill is already posted and results in extra $ posted to A/P
This adds a test in gncInvoice to return NULL it already posted.
Adds checks in dialog-invoice to test for already posted invoices. Messages
user and refuses to post entire selection if more than one selected.
Translators: This adds a message string.
This looks a rounding error caused by not setting the denominator to an
appropirate value. I've set it to 100x the currency fraction.
For some reason I removed the call to gnc_numeric_convert() in commit
564b987457 I shouldn't have done that. I should have adjusted the denom.
Don't set the invoice ID before the user has clicked OK in the dialog.
If the user cancels in the dialog the counter would have already been
incrementd. Making the ID an empty string makes the ID be set in
gnc_invoice_window_verify_ok().
Prevent editing the terms from the invoice view. This has to be edited
via the edit invoice button or menu Edit->Edit Invoice. The dropdown
in the invoice view has been replaced with an edit text box set to
non-editable in the glade file.
Alter the SWIG interface file to expose the
gncCustomerNextID in Python and adds a CustomerNextID() function
in the book class similar to the InvoiceNextID and BillNextID function.
Author: Tom Lofts <dev@loftx.co.uk>
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@23777 57a11ea4-9604-0410-9ed3-97b8803252fd
Make "Date Posted" and "Posted Account" widgets visible when an invoice is posted.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@23751 57a11ea4-9604-0410-9ed3-97b8803252fd
Any Entry.functions were returning <Swig Objects> instead of instances.
Also removed invalid items from entry_dict in gnucash_business.py.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@23661 57a11ea4-9604-0410-9ed3-97b8803252fd
Fixes the labelling in the bill or voucher windows and the new dialog.
It doesn't fix the bug, but is related to it.
Note to translators: Introduces four new strings
"Voucher Information", "Bill Information", "Bill", "Voucher",
modified: src/business/business-gnome/dialog-invoice.c
modified: src/business/business-gnome/gnc-plugin-page-invoice.c
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@23458 57a11ea4-9604-0410-9ed3-97b8803252fd
Reverses previous commit for this bug and applies patches for fix.
This is an amalgum of 7 patches.
Patch comments are reproduced below. All patches supplied by R Ratcliff.
[PATCH 1/7] Fix budget view resizing issue
The fix here is to change the hardcoded width value from 86 to 60.
* Remove size-allocate signal bound to treeviewcolumn (columns
don't emit signals)
[PATCH 2/7] Fix the way column width is determined
The budget tree view has a bunch of columns that have visible
set to false. These columns have a width of 0. Change
gbv_tree_view_resized_cb to ignore these columns.
[PATCH 3/7] Change column sizing method.
Not sure if this is crucial to the bug fix.
[PATCH 4/7] Fix regression for window horizontal resizing
This change does two things
* Set expand on totals_title_col to TRUE
* Not set the width of this column in gbv_treeview_resized_cb
Note: The second one is a bit tricky. It relies on the fact that
totals_title_col has a default sizing of GROW_ONLY. It only explicitly
sets the size on columns that have a sizing of FIXED
[PATCH 5/7] Fix horizontal scrolling
* Add a vbox inside the scrolled_window, and add the two treeviews to that.
This fixes horizontal scrolling. If the budget view is too wide for the
window, then a horizontal scrollbar will appear at the bottom, and scroll
both the main budget view and the totals view at the bottom.
However, it breaks vertical scrolling (vertical scrollbar will scroll the
entire view, instead of just the top view). I'll fix this in the next commit.
[PATCH 6/7] Fix vertical scrolling
Vertical scrolling will only apply to the top view (budget values) and not
to the bottom view (budget totals).
Implementation: add an inner scrolled window for the vertical scrollbar.
Set scrolled_window vertical scrollbar policy to NEVER.
Note: This design looks weird when both scrollbars are used because you
have to scroll horizontally to the right in order to see the vertical
scrollbar for the top section.
[PATCH 7/7] Clean up code before submitting patch
* Remove debugging and commented out code
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@23202 57a11ea4-9604-0410-9ed3-97b8803252fd
* Remove extra call to gtk_tree_view_append_column. (It is already
called in gnc_tree_view_account_add_custom_column.)
Author: Robert Ratliff <ratliff.bobby@gmail.com>
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@23175 57a11ea4-9604-0410-9ed3-97b8803252fd
TODO:
Saving search preferences doesn't save reverse sort.
The blank_split remains at the bottom of the register when reverse
sorted.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@22766 57a11ea4-9604-0410-9ed3-97b8803252fd
Done using the following options:
astyle --indent=spaces=4 --brackets=break --pad-oper --pad-header --suffix=noneR
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@22433 57a11ea4-9604-0410-9ed3-97b8803252fd
were always created even if one with a matching ID already exists.
The intended behaviour is to update customer or vendor data if
one already exists with a matching ID.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@22432 57a11ea4-9604-0410-9ed3-97b8803252fd
From a patch by Bob.
Patch also resizes small OK button.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@22353 57a11ea4-9604-0410-9ed3-97b8803252fd
Change date cells type from text-cell to date-cell to apply white-space: nowrap
style.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@22281 57a11ea4-9604-0410-9ed3-97b8803252fd
Add job name and number to printable invoice. This only applies to
invoice.scm.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@22233 57a11ea4-9604-0410-9ed3-97b8803252fd
unchecking the taxable flag for that item didn't remove the tax related columns
from the invoice where there are no other taxable items.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@22141 57a11ea4-9604-0410-9ed3-97b8803252fd
Fix typo. Fix column misalignment when no taxes are present in the invoice.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@22119 57a11ea4-9604-0410-9ed3-97b8803252fd
dialog-customer-import.c:399:36: error: 'shipaddr' may be used uninitialized in this function [-Werror=uninitialized]
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@22110 57a11ea4-9604-0410-9ed3-97b8803252fd
From a patch by Sebastian Held.
Again the CSV file is of fixed number of fields, similar to invoice/bill importer.
Please test this.
Field list:
id, company, name, addr1, addr2, addr3, addr4, phone, fax, email, notes, shipname, shipaddr1, shipaddr2, shipaddr3, shipaddr4, shipphone shipfax, shipemail
Vendors don't have shipping information so even though the fields have to exist, leave them empty.
The id field is optional, if empty a new id will be chosen. If an id is used this will UPDATE
a vendor/customer with the same id. This may not be what the user wants. Maybe this should
be optional/selectable behaviour.
To enable the plugin, add the line:
(gnc:module-load "gnucash/plugins/customer_import" 0)
to ~/.gnucash/config.user
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@22065 57a11ea4-9604-0410-9ed3-97b8803252fd
Add the renamed files. Oops, missed one, here it is.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@21872 57a11ea4-9604-0410-9ed3-97b8803252fd
Add the renamed files.
Patch supplied by Bob Fewell. Many thanks.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@21871 57a11ea4-9604-0410-9ed3-97b8803252fd
Open a save dialog after chart of accounts assistant.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@21650 57a11ea4-9604-0410-9ed3-97b8803252fd
Added Swedish chart of accounts for small businesses.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@21632 57a11ea4-9604-0410-9ed3-97b8803252fd
Added new line chart report for assets, net-linechart.scm.
Distantly related to Bug #570011
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@21629 57a11ea4-9604-0410-9ed3-97b8803252fd
Mike Evans