Commit Graph

26261 Commits

Author SHA1 Message Date
John Ralls
7c350c3ae5 Bug 798616 - Can't register amount greater than 9,000,000,000
Because when loading the value the split in the xml backend doesn't yet
have a parent so the code tried to convert to GNC_COMMODITY_MAX_FRACTION
and if the numerator was larger than 10^10 that would overflow.

To fix it this changes the "don't know" response to get_currency_denom
and get_commodity_denom to GNC_DENOM_AUTO which will normally leave
the denominator alone.
2022-09-19 18:17:58 -07:00
Christopher Lam
1752f1d19d [assistant-stock-transaction] disallow stock split ratio of 0.
otherwise the reverse stock split would allow a new stock amount
balance of zero.
2022-09-20 08:45:07 +08:00
Christopher Lam
84f4f3b6f8 [assistant-stock-transaction] add to toolbar 2022-09-19 10:03:28 +08:00
Christopher Lam
cfd37c9102 [assistant-stock-transaction] fix stock split creation algorithm
* stock_amount was reduced as a previous bugfix attempt
* remove references to Stock Split Assistant
2022-09-19 09:37:19 +08:00
Christopher Lam
6ba0f849ba [assistant-stock-transaction] refactor: centralize price calculator
Price was being computed in 3 places: the stock_value page, the
summary-table info list, and the final pricedb creation function. This
commit centralizes it into 1 function which returns std::nullopt if
the price is not computable.

Also fixes price display to follow global pref general/force-price-decimal
2022-09-17 23:12:00 +08:00
Christopher Lam
9a8bc8f7e5 [assistant-stock-transaction] disallow selection in summary table
... because selection hides the red color from last commit. There's no
action attached to selection in the treeview. It can be disabled.
2022-09-17 14:21:51 +08:00
Christopher Lam
596ff26928 [assistant-stock-transaction] if negative Units, render in red color
...in the summary table
2022-09-17 13:52:01 +08:00
Christopher Lam
58c1a51897 Merge branch 'master-budget-changes' #1238 2022-09-16 23:15:24 +08:00
Christopher Lam
8e6c07db1e Merge branch 'maint-currency-edit-completion' #1429 2022-09-16 18:06:38 +08:00
Christopher Lam
84ac769b14 Merge branch 'maint' 2022-09-16 18:06:28 +08:00
Christopher Lam
8dd063b84d Merge branch 'maint-stock-assistant-stock-split' into maint #1414 2022-09-15 20:54:43 +08:00
Christopher Lam
723189b26c [assistant-stock-transaction] special stock_amount input stock splits 2022-09-15 08:04:07 +08:00
Christopher Lam
ab06e1e065 [assistant-stock-transaction] specialises stock_amount input 2022-09-15 07:59:49 +08:00
Christopher Lam
1d4e522597 [assistant-stock-transaction] refactor create_split
takes gnc_numeric instead of GtkWidget*
2022-09-15 07:59:48 +08:00
이정희
5c97da5d87
Translation update by 이정희 <daemul72@gmail.com> using Weblate
po/ko.po: 63.8% (3449 of 5401 strings; 1015 fuzzy)
263 failing checks (4.8%)
Translation: GnuCash/Program (Korean)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/ko/

Translation update  by 이정희 <daemul72@gmail.com> using Weblate

po/ko.po: 62.2% (3364 of 5401 strings; 1085 fuzzy)
315 failing checks (5.8%)
Translation: GnuCash/Program (Korean)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/ko/

Translation update  by 이정희 <daemul72@gmail.com> using Weblate

po/ko.po: 62.2% (3363 of 5401 strings; 1085 fuzzy)
315 failing checks (5.8%)
Translation: GnuCash/Program (Korean)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/ko/

Co-authored-by: 이정희 <daemul72@gmail.com>
2022-09-15 01:27:09 +02:00
Christopher Lam
b21756119b Merge branch 'CDB-Man-changes' into maint #1431 2022-09-15 07:23:27 +08:00
Christopher Lam
1ddb492638 [assistant-stock-transaction] remove combined transactions types
They will be recorded separately.

* Dividend Reinvestment = Dividend + Long Buy
* Reverse Split with Cash-in-Lieu = Sell or Cover Buy + Reverse-Split
2022-09-15 00:36:47 +08:00
Christopher Lam
fe48d56a66 [assistant-stock-transaction] if applicable, show price to insert 2022-09-14 23:40:05 +08:00
Christopher Lam
692cbfc844 [assistant-stock-transaction] add forgotten default memo 2022-09-14 23:40:05 +08:00
이정희
d167b017a8
Translation update by 이정희 <daemul72@gmail.com> using Weblate
po/ko.po: 57.7% (3120 of 5401 strings; 1258 fuzzy)
433 failing checks (8.0%)
Translation: GnuCash/Program (Korean)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/ko/

Co-authored-by: 이정희 <daemul72@gmail.com>
2022-09-13 17:50:57 +02:00
Wellington Terumi Uemura
f232ae48d3
Translation update by Wellington Terumi Uemura <wellingtonuemura@gmail.com> using Weblate
po/pt_BR.po: 100.0% (5401 of 5401 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Portuguese (Brazil))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/pt_BR/

Co-authored-by: Wellington Terumi Uemura <wellingtonuemura@gmail.com>
2022-09-13 17:50:56 +02:00
Pedro Albuquerque
ece820da27
Translation update by Pedro Albuquerque <pmra@gmx.com> using Weblate
po/pt.po: 100.0% (5401 of 5401 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Portuguese)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/pt/

Co-authored-by: Pedro Albuquerque <pmra@gmx.com>
2022-09-13 17:50:56 +02:00
Frank H. Ellenberger
4321136480
Translation update by Frank H. Ellenberger <frank.h.ellenberger@gmail.com> using Weblate
po/de.po: 100.0% (5401 of 5401 strings; 0 fuzzy)
178 failing checks (3.2%)
Translation: GnuCash/Program (German)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/de/

Co-authored-by: Frank H. Ellenberger <frank.h.ellenberger@gmail.com>
2022-09-13 05:54:02 +02:00
Yuri Chornoivan
5a0be7acc4
Translation update by Yuri Chornoivan <yurchor@ukr.net> using Weblate
po/uk.po: 100.0% (5401 of 5401 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Ukrainian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/uk/

Co-authored-by: Yuri Chornoivan <yurchor@ukr.net>
2022-09-13 05:54:01 +02:00
Yaron Shahrabani
64508df4ce
Translation update by Yaron Shahrabani <sh.yaron@gmail.com> using Weblate
po/he.po: 100.0% (5401 of 5401 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Hebrew)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/he/

Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com>
2022-09-13 05:54:00 +02:00
Eric
e698013fc5
Translation update by Eric <hamburger1024@mailbox.org> using Weblate
po/zh_CN.po: 99.9% (5396 of 5401 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Chinese (Simplified))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/

Co-authored-by: Eric <hamburger1024@mailbox.org>
2022-09-13 05:54:00 +02:00
CDB-Man
9cd66451c2
Update assistant-stock-transaction.cpp - reverse split remainders 2022-09-12 02:21:03 -04:00
CDB-Man
6ceee1b850
Update assistant-stock-transaction.cpp - dividend reinvestment
"Company issues dividend, which may be reinvested. Remaining non-reinvested dividends (if any) are paid out as a cash dividend.")
2022-09-12 02:04:16 -04:00
CDB-Man
f9f3717fdf
Update assistant-stock-transaction.cpp - consistent wording
Harmonizing some wording for consistency.
2022-09-11 18:13:48 -04:00
Frank H. Ellenberger
b727b87404 I18N: String Freeze – msgmerge 4.12-pre1 2022-09-11 23:42:21 +02:00
Frank H. Ellenberger
3a9ded2a2c I18N: Resolve "Open" ambiguity 2022-09-11 23:40:09 +02:00
CDB-Man
eaa7824b15
Update assistant-stock-transaction.cpp
1. Remove $ currency signs to make it region agnostic
2. Remove the word "value" from stock splits and replace with "overall investment"
3. Remove $ signs from the compensatory return of capital and compensatory notional distribution transactions
2022-09-11 17:04:48 -04:00
Frank H. Ellenberger
88e942bcc1
Translation update by Frank H. Ellenberger <frank.h.ellenberger@gmail.com> using Weblate
po/de.po: 99.9% (5399 of 5400 strings; 1 fuzzy)
181 failing checks (3.3%)
Translation: GnuCash/Program (German)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/de/

Co-authored-by: Frank H. Ellenberger <frank.h.ellenberger@gmail.com>
2022-09-11 22:58:17 +02:00
Christian Wehling
0d0e181324
Translation update by Christian Wehling <christian.wehling@web.de> using Weblate
po/de.po: 99.9% (5398 of 5400 strings; 2 fuzzy)
182 failing checks (3.3%)
Translation: GnuCash/Program (German)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/de/

Co-authored-by: Christian Wehling <christian.wehling@web.de>
2022-09-11 22:58:16 +02:00
Simon Arlott
9f66313423
Translation update by Simon Arlott <weblate.simon@arlott.org> using Weblate
po/en_NZ.po: 100.0% (5400 of 5400 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (English (New Zealand))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/en_NZ/

Translation update  by Simon Arlott <weblate.simon@arlott.org> using Weblate

po/en_AU.po: 100.0% (5400 of 5400 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (English (Australia))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/en_AU/

Translation update  by Simon Arlott <weblate.simon@arlott.org> using Weblate

po/fr.po: 99.9% (5398 of 5400 strings; 2 fuzzy)
3 failing checks (0.1%)
Translation: GnuCash/Program (French)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/fr/

Translation update  by Simon Arlott <weblate.simon@arlott.org> using Weblate

po/en_GB.po: 100.0% (5400 of 5400 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (English (United Kingdom))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/en_GB/

Co-authored-by: Simon Arlott <weblate.simon@arlott.org>
2022-09-11 22:58:16 +02:00
Christopher Lam
a6ffd6e119 [gnc-currency-edit] allow GtkEntry completion 2022-09-11 11:49:57 +08:00
Christopher Lam
fe37b994db [gnc-currency-edit] use enum for GtkListStore columns 2022-09-11 11:49:57 +08:00
CDB-Man
e19308bd49
Pull request for updated wording
On the long side of the transaction list, dividend reinvestments with and without remainder can be merged.

On the short side of the transaction list, the 2 dividend reinvestment transactions are not relevant and should be deleted.  There is no such thing as a "compensatory dividend reinvestment".
2022-09-10 20:04:48 -04:00
Milo Ivir
cb1bdb81bf
Translation update by Milo Ivir <mail@milotype.de> using Weblate
po/hr.po: 100.0% (5400 of 5400 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Croatian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hr/

Co-authored-by: Milo Ivir <mail@milotype.de>
2022-09-09 17:50:49 +02:00
Christopher Lam
161b07b241 Merge branch 'maint' 2022-09-09 21:23:40 +08:00
Christopher Lam
6d7b0cccbe Merge branch 'maint-stock-transaction-summary' into maint #1423 2022-09-09 20:11:03 +08:00
Christopher Lam
eab8a218b1 [assistant-stock-transaction] add translator hints 2022-09-09 18:01:28 +08:00
Christopher Lam
6da1ddaec6 [assistant-stock-transaction] hide zero-fee line in summary table 2022-09-09 18:00:28 +08:00
Christopher Lam
c1c82b96a9 [assistant-stock-transaction] add Units column 2022-09-09 18:00:27 +08:00
Christopher Lam
bd0e9cdae1 [assistant-stock-transaction] add_to_summary_table outside check_page
refactor; refresh_page_finish calls add_to_summary_table instead of
check_page.
2022-09-09 18:00:10 +08:00
Christopher Lam
391c7b2e75 [assistant-stock-transaction] modify GtkListStore outside check_page
Pull out add_to_summary_table function to populate the
summary_info. Preparation for next commit
2022-09-09 18:00:09 +08:00
이정희
7fd4c8bb48
Translation update by 이정희 <daemul72@gmail.com> using Weblate
po/ko.po: 57.7% (3120 of 5400 strings; 1257 fuzzy)
438 failing checks (8.1%)
Translation: GnuCash/Program (Korean)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/ko/

Translation update  by 이정희 <daemul72@gmail.com> using Weblate

po/ko.po: 56.7% (3063 of 5400 strings; 1279 fuzzy)
454 failing checks (8.4%)
Translation: GnuCash/Program (Korean)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/ko/

Co-authored-by: 이정희 <daemul72@gmail.com>
2022-09-08 21:22:30 +02:00
Giuseppe Foti
8cd3c70d48
Translation update by Giuseppe Foti <foti.giuseppe@gmail.com> using Weblate
po/it.po: 100.0% (5400 of 5400 strings; 0 fuzzy)
3 failing checks (0.1%)
Translation: GnuCash/Program (Italian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/it/

Co-authored-by: Giuseppe Foti <foti.giuseppe@gmail.com>
2022-09-08 21:22:30 +02:00
Wellington Terumi Uemura
570d249f32
Translation update by Wellington Terumi Uemura <wellingtonuemura@gmail.com> using Weblate
po/pt_BR.po: 100.0% (5400 of 5400 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Portuguese (Brazil))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/pt_BR/

Co-authored-by: Wellington Terumi Uemura <wellingtonuemura@gmail.com>
2022-09-08 05:18:27 +02:00
Yaron Shahrabani
ffbea40628
Translation update by Yaron Shahrabani <sh.yaron@gmail.com> using Weblate
po/he.po: 100.0% (5400 of 5400 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Hebrew)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/he/

Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com>
2022-09-08 05:18:27 +02:00