I think in the specific case of the
"Transaction Report" this is the better choice. The error message
will be clear enough ("No accounts selected. Click here to Edit report
options"), and it will probably meet the user expectation that some account
needs to be selected anyway before something can be seen.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19432 57a11ea4-9604-0410-9ed3-97b8803252fd
Patch by Mike E and Mark Jenkins:
When creating or appending to invoices, customers and bills, searching by ID is
likely more useful than by GUID. I've added this functionality to the Python
bindings.
Search by ID using the python code:
tmp = gnucash.gnucash_core_c.search_invoice_on_id(ID,book.instance)
if tmp:
invoice = gnucash.gnucash_business.Invoice(instance=tmp)
Use the invoice object as in sample_scripts/simple_invoice_insert.py
I support this patch, but I've made a few improvments of my own.
I switched up the arguments in search_customer_on_id, search_invoice_on_id,
search_bill_on_id to have Book first and ID second. The reason for this was to
make these functions more consistent with the other functions where a search is
done through a book on a particular attribute.
Also added some specific python bindings support to allow this to be used as
methods of Book: Book.CustomerLookupByID, Book.InvoiceLookupByID,
Book.BillLoookupByID.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19431 57a11ea4-9604-0410-9ed3-97b8803252fd
Patch by Matthijs Kooijman:
The current eguile template implementation catches errors that occur while
evaluating an eguile template. However, only the error is shown, not a
backtrace (so no location of the error either).
The attached patch modifies the error handling to also capture the stack
backtrace, using a lazy exception handler (e.g., capture the stack before
unwinding the stack to the real exception handler).
To extract only the relevant part of the stack (e.g., the part inside the
eguile template, not the tens of stack frames leading up to the report
rendering), a stack dump is made just before evaluating the eguile template (so
a sort of "diff" can be made).
For more details, see the extensive comments in the patch itself.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19430 57a11ea4-9604-0410-9ed3-97b8803252fd
Patch by "Bob":
The enclosed patch simply tests for a period in the file name,
if one exists it leaves it alone,
if not, it adds one plus a default extension.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19429 57a11ea4-9604-0410-9ed3-97b8803252fd
Patch by Alex Aycinena:
The 'default' stylesheet formats the balance sheet, cash flow, income statement
and transaction reports properly under webkit but not under gtkhtml.
The 'easy', 'footer', and 'technicolor' stylesheets are the reverse; that is,
they format the balance sheet, cash flow, income statement and transaction
reports properly under gtkhtml but not under webkit, except that the 'footer'
stylesheet also has some formatting problems with gtkhtml as well.
The attached patch file corrects these problems. Specifically:
- styles that are missing in the 'footer' stylesheet (compared to 'easy') are
added
- the function 'gnc-html-engine-supports-css' is used in the 'default', 'easy',
'footer' and 'technicolor' stylesheets to provide styles for either webkit or
gtkhtml
- the taxtxf.scm report file is simplified to take advantage of these changes
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19428 57a11ea4-9604-0410-9ed3-97b8803252fd
This term is used in the first dialog of "Ta_x Report Options".
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19427 57a11ea4-9604-0410-9ed3-97b8803252fd
(Should compile first, then commit, not the other way round.)
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19422 57a11ea4-9604-0410-9ed3-97b8803252fd
Patch by "Bob": I thought I would give this a try and come up with a patch to use the file save
as function after the after pressing the apply button. Not sure if it is the
best way but seems to work on my linux box and on windows without any errors.
I have changed the text in the account.glade file to reflect the firing of the
save as and also increased the size of the window to give more room for the
'Category Description' to stop scroll bars.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19377 57a11ea4-9604-0410-9ed3-97b8803252fd
The print checks operation should be able to print more than one check with a
single invocation of the "Print Check..." command. The attached patch does
this. If the active register is an account register, then the selected
transaction is printed (as before). If it is a search results register where
all the splits are from the same account, then it prints a check for each of
them. Anything else is an error.
Patch by Mike Alexander.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19370 57a11ea4-9604-0410-9ed3-97b8803252fd
It automatically download,
build, install and packaging the isocodes.
Currently, the patch will not make Windows build show the locale long
currencies name. But it make the isocode available on Windows. Since the long
currencies names are already shown on Linux, I think it should not far to make
it happen on Windows too, especially the isocode will be available after this
patch.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19369 57a11ea4-9604-0410-9ed3-97b8803252fd
The attached patch should fix the remaining outstanding issues of this bug.
Applying this patch now would break string freeze.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19366 57a11ea4-9604-0410-9ed3-97b8803252fd
Also, completely remove the business-core/sql module because it is
no longer needed. The tests of this module have been moved into
backend/dbi because they depend on sql+dbi, but not more than that.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19364 57a11ea4-9604-0410-9ed3-97b8803252fd
This should avoid accidentally loading .scm~ backup files etc. The code
matches the filenames against the regexp "\.scm$", so the previous hand-
written comparison against "." and ".." is no longer necessary as those don't
match that regexp anyway.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19309 57a11ea4-9604-0410-9ed3-97b8803252fd
There were some equivocalnesses between invoice and balance.
After using the strings from tax-invoice in the other invoice forms,
the de translations should switch back.
Patch by Frank H. Ellenberger.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19308 57a11ea4-9604-0410-9ed3-97b8803252fd
This re-indentation was done using astyle-1.24 using the following options:
astyle --indent=spaces=4 --brackets=break --pad-oper --pad-header --suffix=none
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19301 57a11ea4-9604-0410-9ed3-97b8803252fd
Same change as what r18841 added in business-core/xml.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19255 57a11ea4-9604-0410-9ed3-97b8803252fd
Will be activated once we're out of string freeze in order not to have
untranslated strings show up for the user.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19253 57a11ea4-9604-0410-9ed3-97b8803252fd
Patch by Frank H. Ellenberger.
Now in the tested (european) languages one can understand the meaning without
horizontal scrolling - search for MXV or UYI to see long examples.
I used glade 3, which created the file in a somewhat different way -
let me know, if that is a problem.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19225 57a11ea4-9604-0410-9ed3-97b8803252fd
Gnumatic Inc. does since a few years no longer exist.
So it makes no sense, to have it as copyright holder of new GnuCash
translations.
I got Linas OK for this change on IRC:
http://lists.gnucash.org/logs/2010/05/2010-05-28.html#T13:37:53 - #T16:12:23
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19224 57a11ea4-9604-0410-9ed3-97b8803252fd
I thought I would get access to the build server immediately to
perform the cleanup of the old tag file, but apparently the server is
unreachable for me for now, so I cannot commit this change today. Maybe later.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19164 57a11ea4-9604-0410-9ed3-97b8803252fd
In most cases, the changed strings already appear somewhere else in the program,
so only very few are unfortunately now new strings even though we hoped
we could stick to the string freeze.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19162 57a11ea4-9604-0410-9ed3-97b8803252fd
Apparently guile-1.6 needs this in more places than I thought at r19148.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19154 57a11ea4-9604-0410-9ed3-97b8803252fd
There are no more instances of (require ...), so Guile's slib support is
no longer needed.
Patch by Andy Wingo, but except report-system.scm because saved
reports still use the hash-for-each -- so we will need to
continue to support the symbol.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19148 57a11ea4-9604-0410-9ed3-97b8803252fd
Patch by Andy Wingo, but except report-system.scm.
There is nothing that the slib hash-table module provides that was used
in any of these files; they all used Guile's stock hash tables.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19147 57a11ea4-9604-0410-9ed3-97b8803252fd
Adjust in iso-4217-currencies.scm fullnames to conform with iso-codes-3.3
Patch by Frank H. Ellenberger.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19131 57a11ea4-9604-0410-9ed3-97b8803252fd
Finally, config.h will only be re-created if anything has changed, thus
reducing re-compiling to a minimum. This was done with instructions from
http://www.cmake.org/Wiki/CMake:How_To_Write_Platform_Checks ; however,
more of those checks (like CheckFunctionExists etc) don't work as easily as
CheckHeaderExists, so I left it at that.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19127 57a11ea4-9604-0410-9ed3-97b8803252fd
The .c file gets outdated easily because the makefile doesn't contain
enough of its dependencies. I would need to be regenerated each time any of the
included files was changed, but currently it doesn't contain these dependencies
in the makefile rules. Having it depending on config.h should
at least trigger the generation at each version number change (so
that the tarball contains an up-to-date version.)
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19124 57a11ea4-9604-0410-9ed3-97b8803252fd
Patch by Jeff Kletsky.
(Cstim: Accepted even though string freeze is in effect because it was
submitted before the freeze. Also, the string additions are very minor.)
Summary of Changes:
* Initial story related to providing default budget control
* Add a "Budgeting" tab to the book-level preferences dialog
* Add a "Default Budget" selector to the "Budgeting" tab
* Modify gnc_budget_get_default() to
* Respect the new KVP, if present
* Fall back to 2.2.x behavior, if not present
* Modify gnc:make-budget-option
* Reformatted for readability with additional comments
* Default is now "#f" so that selected value is always saved
Otherwise, if selection happened to be the current default
and the default was later changed, the report would change
* getter, setter, and generate-restore-form all now consistent
* setter now always takes a budget object
* generate-restore-form does not rely on "hack" in setter that
previously allowed either a budget object or a GUID string
This is a different fix for 603215 -- see Known Issues
* Provide translation support for "Trading Acccounts" (and "Budgeting")
* Refactor #define names for consistency and extensibility
* KVP_OPTION_PATH for consistency with Guile usage
* OPTION_SECTION_blahblah
* OPTION_NAME_blahblah
* Modify qofbookslots.h to be "SWIG-aware"
* Pick up qofbookslots.h in make-gnucash-potfiles.in and po/POTFILES.in
Known Issues:
* There is no selection (yet) for "Use default budget" so changing the
default budget and reloading a report does not change the budget used
* setter is no more robust to "bad" values than in previous code
* Budget reports created with 2.3.x after r18528 (between 2.3.8 and
2.3.9) may not load or re-render as they relied on the setter taking
either a budget object or a GUID as a string This should not impact
any 2.2.x users as nothing was saved under 2.2.x related to the
default budget. This can be resolved through removing the option
restore code in ~/.gnucash/saved-reports-2.4 and, if affected reports
were open, in ~/.gnucash/books/<name_of_book>
* Budget reports prior to r18528 did not save budget selection (603215)
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19123 57a11ea4-9604-0410-9ed3-97b8803252fd
Changes abs function to fabs in gnc-csv-model.c, to allow csv imports of values
less than $1.00.
Patch by James Raehl.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19122 57a11ea4-9604-0410-9ed3-97b8803252fd
Patch by Frank H. Ellenberger
1. improve the header of fieldnames with annotations
2. sort by ISO code, because
a. easier for non english people
b. most tables in the internet have this sort order.
So maintainance becomes easier.
3. inserting a Column local_symbol, because some people like to use it, e.g.
https://bugzilla.gnome.org/show_bug.cgi?id=492417#c3
But probably there is a better way to get this informations.
4. Review List:
a. adding: CDF, GHS, ...
b. outdated: AON->AOR->AOA, GWP->XOF, ...
c. Typos like "fening".
d. Alway use singular instead of a mixture.
5. add comments:
a. outdated currencies prepared as in the header shown.
b. for abbreviations.
Background is the thread starting with
https://lists.gnucash.org/pipermail/gnucash-devel/2009-October/026558.html
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19120 57a11ea4-9604-0410-9ed3-97b8803252fd
Remove generated file qofla-dir.h. This is actually good progress because
it gets rid of yet another compiled-in path, which are a nuisance and
need to be replaced by runtime path lookup everywhere, if needed.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19118 57a11ea4-9604-0410-9ed3-97b8803252fd
Patch by Andy Wingo.
* src/scm/main.scm (hash-fold): Only do the conditional hash-fold dance
if we don't have guile 2.0. (Definitions in expression context are
actually invalid Scheme, but older Guiles are more permissive.)
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19079 57a11ea4-9604-0410-9ed3-97b8803252fd
Patch by Andy Wingo.
Fix up a couple uses of scm_i_string_length, and add a back-compat shim
for earlier versions.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19078 57a11ea4-9604-0410-9ed3-97b8803252fd
This (tooltip) string is blatantly wrong, so we need to fix it regardless
of string freeze.
Spotted by Mark Haanen.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19069 57a11ea4-9604-0410-9ed3-97b8803252fd
These are allowed regardless of string freeze because the strings are already
in the program and are untranslated so far. So marking them for translation
will only improve the situation but not introduce new strings into the
program in general.
Spotted by Mark Haanen.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19068 57a11ea4-9604-0410-9ed3-97b8803252fd
So, the right thing is for each file to be in its own module. Barring
that it's tough to see what the environment is in a given module. So to
be safe, everywhere there's a printf, make sure the (gnucash printf)
module is duly included.
Patch by Andy Wingo.
Conflicts:
src/business/business-reports/easy-invoice.scm
src/business/business-reports/fancy-invoice.scm
src/business/business-reports/invoice.scm
src/business/business-reports/job-report.scm
src/report/standard-reports/budget-income-statement.scm
src/report/standard-reports/income-statement.scm
src/report/standard-reports/trial-balance.scm
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19067 57a11ea4-9604-0410-9ed3-97b8803252fd
This kind of error is detected "eagerly" in Guile 2.0.
Patch by Andy Wingo.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19066 57a11ea4-9604-0410-9ed3-97b8803252fd
src/engine/iso-currencies-to-c did the same simple-format dance that is
now unnecessary.
Patch by Andy Wingo.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19064 57a11ea4-9604-0410-9ed3-97b8803252fd
Guile 1.6 and up always provides simple-format, and defines it as a
restricted subset of the full format, so there's no harm in using the
construct's proper name.
Patch by Andy Wingo.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19063 57a11ea4-9604-0410-9ed3-97b8803252fd
There is a new module, (gnucash printf).
Patch by Andy Wingo.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19062 57a11ea4-9604-0410-9ed3-97b8803252fd
Christian Stimming