Commit Graph

3551 Commits

Author SHA1 Message Date
John Ralls
bbb4113a5a Bug 798156 - glib 2.68.0 breaks gnucash
Move all of the #include <glib> to before the extern "C" blocks
so that the include guards will protect against headers inside
the extern "C" block also including glib.h.
2021-04-20 11:03:23 -07:00
John Ralls
40e005d963 Bug 798133 - Gnucash crash when any custom action is entered
1. Protect strlen call in gnucash_sheet_modify_current_cell to
prevent it from crashing.

2. Handle NULL selection in gnc_item_list_key_event when key is
GDK_KEY_Return so that new string in combo control is handled
correctly.
2021-04-20 10:22:05 -07:00
Robert Fewell
cd355c20fc Bug 648335 - Add preference for 'Review Created Transactions'
Add a preference for the 'Review Created Transactions' setting in the
'Sinse Last Run' dialog so that the default can be specified.
2021-04-19 11:07:20 +01:00
Robert Fewell
2da78db5e4 Reformat schedule transaction source files for white space 2021-04-19 11:07:20 +01:00
Robert Fewell
c2a7b8eaaf Bug 753283 - Highlight missing when returning from schedule edit.
When you return from editing a scheduled transaction the highlight is
missing in the tree view. This is partly due to the model being
recreated when ever a change is made to a scheduled transaction. To
overcome this, the selected schedules are added to a GList which is
used in a new call back signal that has been added to indicate when the
model is populated. When this happens, the model is scanned for the
schedules that are in the GList so they can be reselected.
2021-04-19 11:07:20 +01:00
Robert Fewell
00bde6a32c Remove individual tool tips from radio button options 2021-04-18 12:17:51 +01:00
Robert Fewell
08f490ee98 Remove widget GncCombott - Part2
Remove tip entry for gnc:make-multichoice-option in SCM files and
change some of the multichoice items to that of the removed tip
2021-04-18 12:17:51 +01:00
Robert Fewell
e1525721ad Remove widget GncCombott - Part1
It has been decided that per menu item tooltips is not required so it
has been removed and replaced with GtkComboBox where required.
2021-04-18 12:17:51 +01:00
Frank H. Ellenberger
97c480cb08 I18N: Remove superflous newlines from online banking intro 2021-04-16 23:43:19 +02:00
Frank H. Ellenberger
8c29af5153 Bug 794877 - Intro text of "Online Banking Setup" is outdated 2021-04-16 21:18:38 +02:00
Frank H. Ellenberger
913c84b0a2 I18N: 1 Remove and 1 Improvement of text about Saved Settings 2021-04-16 20:05:50 +02:00
Frank H. Ellenberger
0d8f96ee7d I18N: Overwrite (one word) 2021-04-16 20:05:25 +02:00
Frank H. Ellenberger
26606c3b4e I18N: Explain $DISPLAY to translators 2021-04-16 20:05:10 +02:00
Frank H. Ellenberger
91d2bcdac9 I18N: Replace several wrong accent grave by apostroph 2021-04-16 20:04:55 +02:00
Frank H. Ellenberger
f12a134a26 I18N: Use a real sentence in the dup trans dialog tooltip 2021-04-16 20:04:26 +02:00
Robert Fewell
b1a8615d15 Bug 798159 - Keyboard shortcut bug to manage document link
The GtkFileChooserButton was grabbing focus on load but was not
responding to it, possibly due to it already been created but hidden so
change it to a normal button that starts a GtkFileChooserNative dialog.
Also stop grabbing focus on the use of the toggle buttons to aid
navigation by keyboard.
2021-04-16 11:17:51 +01:00
Christopher Lam
668986ce97 Merge branch 'sx-progress' into maint #965 2021-04-14 21:22:32 +08:00
Christopher Lam
57f14e488a [dialog-sx-editor]: Extract update_sensitivity
Refactors and centralises SX GtkWidget property sensitivities logic
into one function, with the following logic:

* SX properties are disabled if the SX enabledOpt is FALSE
* if autocreate then enable 'notify when autocreating'
2021-04-14 21:22:05 +08:00
Robert Fewell
4e653729ba ESC key was not working on load of Scheduled Transaction Editor
This is due to trying to grab focus on the sheet when it was not
realized so add a check for the sheet being realized before grabbing
focus on it.
2021-04-13 11:01:36 +01:00
Robert Fewell
b9789b66ca Fix an alignment of widgets in the schedule transaction editor 2021-04-13 10:48:14 +01:00
Robert Fewell
48ebc24d99 Bug 798151 - SLR does not scroll to entry
If a row requires an entry and is not visible when you press OK, the
entry is detached from the row and is confusing so scroll the tree view
to make the required row visible.
2021-04-13 10:42:30 +01:00
Christopher Lam
4a3473d991 [dialog-sx-editor] fix whitespace 2021-04-07 07:11:54 +08:00
Christopher Lam
d1e6163cd9 Remove dead code and unused strings 2021-04-05 21:19:17 +08:00
Christopher Lam
05b7c1492c [budget.scm] show correct tooltip for report option
Budget Report option 'Show notes' had used incorrect tooltip
2021-04-02 09:44:33 +08:00
Christopher Lam
22cb1f3567 Remove unused indentifiers 2021-04-02 09:37:14 +08:00
Christopher Lam
67e65d436c Remove duplicate definitions 2021-04-02 09:37:14 +08:00
Frank H. Ellenberger
4e8b0f8522 Partial rewording of the intro of csv-transaction-import 2021-03-31 23:10:20 +02:00
Christopher Lam
55ecaa9252 [report-core] fix error string 2021-03-30 18:08:21 +08:00
Christopher Lam
0a9f9821ca [report-core] Remove unused string definition 2021-03-30 18:08:21 +08:00
Frank H. Ellenberger
70ae113614 Remove a misleading comma in assistant-csv-export 2021-03-29 20:36:28 +02:00
Frank H. Ellenberger
a59fa375f5 Layout fix of assistant-csv-export
Also order start messages before finish messages for easier
understanding by translators
2021-03-29 18:12:04 +02:00
Christopher Lam
26286e2f6e [html-acct-table] Remove 'pre-adjusting balances option
'pre-adjusting was formerly handled in html-acct-table.scm; 1b41d517
removed this balance option due to being unused for nearly 20
years. No need to test it anymore.
2021-03-29 16:44:28 +08:00
Christopher Lam
114758190e Bugfix: export-code for category-barchart reports would fail.
This stems from trying to handle file-name when calling export code.

Export code no longer require file-name, The export-code returns a
string in the html-document object instead. Remove all file-name
handling in reports. No backward compatibility issues because most
users would not copy a GnuCash >=4.6 report code onto a <4.5
installation.
2021-03-29 16:41:47 +08:00
Christopher Lam
c91f0c81f8 [gnucash-cli] improve discoverability of export-type
Formerly, selecting --export-type EXT would dump the cryptic "Report
REPORTNAME has no export code". Modify to hint the user on acceptable
reports with export-code.
2021-03-29 16:34:08 +08:00
Christopher Lam
a108c5501d [html-acct-table] deprecate unused functions 2021-03-29 16:34:08 +08:00
Christopher Lam
4e38b685e2 [html-acct-table] remove dead code
The parameters account-less-p, column-header, account-name,
logical-depth, label-cols in html-table-add-account-balances are
unused in code.

The removal of the parameter handling will not cause crash in a custom
report.
2021-03-29 16:34:08 +08:00
Geert Janssens
5d1e4ceef9 i18n - fix several source string issues brought up by translators on weblate 2021-03-28 20:51:19 +02:00
Geert Janssens
a4cab54afc i18n - Reuse strings for less translation work 2021-03-28 20:51:19 +02:00
Geert Janssens
0b6b88b771 i18n - several minor tweaks to cope with translation issues in weblate 2021-03-28 20:51:18 +02:00
Geert Janssens
5a10279f22 i18n - Extract common parts of the long intro text to reduce translation effort 2021-03-28 20:49:59 +02:00
John Ralls
f3c2d1e145 Fix missing prototype error, void end of function error on Windows.
MinGW64 gcc silently ignores C prototype with no arguments, issuing
a missing prototype error instead. set_platform_locale must return
a free-able char* even if all of LC_ALL, LC_MESSAGES, and LANG are
unset.
2021-03-25 13:31:19 -07:00
John Ralls
db4417b212 Fix typo blocking Windows build. 2021-03-25 07:40:42 -07:00
Dries
7c323b222d Bug 798154 - Tooltips wrong when multiple charts in one report
with multiple chartjs on one page this fix will pick up the correct
data.
2021-03-24 06:41:10 +08:00
Geert Janssens
0c15dc175c Fix building based on unix makefiles
There are a few subtle differences between unix makefiles and ninja
that sometimes go uncaught as the core devs usually use ninja.
This commit fixes two:
- don't depend directly on files in other source/binary directories.
  Use a custom target to depend on instead
- recursively create target directories, as make doesn't automatically
2021-03-23 16:33:56 +01:00
Robert Fewell
48698395e2 Bug 797621 - Sometimes freeze on Invoice Sales Tax Table
If there are no entries in the list, the return height of
popup_get_height was 0 but when a confirmation check is made on true
height it returned 1 and so try and queue a resize and hence a loop so
in popup_get_height return 1 if list is empty.

Also to prevent this from happening entirely, disable the toggle button
when there are no entries in the list. The entry will still be active
so new list entries can be created as before.
2021-03-23 10:09:25 +00:00
Robert Fewell
03fa0ed611 Allow the context menu when GncCellRendererTextView is in edit mode. 2021-03-23 09:59:32 +00:00
Robert Fewell
8b79002a75 Bug 798147 - Accounts Page Notes entry crash
There were a couple of places that a value was being used after it had
been freed so they were fixed.
2021-03-23 09:59:09 +00:00
Geert Janssens
2eadfb9b41 Fix review comments for locale restructuring 2021-03-22 12:17:38 +01:00
Geert Janssens
6537135e70 Restructure early locale initialization
- Move Macos specific bits to its own source file. As this is objective-c use .mm extension
- Use common function signature for Macos and Windows init function and include via common header file
2021-03-22 12:10:55 +01:00
Christopher Lam
c6c5777cf2 gnc_invoice_window_print_invoice return NULL if invoice is NULL.
d6082e1a6 had triggered macOS's clang failures.
2021-03-20 23:00:38 +08:00