Commit Graph

19983 Commits

Author SHA1 Message Date
John Ralls
fa1b4c685f Add jenny to sources for combinatorics testing. 2018-07-16 14:08:24 -07:00
John Ralls
6f1c63dbda Merge Chris Lam's 'maint-stress-tests' into maint. 2018-07-16 12:52:01 -07:00
John Ralls
c444729db5 Bug 796755 - buggy window handling at startup
Defer showing the main window until after its size and location are
restored from the state file.
2018-07-16 10:09:34 -07:00
Christopher Lam
294e113fec Small typo fix
Fixes typo in a51be5157c
2018-07-16 18:51:37 +08:00
Christopher Lam
414ab99aa0 [test-stress-options] Set COMBINATORICS to full path to jenny
Setting COMBINATORICS to the full path name to jenny will enable
pairwise testing.

e.g. COMBINATORICS=/home/user/jenny/jenny ninja check
2018-07-16 18:51:37 +08:00
Christopher Lam
b8ce2b545a [stress-test] run tests on empty book and populated book
Refactor (tests) into call (create-test-data) which will add sample
txns in the environment.

As a result we can run tests twice - once before and once
after (create-test-data) which helps dislodge a few more report bugs.
2018-07-16 18:51:37 +08:00
Christopher Lam
aa4da810c1 [test-stress-options] introduce combinatorial testing
This is enabled if the environment variable COMBINATORICS exists.
I guess it can be run via:

COMBINATORICS=bla ninja check
2018-07-16 18:51:37 +08:00
Christopher Lam
dfe1f34573 [stress-test] stress test options! 2018-07-16 18:51:37 +08:00
Christopher Lam
694d0f0613 [budget-flow] fix report-title not defined
this report uses reportname instead
2018-07-16 18:18:25 +08:00
Christopher Lam
57c6f175b4 [html-chart] num-columns return 0 for empty-table
this commit fixes whereby data is '() indicating no columns
2018-07-16 18:18:25 +08:00
Christopher Lam
e2907844be [customer-summary] prevents crash on empty-book with no accounts 2018-07-16 18:18:25 +08:00
John Ralls
ff91056ab1 Resolve ubuntu 14.04 naming conflict. 2018-07-15 16:55:55 -07:00
John Ralls
a51be5157c Add preference for forcing prices to decimal display.
Anticipating that some users might prefer to see exact prices,
add a preference to General>Numbers to configure whether prices
are rounded to decimals or are displayed as exact fractions.
2018-07-15 14:18:01 -07:00
John Ralls
1fffbaf856 Bug 794755 - Commodity Register displays fractional prices
When printing numbers convert them to a new decimal denominator with
rounding if the passed-in print info specifies that they should be
forced and rounded.

Make the default price settings forced and rounded.

Pass the price currency to gnc_default_price_print_info and
use the currency's fraction * 100 to determine the round-to
denominator and the number of decimal places to display.
2018-07-15 13:20:21 -07:00
John Ralls
374477c360 Merge Bob Fewell's 'color-accounts' into maint. 2018-07-15 10:47:19 -07:00
Robert Fewell
8c4a5adb43 Align the Reconcile totals in the Reconcile Window.
This change aligns the totals with the account column by obtaining the
reconcile column width and adjusting the label padding. This is done at
initial display so it does not track column resizing or the use of the
scrollbar.
2018-07-15 10:45:45 -07:00
Robert Fewell
b95981e6af Bug 796751 - reconcile window usability - R column should be...
next to Amount.

With the use of the previous update the original order is possible as
the scrollbar is not hovering over the reconcile tick box
2018-07-15 10:44:23 -07:00
Robert Fewell
aa77b21dfb Reconcile vertical scrollbars hover over tree view data
In the reconcile window the vertical scrollbars when selected obscure
the tree view data so get the width of the scrollbar and add it to the
cell renderer x padding of the last column.
2018-07-15 10:44:17 -07:00
Robert Fewell
c513d78846 Remove white space and tabs from gnc-main-window.c 2018-07-15 10:44:16 -07:00
Robert Fewell
0199fef584 Add the toolbar preference changes to window-reconcile.
Fixes Bug 796739 - Toolbar buttons have no labels, part 3 of 3.
2018-07-15 10:43:44 -07:00
Robert Fewell
a75eb4c8ec Add toolbar preference changes to embedded-window.
Fixes Bug 796739 - Toolbar buttons have no labels, part 2 of 3.
2018-07-15 10:42:54 -07:00
Robert Fewell
3b09313107 Add preference to control toolbar appearance
Add preferences to select icon size and item layout on the toolbar.
Fixes Bug 796739 - Toolbar buttons have no labels, part 1 of 3.
2018-07-15 10:40:41 -07:00
Robert Fewell
3e37b87997 Bug 796669 - Dark Theme Text Colors Hard to Read
Only add the register-foreground class when using Gnucash built in
colours. When this setting not used, the foreground colour by default
will be what ever the theme has set and will be down to the user to
over ride along with the other register colours.
2018-07-15 10:39:50 -07:00
Robert Fewell
36dc2acd4a Remove some white space and replace tabs with spaces. 2018-07-15 16:45:41 +01:00
Robert Fewell
0e4898fe0a Add the ability to cascade account colours in account tree
Add the ability to select an account that has sub-accounts and use that
accounts colour on all sub accounts. By default only sub accounts that
do not have a colour set are updated but there is an option to over ride
 this.
2018-07-15 16:44:50 +01:00
John Ralls
43af50bd8a Bug 796759 - --add-price-quotes <sql file> leaves a lock on the file.
First, save isn't necessary if the book is dirty, so don't... but that
means that the book has to be marked dirty after a session swap. No more
laziness.

Second, regardless of the outcome of inner_main_add_price_quotes the
session must be destroyed to remove the lock.

A couple of cleanups in QofSessionImpl::save as well: Rewrote the
descriptive comment to reflect how it really works when the backend has
gotten disconnected and removed the superfluous qof_book_set_backend
with the backend that we'd *just gotten from the book*.
2018-07-14 17:09:22 -07:00
John Ralls
de927d535d Fix test-backend-dbi for Postgress and MySQL.
Pass MySQL database exists errors and skip creating the database
if it exists.
2018-07-13 16:34:42 -07:00
John Ralls
c2972c75d0 Fix missing prototype error. 2018-07-13 12:18:25 -07:00
John Ralls
9db7d89474 Bug 796756 - OFX import fails to recognize associated income accounts.
Because qof_instance_set and qof_instance_get were being called with the
KVP key instead of the property name.

Since we don't really want references to KVP outside of engine and since
the two functions are called exactly once each in qof-ofx-import.c move
them inside qof-ofx-import.c and get rid of gnc-ofx-kvp.[ch] as well as
fix the bug.
2018-07-13 11:46:50 -07:00
John Ralls
983c7ce0bc Bug 796579 - Cannot go forward with empty duplicates screen
Set the key name to (default-unspec-acct) for the case where both payee
and memo are blank so that it can be found, then
look for that key in the right hash, qif-memo-map, instead of looking for
cat (already known to be "") in the wrong hash, qif-cat-map.
2018-07-13 10:41:33 -07:00
John Ralls
756f444ac3 Update bug tracker URL
Change all instances of bugzilla.gnome.org to bugs.gnucash.org, reflecting
our migration to a self-hosted bug tracker.

Inform the Translation Project Coordinator at release that this affects
translatable strings and that all message catalogs have been updated.
2018-07-13 09:49:33 -07:00
John Ralls
e6ea84ba58 Fix missing leading dot in sheet specification. 2018-07-10 07:12:21 -07:00
Geert Janssens
38748f20fe Add favicons for wiki 2018-07-09 11:47:16 +02:00
David Osguthorpe
4d013e091c Bug 796737 - Patch to restore gncmod-python.c.
Restores the gncmod-python module.

It removes the need to link the module to libgncmod-app-utils.dylib or
libgncmod-core-utils.dylib. This was needed previously as the init
function for those modules was called in the c code. However, unless
there was python c code at some point in gncmod-python.c to use
functions in c of either core utils or app utils these are not needed.
Those module init functions would be called when the modules are
imported in eg init.py, which does indeed import _sw_app_utils
successfully.

I have made edits to init.py (and other files) so it loads without
errors with python 3. These edits are NOT tested. I dont actually use
pycons, I update the init.py to simply import my python subsystem init
module. I never set the if False: to if True: to actually activate the
console.
2018-07-07 13:33:22 -07:00
John Ralls
ad7c14a5df Partial merge of Chris Lam's maint-stress-tests into maint.
Merges he commits that aren't the stress-test.
2018-07-07 13:05:35 -07:00
Christopher Lam
582265d0c6 [job-report] Prevent Crash if there is no AR account
I think this crash is triggered because the 'account' variable
defaults to the first available AR account. If there's no AR account
it becomes null, and querying null's default book leads to segfault.

I guess I can fix segfault too by fixing gnc_account_get_book.
2018-07-07 12:58:13 -07:00
Christopher Lam
0594beb081 Bug 779888 - Find Transaction by Value will not always find a split when commodities change
This commit changes the "Shares" find-text to "Amount". Thus, a
transfer from USD for 100USD -> 80GBP will be found if "Amount=80" or
"Amount=100" are chosen. A search for "Value=80" will not find
it. Perhaps the "Value" search option should be removed?
2018-07-07 12:57:54 -07:00
Christopher Lam
5c8af37901 [tests] modify load-path to find the parent directory
Find the parent directory programmatically.
2018-07-07 12:57:13 -07:00
Christopher Lam
d12ee9a4fc [commodity-utilities] prevent crash if end-date is #f
crash happens when (I think) no valid splits found.
2018-07-07 12:56:54 -07:00
John Ralls
eb0256e3e7 Bug 796474 - Segmentation fault while setting up online banking
Allow only a single instance of the assistant.
2018-07-07 12:36:00 -07:00
Geert Janssens
9d5712ef09 Use same 'force' logic sequence for sqlite and other dbs 2018-07-06 22:32:01 +02:00
Geert Janssens
875781847a Bug 796724 - Can't overwrite gnucash DB on MariaDB 2018-07-06 22:30:15 +02:00
Geert Janssens
f067e8328e Allow saving to xml over an existing sqlite3 file and the other way around
A type check on the pre-existing file was preventing this. The type check however
only makes sense when opening files, not when overwriting.
2018-07-06 22:00:08 +02:00
Geert Janssens
49bd9c41c4 Rename confusing directory 2018-07-06 21:24:44 +02:00
Geert Janssens
9ab06bc9b3 Bug 789594 - Unable to overwrite sqlite3 database file 2018-07-05 22:41:56 +02:00
Geert Janssens
240c4bd2cf Whitespace cosmetics 2018-07-05 22:41:56 +02:00
Geert Janssens
04424b62b8 Add logo and favicon for gnucash bugzilla site
The logo is a blend of the gnucash tango icon with bugzilla's mascotte Buggie.
The favicon and assorted files has been generated from the logo via
https://realfavicongenerator.net
That site offers a more complete solution than just a simple favicon, when time
permits we may want to implement a more complete favicon handling on our websites
based on recommendations found there.
2018-07-05 22:41:56 +02:00
Geert Janssens
00ef7f3ab3 Guile 2: stop suppressing guile deprecated messages
All known deprecations have been dealt with and if new uses
of deprecated methods appear we want know this.
2018-07-05 14:25:38 +02:00
Geert Janssens
463b551db9 Bug 771667 - Different warnings when changing reconciled splits vs. splits linked to reconciled splits
This is the final bit that ensures a warning is only presented if a previous warning
didn't already include the change we're about to warn about.

This should prevent two warnings popping up when only one is sufficient. For example
when the user first edits a protection field the warning will notify the user all
reconciled splits will be unreconciled. If the user then continues to edit a
(previously) a protected split field before leaving the transaction, no extra warning
is needed.
2018-07-04 17:58:56 +02:00
Geert Janssens
3d4201f172 Adjust icon installation regex a bit more
This will only exclude apps and actions if they are directories.
2018-07-04 17:50:50 +02:00