IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-09-05 04:40:41 -05:00
Code Issues Packages Projects Releases Wiki Activity
28,810 Commits 1,018 Branches 579 Tags
a0a520db26c81516aebf8b7166526e2cbdab7404
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Guo Xiang Tan a0a520db26 Fix lint. 2018-07-19 17:55:40 +08:00
Guo Xiang Tan e47e33e162 Bump prettier to 1.13.7. 2018-07-19 17:52:18 +08:00
Guo Xiang Tan 4765507585 Remove code that is no longer required. 2018-07-19 16:56:53 +08:00
Guo Xiang Tan b165cfdfbe FIX: Raise a better error in SiteSettings::TypeSupervisor. 2018-07-19 16:41:00 +08:00
Guo Xiang Tan 9b18ee4bba Improve handling of file params in lograge. 2018-07-19 08:23:59 +08:00
Guo Xiang Tan 487ef9773f Better logging when optimizing image fails. 2018-07-18 14:11:23 +08:00
Guo Xiang Tan b068a8a771 Fix the build. 2018-07-18 14:03:27 +08:00
Guo Xiang Tan be71f9ff82 REFACTOR: Don't load entire AR object just to get a column. 2018-07-18 13:53:57 +08:00
Guo Xiang Tan 3874d40910 Prepare to drop EmailLog#topic_id. 2018-07-18 10:22:24 +08:00
Guo Xiang Tan 202b839208 Fix the build. 2018-07-17 17:20:57 +08:00
Guo Xiang Tan d839a42bf9 Skip imagemagick tests on Travis. 2018-07-17 17:11:05 +08:00
Guo Xiang Tan 3553375dd2 PERF: Store EmailLog#reply_key as uuid data type. 2018-07-17 17:05:42 +08:00
Guo Xiang Tan 1d74ccaaf8 Add compatibility for ImageMagick7. 2018-07-17 15:50:58 +08:00
Guo Xiang Tan fe230f29cd Update annotations. 2018-07-17 13:11:45 +08:00
Guo Xiang Tan a6e9f4f44b FIX: DROP NOT NULL instead of changing all the rows in the table. 
```
change_column :topic_views, :ip_address, :inet, null: true
```

translates to

```
"ALTER TABLE \"topic_views\" ALTER COLUMN \"ip_address\" TYPE inet"
```

which locks the whole table while the migration is taking place.
 2018-07-17 11:03:41 +08:00
Guo Xiang Tan 59e72b466a Add uniq_ip_or_user_id_topic_views index concurrently. 2018-07-16 23:45:38 +08:00
Guo Xiang Tan 6761f8ecbf PERF: Add missing index on user_id for user_second_factors table. 2018-07-16 14:21:07 +08:00
Guo Xiang Tan 214dac05de Update annotations. 2018-07-16 14:19:07 +08:00
Guo Xiang Tan 767395449f Make prettier happy. 2018-07-16 11:31:23 +08:00
Guo Xiang Tan 50e59fb9bd Fix the build. 2018-07-16 10:12:19 +08:00
Guo Xiang Tan b459a589ab FIX: jumpToPost no working on megatopics. 2018-07-13 16:16:39 +08:00
Guo Xiang Tan 9647a0a4bc Remove unnecessary complex method. 2018-07-13 15:34:28 +08:00
Guo Xiang Tan 711371e8c8 FIX: Select+below will ask server for post ids on megatopics. 2018-07-13 15:10:39 +08:00
Guo Xiang Tan c722b07057 FIX: /t/:topic_id/last route did not return any posts. 2018-07-13 14:26:10 +08:00
Guo Xiang Tan 409a30ce1c FIX: Selecting & moving posts not working on megatopics. 2018-07-13 11:16:43 +08:00
Guo Xiang Tan 18e281606a UX: Clicking admin menu does not hide select posts box. 2018-07-13 10:56:14 +08:00
Guo Xiang Tan 79ba418edd DEV: Don't join on a thread forever. 2018-07-12 15:46:07 +08:00
Guo Xiang Tan 7c8cd9cfdd Fix the build. 2018-07-12 14:11:42 +08:00
Guo Xiang Tan 258e9e35ca PERF: Make mega topics work without a stream. 
There are tradeoffs that we took here. For the complete
story see
https://meta.discourse.org/t/performance-improvements-on-long-topics/30187/27?u=tgxworld.
 2018-07-12 12:46:12 +08:00
Guo Xiang Tan bdf3da8f80 DEV: Raise an error if any test finishes with more than 1 busy AR connection. 2018-07-11 09:54:01 +08:00
Guo Xiang Tan a17f5052a3 FIX: ignored_columns was called twice. 2018-07-11 09:52:37 +08:00
Guo Xiang Tan 8f4cb1a742 UX: Timeline lookup on mega topics should use date of current post. 2018-07-10 16:43:20 +08:00
Guo Xiang Tan b4e1388f9b PERF: Drop support for gaps in mega topics. 
Based on our current implementation, there isn't a
practical way to determine the gaps of large topics
cheaply. We tried to load the gaps in chunks but felt
that the code becomes too complicated. Note that
megatopics are quite rare in the wild.
 2018-07-10 16:27:02 +08:00
Guo Xiang Tan 21f333654c REFACTOR: Reduce dependency on the post stream in TopicView. 
This will allow us to drop the post stream from the payload for
mega-topics. On smaller topics, the extra query is fast because
of an existing index.
 2018-07-10 15:53:00 +08:00
Guo Xiang Tan 0a28181c62 Fix the build take 2. 2018-07-10 11:27:03 +08:00
Guo Xiang Tan 4163f9e61e DEV: Better clean up for PostgreSQL failover test. 2018-07-10 09:53:25 +08:00
Guo Xiang Tan 5374a0e720 Fix the build. 2018-07-10 09:48:57 +08:00
Guo Xiang Tan 6d0732f7b4 Disable service worker on Apple devices for now. 
The service worker is not used for any features
on Apple devices and we've received multiple reports
of service workers causing problems.
 2018-07-09 11:34:16 +08:00
Guo Xiang Tan 0ab42e9185 Revert "DEV: Add param that allows service worker to be removed." 
This reverts commit cb12f462a2.
 2018-07-09 11:29:09 +08:00
Guo Xiang Tan cb12f462a2 DEV: Add param that allows service worker to be removed. 2018-07-09 11:24:06 +08:00
Guo Xiang Tan 72a3457379 Bump discourse_image_optim which uses a global timeout. 
Our previous solution has the timeout set at the worker level
which means the total timeout would be X timeout secs * N number of
workers.
 2018-07-09 10:30:18 +08:00
Guo Xiang Tan 9948f57a99 REFACTOR: Update test to assert for the right objects. 2018-07-09 09:54:14 +08:00
Guo Xiang Tan 59a2767de8 Ensure that we restore the site setting in posts:rebake rake task. 2018-07-06 16:22:54 +08:00
Guo Xiang Tan 875008522d FIX: Discourse.S3BaseUrl did not account for subfolder bucket names. 2018-07-06 15:53:57 +08:00
Guo Xiang Tan 73e30ff4c2 Revert "Rename s3 vars, change condition when displaying s3 uploads" 
The new variables do not reflect that they represent S3 settings.

This reverts commit 24dfa1b657.
 2018-07-06 15:53:57 +08:00
Guo Xiang Tan 7163bf9323 FIX: Upload.get_from_url not respective subfolder in s3 bucket names. 2018-07-06 11:37:11 +08:00
Guo Xiang Tan af5cd7e548 Unregister old service workers when Discourse.ServiceWorkerURL changes. 2018-07-05 14:57:32 +08:00
Guo Xiang Tan 0af159546a FIX: BackupRestore::Backuper#remove_tar_leftovers not cleaning up files. 
Wildcard is sanitized when passed to `system()`.
 2018-07-04 13:58:39 +08:00
Guo Xiang Tan 3d2f3ef8ae Update discourse_image_optim gem. 2018-07-03 15:22:54 +08:00
Guo Xiang Tan 969e79d7c6 PERF: Do not calculate gaps for TopicViewPostsSerializer. 
The client doesn't use the gaps results when loading new posts.
 2018-07-02 14:01:50 +08:00
Guo Xiang Tan f7322c05ad FIX: Avoid destroy_all in Jobs::CleanUpUploads. 
`destroy_all` loads all the relation into memory as once.

See https://github.com/rails/rails/issues/22510
 2018-07-02 12:44:36 +08:00
Guo Xiang Tan 4774cabb84 Update .eslintrc to support new ES6 globals. 2018-06-30 08:20:34 +08:00
Guo Xiang Tan d1c3eb6bfa FIX: Recovering a post does not insert it back into the stream correctly. 2018-06-29 11:41:44 +08:00
Guo Xiang Tan 252e5574cc FIX: Prevent ambigous column errors when joining TopicView queries. 2018-06-29 10:33:08 +08:00
Guo Xiang Tan b59c17d484 Update title site setting defaults for ja locale. 
https://meta.discourse.org/t/updating-title-when-using-japanese-characters-does-not-work/88718/7
 2018-06-28 23:23:00 +08:00
Guo Xiang Tan eb427f7cf4 PERF: Update TopicView#participant_count to use Topic#posts_count. 
Use the counter cache instead of hitting the DB and plucking
every single id.
 2018-06-27 17:18:47 +08:00
Guo Xiang Tan cfa7898c2d Rename TopicView#last_read_post_id to TopicView#filtered_post_id. 2018-06-27 12:33:57 +08:00
Guo Xiang Tan cb69888758 PERF: Don't pluck all the columns just to retrieve a single value. 2018-06-27 11:41:35 +08:00
Guo Xiang Tan 49ffc1eb61 Revert "PERF: Send down gaps as the relevant posts load instead of front loading." 
This reverts commit 4c3352528e.
 2018-06-26 12:54:14 +08:00
Guo Xiang Tan 4c3352528e PERF: Send down gaps as the relevant posts load instead of front loading. 2018-06-26 12:49:06 +08:00
Guo Xiang Tan 0b6a2e9d1f Remove force summary mode for megatopics for now. 
The logic is too hairy and we can't reliably determine
when to force summary mode. Work is underway to improve
perf for megatopics so this will not be required
eventually.
 2018-06-26 12:49:06 +08:00
Guo Xiang Tan 5100a62fc0 FIX: Megatopics forced into summary mode when loading posts. 2018-06-25 22:11:56 +08:00
Guo Xiang Tan d08b596e47 Remove unused function in post-stream.js.es6. 2018-06-25 17:23:34 +08:00
Guo Xiang Tan 50f14c6e61 Prefer update! -> update!. 2018-06-22 15:13:04 +08:00
Guo Xiang Tan 6597cc4cd0 Fix the build. 2018-06-22 13:42:43 +08:00
Guo Xiang Tan cb622ead43 Make prettier happy. 2018-06-22 11:37:43 +08:00
Guo Xiang Tan f69356e628 FIX: Users can't "show all posts" in forced summary topics. 2018-06-22 11:32:45 +08:00
Guo Xiang Tan bad6a5142c PERF: Don't include entire post stream when we're loading more posts. 2018-06-22 10:49:03 +08:00
Guo Xiang Tan 657c8a013a UX: Don't display an empty participants section. 2018-06-22 10:16:43 +08:00
Guo Xiang Tan 4c6a0a4046 UX: Don't display participants count if it is zero. 
This can happen for megatopics where we don't send
down the payload for participants count.
 2018-06-22 08:32:20 +08:00
Guo Xiang Tan 97d8cd820e No need to expire readonly mode key immediately. 2018-06-21 17:52:42 +08:00
Guo Xiang Tan 68388dfd25 Fix the build. 2018-06-21 15:57:59 +08:00
Guo Xiang Tan 71908cd634 Make prettier happy. 2018-06-21 15:37:24 +08:00
Guo Xiang Tan 9a7a079f4d Force summary mode when user enters at the top of megalodoon topics. 2018-06-21 15:18:52 +08:00
Guo Xiang Tan f7d22bad90 FEATURE: Forced summary mode for megalodon topics. 
This is mainly done for performance reasons and megalodon
topics are usually a byproduct of imports where site setting
limits are not respected.
 2018-06-21 14:00:20 +08:00
Guo Xiang Tan ac80360bea PERF: Help postgres make use of index in Post.summary. 2018-06-21 13:29:16 +08:00
Guo Xiang Tan 5cef4e281b PERF: Memoize TopicView#gaps results. 2018-06-21 12:37:24 +08:00
Guo Xiang Tan 6ddd214476 FIX: Post#summary returning posts from other topics. 2018-06-21 12:00:54 +08:00
Guo Xiang Tan c5cc582549 FIX: Participants may not be in topic maps's attributes. 2018-06-21 10:23:55 +08:00
Guo Xiang Tan c1972f8438 PERF: Add index_topic_id_percent_rank_on_posts. 
Speeds up the `Posts#summary` mode query for large topics.
 2018-06-21 09:49:15 +08:00
Guo Xiang Tan 0365806b93 FIX: Properly display error when post action fails to create. 2018-06-20 21:20:23 +08:00
Guo Xiang Tan bb959e85e6 Pin exifr to 1.2.5. 2018-06-20 17:27:46 +08:00
Guo Xiang Tan ff5fc3cb08 Use a fixed limit for mega topic posts count. 2018-06-20 16:58:52 +08:00
Guo Xiang Tan 9c925a66ff PERF: Don't display days ago on timeline for megatopics. 
Analysis using `pg_stat_statements` showed this query
to be eating up a significant portion of CPU.
 2018-06-20 16:25:54 +08:00
Guo Xiang Tan 76707eec1b Update rails_multisite. 2018-06-20 15:11:41 +08:00
Guo Xiang Tan 806f0ca19d FIX: URL with params for svg images should not be light boxed. 2018-06-20 10:47:14 +08:00
Guo Xiang Tan 7eff64773c Revert "FIX: Don't clear active connections in defer queue." 
This reverts commit c9feadf9ec.
 2018-06-19 17:58:21 +08:00
Guo Xiang Tan df24c51c6f Revert "FIX: Don't try to dequeue an empty queue." 
This reverts commit 1af7d4a894.
 2018-06-19 15:49:45 +08:00
Guo Xiang Tan 41c1e1b302 FIX: Discourse.keep_readonly_mode does not work for multisite. 2018-06-19 15:44:08 +08:00
Guo Xiang Tan 1af7d4a894 FIX: Don't try to dequeue an empty queue. 2018-06-19 15:25:44 +08:00
Guo Xiang Tan c9feadf9ec FIX: Don't clear active connections in defer queue. 2018-06-19 12:45:16 +08:00
Guo Xiang Tan 34e4c8f573 FIX: Discourse.keep_readonly_mode spins a new thread each time it is called. 2018-06-19 10:24:08 +08:00
Guo Xiang Tan 6e97242bb9 Monkey patch in https://github.com/ruby/ruby/commit/7830a950efa6d312e7c662beabaa0f8d7b4e0a23 2018-06-19 09:45:48 +08:00
Guo Xiang Tan 630b4570ef Add specs for RateLimiter::LimitExceeded#description. 2018-06-19 07:48:03 +08:00
Guo Xiang Tan c18b86d9b2 UX: Don't add light box for SVG images. 2018-06-18 17:11:06 +08:00
Guo Xiang Tan c34100d1e7 Remove unused variable. 2018-06-15 07:45:51 +08:00
Guo Xiang Tan 139d0813b4 Re-enable fast_pluck freedom patch. 2018-06-13 09:25:23 +08:00
Guo Xiang Tan 7c173265d5 FIX: Don't clear connections on the same process. 2018-06-12 13:06:25 +08:00
Guo Xiang Tan 646ed87aba Clear all connections once master recovers. 2018-06-12 12:13:59 +08:00
Guo Xiang Tan c06824e9c2 FIX: Clients get stucked in readonly mode if messageBus fails. 2018-06-12 12:02:37 +08:00