Sam Saffron
e90af4f2de
FEATURE: Update omniauth twitter as prep for Ruby 2.4 support
2017-01-14 20:10:09 -05:00
Sam Saffron
920050c3ec
remove conditional support for ruby 2.0
2016-12-29 16:32:23 +11:00
Sam Saffron
65c40feb32
upgrade libv8 so it installs better on mac
2016-12-29 16:29:37 +11:00
Sam
3cb0ad7858
Merge pull request #4623 from maclover7/jm-rm-rails-observers
...
Don't try and update rails-observers
2016-12-28 17:51:01 +11:00
Sam
d28d8a1f85
FIX: order by op_likes leads to broken browsing
2016-12-27 19:08:54 +11:00
Sam
4bc57f3686
update memory profiler
2016-12-23 12:58:44 +11:00
Sam
c531f4ded5
remove rails-observers
...
Rails yanked out observers many many years ago, instead the functionality
was yanked out to a gem that is very lightly maintained.
For example: if we want to upgrade to rails 5 there is no published gem
Internally the usage of observers had quite a few problem.
The series of refactors renamed a bunch of classes to give us more clarity
and removed some magic.
2016-12-22 16:46:53 +11:00
Sam
019f1a1d06
UserEmailObserver is now removed
...
no big surprises here was pretty straightforward
after_commit semantics sure are weird though
2016-12-22 16:46:53 +11:00
Sam
2f6a4cc6de
remove UserActionObserver, replace with after_save and service
...
interestingly there was some left over dead code from when stars
existed in the topic_users table
2016-12-22 16:46:53 +11:00
Sam
0a78ae739d
Remove SearchObserver, aim is to remove all observers
...
rails-observers gem is mostly unmaintained and is a pain to carry forward
new implementation contains significantly less magic as a bonus
2016-12-22 13:13:14 +11:00
Sam
ea9f7a41af
remove gctools (no longer used) add gctracer for debugging
2016-12-20 15:07:30 +11:00
Sam
6965079108
Merge pull request #4606 from mabras/fix_arabic_pluralization
...
Fix Arabic Pluralization Rules for Client
2016-12-20 09:17:59 +11:00
Sam
2b808ad9da
Merge pull request #4609 from joebuhlig/category-topics-wiki
...
FEATURE: Category setting to make all topics wikis
2016-12-20 09:15:51 +11:00
Sam
e0ff57ca75
SECURITY: prevent reuse of password reset
2016-12-19 18:00:22 +11:00
Sam
eb2db23b40
FEATURE: remove email_token_grace_period_hours
...
The site setting email_token_grace_period_hours just causes confusion and
should not be used anyway.
Out of the box, tokens stop working once confirmed, no need to add complexity here
2016-12-19 17:15:20 +11:00
Sam
7918d99a2e
SECURITY: update onebox gem
2016-12-19 13:17:51 +11:00
Sam
dd383300b1
FEATURE: rate limit by login on password reset
2016-12-19 11:03:07 +11:00
Sam
0599bd0154
FEATURE: add referrer never tag to password reset page
2016-12-19 11:01:58 +11:00
Sam
15b5fddd49
SECURITY: protect upload params, only allow very strict filenames
2016-12-19 10:16:18 +11:00
Sam
30e0154e5d
SECURITY: fix reflected XSS with safe_mode param
...
(only applies to beta and master)
2016-12-19 10:11:51 +11:00
Sam
d4a0508744
FEATURE: outlet prior to Reply button at the bottom of topics
2016-12-16 17:10:32 +11:00
Sam
61eb134181
FEATURE: setting to allow arbitrary redirects from sso origin
...
if sso_allows_all_return_paths is set to true you can redirect off-site from sso success
2016-12-16 13:37:44 +11:00
Sam
6ff309aa80
SECURITY: don't grant same privileges to user_api and api access
...
User API is no longer gets bypasses that standard API gets.
Only bypasses are CSRF and XHR requirements.
2016-12-16 12:05:43 +11:00
Sam
162413862c
FEATURE: add staff class to HTML body for staff
2016-12-15 16:23:03 +11:00
Sam
98f4a2adcb
FIX: on 404 from brotli asset path return a correctly encoded doc
...
old implementation would cache the 404 for 1 year with incorrect encoding
hilarity would ensue
2016-12-15 16:05:20 +11:00
Sam
f867af6bf9
bye bye byebug
2016-12-15 15:52:25 +11:00
Sam
b650a45b37
tweak perf of rake and rails
2016-12-13 14:51:07 +11:00
Sam
4faec8af96
add some extra helper scripts
2016-12-13 09:24:31 +11:00
Sam
97e2a614c8
add wrappers for mailcatcher and sidekiq
...
add symlink to simplify invoking docker commands `d/rake`
2016-12-13 09:05:45 +11:00
Sam
107a21c069
update readme for docker dev
2016-12-12 18:00:25 +11:00
Sam
4b0f013edf
migrate test as well
2016-12-12 17:47:24 +11:00
Sam
1cbb8dc9b7
improve dev process
2016-12-12 17:39:20 +11:00
Sam
846597f563
FIX: staff tags are stripped by non-staff
2016-12-09 17:24:26 +11:00
Sam
02b21a26dd
Merge pull request #4585 from ibnesayeed/urdu-support
...
Add initial Urdu support with RTL direction
2016-12-09 13:01:25 +11:00
Sam
861a91d48a
correct styling for tracking button on mobile
2016-12-09 12:20:33 +11:00
Sam Saffron
b4cafc5e78
UX: add notification level button to mobile
2016-12-08 17:47:57 +11:00
Sam
badfda223c
FEATURE: add outlet for user stats in summary
2016-12-06 17:26:02 +11:00
Sam
1135e00c83
FIX: regression unable to dismiss unread
2016-12-06 08:49:40 +11:00
Sam
dab48b7c17
correct regression
2016-12-05 17:40:47 +11:00
Sam
3e099ab2b1
PERF: avoid query on every logged on page load
2016-12-05 17:38:02 +11:00
Sam
c2a17826e7
ship highest staff post number to staff
2016-12-05 17:22:25 +11:00
Sam
dc66f6681a
add spec for brotli controller, ensure cached correctly
2016-12-05 16:08:36 +11:00
Sam
8a98d617df
correct headers and add better caching
2016-12-05 15:11:07 +11:00
Sam
96183dbf6b
remove unused site setting, not really needed any more
2016-12-05 13:57:35 +11:00
Sam
39a524aac8
FEATURE: brotli cdn bypass for assets
...
Allow CDNS that strip out brotli encoding to use brotli regardless
2016-12-05 13:57:09 +11:00
Sam
bd217bb440
remove ux regression
2016-12-05 12:21:07 +11:00
Sam
1db9d17756
Make removal of topic columns more resilient to deploys
2016-12-05 12:11:46 +11:00
Sam
33d0a23d84
Merge branch 'fix_whisper'
2016-12-05 10:01:03 +11:00
Sam
d5f4f2f5c1
regression composing topics on desktop
...
caught by smoke test
2016-12-02 18:20:23 +11:00
Sam
f57feb2a4b
regression composing topics on desktop
...
caught by smoke test
2016-12-02 18:19:39 +11:00
Sam
9a685c64ee
UX: have webkit safari mobile stop with inner shadows
...
http://stackoverflow.com/questions/3062968/remove-textarea-inner-shadow-on-mobile-safari-iphone
2016-12-02 17:56:37 +11:00
Sam
2793e7bebc
UX: have webkit safari mobile stop with inner shadows
...
http://stackoverflow.com/questions/3062968/remove-textarea-inner-shadow-on-mobile-safari-iphone
2016-12-02 17:56:01 +11:00
Sam
9b885c039a
Merge branch 'master' into fix_whisper
2016-12-02 17:44:05 +11:00
Sam
7b5b255168
UX: improve topic composition on mobile
...
- tighten up space used for composer body
- stop collapsing and expanding so much
2016-12-02 17:43:18 +11:00
Sam
2a19e8f239
UX: improve topic composition on mobile
...
- tighten up space used for composer body
- stop collapsing and expanding so much
2016-12-02 17:42:27 +11:00
Sam
c04d4171ff
FIX: whisper no longer experimental
...
- Regular users are not notified of whispers
- Regular users no longer have "stuck" topics in unread
- Additional tracking for staff highest post number
- Remove a bunch of unused columns in topics table
2016-12-02 17:03:31 +11:00
Sam
612ff9fea4
Merge pull request #4579 from cpradio/discourse-tag-color-override
...
UX: Remove !important from header .discourse-tag
2016-12-01 11:12:28 +11:00
Sam
b8dc58be90
got to be careful with integrity specs
2016-11-29 18:01:09 +11:00
Sam
266322ce2e
FEATURE: add help text for no bookmarks in user page
2016-11-29 17:56:00 +11:00
Sam
1939104d46
Add mapping for Discourse solved
...
This basically reserved user action 15 for Discourse solved.
2016-11-29 16:17:32 +11:00
Sam
26db5d4c11
FIX: correctly specify outlet adds LI
2016-11-29 16:17:32 +11:00
Sam
0631a84ca0
Merge pull request #4576 from cpradio/min-posts-search
...
FEATURE: Add min_post_count search filter
2016-11-29 10:19:33 +11:00
Sam
add831dbc1
clamp excerpt at 8 lines to avoid cut off
2016-11-28 11:35:32 +11:00
Sam
ed16589b12
correct off by 1
2016-11-25 13:18:56 +11:00
Sam
881eb373c5
improve performance of backfill avoid queuing more than 1 backfill call
2016-11-25 12:33:10 +11:00
Sam
3bec128f5f
DEV: add warning if force_https in dev
2016-11-25 11:35:29 +11:00
Sam
bc6ee85850
FIX: stop caching locale cause it bleeds in multisite
2016-11-25 11:35:29 +11:00
Sam
88a46be051
FEATURE: display text excerpts when scrolling on mobile
2016-11-25 11:35:29 +11:00
Sam
bfd0418f07
added a test for safe mode
2016-11-23 13:31:05 +11:00
Sam
e2c87da42a
FEATURE: Add basic support for Safe Mode
...
In Safe Mode all JS extensions and site customizations are disabled.
To access Safe Mode visit `sitename.org/safe-mode`
2016-11-21 16:46:14 +11:00
Sam
63d9d4f301
FIX: properly specify default on no cache on all resources
2016-11-15 17:00:44 +11:00
Sam
095767bdb4
tweak position and style of registrations disclaimer
2016-11-15 13:41:43 +11:00
Sam
7d531910a4
fix tests
2016-11-15 13:30:03 +11:00
Sam
a07148830e
FEATURE: add TOS and Privacy links to sign up
2016-11-15 13:29:54 +11:00
Sam
f4c754b389
FEATURE: split JavaScript application bundle, so plugins live in own file
...
This adds plugin.js and plugin_third_party.js files
2016-11-15 11:43:13 +11:00
Sam
115c454002
FIX: if prioritizing names in ux choose name over username in email
2016-11-14 11:09:24 +11:00
Sam
3d76ce1421
FEATURE: SSO support for adding and removing a user to groups
...
Use: add_groups with a comma delimited list to ensure a user is in groups (using group names)
Use: remove_groups with a comma delimited list to ensure a user is removed from groups (using group names)
2016-11-11 16:57:31 +11:00
Sam
ac2c035856
FIX: stop raising exceptions when a post goes missing
2016-11-08 14:51:56 +11:00
Sam
a1a7094604
Merge pull request #4539 from tgxworld/use_a_time_task_for_redis_failover
...
PERF: Spawn a seperate timer task to check if Redis master is up.
2016-11-08 11:18:54 +11:00
Sam
2ddabc3928
FIX: protect against future regressions of google omniauth
2016-11-07 12:48:00 +11:00
Sam
6a720b6011
Merge pull request #4538 from kgish/master
...
A new guard for changing post timestamps
2016-11-07 11:28:47 +11:00
Sam
a5bf3b88a7
FIX: mini_racer will no longer Dispose forked isolates
2016-11-02 22:20:29 +11:00
Sam
383b57a350
improve test
2016-11-02 22:19:16 +11:00
Sam
c995fd65be
fix oops
2016-11-02 17:00:24 +11:00
Sam
920264349d
UX: title links to first post on expanded timeline
2016-11-02 15:12:13 +11:00
Sam
7e43e73df6
FIX: properly reset all contexts after forking
...
Fixes hang on backup
2016-11-02 13:34:20 +11:00
Sam
584dc63d13
UX: align timeline to the right in mobile and add jump to button
2016-10-31 12:40:40 +11:00
Sam
497ff76a67
make sure 1 is a string
2016-10-27 18:08:01 +11:00
Sam
3e7190866a
make code a bit safer
2016-10-27 16:50:56 +11:00
Sam
8a477f1857
FEATURE: added X-Discourse-TrackView header
...
This header is set to 1 if the particular request is a tracked page view
2016-10-27 16:48:27 +11:00
Sam
9848e26190
FIX: force secure cookies on session if force https is enabled
2016-10-27 15:15:58 +11:00
Sam
55e33414bb
update mini_racer to latest version
2016-10-25 13:21:02 +11:00
Sam
9a94d1b212
FIX: everyone is not a visible group
2016-10-24 13:03:22 +11:00
Sam
f083994f5a
FIX: exact group match always should be added
2016-10-24 12:43:38 +11:00
Sam
35d248ab0d
FIX: if badge has an image do not override icon
2016-10-21 10:54:16 +11:00
Sam
d13cd3471f
Merge pull request #4504 from Dax74/patch-1
...
Create client.it.yml for details plugin
2016-10-21 10:41:37 +11:00
Sam
bfa33f2518
Merge pull request #4500 from tgxworld/performance_on_users_page
...
PERF: Remove ordering by username.
2016-10-21 10:40:58 +11:00
Sam
81197ec403
Merge pull request #4483 from bekicot/update-development-osx-native
...
Update DEVELOPMENT-OSX-NATIVE.MD
2016-10-21 10:37:20 +11:00
Sam
9457b03da1
UX: make it easier to collapse the timeline from fullscreen
2016-10-20 10:14:53 +11:00
Sam
674264726d
FIX: should not be allowed to see users list of people who started a PM
2016-10-19 17:36:35 +11:00