Commit Graph

96 Commits

Author SHA1 Message Date
Nick Richmond
7ec93edec1
ExploreMetrics: Adjust wording to improve clarity (#88319)
refactor: change wording add clarity
2024-05-30 16:00:57 -04:00
Darren Janeczek
763108ce10
datatrails: in Components, model.useState(), instead of model.state (#88432)
fix: in Components, `model.useState()`, instead of `model.state`

Generally, it is better practice. More succinct.
It could also eliminate subtle state bugs.
2024-05-29 10:29:57 -04:00
Darren Janeczek
80a0de511f
data trails: alternate legend display for missing label value (#88153)
* fix: alternate legend display for missing label value

* Update public/app/features/trails/ActionTabs/BreakdownScene.tsx

Co-authored-by: Nick Richmond <5732000+NWRichmond@users.noreply.github.com>

* Update public/app/features/trails/ActionTabs/BreakdownScene.tsx

Co-authored-by: Nick Richmond <5732000+NWRichmond@users.noreply.github.com>

---------

Co-authored-by: Nick Richmond <5732000+NWRichmond@users.noreply.github.com>
2024-05-24 15:41:20 -04:00
Darren Janeczek
a7d304a871
datatrails: on histogram breakdowns, show label value in legend (#88154)
fix: on histogram breakdowns, show label value in legend
2024-05-24 15:41:00 -04:00
Darren Janeczek
5c29052219
datatrails: refactor: move related code to trails/MetricSelect subdir (#88262)
refactor: move related code to trails/MetricSelect subdir
2024-05-24 13:45:21 -04:00
Darren Janeczek
e9b932c8f6
datatrails: reloaded trail bugs related to no selected metric (#87344)
* fix: reloaded scene first step topScene

The top scene was not being initialized
when reloading trails, causing it to use
the top scene of whatever was selected
previously.

* fix: select new metric node not reloading right

On reloading trails, any metric node that
was 'green' with a undefined metric due to
clicking on the "select new metric" button,
was reloading with the metric of the step
directly before it (in index order).
2024-05-03 21:29:54 +03:00
Darren Janeczek
f93c330b66
datatrails: only fetch metrics metadata when using the language provider, avoid redundant fetch of metric names (#87067)
* fix: only fetch metrics metadata, not metric names
2024-05-03 12:24:18 -04:00
Darren Janeczek
6524febbd4
datatrails: quick bugfix: handle undefined step (#87337)
fix: handle undefined step
2024-05-03 19:22:23 +03:00
Darren Janeczek
046eedaa4c
datatrails: recently loaded trails modify parent variables when making new steps (#87284)
* fix: loaded trails modified parent var on new step

This ensures that recently loaded trails won't have variable changes
which create new steps modify the previous step.
2024-05-03 11:38:47 -04:00
ismail simsek
9fbca6c035
Datatrails: Fix overflow of labels (#87301)
Fix overflow of labels
2024-05-03 09:26:30 -04:00
Darren Janeczek
b1d98939e1
datatrails: include step index and number of steps when reporting trail step navigation usage (#87068)
* fix: include step index and number of steps
2024-05-02 09:55:58 -04:00
Darren Janeczek
9af4607e78
datatrails: fix bookmark/recent trail detection, prevent duplications, save trail on browser close/reload (#85677)
* fix: persistence trail detection, save on unload

- fixes detection on bookmarks and recents when current step isn't final
- now save current trail on browser close or reload (unload)
- refresh page or return to URL that corresponds to a recent trail will
   resume that trail instead of creating a duplicate recent trail
- do not create a recent trail out of an empty starting trail

* fix: bookmarks status after making new step

- clone bookmark trail state to prevent it from being changed by user
- re-evaluate bookmark status after creating new step
2024-04-26 11:35:38 -04:00
Darren Janeczek
53ead9904d
datatrails: interpolate adhoc variables and datasource variables when opening "explore metrics" from dashboard panels (#86252)
* fix: interpolate "explore metrics" from panels

---------

Co-authored-by: Darren Janeczek <darren.janeczek@grafana.com>

* fix: remove support for legacy dashboard

- simplify code
- take advantage of scenes dashboard async and datasource api object

---------

Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
2024-04-24 12:05:48 -04:00
Torkel Ödegaard
c965c27994
DataTrails: Exploring alternatives to history issues (#86843)
* DataTrails: Exploring alternatives to history issues

* incorporated unit tests from #86817 and #86741

---------

Co-authored-by: Darren Janeczek <darren.janeczek@grafana.com>
2024-04-24 10:36:58 -04:00
Darren Janeczek
2ed7eecf2d
fix: datatrail link to "open in explore" prefix with config.appSubUrl (#86375)
* fix: datatrail link to explore needs appSubUrl
* fix: use `appUrl` when creating URL for sharing
2024-04-17 16:40:40 +02:00
TechVest
1ffe858e06
chore: remove repetitive words (#86412)
Signed-off-by: TechVest <techdashen@qq.com>
2024-04-17 13:08:00 +01:00
Darren Janeczek
ea90f0119c
datatrails: track user interactions (#85909)
* chore: add interaction tracking
2024-04-16 15:55:07 -04:00
Brendan O'Handley
f85470d652
Prometheus: Use the frontend package in Prometheus and remove feature toggle (#86080)
* add history links for monaco completion provider folder

* add history links for monaco query field folder

* add history links for components folder

* add history links for configuration folder

* add history links for dashboard json folder

* add history links for gcopypaste folder

* add history link for variableMigration

* add history link for querybuilder/components/metrics-modal folder

* add history link for querybuilder/components/promqail folder

* add history links for querybuilder/components folder

* add history links for querybuilder/hooks folder

* add history links for querybuilder/shared folder

* add history links for querybuilder folder

* add history links for querycache folder

* add history links for src folder

* use frontend package and custom auth in module.ts

* remove files and fix import issues

* remove usePrometheusFrontendPackage

* remove extra files

* update betterer

* remove extra files after rebase

* fix betterer for rebase

* fix e2e flakiness
2024-04-15 16:45:23 -05:00
Darren Janeczek
34875344ed
datatrails: fix: clear undefined query params on history step change (#85607)
* fix: clear undefined query params on history step change

* Minor tweak

* fix: resolve CodeQL check: Client-side cross-site scripting

---------

Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
2024-04-11 09:52:33 -04:00
Darren Janeczek
2e1e45bbb1
datatrails: ensure breakdown yaxis sync is maintained when layout changes (#85380)
fix: ensure breakdown yaxis sync is maintained when layout changes
2024-04-10 17:12:33 -04:00
Sergej-Vlasov
79631bdd15
DashboardScene: prevent panel hovel header crop with scenes (#85869)
* add behaviour that adjusts hoverHeaderOffset

* clean up behaviour logic

* optimise and extract behaviour to separate file

* fix hoverHeaderOffsetBehavior unsubscribe

* update to latest scenes version

* Fix PanelOptionsTest

* fix: test value for adhoc filter url param

* Fix transformation tab tests

* bump scenes version

* Revert "Fix transformation tab tests"

This reverts commit 3ec9f5b226.

---------

Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com>
Co-authored-by: Darren Janeczek <darren.janeczek@grafana.com>
Co-authored-by: oscarkilhed <oscar.kilhed@grafana.com>
2024-04-10 20:39:43 +03:00
Sergej-Vlasov
33b6f45a9e
Revert "DashboardScene: prevent panel hovel header crop with scenes" (#85865)
Revert "DashboardScene: prevent panel hovel header crop with scenes (#85780)"

This reverts commit 23f1732855.
2024-04-10 16:27:53 +03:00
Sergej-Vlasov
23f1732855
DashboardScene: prevent panel hovel header crop with scenes (#85780)
* add behaviour that adjusts hoverHeaderOffset

* clean up behaviour logic

* optimise and extract behaviour to separate file

* fix hoverHeaderOffsetBehavior unsubscribe

* update to latest scenes version

* Fix PanelOptionsTest

* fix: test value for adhoc filter url param

* Fix transformation tab tests

---------

Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com>
Co-authored-by: Darren Janeczek <darren.janeczek@grafana.com>
Co-authored-by: oscarkilhed <oscar.kilhed@grafana.com>
2024-04-10 15:39:51 +03:00
Torkel Ödegaard
4f290ebf99
DataTrails: Do not create a new VizPanel every activation (#85693) 2024-04-09 08:39:26 +02:00
Darren Janeczek
18f3c7188b
datatrails: handle "single" layout when switching to "all" labels (#85373)
* fix: handle "single" layout when switching to "all" labels
2024-03-28 18:13:43 +02:00
Darren Janeczek
137061d1d5
datatrails: fix stability issues between conflict between browser history, URL sync, and trail history (#85134)
* fix: conflict between browser history and trail history

- ensure the back button or url changes don't generate trail steps
- ensure label breakdown TextLinks which appear on the summary tab work in embedded mode
2024-03-28 09:59:16 -04:00
Darren Janeczek
f850b00a92
datatrails: avoid double scrollbar with new viz tooltips (#85197)
fix: avoid double scrollbar
2024-03-27 12:50:02 -04:00
Darren Janeczek
2ecc1bb646
datatrails: hide "add to filter" button when there is no label value to add to filter (#85270)
fix: hide add to filters button when it won't work
2024-03-27 16:33:21 +02:00
Torkel Ödegaard
d039a0a485
DataTrails: Fixes home page background issue to make Cards work better (#85055)
* DataTrails: Fixes home page background issue to make Cards work better

* Update DataTrailsHome.tsx
2024-03-26 10:39:56 +01:00
Darren Janeczek
5d477d711a
datatrails: do not show the "le" label (#85114)
fix: do not show the "le" label
2024-03-26 09:00:25 +01:00
Darren Janeczek
2e06677240
datatrails: throttle the resetting of yaxis (#85117)
fix: throttle the resetting of yaxis
2024-03-25 19:33:57 -04:00
Darren Janeczek
7c03cc83c6
Datatrails: hide empty breakdown panels, improve loading status (#85028)
feat: hide empty breakdown panels, improve loading status
2024-03-25 18:56:03 -04:00
Darren Janeczek
810c224039
datatrails: synchronize the range of the y axis for all breakdown panels (#84781)
feat: sync the yaxis of breakdown panels
2024-03-22 16:19:11 -04:00
Darren Janeczek
08c24e4133
datatrails: feat: metadata for metric panels (#84872)
* feat: metadata for metric panels

* fix: missing import?

* fix: async await to get description first

- also add description to metric-name-only panels

* fix: change description, remove from main viz

* fix: remove import
2024-03-22 10:05:20 -04:00
Darren Janeczek
a2795f1291
datatrails: fix: only show datatrails link for timeseries dashboard panels (#84942)
fix: only show datatrails link for timeseries dashboard panels
2024-03-22 10:05:03 -04:00
Andre Pereira
93ca49b785
Explore Metrics: Show toast when bookmarking (#84987)
* Show toast notification when bookmarking a trail

* Copy change

* Move to LinkButton

* Secondary solid button
2024-03-22 15:33:50 +02:00
Andre Pereira
0b4c81158e
Datatrails: Sync layout with URL values (#84865)
* Sync layout with URL values

* Refactor
2024-03-22 12:27:19 +00:00
Darren Janeczek
1eff5fb791
datatrails: lazy load the breakdown queries, reduce panels, reduce number of points (#84965)
fix: lazy load the breakdown queries, reduce panels
2024-03-22 08:26:35 -04:00
Darren Janeczek
e233c963a3
datatrails: fix dark mode drawer background clashing with data trail backgrounds (#84941)
fix: drawer background clashed with data trail bgs
2024-03-21 19:49:32 +02:00
Darren Janeczek
7653da1870
datatrails: add ability to deselect currently metric (#84586)
* feat: ability to deselect currently metric
2024-03-20 21:51:47 -04:00
Darren Janeczek
d58e652cc3
datatrails: include description of related metrics tab (#84525)
* fix: include description of related metrics tab
2024-03-21 00:20:23 +02:00
Darren Janeczek
5d5e22ae11
datatrails: fix: position of new metric exploration button (#84844)
fix: position of new metric exploration button
2024-03-20 18:08:13 -04:00
Darren Janeczek
63e8753aa0
datatrails: integrate dashboard panels with metrics explore (#84521)
* feat: integrate dashboard panels with metrics explore

- add dashboard panel menu items (in non-scenes dashboard) to open
  `metric{filters}` entries detected from queries to launch
  "metrics explorer" drawers for the selected `metric{filter}`

* fix: remove OpenEmbeddedTrailEvent

* fix: use modal manager dismiss capabilities instead
2024-03-18 17:16:38 +01:00
Darren Janeczek
e96836d19e
datatrails: Remove prefix filter (#84661)
* fix: use cascader's clear button

* fix: remove the prefix filter from metric select

* fix: remove supporting code in metric select scene

- For the removed prefix filter

* fix: spacing
2024-03-18 11:00:31 -04:00
Darren Janeczek
767608f3a6
Data trails: use description of data source to shorten label (#84665)
fix: use description of data source to shorten label
2024-03-18 16:23:19 +02:00
Andre Pereira
6241386a96
Data Trails: Sticky main metric graph (#84389)
* WIP

* Refactor code a bit so we can sticky the main graph and tabs

* Make sure it works in Firefox. Avoid annoying warnings in breakdown tab. Update pin metrics graph label

* Small copy change

Co-authored-by: Darren Janeczek <38694490+darrenjaneczek@users.noreply.github.com>

---------

Co-authored-by: Darren Janeczek <38694490+darrenjaneczek@users.noreply.github.com>
2024-03-18 13:38:17 +02:00
Darren Janeczek
59baa7a4a4
fix: data trails ignore usage syntax (#84610) 2024-03-15 21:27:31 +02:00
Darren Janeczek
e93ba13f7a
datatrails: style: update buttons to secondary solid format (#84526)
* fix: secondary solid buttons for selecting metrics

* fix: secondary solid buttons for selecting labels

* fix: secondary solid buttons for adding filters
2024-03-15 11:00:05 -04:00
Darren Janeczek
73d96b6d1f
datatrails: fix: clearly identify unspecified label values (#84474)
fix: clearly identify unspecified label values
2024-03-14 10:39:01 -04:00
Leon Sorokin
1dc6014b10
Dashboard: Revert descending z-index changes (#83466)
Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
2024-03-06 16:31:54 +02:00