Commit Graph

802 Commits

Author SHA1 Message Date
Leon Sorokin
b022ddeee8 VizLegend: Implement natural sort, simplify, optimize (#78570) 2023-11-27 16:39:43 -06:00
Khushi Jain
b7c74a1af6 Alerting: Migrate from aria-label e2e selectors to data-testid (#78437)
Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
2023-11-27 16:24:31 +01:00
Ashley Harrison
441d24f955 Chore: Remove some gf-form classes (#78601)
* remove some gf-form

* couple more transformations

* clean up Playlists

* review comments

* fix unit tests
2023-11-24 12:09:09 +00:00
Ivana Huckova
8a7eb4b484 Loki: Refactor template variable logic and remove reliance on timeSrv (#78586)
* Loki: Refactor variables support to reuse loic

* Remove redundant methods

* Make parseStringToVariableQuery private
2023-11-24 12:52:29 +01:00
Joey
4f46fb412c Tempo: Embed flame graph in span details (#77537)
* Embed flame graph

* Update test

* Update test

* Use toggle

* Update test

* Add tests

* Use const

* Cleanup

* Update profile tag

* Move flame graph out of tags, remove request and other cleanup + tests

* Update test

* Set flame graph by profile id and simplify logic

* Cleanup and redrawListView

* Create/use feature toggle
2023-11-23 13:36:53 +00:00
Josh Hunt
05070385cd Chore: Refactor TimeRangePicker for aria-label selectors (#78399)
* Change from aria-label to data-testid for e2e selectors

* translate

* update tests

* swap buttons:
2023-11-23 10:39:26 +00:00
Ashley Harrison
4290ed3d86 Chore: Remove newBrowseDashboards feature toggle (#78190)
* remove all the things

* fix OldFolderPicker tests

* i18n

* remove more unused code

* remove mutation of error object since it's now frozen in the redux state

* fix error handling
2023-11-22 15:22:00 +00:00
Ivana Huckova
02090f71d2 @grafana/data: Add serializeParams (#78468)
* Move serializeParams to @grafana/data

* Update comment

* Update solution in Tempo

* Fix type assertions

* Use toUrlParams in serializeParams

* Update data sources

* Update

* Update packages/grafana-data/src/utils/url.ts
2023-11-22 13:15:29 +01:00
Sonia Aguilar
2acf153a26 Alerting: Simplify routing in alert form - part1 (#78040)
* Add routing option tabs

* Use alertingSimplifiedRouting feature toggle

* Move simplified routing tab to a separate component:SimplifiedRouting

* Populate contact point selector with the right values

* Show alert manager icons

* Fix descriptions

* Remove clear button on ContactPointSelector and save updated reducer state in the form

* Load contact points and manual option from rule data in RuleFormValues

* make contact point selector not clearable

* Refactor

* Add link to contact points view

* Move ContactPointSelector to a separate file

* Refactor: move hoook useReceiversMetadataMapByName to a separate file

* Update Need more info texts

* Address some PR review comments

* Use useContactPointsWithStatus hook and wrap each ContacPointSelector with AlertmanagerProvider

* use getAlertManagerDataSourcesByPermission instead of useGetAlertManagersMetadata in NotificationPreview

* Update enum

* Remove css style

* remove console

* update contact point selector

* file cleanup

* adds summary as description

* Update text in manual tab

* Fix preview routing not checking if alert manager can handle grafana alerts

* Fix typo

* remove unused location form field

* fix prettier

* fix test

* Remove unused location form field from AlertRuleNameInput

* Only use internal AlertManager for now

---------

Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
2023-11-22 10:15:33 +01:00
Jev Forsberg
4275f2dc8c Chore: Update e2e selectors for Transformations (#78426)
* baldm0mma/e2e_selector_migration/ update labels

* baldm0mma/e2e_selector_migration/ run prettier

* baldm0mma/e2e_selector_migration/ add test

* baldm0mma/ update results

* baldm0mma/e2e_selector_migration/ update betterer
2023-11-21 09:31:56 -07:00
Leon Sorokin
d1cffdc58a HeatmapTooltip: Refactor to simplify upcoming PRs (#78436) 2023-11-21 10:16:45 -06:00
Kevin Yu
7f7d912af7 CloudWatch: Call query method from DataSourceWithBackend to support public dashboards (#77532)
* CloudWatch: call query method from DataSourceWithBackend to support public dashboards

* add test

* remove unneeded properties from test case

* update betterer

* add parens to group related logic

* remove unnecessary aliasing of variable

* use t.Cleanup

* remove redundant check

* add comment
2023-11-20 14:44:22 -08:00
Giordano Ricci
53642b60ed Explore: handle URLs parse errors (#77784)
* Explore: handle URLs parse errors

* minor modifications

* tentative fix

* update docs

* omit v0 params from the final url

* Apply suggestions from code review

Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com>

* remove safeParseJson, make parse return an object

---------

Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com>
2023-11-20 13:54:00 +00:00
Ida Štambuk
b56d7131bd Cloudwatch: Migrate Config editor and Variable editor to new form stying under feature toggle (#77838) 2023-11-20 14:40:02 +01:00
Ashley Harrison
2c0c51a0df Chore: improve types (#78126)
* fix some types

* more type updates

* some more fixes

* more changes

* string instead of unknown

* more like original logic

* remove outdated comment

* update betterer
2023-11-16 12:39:12 +00:00
Dominik Prokop
0122f7ccad DashboardScene: Support dashboard links (#77855)
* MenuItem: Allow react node as label

* LinkButton: Expose ButtonLinkProps

* Typecheck fix

* DashboardLinks: Refactor and use LinkButton and menu

* DashbaordLinks scene object

* Use flex layout for dashboard controls

* Update public/app/features/dashboard/components/SubMenu/DashboardLinksDashboard.tsx

Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>

* fix keepTime and includeVars

* Add ellipsis to menu item label and description

* Use DashboardLink type from grafana/schema

* Update dashboard scene controls layout

* Fix e2e

* Test fix

* Bring back keyboard navigation

* Remove unused code

* One more fix

---------

Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
2023-11-15 17:49:51 +02:00
Torkel Ödegaard
1f1d348e17 DataTrails: Auto query, explore and breakdown/drilldown prototype (#77019)
* First try

* Update

* app with drilldowns

* Progres

* Progress

* update

* Update

* update

* Update

* Update

* Progress

* Update

* Progress

* Update

* Progress

* logs url sync

* related metrics

* Progress

* progress

* Progress

* Update

* Update

* Update

* Update

* Update

* fix

* Update

* update

* Update

* update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* update

* Update

* Update

* Settings

* Update

* Tweaks

* update

* Improve auto queries

* Update

* Update

* Fixes

* Update

* Update

* Update

* fix

* Update

* Removing logs view, cleanup

* Update

* Update

* disabled not implemented buttons

* Update

* Feature toggle on dashboard menu

* remove unused prometheus change

* removed bit

* Fix failing test

* chore: added `/public/app/features/trails/` to CODEOWNERS

* go mod tidy

* go mod tidy

* fix: added missing arg

* Moved panel action

* Moved panel action

---------

Co-authored-by: André Pereira <adrapereira@gmail.com>
Co-authored-by: Darren Janeczek <darren.janeczek@grafana.com>
2023-11-15 11:28:29 +00:00
kay delaney
d0180957d1 Scenes/ShareModal: Implement public dashboard tab (#76837)
Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com>
2023-11-14 17:05:24 +00:00
Josh Hunt
2f2be24e01 Chore: Remove unnecessary type assertions (#78009)
* Chore: Remove unnecessary type assertions

* betterer
2023-11-14 09:17:29 +00:00
Dominik Prokop
a3ae9d418d DashboardScene: Alert states data layer (#77945)
* Add AlertStates data topic

* DashboardScene: Alert states data layer

* TMP package json

* Remove duplicated function

* Use latest scenes canry

* Use latest scenes and add transformation test
2023-11-14 00:08:06 -08:00
Torkel Ödegaard
867ff52b38 Select: Overflow ellipsis and control over multi value wrapping (#76405)
* Select: Better overflow and wrapping behavior and control

* Update

* truncate

* minor update

* review fixes

* Remove legacy big
2023-11-14 08:29:12 +01:00
Josh Hunt
4a3c148298 Chore: Stricter typing in type guards (#77809)
* Stricter typing in type guards

* create utility isObject fn

* better isAlertStateWithReason

* better name

* restore "data !== undefined"
2023-11-13 16:11:54 +00:00
Oscar Kilhed
721988e931 Transformations: break add field from calculation transformation UI into sub components (#77874)
* break out subcomponents

* prettify

* break out editors into separate files

* update betterer since this is only moving around lint issues

* Fix import
2023-11-10 17:12:34 +02:00
Ashley Harrison
40fd80c46f Chore: Various type improvements (#77877)
* more datasource type fixes

* more type updates
2023-11-09 17:39:02 +00:00
Daniel Benjamin
714dd0ec47 Tempo: remove gf-form from TagMappingInput in trace to logs config section (#77835)
ref: remove gf-form from TagMappingInput
2023-11-08 14:31:01 +01:00
Aaron Sanders
963251b520 Auto-generate: Optimize panel title / description generation (#77661)
Co-authored-by: nmarrs <nathanielmarrs@gmail.com>
2023-11-08 01:18:07 +02:00
Oscar Kilhed
59df27cd27 Transformations: Convert calculate field transformer editor to functional component (#77777)
convert class based transformer editor to functional component
2023-11-07 15:05:05 +01:00
Esteban Beltran
0b03344baa Chore: Update to typescript 5 (#76511)
* Update dependency typescript to v5

* Update yarn.lock

* Fix typescript errors

* Update typescript version sdk

* Revert useDescription.ts

* Fix ts errors

* Fix Typescript errors after Symbol.unscopables type change

* Fix colormanipulator errors

* Update packages/grafana-data/src/vector/FunctionalVector.ts

* Fix ts errors in dashboardmigrator

* Fix sandbox component typescript error

* Update yarn

* Update to typescript 5.2

* Fix typescript error

* update typescript/vscode patch/sdk/whatever

* fix ts errors in elasticsearch

* Fix two errors in alerting

* Fix error in dashboard-scene

* Fix errors in dashboard tests

* Fix errors in explore tests

* Fix error in plugins sandbox

* fix error in DashboardQueryRunner

* fix errors in grafana-data

* fix errors in PanelChrome story

* update betterer

* better fix for cloud monitoring

* fix error in reducer tester

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Zoltán Bedi <zoltan.bedi@gmail.com>
Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com>
Co-authored-by: joshhunt <josh@trtr.co>
2023-11-07 13:20:20 +00:00
Piotr Jamróz
b7f854a06c Correlations: Fix incorrect state transitions in transformations editor (#77434)
* Extract transformations editor row to a seprate component

* Use css object instead of string literals

* Update .betterer.results

* Post merge fixes

* Bring back validation rules

* Switch to css/object

* Post-merge fixes

Ensuring Stack from grafana-ui is used after conflicts with 25779bb6e5
2023-11-07 12:17:02 +01:00
ismail simsek
73f25f7ccc Prometheus: Remove unsupported browser access mode related code (#77316)
* Remove unused code

* More cleaning

* Delete more

* betterer

* Small import fixes

* Fix unit test

* Fix unit test

* uncomment

* Remove PromLink component since it was removed from Prometheus data source

* Clean the direct/browser access code

* Remove directUrl

* Big cleaning

* unit test fixing

* cleaning

* fix metric_find_query tests

* clean result_transformer tests

* betterer

* Remove unused type

* betterer
2023-11-06 18:03:05 +01:00
Ashley Harrison
d1e52d4788 Chore: type fixes (#77618)
* type fixes

* couple more

* just a couple more

* small fixes to prometheus typings

* improve some more datasource types
2023-11-06 11:28:44 +00:00
kay delaney
c98add6e5a Dashboards: Fix issue causing crashes when saving new dashboard (#77620)
Closes #77593
2023-11-03 18:33:59 +02:00
Victor Marin
61d63d3034 Transformations: Cumulative and window modes for Add field from calculation (#77029)
* cumulative sum

* refactor and create new mode

* refactor - use reduceOptions for new mode also

* revert naming

* Add window function, rename statistical to cumulative (#77066)

* Add window function, rename statistical to cumulative

* Fix merge errors

* fix more merge errors

* refactor + add window funcs

Co-authored-by: Oscar Kilhed <oscar.kilhed@grafana.com>

* add ff + tests + centered moving avg

Co-authored-by: Oscar Kilhed <oscar.kilhed@grafana.com>

* make sum and mean cumulative more efficient (#77173)

* make sum and mean cumulative more efficient

* remove cumulative variance, add window stddev

* refactor window to not use reducer for mean. wip variance stdDev

* fix tests after optimization

---------

Co-authored-by: Victor Marin <victor.marin@grafana.com>

* optimize window func (#77266)

* make sum and mean cumulative more efficient

* remove cumulative variance, add window stddev

* refactor window to not use reducer for mean. wip variance stdDev

* fix tests after optimization

* fix test lint

* optimize window

* tests are passing

* fix nulls

* fix all nulls

---------

Co-authored-by: Victor Marin <victor.marin@grafana.com>

* change window size to be percentage

* fix tests to use percentage

* fixed/percentage window size (#77369)

* Add docs for cumulative and window functions of the add field from calculation transform. (#77352)

add docs

* splling

* change WindowType -> WindowAlignment

* update betterer

* refactor getWindowCreator

* add docs to content.ts

* add feature toggle message

---------

Co-authored-by: Oscar Kilhed <oscar.kilhed@grafana.com>
2023-11-03 16:39:58 +02:00
Jacob Zelek
6bf4d0cbc6 DashboardGrid: Add support to filter panels using variable (#77112)
* DashboardGrid panel filter

* Missed segment and changes per PR discussion

* Hide feature flag from docs

---------

Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com>
2023-11-03 05:15:54 -07:00
Alexander Zobnin
dcdd334663 RolePicker: Use portal to render menu (#77499)
* RolePicker: Use portal for menu

* Remove logging

* Fix submenu styles

* Fix ROLE_PICKER_MAX_MENU_WIDTH calculation

* Fix first menu open glitch

* Fix menu closing on ckick

* Fix menu position
2023-11-03 11:06:51 +02:00
Ryan McKinley
0d1d45ee58 Graph: Move graph component to graveyard folder (#77579) 2023-11-02 18:24:30 +02:00
Ryan McKinley
c6e27e00b4 Chore: Move internal GraphNG+Timeseries components into core (#77525)
* move to core where possible

* update imports

* ignore import order for now

* add graveyard files

* update codeowners
2023-11-01 21:59:55 -07:00
Nathan Marrs
124bf6bfa9 chore: canvas cleanup betterer styles object notation edition (#76315)
Co-authored-by: drew08t <drew08@gmail.com>
2023-11-01 18:25:26 +02:00
Alexander Zobnin
cf7a2ea733 RolePicker: Optimise rendering inside lists of items (#77297)
* Role picker: Load users roles in batch

* Use orgId in request

* Add roles to OrgUser type

* Improve loading logic

* Improve loading indicator

* Fix org page

* Update service accounts page

* Use bulk roles query for teams

* Use POST requests for search

* Use post request for teams

* Update betterer results

* Review suggestions

* AdminEditOrgPage: move API calls to separate file
2023-11-01 11:57:02 +01:00
Ieva
ed88289984 Chore: remove legacy dashboard and folder permission pages (#77143)
remove legacy dashboard and folder permission pages
2023-10-31 14:23:37 +00:00
Dominik Prokop
bbe1767310 DashboardScene: Panel links support (#77295)
* DashboardScene: PanelLinks support

* Update public/app/features/dashboard-scene/scene/PanelMenuBehavior.tsx

* Remove code

* Use updated API

* Bump scenes version
2023-10-31 01:57:38 -07:00
ismail simsek
f3fe63e87e Chore: Remove unused code from prometheus datasource (#76776)
* Remove unused code

* More cleaning

* Delete more

* betterer

* Small import fixes

* Fix unit test

* Fix unit test

* uncomment

* Have template_srv from @grafana/runtime
2023-10-30 17:00:34 +01:00
Andre Pereira
107cf0dc04 Trace View: Critical path highlighting (#76857)
* Added critical path computation code. Refactor some trace view code

* Refactor js to ts

* First implementation of critical path working

* Simplified code

* Added filter to show only critical path spans

* Lint and stuff

* Fixes and moving styling to object

* Betterer
2023-10-30 10:43:14 +00:00
Kyle Cunningham
71e3814c46 Transformations: Allow Timeseries to table transformation to handle multiple time series (#76801)
* Initial fix up of getLabelFields

* Update time series to table code

* Cleanup and allow merging

* Support merge and non-merge scenarios

* Update editor

* Fix case with merge true for multiple queries

* Update time series detection, fix tests

* Remove spurious console.log

* Prettier plus remove test console.log

* Remove type assertion

* Add options migration

* Add type export

* Sentence casing

* Make sure current options are preserved when making changes

* Add disabled image

* DashboardMigrator prettier

* Add type assertion explanation and exception

* Fix schema version test

* Prettier

* Fix genAI tests and make them more robust so they dont break on every new schema version

---------

Co-authored-by: nmarrs <nathanielmarrs@gmail.com>
2023-10-27 10:30:49 -05:00
Ihor Yeromin
8effa165dd Tooltip: New styles (#76964) 2023-10-27 09:22:48 -05:00
Leon Sorokin
45aa58c4a8 Histogram: Render heatmap-cells and heatmap-rows frames (#77111) 2023-10-26 23:23:01 -05:00
Sonia Aguilar
61f056fe15 Alerting: Show receiver in groups view to avoid duplication in the list (#77109) 2023-10-26 13:04:26 +02:00
Torkel Ödegaard
c4bf32fa2d EmbeddedDashboard: Removes no longer used components (#77195) 2023-10-26 11:40:15 +02:00
Josh Hunt
333c858bc6 GrafanaUI: Prevent code editors from 'trapping' scroll (#77125)
* GrafanaUI: Prevent CodeEditor from 'trapping' scroll

* fix test

* fix lint for unused import
2023-10-25 19:21:54 +03:00
Ben Sully
eb62e02259 chore: use grafana/experimental for dashboard AI feature (#76948)
The 'llms' module of @grafana/experimental was vendored into the
GenAI components at some point in the past to speed up iteration, so
that dashboard feature development didn't have to wait for a new
release of the experimental package for every change. Now that we
think this has stabilized, we can remove the vendored module from
the Grafana codebase and use the version from @grafana/experimental
instead.

This requires a couple of minor changes, mostly around health check
results which are slightly different in @grafana/experimental now,
but otherwise the changes are mechanical.

Co-authored-by: nmarrs <nathanielmarrs@gmail.com>
2023-10-25 16:38:55 +01:00