Commit Graph

300 Commits

Author SHA1 Message Date
Josh Hunt
0c36b247af
Chore: Refactor Search/Folder view types into DashboardViewItem (#63162)
* Chore: Refactor Search/Folder view types into DashboardViewItem

* uid is not optional in api

* rename queryResultToNestedFolderItem function

* Fix error from locationInfo being empty

* change queryResultToViewItem to take view instead

* Fix sortMeta fields not showing on search cards

* Show correct parent for panel search results
2023-02-23 15:52:54 +00:00
Josh Hunt
54aaaf169f
Internationalization: Mark up more of Dashboard Variables and Browse/Search Dashboards (#63518)
* Extract dirty translations from main

* Translate some variable phrases

* Translate nav bar

* Translate search/browse

* Fix header returning null

* Translate search results type

* fix test
2023-02-23 10:46:07 +00:00
Ashley Harrison
f8d89eff56
Chore: fix type errors in tests (#63270)
* fix any's in tests

* fix more any's in tests

* more test type fixes

* fixing any's in tests part 3

* more test type fixes

* fixing test any's p5

* some tidy up

* fix template_srv
2023-02-14 16:46:42 +01:00
Josh Hunt
09637caade
Chore: Remove search_srv (#62964)
* Chore: Remove Search Service

* use getSortOptions from grafana searcher

* wip

* fix library panels search tests
2023-02-07 15:28:07 -05:00
Josh Hunt
c9773e55b2
Search: Switch to list view when filtering by tags (#63004)
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
2023-02-07 12:05:00 +00:00
Josh Hunt
f8809eef59
Search: Fix not being able to clear sort value (#62557)
* user essentials mob! 🔱

lastFile:public/app/features/search/state/SearchStateManager.ts

* user essentials mob! 🔱

lastFile:public/app/features/search/page/components/ActionRow.tsx

* user essentials mob! 🔱

* remove searchSort state from localStorage when cleared

---------

Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
Co-authored-by: Joao Silva <joao.silva@grafana.com>
2023-02-03 13:44:57 +00:00
Leon Sorokin
4d564f8b0a
Chore: uFuzzy 1.0.2 (#62276)
Co-authored-by: joshhunt <josh@trtr.co>
2023-02-02 09:09:48 -06:00
Joao Silva
3ea7ca0993
Search: Fix alignment of checkbox in folder view (#62678) 2023-02-01 17:36:28 +01:00
Yaelle Chaudy
3281eb9223
[Navigation] Add user events for quick actions/dashboard actions (#62220)
Add fe events for quick actions/dashboard actions
2023-01-27 14:11:17 +01:00
Josh Hunt
960307e938
Search: Remember sorting preference between visits (#62248)
Search: Remember sort option between uses
2023-01-27 11:00:28 +00:00
Josh Hunt
70f109526a
Search: Store only search value in state, not the whole selectable value (#62228)
* Search: Store only search value in state, not the whole selectable value

* type sort to undefined-able
2023-01-27 10:50:48 +00:00
Ryan McKinley
c315946a91
SearchV2: Fix star query when no stars exist (#61726) 2023-01-19 21:37:06 +00:00
Laura Fernández
bb7410aa09
Search: Fix empty folder message showing when by starred dashboards (#61610) 2023-01-17 16:35:54 +01:00
Ryan McKinley
ce3a96abec
Search: Auto focus input elements (#61443) 2023-01-13 16:01:47 +00:00
TaitChan
a1d33c63c8
Internationalization: Translate page headers and Search dashboard actions (#60727)
* Fix: PageHeader & PageHeaderTabs & NavBarItem & DashboardActions & PanelMenu is displayed in default_language (#60719)

* I18N: update strings (#60719)

Co-authored-by: TaitChan <1441645821@qq.coom>
2023-01-13 14:33:42 +00:00
Ryan McKinley
48fbe51d37
Chore: Avoid FC in canvas elements and dimension editors (#61014) 2023-01-05 09:55:55 -08:00
Josh Hunt
ecf83a6df9
Search: Fix report search usage from throwing in console (#60382) 2022-12-15 13:58:20 +00:00
Artur Wierzbicki
009d65b794
Add query library behind dev-mode-only feature flag (#55947)
Co-authored-by: nmarrs <nathanielmarrs@gmail.com>
Co-authored-by: Adela Almasan <adela.almasan@grafana.com>
Co-authored-by: drew08t <drew08@gmail.com>
Co-authored-by: Ryan McKinley <ryantxu@gmail.com>
2022-11-30 15:33:40 -08:00
Leo
ce630b2dc5
Folder: Fix top folder creation (#59422)
fix top folder creation
2022-11-30 18:51:14 +01:00
renovate[bot]
e84a01e870
Update jest monorepo to v29 (#58261)
* Update jest monorepo to v29

* update snapshots + wrap test in act

* fix linting errors: jest.mocked now defaults to deep mocking

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
2022-11-24 14:00:41 +00:00
Leo
7d82a27835
Folder: Provide adhoc ui for nested folder creation (#59126)
chore: provide adhoc ui for nested folder creation
2022-11-23 13:08:36 +01:00
Josh Hunt
b1ffe18599
Chore: Fix some as HTMLElement type assertions (#58667) 2022-11-21 13:05:55 +00:00
Ashley Harrison
5226a61f67
Navigation: Stop clearing search state when opening a result in a new tab (#58880)
search: only clear search state if not opening in a new tab
2022-11-18 14:17:59 +00:00
Leo
27b6b3b3bd
Folder: Replace folderId with folderUid (#58393)
* support folderuid in FolderPicker

* support folderuid in unified alerting

* support folderuid when returning to view mode after editing a panel

* support folderuid when preselecting the folderpicker in dashboard general settings

* support folderuid when saving dashboard

* support folderuid when pre-selecting folderpicker in dashboard form

* support folderuid in routes when loading a dashboard

* support folderuid when saving dashboard json

* support folderuid when validating new dashboard name

* support folderuid when moving dashboard to another folder

* support folderuid on dashboard action buttons

* support folderuid when creating a new dashboard on an empty folder

* support folderuid when showing library panel modal

* support folderuid when saving library panel

* support folderuid when importing dashboard

* fixed broken tests

* use folderuid when importing dashboards

* remove commented line

* fix typo when comparing uid values
2022-11-17 09:22:57 +01:00
Joao Silva
20e6ac397e
Search: Fixes issue with Recent/Starred section always displaying "General" folder (#58746) 2022-11-15 13:16:03 +01:00
kay delaney
a8c181bf6a
Chore: Migrate usage of v1 theme to v2 (#58154) 2022-11-03 18:15:55 +00:00
Marcos Vinicius
372ba83534
reduce the number of requests in folder section (#55876) 2022-11-03 13:22:07 +00:00
Torkel Ödegaard
915ebcf832
Search: Refactor state and logic to be less fragmented and spread out (#57973)
* Started search state refactor

* Things are working

* Move more to statemanger

* minor tweaks

* Fixed name of hook

* revert yarn.lock changes

* Harderning StateManagerBase

* More tests and refinements

* Fixed unit test

* More polish

* fixing tests

* fixed test

* Fixed test
2022-11-03 08:29:39 +01:00
Torkel Ödegaard
3991be4c1d
Search: Fixes searching by current folder when opened by clicking dashboard folder name (#57716)
* Search: Read from url on mount no on app boot

* Fixed tests

* Remove unused type
2022-11-01 10:11:42 +01:00
Gabriel MABILLE
4d380978d3
Fix: Unlock new button based on user permissions (#57733) 2022-10-27 15:48:07 +02:00
Ashley Harrison
d2a70bc42d
Chore: more any/type assertion improvements (#57450)
* more friday any/type assertion improvements

* Apply suggestions from code review

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* Update public/app/angular/promiseToDigest.test.ts

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>
2022-10-25 11:04:35 +02:00
Artur Wierzbicki
c26cf6a517
Search: Sort alphabetically in the folder view, increase the limit of the folder search from 50 to 1000 (#57078)
* search: sort folders

* search: increase the limit for folder search to 1000

* add folder view sort test

* search: getFolderViewSort

* search: revert test

Co-authored-by: Todd Treece <todd.treece@grafana.com>
2022-10-18 14:10:53 +08:00
kay delaney
5d53a983d8
React18: Update useCallback arg types where needed (#57084) 2022-10-17 14:52:12 +01:00
Torkel Ödegaard
0d9b321058
DashboardsList: Fixes issue with overflow hidden causing input focus state to be obscured (#57021) 2022-10-17 14:19:57 +02:00
kay delaney
e85917f041
Chore/React18: Update component prop types (#56898) 2022-10-14 10:24:32 +01:00
Leon Sorokin
5acda40248
Search/ActionRow: drill placeholder to SortPicker (#56475) 2022-10-13 13:30:20 -06:00
Torkel Ödegaard
85e3ed491d
DashboardsList: Fix height issue in topnav (#56661) 2022-10-12 11:00:45 +01:00
Leon Sorokin
8300702524
Search: fuzzy match dashboard names in frontend from full list (#55721) 2022-10-05 18:32:35 -04:00
George Rodrigues
8950d86141
fix: some typos (#56171) 2022-10-04 18:43:49 -05:00
Ashley Harrison
e942a3d99d
enable jsx-a11y/no-autofocus (#56288) 2022-10-04 12:54:14 +01:00
Laura Fernández
fca252e7dc
A11y: enable rule jsx-a11y/alt-text (#55832)
* Enable jsx-a11y/alt-text rule

* Fix errors

* Fix tests

* Enable jsx-a11y/alt-text rule after solving merge conflict

* Delete unused import

* Modify files according to the reviewer's comments

* Revert test changes and update snapshot

* tweaks to image alt names

Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
2022-10-03 09:27:04 +01:00
Ashley Harrison
5b1fdd535a
Accessibility: turn on jsx-a11y/no-noninteractive-tabindex + fix/ignore errors (#56084)
* turn on jsx-a11y/no-noninteractive-tabindex + fix/ignore errors

* update comments
2022-09-30 13:20:39 +01:00
Alexa V
51028b1b2e
Panel Inspect JSON: Add instrumentation for "Apply" feature (#55179)
Co-authored-by: Ivan Ortega Alba <ivanortegaalba@gmail.com>
2022-09-28 09:56:58 +02:00
Artur Wierzbicki
202dce66ff
Search: add basic e2e test for the folder view (#55820) 2022-09-28 09:46:24 +04:00
Artur Wierzbicki
814211282a
Search: Fix tags query (#55851)
* Search: fix tags query

* Search: fix type
2022-09-27 21:16:49 +04:00
Artur Wierzbicki
af9e58eeeb
Search: fix cache in the frontend search engine (#55681) 2022-09-23 10:13:14 -07:00
Ashley Harrison
480a3b92d2
dispatch clearFilters when an item is selected (#55512) 2022-09-23 14:46:21 +01:00
Artur Wierzbicki
f8d69415ca
Search: create a separate HTTP endpoint (#55634)
* search: create a separate http endpoint

* search: extract api uri

* search: rename uri

* search: replicate the readiness check

* search: replicate the readiness check metric

* search: update mock
2022-09-22 19:02:09 -04:00
Artur Wierzbicki
e341aa4dab
Search: fix front end query search condition (#55611)
* fix frontend query condition

* refactor to `inludes`
2022-09-22 05:34:09 -04:00
Ryan McKinley
0c38a3ba97
Search: Investigate frontend search options (again) (#55526) 2022-09-20 20:24:29 -04:00
Torkel Ödegaard
10b3c0787a
CSSTransition fixes warnings (#55340) 2022-09-20 11:47:31 +02:00
kay delaney
64bbb7a7ce
Chore: Update and enforce usage of typed react-redux hooks (#55349)
* Chore: Update and enforce usage of typed react-redux hooks
2022-09-19 10:49:35 +01:00
Leo
896d684065
Browse: Hide dashboard actions if user does not have enough permission (#55218)
* hide dashboard actions if user does not have enough permission

* improve test description
2022-09-16 09:19:19 +02:00
Joao Silva
13014dc0df
Search: Fixes folder section not displaying dashboards (#55231) 2022-09-15 14:00:05 +01:00
Joao Silva
ca2139e9ce
Search: Avoid requesting all dashboards when in Folder View 2022-09-14 18:51:55 +01:00
Ashley Harrison
a861c10f1b
Navigation: Integrate search into topnav (#54925)
* behaviour mostly there

* slight performance improvement

* slightly nicer...

* refactor search and add it to the store

* add comments about removing old component

* remove unneeded logic

* small design tweak

* More small tweaks

* Restore top margin

* add onCloseSearch/onSelectSearchItem to useSearchQuery

Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
2022-09-09 11:01:31 +01:00
Josh Hunt
139705611a
Chore: Remove remaining IconName type assertions (#54658)
* Chore: Remove remaining IconName type assertions

* fix lints
2022-09-06 09:15:36 +01:00
Ryan McKinley
ac93cf1db2
Playlists: Migrate to UIDs and load dashboards in the frontend (#54125) 2022-09-05 20:40:01 -07:00
Artur Wierzbicki
74158ed66b
Search: use SQL search as a fallback during bluge's initial indexing (#54095)
* Search: use SQL search as a fallback when bluge indexing is ongoing

* Search: lint

* Search: feedback fixes - return an empty frame with a special name

* Search: revert readiness check query type

* Search: remove println

* remove sleep, get coffee
2022-08-26 12:36:41 +04:00
Ivan Ortega Alba
c332bf885c
Migrate to UID: Stop using search result ID (#54099)
* DashList: Stop using IDs

* DashLinks: Stop using IDs

* BackendSrv: Do not use ID for search endpoint

* DashboardDataDTO: Remove ID

* Remove unused properties from DashboardSearchItem
2022-08-26 09:42:46 +02:00
Ryan McKinley
94b4f6f459
Search: Show all dashboards in the folder view (#54163) 2022-08-24 12:10:34 -04:00
Esteban Beltran
81957732ab
Chore: Replace react-inlinesvg usage for the Icon component (#53736) 2022-08-17 09:09:58 +02:00
Leo
0ce89dbcb6
use dash-db type when searching for dashboard (#53607) 2022-08-12 16:14:04 +02:00
Leo
64967325b2
Search: Migrated impressions to use dashboardUID (#53090)
* used dashboarduid in impressions

* handle scenario to convert all ids saved in storage to uids
2022-08-08 11:13:19 +02:00
Artur Wierzbicki
f61a97a0ab
Search: rename remove search constraints (#53190) 2022-08-03 16:44:51 +04:00
Ivan Ortega Alba
c9d50ddaaa
Search: Track user searches and results interactions (#52949) 2022-07-29 11:30:13 -04:00
Ryan McKinley
fbd289c19c
Search: add starred filter and swap button order (#52184)
Co-authored-by: Alexandra Vargas <alexa1866@gmail.com>
Co-authored-by: Ivan Ortega Alba <ivanortegaalba@gmail.com>
2022-07-29 16:34:17 +02:00
Leo
8d6d5f2fdc
SearchV2: Add minor UX improvements to Search pages (#52833)
* Search: display dash for panel and folder when sort type is view or error

* Search: Disabled panel checkbox in folrder view
2022-07-28 11:17:47 +02:00
Ryan McKinley
238d761450
Geomap: refactor and cleanup structures (#52760)
Co-authored-by: Adela Almasan <adela.almasan@grafana.com>
2022-07-25 20:12:20 -04:00
Torkel Ödegaard
973be23908
FolderPage: Do not create browser history when adding slug to url (#52695) 2022-07-24 09:32:16 -07:00
Artur Wierzbicki
bcfa4fabf6
Search: Allowed actions (#52529) 2022-07-22 17:42:43 -07:00
Ivan Ortega Alba
2ec01c8d08
Preferences: Use dashboardUID to set the home dashboard (#51919) 2022-07-22 10:44:22 +02:00
Torkel Ödegaard
77f7e8dafc
PageLayouts: Updates dashboard section routes with navId (#52175)
* First stab at new page layouts behind feature toggle

* Simplifying PageHeader

* Progress on a new model that can more easily support new and old page layouts

* Progress

* rename folder

* Progress

* Minor change

* fixes

* Fixing tests

* Make breadcrumbs work

* Add tests for old Page component

* Adding tests for new Page component and behavior

* fixing page header test

* Fixed test

* Moving user profile routes to navId

* PageLayouts: Updates dashboards routes with navId

* added missing navId

* AppChrome outside route

* Renaming folder

* Minor fix

* Updated

* Fixing StoragePage

* Updated

* Updating translation ids

* Updated snapshot

* update nav translation ids (yes this is confusing)

Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
Co-authored-by: joshhunt <josh@trtr.co>
2022-07-20 17:26:52 +02:00
Torkel Ödegaard
52a7b0e75f
Browse/Search: Make browser back work properly when visiting Browse or search (#52271) 2022-07-14 21:07:12 +02:00
Ryan McKinley
eb6d6d0d2b
Search: pass the 'explain' flag from the UI and debug paging issues (#51847) 2022-07-08 15:28:21 -04:00
Torkel Ödegaard
1e85a6f4fd
TopNav: New page layouts (#51510)
* First stab at new page layouts behind feature toggle

* Simplifying PageHeader

* Progress on a new model that can more easily support new and old page layouts

* Progress

* rename folder

* Progress

* Minor change

* fixes

* Fixing tests

* Make breadcrumbs work

* Add tests for old Page component

* Adding tests for new Page component and behavior

* fixing page header test

* Fixed test

* AppChrome outside route

* Renaming folder

* Minor fix

* Updated

* Fixing StoragePage

* Fix for banners

Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
2022-07-06 17:00:56 +02:00
Alexander Emelin
a2478c3a32
Search: Sort by updated at and created at (#50416)
Co-authored-by: Artur Wierzbicki <artur.wierzbicki@grafana.com>
Co-authored-by: Ryan McKinley <ryantxu@gmail.com>
2022-06-30 16:33:30 -07:00
Ryan McKinley
281ed419a8
Chore: add generics to backendSrv (#51606) 2022-06-30 14:34:23 -04:00
Ryan McKinley
c0f10af545
SearchV2: Use the same components for both SQL and bluge backends (#50125) 2022-06-30 12:45:45 -04:00
Maria Alexandra
76aa4f770e
SearchV2: add back the column styles for the SearchResultsTable component (#51549) 2022-06-29 15:45:20 +02:00
Ashley Harrison
2429fe1c70
Search: Add unit tests for SearchResultsTable (#51269)
* initial scaffolding for unit tests

* more tests for searchresultstable

* skip failing test, remove unused css

* Correctly mock stuff so TableCell renders correctly!
2022-06-28 12:48:59 +01:00
Ryan McKinley
b6a9b9804d
Plugin admin: Add a page to show where panel plugins are used in dashboards (#50909) 2022-06-27 20:23:43 -04:00
Ryan McKinley
c8f814196a
CommandPalette: Populate dashboard search when the palette is opened (#51293)
Co-authored-by: Kristina Durivage <kristina.durivage@grafana.com>
2022-06-24 23:08:29 +02:00
Artur Wierzbicki
c496b3e712
Search: Fix pagination in the new search page (#51366)
* Fix pagination in the new search

* update betterer betterer betterer betterer betterer betterer

* revert packagejson
2022-06-24 21:21:59 +04:00
Ryan McKinley
a093250dd5
Chore: avoid implicit any by using inline functions (#51338) 2022-06-23 11:19:08 -07:00
Ryan McKinley
eceb21e72d
Search: switch to a card view when the display is narrow (#51208) 2022-06-23 07:30:47 -07:00
Maria Alexandra
81dc9ef725
SearchV2: Add unit test to SearchResultsGrid (#51296)
* SearchResultsGrid add unit test

* Fix linting issues
2022-06-23 12:14:30 +02:00
Joao Silva
cbefbd3ff7
Search: Adds tests to SearchView (#51248) 2022-06-22 17:20:57 +01:00
Josh Hunt
357b859fa7
Remove any generics from configureMockStore in tests (#51179) 2022-06-21 17:48:52 +01:00
Maria Alexandra
395623b0a2
SearchV2: Add unit test for ManageActions (#51131) 2022-06-21 13:44:46 +02:00
Ashley Harrison
05fbfdaa13
Search: add unit tests for FolderView (#51114)
* add unit tests for FolderView

* add basic unit test for Alert component

* prevent flicker of `No results found`
2022-06-21 09:35:03 +01:00
Ashley Harrison
1b9dd378f2
Chore: Unit tests for FolderSection (#50961)
* unit test scaffolding for FolderSection

* remove redundant spinner + more test scaffolding

* more test experimentation

* clear localStorage between test runs

* more tests + add back spinner when renderStandaloneBody

* bit of tidy up

* update Spinner data-testid

* fix import ordering
2022-06-17 10:14:33 +01:00
Ryan McKinley
e23dbfe605
Search: default layout to last selected value (#50743) 2022-06-15 10:07:34 -07:00
Ryan McKinley
402b5ce4c6
SearchV2: support keyboard navigation (#49650)
Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
2022-06-13 09:10:19 -07:00
Ryan McKinley
b6f97e8101
SearchV2: move search parameters to a nested object (#50561) 2022-06-10 11:06:41 -07:00
Karl Persson
b4559b41c2
RBAC: fix access control check in both new navivation and new search view (#50596)
* check access control permissions for new navigation

* check access control actions in new search view
2022-06-10 15:26:00 +02:00
Torkel Ödegaard
c1d405a200
Search: Fixes margins and paddings and left position (#50570) 2022-06-10 11:30:52 +02:00
Ryan McKinley
fdf67276ea
FeatureToggles: Support changing feature toggles with URL parameters (#50275) 2022-06-09 11:42:38 +02:00
Jack Westbrook
ccd75d72f8
Chore: Remove react-testing-lib from bundles (#50442)
* refactor(selectoptiontest): move helper function out of grafana/ui so testing-lib isn't in bundle

* test(selectoptionintest): update import location of helper function

* test(amroutes): put back missing selectOptionInTest helper

* test(selectoptionintest): clean up remaining file imports / exports

* test(queryeditor): fix failing import

* refactor(grafana-ui): reuse selectOptionInTest in SelectBase test
2022-06-09 11:10:48 +02:00
Artur Wierzbicki
49112c8356
Search: fix 'Clear filters' button (#50227)
Co-authored-by: Ryan McKinley <ryantxu@gmail.com>
2022-06-07 11:57:23 +04:00