IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2026-07-29 15:59:50 -05:00
Code Issues Packages Projects Releases Wiki Activity
40,559 Commits 1,119 Branches 715 Tags
907e2a840e817717f785f16038a6b94b6544a9c7
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Ashley Harrison 1ef7cfda3f Navigation: more command palette tweaks (#62286) 
* update placeholder text, only create search keybindings if topNavCommandPalette is disabled

* make search input wider
 2023-01-27 16:21:48 +00:00
Ashley Harrison a344c88a01 Chore: don't create the npm-artifacts dir since yarn packages:pack does this… (#62246) 
* don't create the npm-artifacts dir since yarn packages:pack does this already

* fix an any to trigger a canary build
 2023-01-26 16:41:08 +00:00
Ashley Harrison f7d92ab841 Navigation: only show the img for a section root if both img and icon are present (#62127) 
only show an img for a section root if both img and icon are present
 2023-01-26 12:07:43 +00:00
Ashley Harrisonandjoshhunt a77c342764 Navigation: Add keyboard shortcut to search input (#62116) 
* Show shortcut

* add icon to search bar, make same changes in search modal

* rename to modKey

Co-authored-by: joshhunt <josh@trtr.co>
 2023-01-26 12:07:32 +00:00
Ashley Harrison 64352e8d08 Chore: Move to node 18 again (#62079) 
move to node 18 again
 2023-01-26 10:19:39 +00:00
Ashley Harrison a3b396854a Navigation: Command palette topnav tweaks (#61991) 
stylings tweaks to command palette
 2023-01-26 10:03:16 +00:00
Ashley Harrison e6e560e3ed Dropdown: Make escape close a dropdown (#62098) 
* make escape close a dropdown

* make tab close the dropdown
 2023-01-26 09:23:53 +00:00
Ashley Harrison 92a750a732 Chore: convert last test to RTL and remove Enzyme references (#61918) 
convert last test to RTL and remove enzyme references
 2023-01-24 09:20:47 +00:00
Ashley Harrison 6b53f927b2 Navigation: truncate landing page descriptions to 3 lines (#61925) 
* truncate landing page descriptions to 3 lines

* use correct css prop names
 2023-01-23 17:07:36 +00:00
Ashley Harrison 253f9657cb Navigation: Change collapse icon + behaviour (#61496) 
* adjust positioning and switch icon

* hide collapse button unless collapsed/focused

* use Button instead of IconButton
 2023-01-23 09:30:28 +00:00
Ashley Harrison a26bae45e1 Navigation: clean up colors in section nav (#61240) 
* clean up colors in section nav

* just underline on hover/focus
 2023-01-23 09:26:26 +00:00
Ashley Harrison da969e7d48 Command Palette: don't register dashboards as actions in the command palette (#61271) 
* don't register dashboards as actions in the command palette

* create ActionImpls in RenderResults, memoize some array creation

* extract dashboard results out into separate hook

* remove unnecessary memoization from useActions

* move useDashboardResults into dashboardActions
 2023-01-13 11:41:23 +00:00
Ashley Harrison 4e00fbbd7f Navigation: Allow overriding icons in nav settings (#61160) 
expose k6 icon, allow overriding icon in nav settings, override connections + k6
 2023-01-10 10:29:07 +00:00
Ashley HarrisonandMichael Mandrus a9e39a108c RelativeTimeRangePicker: correctly trap focus in overlay (#60984) 
* correctly trap focus in relativetimerangepicker overlay

* add underlay

Co-authored-by: Michael Mandrus <michael.mandrus@grafana.com>
 2023-01-05 11:35:47 +00:00
Ashley Harrison ebb34560a4 Navigation: use "Home" instead of "Grafana" as the default Breadcrumb text (#60973) 
* use Home instead of Grafana as the default Breadcrumb text

* use translated text
 2023-01-04 15:02:30 +00:00
Ashley Harrison 7005b7bf8a Navigation: Update e2e tests to work with topnav (#60910) 
* turn on topnav toggle in e2e tests

* fix variable e2e tests

* fix remaining tests + remove some hardcoded waits

* speculative fixes

* wait for error to disappear

* use new selector, turn toggle back off
 2023-01-04 14:59:53 +00:00
Ashley Harrison 8149efc729 Chore: group visx updates together (#60895) 
group visx updates together
 2023-01-04 14:32:57 +00:00
Ashley Harrison a16ca209fb Segment: Individual segments are now keyboard accessible (#60555) 
use <button> for keyboard accessibility
 2022-12-21 17:26:18 +00:00
Ashley Harrison 44232569a8 ToolbarButtonRow: Overflow button now toggles visibility correctly (#60635) 
* only close the overlay if we're interacting with something other than the overflow button/the overlay itself

* use a ref instead of a test id
 2022-12-21 15:01:39 +00:00
Ashley Harrison 78e12b140e TimePicker accessibility: remove stopPropagation from everywhere (#60404) 
* remove stopPropagation from everywhere

* improve keyboard a11y in DateTimePicker
 2022-12-21 13:04:47 +00:00
Ashley Harrison 793a3f8d32 Accessibility: clean up VisualizationSuggestions (#60557) 
clean up VisualizationSuggestions
 2022-12-21 10:40:25 +00:00
Ashley HarrisonandZoltán Bedi ba6d2f2a82 Chore: improve some more types (#60476) 
* improve some more types

* fixes

Co-authored-by: Zoltán Bedi <zoltan.bedi@gmail.com>
 2022-12-20 13:07:57 +00:00
Ashley Harrison 9b21375d78 Chore: remove @storybook/addon-knobs package (#60524) 
remove @storybook/addon-knobs package
 2022-12-19 15:35:32 +00:00
Ashley Harrison bc3d1fdd2a Command Palette: Correctly clear button styles when changing theme (#60511) 
add topnav feature toggle to new theme created when using 'c t'
 2022-12-19 10:59:28 +00:00
Ashley Harrison 3c399ed943 Accessibility: Render gauge as a button when onClick is provided (#60396) 
render gauge as a button when onClick is provided
 2022-12-19 09:40:45 +00:00
Ashley Harrison 9bbc2c4cbb Chore: fix some typings in @grafana/data (#60009) 
fix some typings in @grafana/data
 2022-12-16 09:59:00 +00:00
Ashley Harrison b2da0d22af Navigation: show section toggle if there are any react children (#60336) 
show section toggle if there are children
 2022-12-15 12:41:46 +00:00
Ashley Harrison 3a5c3b517c Navigation: conditionally use actions in DataSourceListPage (#60300) 
* conditionally use actions in DataSourceListPage

* fix unit tests
 2022-12-14 13:19:29 +00:00
Ashley Harrison bb2ecb1468 Influx: Query segment menus now position correctly near the bottom of the screen (#60087) 
* only open the menu once options are loaded for better positioning

* use !loadState.loading instead of Boolean(loadState.value)
 2022-12-14 09:51:04 +00:00
Ashley Harrison 535c4576f7 Command Palette: Fix not being able to type if triggered whilst another modal is open (#59728) 
handle command palette in the same way as other modals
 2022-12-13 14:44:32 +00:00
Ashley Harrison c801f030fb Navigation: use the branding menu logo in topnav (#60227) 
use the branding menu logo in topnav
 2022-12-13 14:44:18 +00:00
Ashley Harrison 4e7a316903 TimePicker: Fix time picker selection (#60104) 
fix time picker selection
 2022-12-13 14:11:15 +00:00
Ashley Harrison 75a11e92b2 Dropdown: Menu now closes correctly when selecting options on touch devices (#60181) 
update the version of react-popper-tooltip in @grafana/ui
 2022-12-13 13:23:46 +00:00
Ashley Harrison 39a4ba4396 Navigation: Fix some missing pages in admin section (#60143) 
* add stats and licensing under admin -> general when topnav is enabled

* add ldap to users and access

* use ID instead of Id

* add enterprise licensing node
 2022-12-12 15:23:49 +00:00
Ashley Harrison 8e77a42741 Chore: run toggles_gen_test.go to fix backend test (#60164) 
run toggles_gen_test.go
 2022-12-12 14:33:46 +00:00
Ashley Harrison a09d9d68a8 Chore: fix glob pattern in renovate config (#60146) 
fix glob pattern
 2022-12-12 14:19:14 +00:00
Ashley Harrison 97fa63d14d TimeZonePicker: Scroll menu correctly when using keyboard controls (#60008) 
pass innerRef to TimeZoneOption so the menu scrolls properly
 2022-12-12 12:30:02 +00:00
Ashley Harrison 1497ad4760 TimePicker: Prevent TimePicker overflowing viewport on small screens (#59808) 
* render timepicker in a modal style on small screens

* remove top: -1

* apply styles

* prevent bug where selecting a relative range wouldn't apply if the absolute ranges were expanded

* Revert "prevent bug where selecting a relative range wouldn't apply if the absolute ranges were expanded"

This reverts commit 7090443c12.
 2022-12-09 15:02:26 +00:00
Ashley Harrison a589929c92 Navigation: Prevent app crash when importing a dashboard with a uid of home (#59874) 
* change home id to be more unique, refactor so that home circular reference is never created

* prefix starred dashboards

* update reducer
 2022-12-09 12:54:00 +00:00
Ashley Harrison 0c9aed905a Chore: normalize monaco colors to hex string (#59784) 
normalize monaco colors to hex string
 2022-12-09 10:07:32 +00:00
Ashley Harrison c91c828c46 Renovate: use rebaseWhen: conflicted to try to speed up renovate runs (#60028) 2022-12-09 09:45:38 +00:00
Ashley Harrison a3681a3353 Command Palette: Links now work when grafana is served under a subpath (#60033) 
strip base when pushing urls to locationService
 2022-12-08 15:00:07 +00:00
Ashley Harrison 5d0029c647 Navigation: handle case where navIndex is undefined (#59826) 
handle case where navIndex is undefined
 2022-12-07 10:16:55 +00:00
Ashley Harrison 2b3c86d201 Chore: Remove unused/deprecated @types definitions (#59888) 
* remove @types/rc-tree, @types/classnames

* remove @types/rc-time-picker

* remove @types/reselect

* remove @types/testing-library__react-hooks

* only include known package.json's
 2022-12-07 10:10:59 +00:00
Ashley Harrison 46adfb596d Command Palette: Maintain page state when changing theme (#59787) 
* use same function as the change theme keybindings

* rename toggleTheme service to just theme
 2022-12-05 16:12:56 +00:00
Ashley Harrison 2ac235eaff Chore: remove preloading roboto font (#59664) 
remove preloading roboto font
 2022-12-02 09:30:47 +00:00
Ashley Harrison 11a32bddbb Accessibility: Add the correct role to the modal backdrop (#59572) 
add the correct role to the modal backdrop
 2022-12-02 09:30:30 +00:00
Ashley Harrison 94c5be8dfb Navigation: Remember expanded sections in megamenu (#59661) 
use local storage to remember which sections of megamenu are expanded
 2022-12-01 16:04:36 +00:00
Ashley Harrison dab83c6855 Theme: Use Inter font by default (#59544) 
* Switch to using Inter font by default

* run toggles_gen_test
 2022-12-01 11:59:37 +00:00
Ashley Harrison a958b0be44 Accessibility: Use button instead of div in ColorPicker story (#59581) 
use button instead of div in colorpicker story
 2022-12-01 09:26:58 +00:00
Ashley Harrison 000de83eb4 Accessibility: Improve a11y in DataLinkSuggestions (#59569) 
DataLinkSuggestions: Add role + ignore keyboard lint rule
 2022-11-30 15:58:10 +00:00
Ashley Harrison eaa4d19ed0 Navigation: Move k6 to top-level, rename to "Performance testing" (#59481) 
Move k6 to top-level, rename to "Performance testing"
 2022-11-30 10:27:41 +00:00
Ashley Harrison 191ca1df86 Chore: some type fixes (#59030) 
some type fixes
 2022-11-29 15:52:08 +00:00
Ashley Harrison 5e53582bb1 Navigation: change apps icon to differentiate from dashboards (#59476) 
change apps icon to differentiate from dashboards
 2022-11-29 12:02:58 +00:00
Ashley Harrison 5011b259c7 Chore: ignore eslint rules in Dropdown/TopNavBarMenu (#59385) 
ignore eslint rules in dropdown/topnavbarmenu
 2022-11-29 11:13:21 +00:00
Ashley Harrison d33b4918cd Chore: more any/type assertion improvements (#59229) 
more any/type assertion improvements
 2022-11-23 16:54:57 +00:00
Ashley Harrison c2f31c2685 Navigation: always show GetStartedWithPlugin even if there's install control wa… (#59127) 
always show `GetStartedWithPlugin` even if there's install control warnings
 2022-11-23 11:34:00 +00:00
Ashley Harrison 8761a71da2 Navigation: use correct id to find cloud access policies page (#59123) 
use correct id to find cloud access policies page
 2022-11-23 10:01:57 +00:00
Ashley Harrison 824a562b03 Navigation: share logic between buildBreadcrumbs and usePageTitle (#58819) 
* simplify usePageTitle logic a bit

* use buildBreadcrumbs logic in usePageTitle

* always add home item to navTree, fix some tests

* fix remaining unit tests
 2022-11-22 16:48:07 +00:00
Ashley Harrison 26a7423151 Chore: add some unique keys to prevent warnings (#59143) 
add some unique keys to prevent warnings
 2022-11-22 16:42:21 +00:00
Ashley Harrison 6f26668a9f Chore: Document theme toggle keybinding (#59031) 
* make theme toggle keybinding dev only

* fix bug + add support for theme change keybinding
 2022-11-22 14:01:51 +00:00
Ashley Harrison 19e97a1f31 Accessibility: Improve keyboard accessibility in Collapse (#59022) 
fix keyboard accessibility in Collapse
 2022-11-22 11:19:57 +00:00
Ashley Harrison 8aa74fe9ee Accessibility: Improve keyboard accessibility of FilterPill (#58976) 
fix keyboard a11y in FilterPill
 2022-11-21 09:29:41 +00:00
Ashley Harrison 598935cb34 Accessibility: Improve keyboard accessibility in AnnoListPanel (#58971) 
fix keyboard accessibility in AnnoListPanel
 2022-11-21 09:25:56 +00:00
Ashley Harrison e19957bbc8 Accessibility: Improve keyboard accessibility in GettingStarted panel (#58966) 
fix keyboard a11y in `GettingStarted` panel
 2022-11-18 15:29:50 +00:00
Ashley Harrison 5226a61f67 Navigation: Stop clearing search state when opening a result in a new tab (#58880) 
search: only clear search state if not opening in a new tab
 2022-11-18 14:17:59 +00:00
Ashley Harrison d46e3916a1 Navigation: move connections + integrations to be a top level item (#58902) 
* move connections + integrations to be a top level item

* add a test to check we can move apps to the root

* split out movePlugin logic into a separate function

* fix linting

* rename movePlugin -> addPluginToSection
 2022-11-18 09:05:45 +00:00
Ashley Harrison ac66e14054 Navigation: rename Grafana Machine Learning to just Machine Learning (#58893) 
rename Grafana Machine Learning to just Machine Learning
 2022-11-17 14:31:03 +00:00
Ashley Harrison b398e8640d Navigation: Change quick add styling (#58854) 
Change quick add styling + allow for returning isOpen state to dropdown children
 2022-11-17 09:03:12 +00:00
Ashley Harrison ff1afbb699 Revert "Chore: move to node 18 (#58570)" (#58754) 
This reverts commit 0a9129cf90.
 2022-11-15 13:47:14 +00:00
Ashley Harrison 028751a18a Navigation: Add quick actions button (#58707) 
* initial implementation for quick add

* add new isCreateAction prop on NavModel

* adjust separator margin

* switch to primary button

* undo changes to plugin.json

* remove unused props from interface

* use a consistent dropdown overlay type

* memoize findCreateActions

* add prop description

* use a function so that menus are only rendered when the dropdown is open
 2022-11-15 12:08:15 +00:00
Ashley Harrison 500cf16142 Chore: fix some types (#58662) 
chore: fix some types
 2022-11-11 16:29:49 +00:00
Ashley Harrison 0bd120e01b Navigation: fix page title spacing when there is no subtitle (#58654) 
* fix page title spacing when there is no subtitle

* apply margin to whole page header
 2022-11-11 09:43:11 -05:00
Ashley Harrison 6625f6f0c8 Chore: Update .nvmrc (#58641) 
Update .nvmrc
 2022-11-11 07:21:38 -05:00
Ashley Harrison 0a9129cf90 Chore: move to node 18 (#58570) 
* bump node version to 18

* update folder to 18.x

* update README for m1 instructions

* update drone

* update unit test

* update README
 2022-11-11 11:34:00 +00:00
Ashley Harrison 9cbbe65243 Move cloud link app to the Administration section (#58578) 2022-11-10 17:02:41 +00:00
Ashley HarrisonandTorkel Ödegaard 159607fe6f Navigation: Convert PluginDetails page to use new Page extensions (#58509) 
* Added labels

* App page fixes

* Switch to switch

* wip

* Updates

* I am stuck

* Minor tweak

* This props interface could work

* removed change

* use new page extensions in plugin details page

* add link separator, fix action button spacing

* some renaming

* Move PageInfo into it's own folder + add tests

* add support for new props in old page header

* remove PluginDetailsHeader as it's no longer used

* Fix unit tests

* fix some badge alignments

* center align actions

* badge alignment + only show downloads for community/commercial plugins

* better link alignment

* conditionally render description

* move install control warnings to below subtitle + refactor

Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
 2022-11-09 14:44:38 +00:00
Ashley Harrison b3c761aaa7 Navigation: Expose new props to extend Page/PluginPage (#58465) 
* add extensions and customisation to `Page`

* adjust alignment
 2022-11-09 09:05:01 +00:00
Ashley Harrison 831ecb467c Add new PageInfo component (#58421) 2022-11-08 14:20:05 +00:00
Ashley Harrison 334b498632 group d3 updates together (#58309) 2022-11-07 10:30:23 +00:00
Ashley Harrison ca3bcc691c hide sectionnav items when collapsed, ensure focus ring overlays active items (#58250) 2022-11-04 16:42:34 +00:00
Ashley Harrison 871d98e550 hopefully improve slate test reliability (#58171) 2022-11-04 09:20:03 +00:00
Ashley Harrison c1c8dc8749 remove e2e-api-tests + axios dependency (#58148) 2022-11-03 13:52:58 +00:00
Ashley Harrison 514d3111f4 Accessibility: Enable rule jsx-a11y/no-noninteractive-element-interactions (#58077) 
* fixes for no-noninteractive-element-interactions

* remaining fixes

* add type="button"

* fix unit tests
 2022-11-03 10:55:58 +00:00
Ashley Harrison c3206167a6 increase select placeholder contrast to be WCAG AA compliant (#58034) 2022-11-03 10:45:57 +00:00
Ashley Harrison f76ba90078 Accessibility: Enable jsx-a11y/mouse-events-have-key-events (#58050) 
* implement VizLegend keyboard accessibility

* add onBlur/onFocus
 2022-11-03 10:22:50 +00:00
Ashley Harrison b8303fd431 Chore: Convert SpanTreeOffset test to RTL (#56195) 
* convert SpanTreeOffset tests to RTL (minus mouseenter/mouseleave tests)

* fix remaining tests
 2022-11-03 09:31:09 +00:00
Ashley Harrison f1f0a6f88b Revert "Update React Aria (#57975)" (#58001) 
This reverts commit 44069b64cd.
 2022-11-02 09:39:32 +00:00
Ashley Harrison e5c68f40c2 Accessibility: enable rule jsx-a11y/label-has-associated-control (#57964) 
* use labels correctly

* fix opentsdb labels

* fix unit tests

* use aria-label instead of data-testid
 2022-11-01 14:37:58 +00:00
Ashley Harrison cff6d1cf8b Chore: group some packages to reduce number of PRs (#57912) 
* group some packages to reduce number of PRs

* Group slate + slate-react together

* kick drone
 2022-11-01 11:52:17 +00:00
Ashley HarrisonandMarcus Andersson d2a70bc42d Chore: more any/type assertion improvements (#57450) 
* more friday any/type assertion improvements

* Apply suggestions from code review

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* Update public/app/angular/promiseToDigest.test.ts

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>
 2022-10-25 11:04:35 +02:00
Ashley Harrison 7e631e7239 A11y: Enable jsx-a11y/interactive-supports-focus (#57391) 
* first batch of fixes for interactive-supports-focus

* remove role and aria attributes since this won't be focusable to a screenreader anyway
 2022-10-21 13:52:46 +01:00
Ashley Harrison 630c18d79d make border-radius part of the base styles so focus styles are consistent (#57353) 2022-10-20 13:34:14 +01:00
Ashley Harrison 2987734832 only get organizations if user is signed in (#57279) 2022-10-19 14:24:52 +01:00
Ashley Harrison 96660992f4 Navigation: Ignore null children in ToolbarButtonRow (#57201) 
* filter out any null buttons to prevent padding being added for them

* ignore null children in toolbarbuttonrow
 2022-10-19 10:00:57 +01:00
Ashley Harrison 178b05160a make betterer a required step on PRs again (#57099) 2022-10-18 12:22:13 +01:00
Ashley Harrison 3cca8e3676 any/type assertion fixes (#57009) 2022-10-17 10:10:10 +01:00
Ashley Harrison a904372269 Accessibility: enable rule jsx-a11y/no-noninteractive-element-to-interactive-role (#56870) 
* enable rule `jsx-a11y/no-noninteractive-element-to-interactive-role` and switch to extending recommended preset

* fix unit tests

* better unit test
 2022-10-14 11:02:01 +01:00
Ashley Harrison 5af36e48ba convert ThresholdsEditor to RTL (#56791) 2022-10-13 08:56:36 +01:00
Ashley Harrison 61fd369b3f ensure the first item in the sectionnav is always the section root (#56815) 2022-10-12 17:02:31 +01:00