IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2026-07-30 00:08:10 -05:00
Code Issues Packages Projects Releases Wiki Activity
46,569 Commits 1,123 Branches 715 Tags
a3ae9d418d4c6119d49c049e0b1eb01210de9aeb
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Ashley Harrison bd85d3e25e PlaylistPage: Skeleton loading state 💀 (#77992) 
* playlist skeleton poc

* refactor into PlaylistCard

* make card actions more responsive, update skeleton color to work on secondary background

* don't loop over array

* fix unit tests
 2023-11-13 10:32:42 +00:00
Ashley Harrison 40fd80c46f Chore: Various type improvements (#77877) 
* more datasource type fixes

* more type updates
 2023-11-09 17:39:02 +00:00
Ashley Harrison 6a5de14ed1 Chore: Remove compareScreenshot + blink-diff dependency from core (#77920) 
* remove compareScreenshot + blink-diff dependency from core

* missed one...
 2023-11-09 13:18:12 +00:00
Ashley Harrison b6e2db7d91 Navigation: Report megamenu state when clicking a navigation item (#77705) 
report megamenu state when clicking a navigation item
 2023-11-06 14:32:29 +00:00
Ashley Harrison c0afa74876 QueryRows: Fix being able to reorder rows with keyboard (#77355) 
* Revert "Explore: A tooltip for reorder icon in query operation (#75978)"

This reverts commit 76e102d1a3.

* update type

* CI driven development
 2023-11-06 13:52:50 +00:00
Ashley Harrison d1e52d4788 Chore: type fixes (#77618) 
* type fixes

* couple more

* just a couple more

* small fixes to prometheus typings

* improve some more datasource types
 2023-11-06 11:28:44 +00:00
Ashley Harrison ffcaef9c17 Update navigation e2e tests (#77654) 
update navigation e2e tests
 2023-11-03 22:15:53 +02:00
Ashley Harrison d68d31c63c Navigation: Hide Undock menu button when docked (#76965) 
* small dock menu exploration

* fix e2e tests

* revert back to web-section-alt
 2023-11-03 17:07:15 +00:00
Ashley Harrison f32bc17422 Navigation: Use LoadingBar in CommandPalette (#77506) 
try using LoadingBar in CommandPalette
 2023-11-03 09:54:25 +00:00
Ashley Harrison 5892a64e9f CustomScrollbar: Remove chevrons from scroll indicators (#77498) 
remove chevrons from scroll indicators
 2023-11-02 15:21:36 +00:00
Ashley Harrison 9a905b6312 Navigation: Updates to the docs for admin subsections (#77500) 
updates to the docs for admin subsections
 2023-11-02 14:23:19 +00:00
Ashley Harrison 2d5e602b2d Navigation: Minor tweak to dockedMegaMenu to make it slightly tighter (#77493) 
minor tweak to dockedMegaMenu to make it slightly tighter
 2023-11-01 13:56:58 +02:00
Ashley Harrison 78df641b38 Navigation: Make page container automatically scroll when overflowing (#77489) 
add overflow: auto to page container
 2023-11-01 12:41:30 +02:00
Ashley Harrison 5f6d15d912 Chore: Update detect-breaking-changes workflow to use node 20 (#77459) 
* attempt to fix levitate workflow

* add comment to force levitate to run

* update node version in levitate workflow

* change to test levitate

* remove dummy comment
 2023-10-31 17:17:22 +00:00
Ashley Harrison 13c0268d6b Chore: Upgrade react-redux (#77296) 
* try upgrading react-redux

* memoize getNavModel selector, don't return a new object in command palette selector

* use createSelector to memoize some alert manager selectors correctly

* memoize selectors correctly in appNotifications

* memoize some datasource selectors

* use fake timers to avoid the debounce causing flakiness

* remove duplicate import

* just use memoize-one
 2023-10-31 16:24:34 +00:00
Ashley Harrison 3551f49019 Toggletip: Update background color and border (#77437) 
update toggletip background + border
 2023-10-31 15:11:53 +00:00
Ashley Harrison e67485de30 Chore: Add missing comma to renovate config (#77439) 
add missing comma
 2023-10-31 15:18:14 +02:00
Ashley Harrison dba846fe54 Chore: Some renovate config tidy up (#77275) 
* update some comments, remove some things from the ignore list

* remove @mdx-js/react since storybook now directly depends on it

* add issue link to comment

* exclude @locker from grouped patch updates

* ignore grafana-e2e from renovate
 2023-10-27 15:09:23 +01:00
Ashley Harrison 49f8838b62 Navigation: Improve docked auto scroll behaviour (#77117) 
ensure expand works on any location change, only scroll when docked
 2023-10-27 09:26:38 +01:00
Ashley Harrison 5f2fd8935d Spinner: Fix so that the size property is correctly applied (#77135) 
* correctly apply spinner sizes, refactor to have standard sizes

* better prop definitions so constant values show in IDEs

* 12 is xs, not sm
 2023-10-25 15:39:32 +01:00
Ashley Harrison 85468d2a67 DockedMegaMenu: Adjust docked threshold (#77139) 
* adjust docked threshold to be xl instead of md and make sure it's open by default on 1440 res

* don't show dock menu button
 2023-10-25 14:41:07 +01:00
Ashley Harrison 07cc7504ee Icon: Simplify and remove wrapping <div> (#76819) 
* remove wrapping div

* update tests, just gotta figure out how to handle fontawesome :(

* add spinner.svg which matches the font-awesome spinner

* add mock for react-inlinesvg

* update mock and fix some tests

* fix FormField test

* fix CorrelationsPage tests

* increase timeout
 2023-10-24 12:16:32 +01:00
Ashley Harrison ced065c7e9 Chore: fix some more types (#76535) 
* clean up some e2e/runtime types

* fix some stories

* some more fixes

* fix route props

* update unit tests

* update more unit tests

* don't throw here
 2023-10-24 11:53:22 +01:00
Ashley Harrison fbbc524cb6 Navigation: Default MegaMenu to docked when screensize > 1440 (#76960) 
default megamenu to docked when screensize > 1440
 2023-10-24 09:27:23 +01:00
Ashley Harrison efea86eb52 Navigation: Expand active page hierarchy and scroll into center if not visible (#76949) 
* expand page hierarchy and scroll into center if not visible

* remove unnecessary id
 2023-10-23 15:47:16 +01:00
Ashley Harrison f9a89e5cd2 Navigation: correctly mark a MegaMenuItem as active if it has active children (#76944) 
correctly mark a MegaMenuItem as active if it has active children
 2023-10-23 10:55:25 +01:00
Ashley Harrison a2921d9dfb DockedMegaMenu: More consistent spacing on active state (#76873) 
* more consistent spacing on active state

* use correct secondary variant buttons
 2023-10-23 09:15:39 +01:00
Ashley Harrison f5758e9f4b Navigation: Correctly highlight a SectionNavItem if it has children that are active (#76860) 
correctly highlight a sectionnavitem if it has children that are active
 2023-10-20 10:27:25 +01:00
Ashley HarrisonL-M-K-Bjoshhunt
 		d632dd672c Tooltip: Ensure tooltip text is correctly announced by screenreaders (#76683) 
* add aria-describedby, tooltip role and unit tests

Co-authored-by: L-M-K-B <48948963+L-M-K-B@users.noreply.github.com>
Co-authored-by: joshhunt <josh@trtr.co>

* remove `delayShow` so tooltip text is announced correctly

* adjust IconButton, fix unit tests

* undo tooltip aria-label change

* only set aria-describedby if there's no aria-label

---------

Co-authored-by: L-M-K-B <48948963+L-M-K-B@users.noreply.github.com>
Co-authored-by: joshhunt <josh@trtr.co>
 2023-10-18 16:05:20 +01:00
Ashley Harrison ed4c9bb487 Navigation: Correctly set active nested plugin pages (#76526) 
* correctly set active nested plugin pages

* add recursion depth limit
 2023-10-13 16:01:22 +01:00
Ashley Harrison b6fb1e52f2 Navigation: Limit SectionNav to rendering items up to 3 levels (#76478) 
* only render section nav items up to 3 levels

* extract level depth into constant, apply in DockedMegaMenu as well
 2023-10-13 10:38:35 +01:00
Ashley Harrison effd2a1189 Navigation: Split admin into subsections behind navAdminSubsections feature toggle (#76280) 
* split admin into subsections behind feature toggle

* make authentication a section header

* add translations for subsections

* rename translation keys

* add subtitles
 2023-10-11 14:37:36 +01:00
Ashley Harrison abd2c9c287 Navigation: Hide docked menu and dock button on mobile (#76334) 
* hide docked menu and dock button on mobile

* add logic to handle hamburger menu button on mobile
 2023-10-11 11:33:15 +01:00
Ashley Harrisonandeledobleefe 930c753340 Navigation: Implement logic for docking nav menu (#76188) 
* Create a state for dockedMegaMenu and the function to manage it

* Add the dockedMenu icon and handle the status when clicking it

* Add Megamenu to section nav area when it is docked

* get logic working

* fix mobile

* refactor state + persist in localStorage

* adjust icon and don't use position absolute

* restore old rudderstack tracking

* use Flex instead

* adjust feature toggle to be experimental

* extract out localStorage handling into utils

* don't need separate file

* use store.set/get instead

---------

Co-authored-by: eledobleefe <laura.fernandez@grafana.com>
 2023-10-10 14:55:52 +01:00
Ashley Harrison f56cc6fdc0 Navigation: Create navAdminSubsections feature toggle (#76248) 
create feature toggle
 2023-10-10 13:50:44 +03:00
Ashley Harrison 171e2c1adb Chore: Improve typings and ignore Graph (#75742) 
* fix some types, ignore graph plugin as it'll be gone soon

* update comments

* more more more

* undo renderer change

* use Partial in the editor
 2023-10-06 11:48:15 +01:00
Ashley Harrison 9350e8bee5 Renovate: Add yarn dedupe strategy (#75945) 
add dedupe strategy
 2023-10-04 13:29:10 +01:00
Ashley Harrison 18b237879d DockedMegaMenu: Refactor and rename to simplify (#75872) 
* tidy up some styles

* remove NavBarMenuItemWrapper + consolidate components

* lots of renaming

* use object syntax in FeatureHighlight

* fix a couple of missing find+replace

* adjust li positioning

* fix text truncation

* bit more tidy up

* refactor indent into it's own component

* memoize styles in Indent
 2023-10-03 13:03:27 +01:00
Ashley Harrison e9555d727a Drawer: remove wrapping div preventing Drawer from scrolling properly (#75823) 
remove wrapping div prevent drawer from scrolling properly
 2023-10-02 16:01:28 +01:00
Ashley Harrison 158e7b9977 DockedMegaMenu: Show correct breadcrumbs on dashboard settings (#75808) 
need this logic when using dockedMegaMenu
 2023-10-02 13:58:27 +01:00
Ashley Harrison 0b77db0b74 Chore: Improve sandbox e2e test stability (#75663) 
make sure the input isn't disabled
 2023-09-28 18:21:15 +03:00
Ashley Harrison a2964731eb Navigation: Change dashboard settings to use tabs when dockedMegaMenu is enabled (#75463) 
* kinda working

* return to selected parents

* feature toggle everything

* fix toggling of annotations

* use Trans instead of Text

* kick drone
 2023-09-28 16:15:00 +01:00
Ashley Harrison 1c1639b0d8 Chore: Remove .linguirc (#75658) 
* pretty sure we replaced lingui with i18next so this can go

* remove it from CODEOWNERS as well
 2023-09-28 17:54:34 +03:00
Ashley Harrisonandeledobleefe efaa779c2e Navigation: Refactor MegaMenu to separate out overlay/animation logic (#75365) 
* user essentials mob! 🔱

lastFile:public/app/core/components/AppChrome/DockedMegaMenu/DockedMegaMenu.tsx

* mob start [ci-skip] [ci skip] [skip ci]

* user essentials mob! 🔱

lastFile:public/app/core/components/AppChrome/DockedMegaMenu/DockedMegaMenu.tsx

* user essentials mob! 🔱

lastFile:public/app/core/components/AppChrome/AppChrome.tsx

* fix border css + scroll

* import width from DockedMegaMenu

* extract logic out into AppChromeMenu

* fix bug with hamburger icon

* rename some styles

* one more rename

* remove janky state logic

* prevent react-aria closing the overlay when interacting with the toggle button

* don't need boolean

---------

Co-authored-by: eledobleefe <laura.fernandez@grafana.com>
 2023-09-27 17:05:40 +01:00
Ashley Harrison e82e1593d8 Chore: Remove some hardcoded waits from e2e tests (#75515) 
remove some hardcoded waits
 2023-09-27 14:25:04 +01:00
Ashley HarrisonandAlexa V b374912937 Drawer: Make content scroll by default (#75287) 
* deprecate scrollableContent prop and make it the default behaviour

* restore prop behaviour, just make it default to true

* Update packages/grafana-ui/src/components/Drawer/Drawer.tsx

Co-authored-by: Alexa V <239999+axelavargas@users.noreply.github.com>

---------

Co-authored-by: Alexa V <239999+axelavargas@users.noreply.github.com>
 2023-09-27 13:31:57 +01:00
Ashley Harrison d8e99e2bb5 Chore: Remove more stuff from the e2e object (#75513) 
* cut down the e2e object more :)

* undo changes in grafana-e2e

* couple more things to undo in grafana-e2e
 2023-09-27 11:33:00 +01:00
Ashley Harrison ff0642bf6e Chore: Type improvements 🧹 (#75271) 
* fix some e2e flows types

* some type fixes

* must... fix... more...

* MOAR

* MOREMOREMORE

* 1 more
 2023-09-22 15:06:49 +01:00
Ashley Harrison 06d89e1929 Chore: add some basic validation tests for our eslint rules (#75284) 
* add some basic validation tests for our eslint rules

* add 1 more valid case
 2023-09-22 13:03:21 +01:00
Ashley Harrison 04775ec940 Chore: remove the e2e-flow-suite (#75011) 
remove the e2e-flow-suite
 2023-09-20 09:34:44 +01:00
Ashley Harrison cc251db3c1 Browse Dashboards: Better logic for showing selection checkboxes (#74988) 
show selection checkboxes if can edit either folders or dashboards
 2023-09-19 10:51:59 +01:00
Ashley Harrison f0f1da842b Toggletip: Remove form story and update padding (#75007) 
remove form story and update padding
 2023-09-18 14:28:58 +01:00
Ashley Harrison 6b14183706 Cypress dashboard-time-zone: break chain to prevent flakiness (#75001) 
break chain to prevent flakiness
 2023-09-18 12:02:32 +01:00
Ashley Harrison 3fdf96d241 Chore: consolidate e2e scripts in package.json (#74906) 
consolidate e2e scripts in package.json + almost fix benchmarking tests
 2023-09-14 15:00:29 +01:00
Ashley Harrison 8874a8d398 Browse Dashboards: Use correct permissions checks (#74811) 
* use correct permissions checks + update unit tests

* fix rest of the unit tests
 2023-09-14 11:23:12 +01:00
Ashley Harrison ba7f77f25d Chore: remove scenario wrapping in cypress tests (#74674) 
* remove scenario wrapping in cypress tests

* remove more hardcoded logins

* don't forget the various suite!

* make sure we log in for every test

* fix afterAll revert

* stability
 2023-09-13 13:24:20 +01:00
Ashley Harrison fcdae0ca0b Chore: move to cypress 13.1 (#74718) 
* move to cypress 13.1

* update cloud-data-sources docker image
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
 2023-09-13 11:08:43 +01:00
Ashley Harrison 0c44a6f9bb Chore: Improve typings 🧹 (#74599) 
* various type fixes

* candlestick panel type fixes

* few more fixes

* some fixes

* more :)

* moar!

* undo change to SilencesFilter

* undo change to configureStore
 2023-09-13 09:17:07 +01:00
Ashley Harrison 247d91be2b Chore: remove wrapping of cy in the e2e object (#74650) 
* remove cy. wrapping as e2e().

* make trace-view-scrolling more stable and remove waits

* improve stability more
 2023-09-11 11:20:54 +01:00
Ashley Harrison fb367bf91d Chore: fix build (#74651) 
put ts-expect-error in the right place
 2023-09-11 12:07:05 +03:00
Ashley HarrisonandAndreas Christou 0f2f25c5d9 Chore: Move to Cypress 12 and decouple cypress from @grafana/e2e (#74084) 
* update drone to use cypress 12 image

* upgrade cypress to 12 in core

* cypress config actually valid

* update @grafana/e2e imports and add lint rule

* ignore grafana-e2e from betterer now it's deprecated

* fix remaining type errors

* fix failing tests

* remove unnecessary tsconfig

* remove unnecessary comment

* update enterprise suite commands to work

* add cypress config to CODEOWNERS

* export setTimeRange in utils

* remove @grafana/e2e from core deps

* try running the command through yarn

* move CMD to scripts

* Update cloud-data-sources e2e image

* Update paths

---------

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>
 2023-09-08 16:51:59 +01:00
Ashley Harrison a31b02035a Browse Dashboards: fix viewer permissions check (#74604) 
fix permissions check
 2023-09-08 15:07:00 +01:00
Ashley Harrison a7425f875e Browse Dashboards: Update docs to remove reference to General folder (#74528) 
* update documentation to remove mention of General folder

* update swagger-tags
 2023-09-08 03:57:16 +01:00
Ashley Harrison ebe13a53f7 Browse Dashboards: Split new browse UI from nested folders backend (#74435) 
* create new feature toggle + start to put stuff behind it

* block move, tidy up interfaces

* fix new/folder actions buttons

* show warning when deleting library panels/alert rules + run i18n:extract

* pseudo

* update unit tests

* pass alert in description
 2023-09-07 11:41:00 +01:00
Ashley HarrisoneledobleefeJoao SilvaL-M-K-Bjoshhunttskarhed
 		e2724f39d9 Time Range: Using relative time takes timezone into account (#74013) 
* account for timezone when using relative times
Co-authored-by: eledobleefe <laura.fernandez@grafana.com>
Co-authored-by: Joao Silva <joao.silva@grafana.com>
Co-authored-by: L-M-K-B <48948963+L-M-K-B@users.noreply.github.com>
Co-authored-by: joshhunt <josh@trtr.co>
Co-authored-by: tskarhed <1438972+tskarhed@users.noreply.github.com>

* keep as it was originally for now

* add e2e test for relative time zone overrides

* empty commit to add coauthors

Co-authored-by: eledobleefe <laura.fernandez@grafana.com>
Co-authored-by: Joao Silva <joao.silva@grafana.com>
Co-authored-by: L-M-K-B <48948963+L-M-K-B@users.noreply.github.com>
Co-authored-by: joshhunt <josh@trtr.co>
Co-authored-by: tskarhed <1438972+tskarhed@users.noreply.github.com>

* fix types

* switch to using table panel in e2e test

* use regex for partial text match

* actually go to the dashboard...

* use include.text

* check for visibility first

* try waiting on backend request to complete

* CI driven development is fun

* make sure we're waiting for both data query calls

* open dashboard instead

* kick drone

* Revert "open dashboard instead"

This reverts commit bab9c77c4d.

* check timezone second

* refactor to avoid detached elements

---------

Co-authored-by: eledobleefe <laura.fernandez@grafana.com>
Co-authored-by: Joao Silva <joao.silva@grafana.com>
Co-authored-by: L-M-K-B <48948963+L-M-K-B@users.noreply.github.com>
Co-authored-by: joshhunt <josh@trtr.co>
Co-authored-by: tskarhed <1438972+tskarhed@users.noreply.github.com>
 2023-09-04 10:38:35 +01:00
Ashley Harrison 0853819ff7 Chore: friday typings 5 (#73844) 
* fix some event.target as stuff

* segment async story

* segmentinput story

* SegmentSelect

* fixing some tests

* more test fixes

* undo change to SilencesFilter
 2023-08-29 09:14:15 +01:00
Ashley HarrisonjoshhuntRoxana TurcTobias Skarhedeledobleefe
 		45ff0b5cf6 DatePicker: Fix calendar not showing correct selected range when changing time zones (#73273) 
* user essentials mob! 🔱

* user essentials mob! 🔱

lastFile:packages/grafana-ui/src/components/DateTimePickers/TimeRangePicker/CalendarBody.tsx

* user essentials mob! 🔱

lastFile:packages/grafana-ui/src/components/DateTimePickers/TimeRangePicker/CalendarBody.tsx

* user essentials mob! 🔱

* user essentials mob! 🔱

lastFile:e2e/dashboards-suite/dashboard-timepicker.spec.ts

* user essentials mob! 🔱

lastFile:e2e/dashboards-suite/dashboard-timepicker.spec.ts

* user essentials mob! 🔱

* user essentials mob! 🔱

* restore custom.ini

* run betterer + prettier

---------

Co-authored-by: joshhunt <josh@trtr.co>
Co-authored-by: Roxana Turc <anamaria-roxana.turc@grafana.com>
Co-authored-by: Tobias Skarhed <tobias.skarhed@gmail.com>
Co-authored-by: eledobleefe <laura.fernandez@grafana.com>
 2023-08-23 12:57:32 +00:00
Ashley Harrison 02f2ff1870 Chore: some more type fixes (#73606) 
* some type fixes

* some select/table fixes

* some uplot type improvements

* couple more
 2023-08-23 10:11:59 +01:00
Ashley Harrison 1f49d480a8 Drawer: Clicking a Select arrow within a Drawer no longer causes it to close (#73557) 
ensure drawer doesn't close when clicking dropdown arrow
 2023-08-22 16:11:18 +01:00
Ashley Harrison 57d8997b86 CodeEditor: Correctly fires onChange handler (#73030) 
move onChange outside onEditorDidMount condition
 2023-08-15 09:19:14 +01:00
Ashley Harrison 963fffeef1 Chore: fix some more types (#72726) 
fix some more types
 2023-08-14 16:04:04 +01:00
Ashley Harrison 0ffdcbbe52 Chore: improve typings (#72679) 
improve typings
 2023-08-07 09:32:13 +01:00
Ashley Harrison dbef9899ac Nested folders: Clear selection state in tree view when indeterminate (#72595) 
* clear selection state when indeterminate

* ensure search state is properly cleared when toggling the indeterminate checkbox

* select everything in view
 2023-08-02 11:37:19 +01:00
Ashley HarrisonandRoxana Turc 6194d8fd8b Nested folders: Add e2e test for new browse page (#72590) 
* scaffold nested folder structure

* update structure slightly

* update comments

* Added basic scafold for Cypress test

* fix selector name, add table body selector, improve expand aria label

* skip test for now

* undo changes to cypress custom.ini

---------

Co-authored-by: Roxana Turc <anamaria-roxana.turc@grafana.com>
 2023-08-02 11:28:13 +01:00
Ashley Harrison e0587dfb30 Chore: Replace deprecated usage of shape.borderRadius() (#72672) 
* properly mark borderRadius() as deprecated, replace borderRadius() with default

* undo a couple of changes

* use radius.pill in FilterPill
 2023-08-01 14:46:07 +01:00
Ashley Harrison a0b0d704d9 Chore: type fixes (#72604) 
* fixing some types

* some more type fixes

* undo rootReducer type change

* update betterer
 2023-08-01 12:56:21 +01:00
Ashley Harrison 70cbda951f Chore: revert swc upgrade since it breaks CI metrics emit (#72598) 
revert swc upgrade since it breaks CI metrics emit
 2023-07-31 15:35:48 +03:00
Ashley Harrison ae4810f854 Chore: Emit theme token usage metrics (#72500) 
* create rule to find instances of theme variables

* emit theme token usage metrics

* move awking into script

* make sure theme usage is covering ts and tsx files, remove commented lines
 2023-07-28 17:08:02 +03:00
Ashley Harrison 7406c4ff51 Data sources: Dashboards page now loads correctly from direct url (#72264) 
* ensure DataSourceDashboardsPage initialises data source settings

* fix unit test

* apply suggestions from review
 2023-07-28 09:37:56 +01:00
Ashley Harrison 60058cb3da Button: Fix global button styles! (#72391) 
uncomment button focus styles!
 2023-07-26 18:46:16 +03:00
Ashley Harrisonandjoshhunt 2374458e94 Nested folders: use FolderPicker in dashboard settings (#72192) 
* Use new NestedFolderPicker in SaveDashboardAsForm

* use FolderPicker wrapper in dashboard settings

* fix e2e test

* actually pass the deprecated props to the component

* just pass value

---------

Co-authored-by: joshhunt <josh@trtr.co>
 2023-07-24 14:27:47 +01:00
Ashley Harrison 56ae5abf08 Chore: remove comment that doesn't apply anymore (#72186) 
remove comment that doesn't apply anymore
 2023-07-24 10:13:21 +00:00
Ashley Harrison f078a0bb40 NestedFolderPicker: Allow for excluding certain uids (#72019) 
* exclude some uids from nested folder picker so you can't move a folder to itself

* rename excludedUids to excludeUIDs
 2023-07-21 13:10:23 +01:00
Ashley Harrison 8f464ac66e NestedFolderPicker: Correctly handle pagination (#72030) 
correctly handle pagination in the folder picker when there is more than 1 page of dashboards
 2023-07-21 13:08:19 +01:00
Ashley Harrison 01369e6aff Chore: fix .eslintignore to only ignore folder paths at the root (#72032) 
fix eslintignore to only ignore folder paths at the root
 2023-07-21 09:17:42 +01:00
Ashley Harrison b164fa37e6 NestedFolderPicker: Implement keyboard handling (#71842) 
* first attempt at keyboard handling

* rename some things, handle escape

* better

* almost working

* cleaner

* remove aria-label

* add some extra unit tests

* remove onMouseUp

* fix typo

* use a switch instead of if/else

* ensure lsit items are prefixed with an id unique to the picker

* extract keyboard interactions out into custom hook

* wrap handleCloseOverlay in useCallback

* use redux state instead of filtering items
 2023-07-19 15:32:55 +01:00
Ashley Harrison 626ac67dd7 Chore: Convert @grafana/ui to use emotion object syntax (#71374) 
* convert a bunch of grafana/ui to use emotion's object notation

* convert some more grafana-ui emotion styles

* more conversion

* more conversion

* finish conversion

* fix unit tests

* fix focus styles

* remove semicolon from infobox story
 2023-07-17 16:12:09 +01:00
Ashley Harrisonandrenovate[bot] <29139614+renovate[bot]@users.noreply.github.com> 9852b24d61 Chore: Upgrade prettier to v3 (#71764) 
* Update dependency prettier to v3 (#71586)

* Update dependency prettier to v3

* run prettier

* ignore prettier update in legacy select scss

* update command line arg

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>

* unplug prettier

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2023-07-17 15:58:22 +01:00
Ashley Harrison 5ca382c88a Revert "Update dependency prettier to v3 (#71586)" (#71755) 
This reverts commit 2e8cd1c021.
 2023-07-17 14:46:15 +01:00
Ashley Harrison 24bcf9b3fd Chore: Fix pseudo i18n generation script to work with Prettier 3 (#71734) 
prettier.format is now a promise -> await it!
 2023-07-17 14:00:20 +03:00
Ashley Harrisonandjoshhunt 1caf3298ea Nested folders: Empty state for nested folder picker (#71464) 
* add empty state to nestedfolderpicker, add translations

* run i18n:extract

* rename i18n key

---------

Co-authored-by: joshhunt <josh@trtr.co>
 2023-07-14 11:58:43 +01:00
Ashley Harrison ad3d7d5e94 NestedFolderPicker: Truncate overflowing text, fix selected state (#71444) 
* truncate overflowing text, fix selected state

* ensure search state is always clean when opening the overlay
 2023-07-12 14:55:27 +01:00
Ashley Harrison cc0c85a62e Revert "Update dependency @swc/helpers to v0.5.1 (#71331)" (#71432) 
This reverts commit d0bbb69e14.
 2023-07-12 13:32:54 +03:00
Ashley Harrison 580345306b Nested folders: Only show edit title button if user has permissions (#71426) 
only show edit title button if user has permissions
 2023-07-12 11:07:16 +01:00
Ashley HarrisonandTobias Skarhed 29ed310af9 Nested folder picker: Move options into overlay (#71042) 
* move options into overlay

* add some unit tests

* Update public/app/features/browse-dashboards/components/BrowseActions/MoveModal.tsx

Co-authored-by: Tobias Skarhed <1438972+tskarhed@users.noreply.github.com>

* minor refactoring based on review comments

* just pass in uid

---------

Co-authored-by: Tobias Skarhed <1438972+tskarhed@users.noreply.github.com>
 2023-07-12 10:37:08 +01:00
Ashley HarrisonL-M-K-BtskarhedJoao SilvajoshhuntRoxana Turceledobleefe
 		2650aa5600 Internationalization: Correctly generate plural forms (#71341) 
* user essentials mob! 🔱

lastFile:public/locales/pseudo-LOCALE/grafana.json

* user essentials mob! 🔱

* user essentials mob! 🔱

lastFile:contribute/internationalization.md

* user essentials mob! 🔱

lastFile:contribute/internationalization.md

* move pseudo generation to precommit hook if en-US file is modified

Co-authored-by: L-M-K-B <48948963+L-M-K-B@users.noreply.github.com>
Co-authored-by: tskarhed <1438972+tskarhed@users.noreply.github.com>

* fix unit tests

---------

Co-authored-by: Joao Silva <joao.silva@grafana.com>
Co-authored-by: joshhunt <josh@trtr.co>
Co-authored-by: Roxana Turc <anamaria-roxana.turc@grafana.com>
Co-authored-by: eledobleefe <laura.fernandez@grafana.com>
Co-authored-by: L-M-K-B <48948963+L-M-K-B@users.noreply.github.com>
Co-authored-by: tskarhed <1438972+tskarhed@users.noreply.github.com>
 2023-07-11 16:37:01 +01:00
Ashley Harrison ab09c9efc7 TimePicker: Fix issue with previous fiscal quarter not parsing correctly (#71083) 
* fix issue with previous fiscal quarter not parsing correctly

* add comment
 2023-07-05 17:02:28 +01:00
Ashley Harrison 0e4743b852 NestedFolderPicker: Expand/collapse keyboard handling (#70949) 
* better keyboard handling in NestedFolderList

* add check for foldersAreOpenable
 2023-07-04 12:55:25 +01:00
Ashley Harrison 7a2a5dde8b Chore: Enable remaining jsx-a11y rules (#70990) 
enabling remaining a11y rules + ignore existing violations
 2023-06-30 16:58:16 +01:00
Ashley Harrison ebd6aa5034 Permissions: Fix incorrect navId in permissions page (#70906) 
fix navId in permissions page
 2023-06-29 16:35:41 +01:00