Commit Graph

41834 Commits

Author SHA1 Message Date
Matthew Jacobson
b9dc04139a
Alerting: Respect "For" Duration for NoData alerts (#65574)
* Alerting: Respect "For" Duration for NoData alerts

This change modifies `resultNoData` to be more inline with the logic of the other state handlers.

The main effects of this are:

1) NoData states with NoDataState config set to Alerting will respect "For" duration.
2) Prevents zero value in StartsAt and EndsAt for alerts that have only even been in normal state. This includes state transitions from NoDataState=OK and ExecErrState=OK.
3) Better state transition logging.
2023-03-31 19:05:15 +03:00
Yuri Tseretyan
ed8628e39d
Alerting: Fix integration test for creating silences (#65722)
* fix integration test for creating silences

to create correct silence with endsAt in the future

* Update api_alertmanager_test.go
2023-03-31 18:44:05 +03:00
Tobias Skarhed
a24554ba0a
Chore: Make SearchItem return div instead of li (#65685)
Remove use of li
2023-03-31 17:09:39 +02:00
Karl Persson
46cfb73e21
AuthToken: client token rotation fix (#65709)
* AuthToken: respond with 401 if token is not found

* Set retry to one so we don't retry a failed token rotation
2023-03-31 16:44:08 +02:00
Karl Persson
355f47628f
AuthN: Tune logs in client (#65714)
* AuthN: Remove log

* AuthN: Check for user not found error in hook
2023-03-31 16:43:24 +02:00
Ieva
94cc93cc83
LDAP: Always synchronize Server Admin role through role sync if role sync is enabled (#58820)
fix a bug with role sync
2023-03-31 15:39:23 +01:00
Alexa V
c03bf7d8ad
New Panel Header: Fix when clicking submenu item the parent menu item onClick get's triggered (#65691) 2023-03-31 16:35:34 +02:00
Steve Simpson
04336d53a9
Alerting: Update prometheus version (#65688) 2023-03-31 16:34:35 +02:00
ismail simsek
5a7602fee4
Docs: Update influxdb provisioning documentation to align with database deprecation (#65550)
Update influxdb docs to align with database deprecation
2023-03-31 16:33:16 +02:00
Yuri Tseretyan
622c23716a
Alerting: Use logger with context in the state cache (#65663) 2023-03-31 10:11:30 -04:00
Emil Tullstedt
be9361cb9e
Logger: Add feature toggle for errors in HTTP request logs (#64425) 2023-03-31 15:38:09 +02:00
Andrej Ocenas
977a7e9a55
Phlare: Rollback pprof code (#65689) 2023-03-31 15:27:14 +02:00
Jev Forsberg
d7c9dc4730
Stat Panel: Update docs (#65639)
* baldm0mma/update_stat_docs/ update stat docs

* baldm0mma/update_stat_docs/ update content

* baldm0mma/update_stat_docs/ update show text

* baldm0mma/update_stat_docs/ update color mode text

* Update docs/sources/panels-visualizations/visualizations/stat/index.md

Update to fully plural

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>

* Update docs/sources/panels-visualizations/visualizations/stat/index.md

Update to singular

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>

---------

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
2023-03-31 06:55:29 -06:00
Torkel Ödegaard
86b2af35b2
Table: Fix column filter popup shadow (#65675)
* Table: Fix column filter popup shadow

* fix border
2023-03-31 14:51:56 +02:00
Josh Hunt
4f0d811db1
NestedFolders: add delete confirmation to delete modal (#65548)
add delete confirmation to delete modal
2023-03-31 14:53:52 +03:00
Josh Hunt
3e8f29404e
NestedFolders: Folder view move folder (#65661) 2023-03-31 12:32:23 +01:00
Josh Hunt
9f4ab1b6dd
NestedFolders: Support moving folders into other folders (#65519)
* wip for move folders

* hello

* Polish up move dashboard results messages

* tests

* fix other test

* tweak messages when things can't be moved

* tweak messages when things can't be moved

* fix tests

* remove comment

* restore failOnConsole

* .

* Fix move modal not opening due to dodgy rebase
2023-03-31 12:31:06 +01:00
Kate Brenner
c2813869e4
Update CODEOWNERS per new team name for aws-datasources (#65638)
update codeowners per new team name
2023-03-31 07:16:26 -04:00
Andreas Christou
4586bac426
Bump plugin-sdk (#65652) 2023-03-31 12:58:22 +02:00
Josh Hunt
48a2037703
BrowseDashboards: Fix move to General folder not working (#65653)
* BrowseDashboards: Fix move to General folder not working

* simplify isOpen
2023-03-31 13:49:18 +03:00
Ivana Huckova
b09aa7d5f7
Elasticsearch: Add benchmarks for processing of requests and responses (#65354)
* Elasticsearch: Add benchmarks for processing of requests and responses

* Update, use package variable to elimitnate possible optimization

* Update, require no error
2023-03-31 11:59:11 +02:00
Andre Pereira
541a03f33b
Tempo: TraceQL Configurable static fields (#65284)
* TraceQL - configurable static fields for new UI

* TraceQL - filter out static fields from Tags section. Added tooltip to static fields

* Add more units to duration validation. Improve duration field tooltip with accepted units

* Better control of delete button on SearchField

* Move new config behind feature toggle

* Special title for intrinsic "name"

* Fix tests

* Move static fields not in the datasource to the Tags section

* Start using the useAsync hook in the Tempo TraceQL configuration page to retrieve the tags and datasource

* Fix tests

* Fix test. Use useAsync to retrieve options in SearchField

* Remove ability to set a default value in filter configuration.
Removed type from filter, dynamic filters are now any filters not present in the datasource config

* Updated the static filters tooltip

* Replace useState + useEffect with useMemo for scopedTag
2023-03-31 10:35:37 +01:00
Matias Chomicki
fb83414b6a
Logs Volume Timeouts: Add a custom message with options (retry, close) for request timeouts (#65434)
* Logs Volume: identify timeouts and provide remediation action

* Supplementary result error: refactor updated component API

* Create helper to identify timeout errors

* Update timeout identifying function

* Add unit test

* Update panel unit test

* Update public/app/features/explore/utils/logsVolumeResponse.ts

Co-authored-by: Giordano Ricci <me@giordanoricci.com>

* Use some instead of reduce

* Change alert type to info

* Add comment

* Remove unnecessary optional chaining

* Remove unnecessary condition

* Remove unnecessary wrapping arrow function

---------

Co-authored-by: Giordano Ricci <me@giordanoricci.com>
2023-03-31 09:01:12 +00:00
Ashley Harrison
e39c3b76dd
Navigation: Rename Alerts & incidents to Alerts & IRM (#65635)
update Alerts & incidents to Alerts & IRM
2023-03-31 09:40:06 +01:00
Ashley Harrison
a123e0a97c
e2e tests: Add selector to close dashboard settings and use it in e2e tests (#65625)
* add selector to close dashboard settings and use it in e2e tests

* check visibility of add panel button

* check visibility of add new panel button before clicking
2023-03-31 09:32:44 +01:00
Dominik Prokop
bbf74b941b
Update scenes to 0.2 (#65676)
* Update scenes to latest

* Replace FormatRegistryID with VariableFormatID

* Remove scene demos that were moved to scenes repo, fix the remaining demos

* Fix grafana Monitoring app

* DashboardsLoader migration

* Fix test
2023-03-31 00:59:06 -07:00
Leon Sorokin
e0ef79f5cc
TimeSeries: Don't extend stepped interpolation to graph edges (#65657) 2023-03-31 01:09:40 -06:00
Tobias Skarhed
7b4a222fbf
Search: Move checkbox outside of item card (#65540)
* Move checkbox outside of SeachItem

* Add li element
2023-03-31 08:49:03 +02:00
Isabella Siu
92965578b3
CloudWatch Logs: Fix running logs queries with expressions (#65306) 2023-03-30 17:40:01 -04:00
Giuseppe Guerra
09078b14e1
Plugins: Support for distributed tracing in backend plugins SDK (#63714)
* Tracing: Pass OTLP address and propagation format to plugins

* Fix unit tests

* Fix indentation

* Fix plugin manager integration tests

* Goimports

* Pass plugin version to plugins

* Do not add GF_PLUGIN_VERSION if plugin version is not set, add tests

* Allow disabling plugins distributed tracing on a per-plugin basis

* Moved disabled plugins to tracing.opentelemetry config section

* Pre-allocate DisabledPlugins map to the correct size

* Moved disable tracing setting flags in plugin settings

* Renamed plugin env vars for tracing endpoint and propagation

* Fix plugin initializer tests

* Refactoring: Moved OpentelemetryCfg from pkg/infra to pkg/plugins

* Changed GetSection to Section in parseSettingsOpentelemetry

* Add tests for NewOpentelemetryCfg

* Fix test case names in TestNewOpentelemetryCfg

* OpenTelemetry: Remove redundant error checks
2023-03-30 23:31:14 +02:00
Kristina
55947cee8f
Explore: Add click tracking to data links (#65221)
* Add click tracking to data links

* Use constants, mock window.open call

* Add comment about possibly missing reporting data

* Remove superfluous if
2023-03-31 00:30:20 +03:00
sarah-spang
940768cf76
Docs: Fix markup for URL (#65576)
* Docs: Fix markup for URL

* updates absolute URL to a relref

---------

Co-authored-by: Chris Moyer <chris.moyer@grafana.com>
2023-03-30 13:55:08 -05:00
Alexander Weaver
b2abb63286
Alerting: Introduce proper feature toggles for common state history backend combinations (#65497)
* define 3 feature toggles for rollout phases

* Pass feature toggles along

* Implement first feature toggle

* Try a different strategy with fall-throughs to specific configurations

* Apply toggle overrides once outside of backend composition

* Emit log messages when we coerce backends

* Run code generator for feature toggle files

* Improve wording in flag descs

* Re-run generator

* Use code-generated constants instead of plain strings

* Use converted enum values rather than strings for pre-parsing
2023-03-30 13:53:21 -05:00
Ryan McKinley
8a4135f63f
Prometheus: Track request.requestId rather than custom query.requestId (#63913) 2023-03-30 21:29:04 +03:00
David Allen
765073a776
Give more detail and context on http_addr in grafana.ini (#65187)
* Give more detail and context on http_addr in grafana.ini

This particular configuration item is misleadingly named (it's about networking addresses rather than HTTP) and there are a bunch of ways users can misread, misconfigure, and create a situation where grafana won't start due to a bind error.

I'm trying to outline a couple of extra things about what this covers and provide good default advice, leaving room for specialists who know what they're doing to still use this, with more clarity.

* Update _index.md

* Apply suggestions from code review

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>

* Update _index.md

removed recommendation note about http_addr

* makes prettier

---------

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
Co-authored-by: Chris Moyer <chris.moyer@grafana.com>
2023-03-30 13:27:17 -04:00
Laura Fernández
ce1298c947
Storybook: update Alert story (#63959) 2023-03-30 18:11:30 +02:00
Francisco Montes de Oca
15b76808b7
DateTimePicker: Add min date support to calendar (#64632) 2023-03-30 18:04:02 +02:00
Ashley Harrison
ff96cd1342
Chore: add selector for items in the megamenu (#65633)
add selector for items in the megamenu
2023-03-30 16:57:08 +01:00
Josh Hunt
31aadeaecd
Search: Remove old s o search shortcut from HelpModal (#65631) 2023-03-30 18:46:43 +03:00
Leon Sorokin
89f3f289eb
TimeSeries: Improve stacking direction heuristic (#65499) 2023-03-30 10:30:49 -05:00
Karl Persson
e4d998dc1a
ApiKeyGenPrefix: rename package (#65623)
* Rename package to satokengen to make it clearer that it is for service
account tokens
2023-03-30 17:04:10 +02:00
Sofia Papagiannaki
3cd3bb00ec
API: Fix "Updated by" Column in dashboard versions table (#65351)
* API: Fix dashboard versions created by field

* Add tests

* Update OpenAPI specs

* Apply suggestion from code review
2023-03-30 17:31:53 +03:00
Ryan McKinley
71ef159150
Chore: update babel dependencies in in yarn.lock (#65575) 2023-03-30 07:31:01 -07:00
Alexander Weaver
5e87ea745d
Alerting: Fix and re-enable filters instance labels in log line test (#65618)
Fix and reenable test
2023-03-30 09:02:18 -05:00
Polina Boneva
df946ca5eb
Dashboard: Remove tooltip on Add button (#65619)
nested react-popper-tooltip kills functionality for the inner tooltip
2023-03-30 16:57:18 +03:00
Sven Grossmann
d790cb1c09
Loki: Add unpack query builder hint (#65608)
* add unpack hint

* use `hasOwnProperty`

* add unpack completion to monaco

* adjust test name

* fix tests

* fix tests
2023-03-30 15:18:02 +02:00
Dimitris Sotirakis
e758b017d0
Alerting: Disable filters instance labels in log line test (#65610)
* Disable filters instance labels in log line test

* Add drone reference
2023-03-30 16:04:29 +03:00
Alex Khomenko
2407d2a51d
e2e: Add Toggle menu selector (#65607) 2023-03-30 16:01:49 +03:00
Ashley Harrison
98e66654d6
Chore: Some type fixes needed for react 18 (#65600)
some type fixes needed for react 18
2023-03-30 13:40:18 +01:00
Süleyman Barış Eser
6f6ebf5b18
Fix FieldValidationMessage height issue (#64717) 2023-03-30 14:37:15 +02:00