IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2026-07-30 00:08:10 -05:00
Code Issues Packages Projects Releases Wiki Activity
39,477 Commits 1,123 Branches 715 Tags
c91c828c462e52b35fe7d9b71ecb7f9730282f30
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Ashley Harrison c91c828c46 Renovate: use rebaseWhen: conflicted to try to speed up renovate runs (#60028) 2022-12-09 09:45:38 +00:00
Ashley Harrison a3681a3353 Command Palette: Links now work when grafana is served under a subpath (#60033) 
strip base when pushing urls to locationService
 2022-12-08 15:00:07 +00:00
Ashley Harrison 5d0029c647 Navigation: handle case where navIndex is undefined (#59826) 
handle case where navIndex is undefined
 2022-12-07 10:16:55 +00:00
Ashley Harrison 2b3c86d201 Chore: Remove unused/deprecated @types definitions (#59888) 
* remove @types/rc-tree, @types/classnames

* remove @types/rc-time-picker

* remove @types/reselect

* remove @types/testing-library__react-hooks

* only include known package.json's
 2022-12-07 10:10:59 +00:00
Ashley Harrison 46adfb596d Command Palette: Maintain page state when changing theme (#59787) 
* use same function as the change theme keybindings

* rename toggleTheme service to just theme
 2022-12-05 16:12:56 +00:00
Ashley Harrison 2ac235eaff Chore: remove preloading roboto font (#59664) 
remove preloading roboto font
 2022-12-02 09:30:47 +00:00
Ashley Harrison 11a32bddbb Accessibility: Add the correct role to the modal backdrop (#59572) 
add the correct role to the modal backdrop
 2022-12-02 09:30:30 +00:00
Ashley Harrison 94c5be8dfb Navigation: Remember expanded sections in megamenu (#59661) 
use local storage to remember which sections of megamenu are expanded
 2022-12-01 16:04:36 +00:00
Ashley Harrison dab83c6855 Theme: Use Inter font by default (#59544) 
* Switch to using Inter font by default

* run toggles_gen_test
 2022-12-01 11:59:37 +00:00
Ashley Harrison a958b0be44 Accessibility: Use button instead of div in ColorPicker story (#59581) 
use button instead of div in colorpicker story
 2022-12-01 09:26:58 +00:00
Ashley Harrison 000de83eb4 Accessibility: Improve a11y in DataLinkSuggestions (#59569) 
DataLinkSuggestions: Add role + ignore keyboard lint rule
 2022-11-30 15:58:10 +00:00
Ashley Harrison eaa4d19ed0 Navigation: Move k6 to top-level, rename to "Performance testing" (#59481) 
Move k6 to top-level, rename to "Performance testing"
 2022-11-30 10:27:41 +00:00
Ashley Harrison 191ca1df86 Chore: some type fixes (#59030) 
some type fixes
 2022-11-29 15:52:08 +00:00
Ashley Harrison 5e53582bb1 Navigation: change apps icon to differentiate from dashboards (#59476) 
change apps icon to differentiate from dashboards
 2022-11-29 12:02:58 +00:00
Ashley Harrison 5011b259c7 Chore: ignore eslint rules in Dropdown/TopNavBarMenu (#59385) 
ignore eslint rules in dropdown/topnavbarmenu
 2022-11-29 11:13:21 +00:00
Ashley Harrison d33b4918cd Chore: more any/type assertion improvements (#59229) 
more any/type assertion improvements
 2022-11-23 16:54:57 +00:00
Ashley Harrison c2f31c2685 Navigation: always show GetStartedWithPlugin even if there's install control wa… (#59127) 
always show `GetStartedWithPlugin` even if there's install control warnings
 2022-11-23 11:34:00 +00:00
Ashley Harrison 8761a71da2 Navigation: use correct id to find cloud access policies page (#59123) 
use correct id to find cloud access policies page
 2022-11-23 10:01:57 +00:00
Ashley Harrison 824a562b03 Navigation: share logic between buildBreadcrumbs and usePageTitle (#58819) 
* simplify usePageTitle logic a bit

* use buildBreadcrumbs logic in usePageTitle

* always add home item to navTree, fix some tests

* fix remaining unit tests
 2022-11-22 16:48:07 +00:00
Ashley Harrison 26a7423151 Chore: add some unique keys to prevent warnings (#59143) 
add some unique keys to prevent warnings
 2022-11-22 16:42:21 +00:00
Ashley Harrison 6f26668a9f Chore: Document theme toggle keybinding (#59031) 
* make theme toggle keybinding dev only

* fix bug + add support for theme change keybinding
 2022-11-22 14:01:51 +00:00
Ashley Harrison 19e97a1f31 Accessibility: Improve keyboard accessibility in Collapse (#59022) 
fix keyboard accessibility in Collapse
 2022-11-22 11:19:57 +00:00
Ashley Harrison 8aa74fe9ee Accessibility: Improve keyboard accessibility of FilterPill (#58976) 
fix keyboard a11y in FilterPill
 2022-11-21 09:29:41 +00:00
Ashley Harrison 598935cb34 Accessibility: Improve keyboard accessibility in AnnoListPanel (#58971) 
fix keyboard accessibility in AnnoListPanel
 2022-11-21 09:25:56 +00:00
Ashley Harrison e19957bbc8 Accessibility: Improve keyboard accessibility in GettingStarted panel (#58966) 
fix keyboard a11y in `GettingStarted` panel
 2022-11-18 15:29:50 +00:00
Ashley Harrison 5226a61f67 Navigation: Stop clearing search state when opening a result in a new tab (#58880) 
search: only clear search state if not opening in a new tab
 2022-11-18 14:17:59 +00:00
Ashley Harrison d46e3916a1 Navigation: move connections + integrations to be a top level item (#58902) 
* move connections + integrations to be a top level item

* add a test to check we can move apps to the root

* split out movePlugin logic into a separate function

* fix linting

* rename movePlugin -> addPluginToSection
 2022-11-18 09:05:45 +00:00
Ashley Harrison ac66e14054 Navigation: rename Grafana Machine Learning to just Machine Learning (#58893) 
rename Grafana Machine Learning to just Machine Learning
 2022-11-17 14:31:03 +00:00
Ashley Harrison b398e8640d Navigation: Change quick add styling (#58854) 
Change quick add styling + allow for returning isOpen state to dropdown children
 2022-11-17 09:03:12 +00:00
Ashley Harrison ff1afbb699 Revert "Chore: move to node 18 (#58570)" (#58754) 
This reverts commit 0a9129cf90.
 2022-11-15 13:47:14 +00:00
Ashley Harrison 028751a18a Navigation: Add quick actions button (#58707) 
* initial implementation for quick add

* add new isCreateAction prop on NavModel

* adjust separator margin

* switch to primary button

* undo changes to plugin.json

* remove unused props from interface

* use a consistent dropdown overlay type

* memoize findCreateActions

* add prop description

* use a function so that menus are only rendered when the dropdown is open
 2022-11-15 12:08:15 +00:00
Ashley Harrison 500cf16142 Chore: fix some types (#58662) 
chore: fix some types
 2022-11-11 16:29:49 +00:00
Ashley Harrison 0bd120e01b Navigation: fix page title spacing when there is no subtitle (#58654) 
* fix page title spacing when there is no subtitle

* apply margin to whole page header
 2022-11-11 09:43:11 -05:00
Ashley Harrison 6625f6f0c8 Chore: Update .nvmrc (#58641) 
Update .nvmrc
 2022-11-11 07:21:38 -05:00
Ashley Harrison 0a9129cf90 Chore: move to node 18 (#58570) 
* bump node version to 18

* update folder to 18.x

* update README for m1 instructions

* update drone

* update unit test

* update README
 2022-11-11 11:34:00 +00:00
Ashley Harrison 9cbbe65243 Move cloud link app to the Administration section (#58578) 2022-11-10 17:02:41 +00:00
Ashley HarrisonandTorkel Ödegaard 159607fe6f Navigation: Convert PluginDetails page to use new Page extensions (#58509) 
* Added labels

* App page fixes

* Switch to switch

* wip

* Updates

* I am stuck

* Minor tweak

* This props interface could work

* removed change

* use new page extensions in plugin details page

* add link separator, fix action button spacing

* some renaming

* Move PageInfo into it's own folder + add tests

* add support for new props in old page header

* remove PluginDetailsHeader as it's no longer used

* Fix unit tests

* fix some badge alignments

* center align actions

* badge alignment + only show downloads for community/commercial plugins

* better link alignment

* conditionally render description

* move install control warnings to below subtitle + refactor

Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
 2022-11-09 14:44:38 +00:00
Ashley Harrison b3c761aaa7 Navigation: Expose new props to extend Page/PluginPage (#58465) 
* add extensions and customisation to `Page`

* adjust alignment
 2022-11-09 09:05:01 +00:00
Ashley Harrison 831ecb467c Add new PageInfo component (#58421) 2022-11-08 14:20:05 +00:00
Ashley Harrison 334b498632 group d3 updates together (#58309) 2022-11-07 10:30:23 +00:00
Ashley Harrison ca3bcc691c hide sectionnav items when collapsed, ensure focus ring overlays active items (#58250) 2022-11-04 16:42:34 +00:00
Ashley Harrison 871d98e550 hopefully improve slate test reliability (#58171) 2022-11-04 09:20:03 +00:00
Ashley Harrison c1c8dc8749 remove e2e-api-tests + axios dependency (#58148) 2022-11-03 13:52:58 +00:00
Ashley Harrison 514d3111f4 Accessibility: Enable rule jsx-a11y/no-noninteractive-element-interactions (#58077) 
* fixes for no-noninteractive-element-interactions

* remaining fixes

* add type="button"

* fix unit tests
 2022-11-03 10:55:58 +00:00
Ashley Harrison c3206167a6 increase select placeholder contrast to be WCAG AA compliant (#58034) 2022-11-03 10:45:57 +00:00
Ashley Harrison f76ba90078 Accessibility: Enable jsx-a11y/mouse-events-have-key-events (#58050) 
* implement VizLegend keyboard accessibility

* add onBlur/onFocus
 2022-11-03 10:22:50 +00:00
Ashley Harrison b8303fd431 Chore: Convert SpanTreeOffset test to RTL (#56195) 
* convert SpanTreeOffset tests to RTL (minus mouseenter/mouseleave tests)

* fix remaining tests
 2022-11-03 09:31:09 +00:00
Ashley Harrison f1f0a6f88b Revert "Update React Aria (#57975)" (#58001) 
This reverts commit 44069b64cd.
 2022-11-02 09:39:32 +00:00
Ashley Harrison e5c68f40c2 Accessibility: enable rule jsx-a11y/label-has-associated-control (#57964) 
* use labels correctly

* fix opentsdb labels

* fix unit tests

* use aria-label instead of data-testid
 2022-11-01 14:37:58 +00:00
Ashley Harrison cff6d1cf8b Chore: group some packages to reduce number of PRs (#57912) 
* group some packages to reduce number of PRs

* Group slate + slate-react together

* kick drone
 2022-11-01 11:52:17 +00:00
Ashley HarrisonandMarcus Andersson d2a70bc42d Chore: more any/type assertion improvements (#57450) 
* more friday any/type assertion improvements

* Apply suggestions from code review

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* Update public/app/angular/promiseToDigest.test.ts

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>
 2022-10-25 11:04:35 +02:00
Ashley Harrison 7e631e7239 A11y: Enable jsx-a11y/interactive-supports-focus (#57391) 
* first batch of fixes for interactive-supports-focus

* remove role and aria attributes since this won't be focusable to a screenreader anyway
 2022-10-21 13:52:46 +01:00
Ashley Harrison 630c18d79d make border-radius part of the base styles so focus styles are consistent (#57353) 2022-10-20 13:34:14 +01:00
Ashley Harrison 2987734832 only get organizations if user is signed in (#57279) 2022-10-19 14:24:52 +01:00
Ashley Harrison 96660992f4 Navigation: Ignore null children in ToolbarButtonRow (#57201) 
* filter out any null buttons to prevent padding being added for them

* ignore null children in toolbarbuttonrow
 2022-10-19 10:00:57 +01:00
Ashley Harrison 178b05160a make betterer a required step on PRs again (#57099) 2022-10-18 12:22:13 +01:00
Ashley Harrison 3cca8e3676 any/type assertion fixes (#57009) 2022-10-17 10:10:10 +01:00
Ashley Harrison a904372269 Accessibility: enable rule jsx-a11y/no-noninteractive-element-to-interactive-role (#56870) 
* enable rule `jsx-a11y/no-noninteractive-element-to-interactive-role` and switch to extending recommended preset

* fix unit tests

* better unit test
 2022-10-14 11:02:01 +01:00
Ashley Harrison 5af36e48ba convert ThresholdsEditor to RTL (#56791) 2022-10-13 08:56:36 +01:00
Ashley Harrison 61fd369b3f ensure the first item in the sectionnav is always the section root (#56815) 2022-10-12 17:02:31 +01:00
Ashley Harrison 8846778f9b fix title of config node (#56810) 2022-10-12 16:37:14 +01:00
Ashley Harrison 7d18460d8f Chore: convert MetricSelect test to RTL (#56801) 
* convert MetricSelect test to RTL

* remove type param
 2022-10-12 16:33:12 +01:00
Ashley Harrison dd9e1498f9 only render direct children on the landing page routes (#56720) 2022-10-12 10:01:33 +01:00
Ashley Harrison 90cf76e05e Navigation: Integrate Explore actions into topnav (#56381) 
* integrate Explore actions into topnav toolbar

* add keys

* fix unit test

* fix bug with ToolbarButtonRow overflow

* make the render function a bit more readable

* fix overflow not updating when children change
 2022-10-11 12:59:17 +01:00
Ashley Harrison 8348f486d9 Navigation: Make sure topnav is translated (#56643) 
* initial translation progress

* more nav translations

* add subtitle translations

* more specific gitignore path

* fix unit tests
 2022-10-11 11:45:58 +01:00
Ashley Harrison ff41b9544b Chore: more typing improvements to @grafana/ui (#56544) 
* improve grafana-ui types

* more type improvements

* better useState type
 2022-10-07 15:22:21 +01:00
Ashley Harrison c5171b84a0 actually convert Cloudwatch ConfigEditor test to RTL (#56461) 2022-10-06 12:14:41 +01:00
Ashley HarrisonandTorkel Ödegaard 78a57f2064 Navigation: use ToolbarButton in TopSearchBar for consistency (#56371) 
* use ToolbarButton in TopSearchBar for consistency

* Removed unnessary styles

Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
 2022-10-05 12:22:47 +01:00
Ashley Harrison 7ac7f844f4 improve some grafana-ui types (#56318) 2022-10-05 09:04:10 +01:00
Ashley Harrison d293055ef6 enable rule jsx-a11y/iframe-has-title (#56292) 2022-10-04 16:04:28 +01:00
Ashley Harrison d3f50f791c Convert test to RTL (#56279) 2022-10-04 15:37:47 +01:00
Ashley Harrison e942a3d99d enable jsx-a11y/no-autofocus (#56288) 2022-10-04 12:54:14 +01:00
Ashley Harrison ab09f2783c fix section root styling, parentItem will be the home item now (#56266) 2022-10-04 11:17:12 +01:00
Ashley Harrison 7e5509891a Navigation: adjust megamenu position in mobile (#56262) 
* adjust megamenu position in mobile

* improve mobile breadcrumb logic
 2022-10-04 10:40:34 +01:00
Ashley Harrison 317b353b34 Navigation: Collapsible section nav implementation (#55995) 
* initial collapsible section nav implementation

* fix unit tests

* automatically collapse sectionnav when below lg size

* fix unit tests

* only register 1 event listener each time

* fix display name for SectionNavToggle
 2022-10-04 09:19:23 +01:00
Ashley Harrison 8984507291 Navigation: show breadcrumbs correctly when on the home page (#55759) 
* show breadcrumbs correctly when on the home page

* adjust breadcrumb unit tests

* update betterer

* fix backend tests

* update getSectionRoot to look at the home nav id

* remove redundant setting of home dashboard

* construct a home navmodelitem in the backend

* fix cases when the feature toggle is off

* fix unit test

* fix more unit tests

* refactor how buildBreadcrumbs works

* use HOME_NAV_ID

* move homeNav useSelector into NavToolbar

* remove unnecesary cloneDeep

* don't need locationUtil here

* restore using getUrlForPartial in DashboardPage

* special case for the editview query param

* remove commented out code

* add comment to clarify splice behaviour

* slightly cleaner syntax
 2022-10-03 15:05:19 +01:00
Ashley Harrison f2b06abb33 Convert SpanDetail/index.test.js to RTL (#56019) 2022-10-03 10:22:50 +01:00
Ashley Harrison 3e688ecf7d Navigation: remove description from the backend navmodel and use subTitle instead (#56155) 
* remove description from the backend navmodel and use subTitle instead

* only add admin subtitle in topnav
 2022-10-03 10:09:32 +01:00
Ashley Harrison 5b1fdd535a Accessibility: turn on jsx-a11y/no-noninteractive-tabindex + fix/ignore errors (#56084) 
* turn on jsx-a11y/no-noninteractive-tabindex + fix/ignore errors

* update comments
 2022-09-30 13:20:39 +01:00
Ashley Harrison 27abc32608 fix lockfile (#56003) 2022-09-29 06:52:33 -04:00
Ashley Harrison 97f1524b66 Chore: move the a11y rules to the overrides section so they don't apply to t… (#55848) 
* move the a11y rules to the overrides section so they don't apply to tests

* turn alt-text back off
 2022-09-27 16:59:35 +01:00
Ashley Harrison 11eb02a183 enable rule role-has-required-aria-props (#55841) 2022-09-27 11:17:26 -04:00
Ashley Harrison 527c00dae5 enable rule jsx-a11y/role-supports-aria-props (#55839) 2022-09-27 15:42:46 +01:00
Ashley Harrison 422b22a513 enable img-redundant-alt rule (#55833) 2022-09-27 10:26:32 -04:00
Ashley Harrison afdb094983 turn on tabindex-no-positive rule (#55830) 2022-09-27 15:18:24 +01:00
Ashley Harrison 1a830e6f45 don't add folder breadcrumb if there is no folderUid (#55739) 2022-09-26 14:02:50 +01:00
Ashley Harrison 366731d8d9 Navigation: Add descriptions to NavModelItems (#55669) 
* add some descriptions!

* Update some descriptions

* Tweak playlist description

* fix unit tests + betterer
 2022-09-23 16:08:08 +01:00
Ashley Harrison c65a8d3cab reenable active state for home (#55566) 2022-09-23 16:03:01 +01:00
Ashley Harrison 480a3b92d2 dispatch clearFilters when an item is selected (#55512) 2022-09-23 14:46:21 +01:00
Ashley Harrison 80c49688a1 turn on all the rules that are working anyway (#55679) 2022-09-23 09:18:23 -04:00
Ashley Harrison 717e9b0a34 add eslint-plugin-jsx-a11y (#55677) 2022-09-23 14:02:16 +01:00
Ashley Harrison cf19baf80f improve responsiveness of breadcrumbs (#55572) 2022-09-21 15:52:06 +01:00
Ashley Harrison 1978b935ba remove underlay fade out animation (#55578) 2022-09-21 10:42:08 -04:00
Ashley Harrison bd19a06fa9 Update create/edit playlist pages to work with topnav (#55104) 2022-09-13 16:18:50 +01:00
Ashley Harrison 14d4e0eeca set font-weight correctly (#55074) 2022-09-13 13:34:02 +02:00
Ashley Harrison 031c186617 convert AlertRuleList test to RTL (#55045) 2022-09-13 09:29:29 +01:00
Ashley Harrison b90260b3ae Chore: convert LogRowContextProvider tests to RTL (#55031) 
* convert LogRowContextProvider tests to RTL

* remove act
 2022-09-12 15:00:09 +01:00
Ashley Harrison 4c3e08db91 Chore: Convert ShareLink tests to RTL (#55026) 
* Convert ShareLink tests to RTL

* use findByRole instead of findByLabelText to be more robust
 2022-09-12 14:34:06 +01:00
Ashley Harrison 58e17f8144 CustomScrollbar: Add optional scroll indicators to CustomScrollbar (#54705) 
* Add general scroll indicator behaviour to CustomScrollbar

* Extract ScrollIndicators logic into it's own file

* add scroll indicators to MegaMenu
 2022-09-12 11:18:45 +01:00
Ashley Harrison cc5f8b9180 bump eslint sdk (#54968) 2022-09-12 10:00:09 +01:00