Serge Zaitsev
0bdb105df2
Chore: Remove xorcare/pointer dependency ( #63900 )
...
* Chore: remove pointer dependency
* fix type casts
* deprecate xorcare/pointer library in linter
* rooky mistake
2023-03-06 05:23:15 -05:00
Serge Zaitsev
2f8ee38c5e
Chore: Let wire inject prometheus.Registerer ( #62195 )
...
let wire inject prometheus.Registerer
2023-02-28 16:12:23 +01:00
Serge Zaitsev
b1c98f7119
Chore: Remove result field from alert commands and queries ( #62714 )
...
* remove result field from alert notification commands and queries
* fix a few more tests
* ok, linter
* remove alert result fields
* fix api calls
* et tu, linter
2023-02-02 09:41:05 +01:00
Serge Zaitsev
427db55204
Chore: Fix goimports order in RelEng packages ( #62481 )
...
fix goimports order
2023-01-30 15:53:38 +01:00
Serge Zaitsev
907e2a840e
Chore: Fix goimports grouping ( #62429 )
...
* fix goimports ordering
* fix goimports order
2023-01-30 09:57:50 +01:00
Serge Zaitsev
d6d4097567
Chore: Fix goimports grouping in alerting ( #62424 )
...
* fix goimports
* fix goimports order
2023-01-30 09:55:35 +01:00
Serge Zaitsev
0bf4093005
Chore: Fix goimports grouping ( #62428 )
...
* fix goimports order
* fix goimports order
2023-01-30 08:50:27 +00:00
Serge Zaitsev
f8ec35e643
Chore: Fix goimports grouping ( #62427 )
...
* fix goimports order
* fix goimports order
2023-01-30 09:38:51 +01:00
Serge Zaitsev
7dbd2cd139
Chore: Fix goimports grouping ( #62426 )
...
fix goimports ordering
2023-01-30 09:34:18 +01:00
Serge Zaitsev
f531074d89
Chore: Fix goimports grouping in pkg/infra ( #62421 )
...
* fix goimports
* fix goimports order
2023-01-30 08:32:25 +00:00
Serge Zaitsev
aebcecf538
Chore: Fix goimports grouping in other backend platform packages ( #62422 )
...
* fix goimports
* fix goimports order
* fix goimports order
* fix goimports order
* fix goimports order
* fix goimports order
2023-01-30 08:26:42 +00:00
Serge Zaitsev
e2d49ea17f
Chore: Fix goimports grouping ( #62423 )
...
* fix goimports
* fix goimports order
2023-01-30 08:25:58 +00:00
Serge Zaitsev
bc2813ef06
Chore: Fix goimports grouping in pkg/services ( #62420 )
...
* fix goimports
* fix goimports order
2023-01-30 08:21:27 +00:00
Serge Zaitsev
324310abbc
Chore: Fix goimports grouping in pkg/api ( #62419 )
...
* fix goimports
* fix goimports order
2023-01-30 08:18:26 +00:00
Serge Zaitsev
fa36591380
Chore: Remove mockstore and use dbtest instead ( #61629 )
...
* remove mockstore and use dbtest instead
* fix wire
* remove unused expected fields
* fix more tests in alerting
* fix api tests
2023-01-18 16:01:25 +01:00
Serge Zaitsev
efed0151f8
Chore: Remove pkg/models/stats.go ( #61613 )
...
* remove pkg/models/stats.go
* rename models package in tests
2023-01-17 14:17:54 +01:00
Serge Zaitsev
7e51eac740
Chore: Remove unused models ( #61533 )
...
* Chore: Remove unused models
* put AuthModuleConversion back
2023-01-16 12:52:55 +01:00
Serge Zaitsev
1d12dda7db
Chore: Update CODEOWNERS ( #60724 )
...
* Chore: Update CODEOWNERS
* remove comment
2022-12-23 08:46:17 -05:00
Serge Zaitsev
af7d293eaf
Chore: Remove Store interface and use db.DB instead ( #60160 )
...
* Chore: Remove Store interface and use db.DB instead
* use old-style session exec
2022-12-13 11:03:36 +01:00
Serge Zaitsev
43f40e6c7c
Chore: Replace yaml.v2 with yaml.v3 ( #59897 )
...
* replace yaml.v2 with yaml.v3
* fix a few tests due to the yaml.v3 api changes
* and another goconvey mistake in tests
2022-12-06 21:17:17 +01:00
Serge Zaitsev
f1fb202284
Chore: Add encryption codec to the remote cache ( #59871 )
...
* add encryption codec to the remote cache
* change config files too
* fix test constructor
* pass codec into the test cache
2022-12-06 15:12:27 +01:00
Serge Zaitsev
3978502d83
Chore: Remote cache key prefix ( #59838 )
...
* attempt to implement a remote cache key prefix
* add a test for the prefix store
* oh, linter
2022-12-06 13:20:49 +01:00
Serge Zaitsev
b3284a8330
Chore: Make getUserOrgList private to sqlstore ( #59654 )
...
* make getUserOrgList private in sqlstore
* make other identifiers private
2022-12-01 15:46:42 +01:00
Serge Zaitsev
5f3291be03
Chore: remove GetTeamByUser ( #59604 )
...
here goes some unused code
2022-11-30 20:02:31 +01:00
Serge Zaitsev
9cdb6b07c7
Chore: Move stats service into a standalone packge from sqlstore ( #59574 )
...
* move original stats service into a separate package
* add stats service to wire
* move GetAdminStats
* switch to using stats.Service
* add missing package
* fix api tests
2022-11-30 18:11:07 +01:00
Serge Zaitsev
57fbe264ea
Chore: Remove CreateOrg from alerting and use orgStore instead ( #59440 )
2022-11-29 09:59:03 +01:00
Serge Zaitsev
5b861faec3
Chore: Reduce the usage of sqlstore.createorg and use orgservice instead ( #59356 )
...
* remove legacy createorg from org service
* remove another createorg from orgimpl
* remove createorg from api pref tests
* remove createorg from api org tests
* fix tests
* remove createorg from annotations test
* remove createorg from team tests
* remove createorg from service accounts
* remove createorg from accesscontrol tests
* remove createorg from provisioning
* Use quotaservice from sc.hs
2022-11-28 12:05:46 +01:00
Serge Zaitsev
cff36ea7d8
Chore: Remove unused method from sqlstore ( #59156 )
...
remove unused method
2022-11-24 05:21:06 -05:00
Serge Zaitsev
c2e847d0b0
Chore: Remove createorgwithmember ( #59161 )
...
remove createorgwithmember
2022-11-23 10:37:04 +01:00
Serge Zaitsev
245a59548c
Chore: Remove DeleteOrg method from sqlstore ( #59162 )
...
remove DeleteOrg method from sqlstore
2022-11-23 10:22:52 +01:00
Serge Zaitsev
b875ca08c6
SQLStore: Make addOrgUser private ( #59142 )
...
make addOrgUser private
2022-11-22 17:02:39 +00:00
Serge Zaitsev
7ff41cde9a
Chore: Fix status codes for nested folders ( #59087 )
...
* check for errutil errors first
* a better fix
2022-11-22 16:06:39 +02:00
Serge Zaitsev
53baecd71f
Chore: Move folder service into a separate package ( #56591 )
...
* Chore: move folder service interface into a separate package
* copy implementation into a standalone package
* move implementation and tests to the new folder package
* remove leftovers from wire
* add test doubles for folder service
* fix tests in library panels/elements
* fix provideservice in ngalert
2022-10-10 21:47:53 +02:00
Serge Zaitsev
169610fd27
Chore: Reduce test timeouts to 5 minutes ( #56599 )
2022-10-10 09:26:47 +02:00
Serge Zaitsev
4c19e83ff0
Chore: Move team store implementation to a separate package ( #55514 )
...
* Chore: move team store implementation to a separate package
* trying to fix more tests
* fix tests in service accounts and access control
* fix common tests
* restore commented out test
* add todos
2022-09-22 19:16:21 +02:00
Serge Zaitsev
305d494902
Chore: Switch over to team.Service instead of sqlstore ( #55497 )
...
* switch to using team service
* trying to fix tests
* more tests to fix
* add missing teamtest package
2022-09-20 18:58:04 +02:00
Serge Zaitsev
2ee3fd3994
Chore: Create structure for team service ( #55444 )
2022-09-20 10:14:00 +00:00
Serge Zaitsev
8f1e2ed658
Chore: Split temporary user (invite) service ( #55397 )
...
* Chore: Split temporary users
* change references to tempuser service
* fix api tests
* restore tests
2022-09-20 11:29:17 +02:00
Serge Zaitsev
7108b4331d
Fix: return proper values in dashboard thumbs service ( #55421 )
2022-09-20 00:29:55 +02:00
Serge Zaitsev
96b032e103
Chore: Split dashboard thumbnail service ( #55344 )
...
* Chore: split dashboard thumbnail service
* fix typo
* move tests
* make linter happy
2022-09-19 11:29:22 +02:00
Serge Zaitsev
927ddf9376
Chore: Move login attempt methods to separate service ( #54479 )
...
* Chore: Move login attempt methods to separate service
* attempt to fix tests
* fix syntax
* better time mocking
* initialise now func
2022-09-01 18:08:42 +02:00
Serge Zaitsev
72367f99cf
Chore: Move plugin settings store code into a dedicated service ( #53560 )
2022-08-11 09:50:53 +02:00
Serge Zaitsev
6e4b537ba6
Chore: Remove datasources from the Store interface ( #53515 )
2022-08-10 15:04:51 +02:00
Serge Zaitsev
191ab3bb01
Chore: Move api key models into apikey service package ( #53241 )
...
* Chore: move api key models into apikey service package
* force table name for api key
2022-08-04 14:19:09 +02:00
Serge Zaitsev
8d36f71673
Chore: Remove apikey store methods from sqlstore ( #53197 )
...
* Chore: remove apikey store methods from sqlstore
* remove GetAPIKeys
* remove GetAllAPIKeys
* remove the rest of apikey from sqlstore
2022-08-03 08:13:05 -04:00
Serge Zaitsev
64488f6b90
Chore: split APIKey store ( #52781 )
...
* move apikey store into a separate service
* add apikey service to wire graph
* fix linter
* switch api to use apikey service
* fix provideservice in tests
* add apikey service test double
* try different sql syntax
* rolling back the dialect
* trigger drone
* trigger drone
2022-08-02 16:55:19 +02:00
Serge Zaitsev
ae9491c3a7
Chore: Make test tracer noop and return no errors ( #50797 )
2022-06-15 12:40:41 +02:00
Serge Zaitsev
0b55c41d05
Chore: Remove global bus variable ( #50765 )
...
* Chore: Remove global bus variable
* fix bus in tests
2022-06-14 16:07:41 +02:00
Serge Zaitsev
31ff23f542
Fix: add default nop trace exporter to opentelemetry ( #48869 )
2022-05-10 11:29:36 +02:00
Serge Zaitsev
e9a2a06651
Chore: do not run husky hooks on backend-only changes ( #48439 )
2022-04-29 14:01:02 +01:00
Serge Zaitsev and Ying WANG
41012af997
Tracing: Use common traceID context value for opentracing and opentelemetry ( #46411 )
...
* use common traceID context value for opentracing and opentelemetry
* support sampled trace IDs as well
* inject traceID into NormalResponse on errors
* Finally the test passed
* fix the test
* fix linter
* change the function parameter
Co-authored-by: Ying WANG <ying.wang@grafana.com >
2022-04-14 17:54:49 +02:00
Serge Zaitsev
e86b6662a1
Chore: Remove bus.Bus field ( #47695 )
...
* Chore: Remove bus.Bus field
* fix integration test
2022-04-13 15:24:13 +02:00
Serge Zaitsev
18e93c7077
Chore: Remove bus ( #47511 )
...
* Chore: Remove bus
* remove unused const
2022-04-08 16:15:06 +02:00
Serge Zaitsev
b31c7d3654
Chore: Remove bus from alerting rule ( #47508 )
...
* Chore: Remove bus from alerting rule
* fix alerting tests
* fix provide service
2022-04-08 14:30:25 +02:00
Serge Zaitsev
ad432108e6
Chore: Remove bus from dashboards provisioning ( #47495 )
...
* Chore: Remove bus from dashboards provisioning
* fix symlink test, make it run on darwin
* remove unused mock
2022-04-08 13:56:38 +02:00
Serge Zaitsev
2cf88cfec8
Chore: Remove bus from contexthandler ( #47458 )
...
* Chore: remove bus from contexthandler
* remove bus from orgredirect
2022-04-08 10:33:19 +02:00
Serge Zaitsev
d153d896c5
Chore: Remove bus from contexthandler ( #47374 )
...
* Chore: Remove bus from contexthandler
* fix tests
* try different wire binding
* maybe remove a few more dispatches
* fix tests
2022-04-06 16:31:26 +02:00
Serge Zaitsev
3a7fc80948
Chore: Remove last bus parts from login package ( #47313 )
...
* Chore: Remove last bus parts from login package
* fix middleware tests
2022-04-06 08:45:01 +02:00
Serge Zaitsev
bf9e0e8bc8
Chore: Remove some bus from login package (login attempts) ( #47310 )
2022-04-05 13:07:27 +02:00
Serge Zaitsev and Emil Tullstedt
33006436cc
Chore: Remove bus.Dispatch from some login packages ( #47248 )
...
* Chore: Remove bus.Dispatch from some login packages
* remove debug log
Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com >
* remove login.Init()
* remove unused reset function
* remove AuthenticateUserFunc global
* swap conditional branches
Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com >
* fix formatting
Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com >
2022-04-04 20:36:15 +02:00
Serge Zaitsev
4ce7978cd8
Chore: Remove bus from notification service ( #46813 )
...
* Chore: Remove bus from notification service
* fix signature
* fix function signature in tests
2022-03-22 09:04:30 +01:00
Serge Zaitsev
9315ddd57c
Chore: Remove bus from oauthtoken ( #46811 )
2022-03-21 21:13:57 +01:00
Serge Zaitsev
cce46a6349
Chore: Remove bus from live package ( #46803 )
2022-03-21 20:34:19 +01:00
Serge Zaitsev
df465ccad3
Chore: Remove bus from thumbs service ( #46772 )
2022-03-21 14:15:31 +01:00
Serge Zaitsev
fec634a091
Chore: Remove bus.Dispatch from guardian package ( #46711 )
...
* replace bus in guardian with sqlstore
* fix a couple of tests
* replace bus in the rest of the tests
* allow init guardian from other packages
* make linter happy
* init guardian in library elements
* fix another test in libraryelements
* fix more tests
* move guardian mock one level deeper
* fix more tests
* rename init functions
2022-03-21 10:49:49 +01:00
Serge Zaitsev
893f9e8ee4
use datasource service instead of store in provisioning ( #45835 )
2022-02-25 15:56:44 +00:00
Serge Zaitsev
c1239ee67c
Chore: Remove bus from authinfoservice ( #45787 )
2022-02-23 16:22:16 +01:00
Serge Zaitsev
a231c6861c
Chore: Remove bus.Dispatch from provisioning services ( #44989 )
...
* make getordbyname a method
* remove one dispatch from plugins provisioner
* remove bus from the plugins provisioner, skip test for now
* remove bus from datasource provisioning
* resolve tests in notifier provisioning
* remove bus from the dashboards provisioning service
* fix missing struct field
* fix getorgbyid method calls
* pass org store into dashboard provisioner
* fix test function prototype
* fix tests
* attempt to fix tests after the rebase
* fix integration test
* avoid using transaction
* remove comments
2022-02-23 11:12:37 +01:00
Serge Zaitsev
b9e5bae51f
Chore: Remove bus.Dispatch from cleanup service ( #45401 )
2022-02-15 14:56:19 +01:00
Serge Zaitsev
9d654bb6b8
Chore: Remove bus from plugin proxy api ( #44899 )
...
* remove bus from plugin proxy api
* fixing the tests
2022-02-04 17:35:00 +01:00
Serge Zaitsev
61533a3cb4
Chore: Remove bus from health api ( #44897 )
...
* remove bus from health api
* fix health api tests
* use db health query as a method
* use pointer in sqlstore mock
2022-02-04 14:33:35 +01:00
Serge Zaitsev
058e3ffc21
Chore: Remove bus from Alerting API ( #44894 )
...
* assign handlers to httpserver
* turn sqlstore mock in to a pointer
* add search service interface
* fix tests for alerting and other apis
* once again, make linter happy
2022-02-04 13:41:15 +01:00
Serge Zaitsev
43b15b92ad
Chore: Remove bus from the alerting service ( #44496 )
...
* propagate notificationservice down to the notifiers
* replace dispatch in result handler
* remove dispatch from the rule reader
* remove dispatch from eval context
* remove dispatch from alerting usage
* remove dispatch from alerting usage
* remove dispatch from notifier
* attempt to fix tests in alerting
* hello linter, my old friend; also disable some tests for now
* use mocks to fix the tests
* resolving wire providers
* make linter happy
* remove yet another bus.dispatch
* fix tests using store mock
2022-02-03 13:26:05 +01:00
Serge Zaitsev
84a5910e56
Chore: Remove bus from ngalert ( #44465 )
...
* pass notification service down to the notifiers
* add ns to all notifiers
* remove bus from ngalert notifiers
* use smaller interfaces for notificationservice
* attempt to fix the tests
* remove unused struct field
* simplify notification service mock
* trying to resolve issues in the tests
* make linter happy
* make linter even happier
* linter, you are annoying
2022-01-26 16:42:40 +01:00
Serge Zaitsev
f5802878f1
Chore: Move remaining web framework code to pkg/web, remove macaron binding module ( #43018 )
...
* remove macaron binding dependency
* completely purge macaron binding
* move everything to pkg/web
* remove non-go files from pkg/web
* clean up leftovers of macaron imports
* make linter happy
2021-12-13 15:56:14 +01:00
Serge Zaitsev
95831e9be0
Fix: Restore data binding in the create dashboard handler
2021-11-29 19:05:20 +01:00
Serge Zaitsev
d9cdcb550e
Chore: Refactor api handlers to use web.Bind ( #42199 )
...
* Chore: Refactor api handlers to use web.Bind
* fix comments
* fix comment
* trying to fix most of the tests and force routing.Wrap type check
* fix library panels tests
* fix frontend logging tests
* allow passing nil as a response to skip writing
* return nil instead of the response
* rewrite login handler function types
* remove handlerFuncCtx
* make linter happy
* remove old bindings from the libraryelements
* restore comments
2021-11-29 10:18:01 +01:00
Serge Zaitsev
993c60d36e
Chore: Remove GoConvey dependency ( #41146 )
2021-11-01 14:56:18 +01:00
Serge Zaitsev
7b15cd0ed2
Chore: Refactor GoConvey in provisioning package ( #40892 )
...
* refactor goconvey in some provisioning subpackages
* fix goconvey in provisioning/datasources
* remove goconvey from notifiers subpackage
* finally resolve goconvey in dashboards subpackage
2021-11-01 11:31:55 +01:00
Serge Zaitsev
995afa2221
Chore: Refactor GoConvey in auth package ( #40850 )
...
* refactor goconvey in auth package
* make linter happy
2021-10-27 16:08:21 +02:00
Serge Zaitsev
690849cfd6
Chore: Refactor GoConvey in services dashboards package ( #40895 )
2021-10-27 08:17:50 -05:00
Serge Zaitsev
00da702970
Chore: Refactor GoConvey in the guardian package ( #40898 )
2021-10-27 07:45:20 -05:00
Serge Zaitsev
35432b1183
Chore: Refactor GoConvey in tsdb package ( #40847 )
2021-10-27 11:56:34 +02:00
Serge Zaitsev
24a74cd06e
Chore: Refactor GoConvey tests in alerting/conditions ( #40843 )
...
* refactor goconvery tests
* use more meaningful assertion
* use more meaningful assertions
2021-10-26 23:24:58 +02:00
Serge Zaitsev
125e284da2
Chore: Refactor GoConvey in notification service package ( #40897 )
...
* refactor goconvey in notification service package
* avoid return after t.skip
2021-10-26 18:08:04 +02:00
Serge Zaitsev and ying-jeanne
1f1162f1d8
Chore: Refactor GoConvey in teamguardian package ( #40896 )
...
* refactor goconvey in teamguardian package
* use proper order of parameters in equality assertion
Co-authored-by: ying-jeanne <74549700+ying-jeanne@users.noreply.github.com >
Co-authored-by: ying-jeanne <74549700+ying-jeanne@users.noreply.github.com >
2021-10-26 17:59:37 +02:00
Serge Zaitsev
22b428836e
Chore: Refactor GoConvey in setting package ( #40861 )
2021-10-26 13:19:07 +02:00
Serge Zaitsev
16046f6d43
Chore: Refactor GoConvey tests in mssql package ( #40859 )
2021-10-26 13:18:43 +02:00
Serge Zaitsev
249856e527
Chore: Refactor GoConvey in mysql package tests ( #40855 )
2021-10-26 13:18:17 +02:00
Serge Zaitsev
a45861298f
Chore: Refactor GoConvey in tsdb/es/client ( #40846 )
2021-10-26 13:15:47 +02:00
Serge Zaitsev
5409c88fb8
Chore: Refactor GoConvey in alerting tests ( #40845 )
2021-10-26 13:15:09 +02:00
Serge Zaitsev
a97e4d28a4
Chore: Refactor GoConvey in azuremonitor package ( #40878 )
2021-10-25 17:08:24 +02:00
Serge Zaitsev
76e30c5e97
Chore: Refactor alerting notifier tests to remove goconvey ( #40758 )
2021-10-21 17:04:43 +02:00
Serge Zaitsev
2f0fe16759
Chore: Remove GoConvey from sqlstore package ( #40753 )
...
* refactor login attempt test
* refactor tags saving test
* refactor transaction tests
* refactor temporary user tests
* refactor dashboard version tests
* refactor dashboard provisioning tests
* refactor alert notification test
* refactor alert tests
* refactor acl tests
2021-10-21 14:09:19 +02:00
Serge Zaitsev
e47d7532e5
Chore: Goconvey migration for cleanup package ( #40547 )
2021-10-20 21:14:48 +08:00
Serge Zaitsev
7bad00118a
Chore: Replace goconvey in multildap package ( #40681 )
2021-10-20 15:07:37 +02:00
Serge Zaitsev
57fcfd578d
Chore: replace macaron with web package ( #40136 )
...
* replace macaron with web package
* add web.go
2021-10-11 14:30:59 +02:00
Serge Zaitsev
3131388084
Chore: Imperative request data binding ( #39837 )
...
* rename Bind to BindMiddleware
* make things private
* removed unused part of data bindings
* provide json and form binding helpers
* add example of binding migration in login api
* implement validation
* fix tests
* remove debug output
* put new bind api into macaron pacakge
* revert bind api breaking change
2021-10-06 12:52:27 +02:00
Serge Zaitsev
dfbd7bf64f
Chore: Update goxmldsig dependency ( #39566 )
2021-09-23 12:33:31 +02:00
Serge Zaitsev
6005e6572d
Chore: fix param names in ctx.ParamsInt64 ( #39223 )
2021-09-15 12:14:15 +02:00