Commit Graph
100 Commits
Author SHA1 Message Date
Ashley Harrison 3f1e97cb07 NestedFolderPicker: Add clearable prop (#81114)
* add clearable prop to NestedFolderPicker

* update types
2024-01-24 13:18:01 +00:00
Ashley Harrison e84ee33c8b NestedFolderPicker: Debounce search correctly (#80956)
* debounce nested folder picker search

* readd logic when no search string
2024-01-24 11:41:25 +00:00
Ashley Harrison 1cb3cc4ad1 Navigation: handle cloud id when modifying connections url (#80965)
cloud id is different than onprem... who knew?
2024-01-22 13:02:47 +00:00
Ashley Harrison b29748ac59 Chore: remove autoFocus from time range filter input (#80961)
remove autoFocus from time range filter input
2024-01-22 10:42:59 +00:00
Ashley Harrison 5f2ef36e63 Chore: make baseDir absolute in grafana-plugin-config (#80826)
make baseDir absolute
2024-01-19 09:18:48 +00:00
Ashley Harrison d72c035ea6 CommandPalette: Pass matched tag as a search query to 'Add new connection' page (#80556)
* add some special logic to pass the matched tag to the add new connection page

* extend action type to accept callback for url
2024-01-18 16:16:41 +00:00
Ashley Harrison 0a651a90e9 Chore: use GITHUB_TOKEN in metrics-collector action (#80795)
use GITHUB_TOKEN
2024-01-18 15:29:40 +00:00
Ashley Harrison a1a9813d05 Chore: Adjust stale config to start from oldest first and increase operations limit (#80791)
adjust to do oldest first and increase operations limit
2024-01-18 11:48:59 +00:00
Ashley Harrison 127decee1e Release: Deprecate latest.json and replace with api call to grafana.com (#80537)
* remove latest.json and replace with api call to grafana.com

* remove latest.json

* Revert "remove latest.json"

This reverts commit bcff43d898.

* Revert "remove latest.json and replace with api call to grafana.com"

This reverts commit 02b867d84e.

* add deprecation message to latest.json
2024-01-16 11:19:32 +00:00
Ashley Harrison 767029a43d use exposed interface from rc-tooltip 2024-01-16 12:25:31 +02:00
Ashley Harrison 406ace27c0 Chore: remove merge conflict from .betterer.results (#80563)
remove merge conflict
2024-01-15 16:19:16 +00:00
Ashley Harrison d5db67a073 Chore: type improvements (#80464)
* type improvements

* some more fixes

* add TODOs to remove type assertions
2024-01-15 14:29:39 +00:00
Ashley HarrisonandJosh Hunt ec53487c99 NestedFolderPicker: separate toggle to force enable picker without nestedFolders (#80461)
* separate nestedFolderPickerOverride toggle to force enable it without nestedFolders

* let's call it newFolderPicker

* update unit tests and keyboard handling

* reduce spacing when no folder open chevron

---------

Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com>
2024-01-15 11:43:19 +00:00
Ashley Harrison 15af2e5053 Connections: Pass keywords from the backend to CommandPalette (#80276)
* pass keywords from the backend to CommandPalette

* add csv and json to keywords
2024-01-15 11:30:55 +00:00
Ashley Harrison 083605c17f DockedMenu: only set the menu state to be docked if the window size is big enough (#80379)
* only set the menu docked in state if the window size is big enough

* adjust sizes

* remove top border on dockedMegaMenu

* another css tweak

* use xxl consistently

* CONSISTENTLY

* ok maybe not
2024-01-15 10:12:41 +00:00
Ashley Harrison 21200fd5f8 Chore: Mock out faro so this test doesn't throw an error (#80477)
mock out faro for all tests
2024-01-15 09:43:53 +00:00
Ashley Harrison 12135998e6 Profile: Use Stack so the profile tabs span the full width of the page (#80353)
use Stack so the profile tabs span the full width of the page
2024-01-11 12:54:19 +00:00
Ashley Harrison 310ad0474c Chore: Update stale config to run on issues as well (#80024)
* update stale config to run on issues as well

* add issue write permissions
2024-01-11 10:57:54 +00:00
Ashley Harrison 1162c28a55 Connections: hook up search to url params to match cloud behaviour (#80166)
hook up connections search to url params to match cloud behaviour
2024-01-10 09:57:17 +00:00
Ashley Harrison 58f4533382 Chore: Better renovate config (#80202)
* better config

* allow react-hook-form updates
2024-01-09 13:00:46 +02:00
Ashley Harrison 76ca1c6379 Chore: Update lockfile resolution to newer version of follow-redirects (#80199)
update lockfile resolution to newer version of follow-redirects
2024-01-09 12:35:16 +02:00
Ashley Harrison cb43246fcb Chore: update renovate config to automerge >v1 patch updates (#80092)
update renovate config to automerge >v1 patch updates
2024-01-09 10:06:57 +00:00
Ashley Harrison 68ba6cc67b Chore: some type fixes (#80094)
* some type fixes

* few more fixes

* more

* fix unit test
2024-01-09 10:00:00 +00:00
Ashley Harrison 5154a9d99c Chore: wait for component to render properly to prevent act warning (#80016)
wait for component to render properly to prevent act warning
2024-01-04 11:25:48 +00:00
Ashley Harrison d680a020cc Command Palette: Adjust command palette extensions priority (#79992)
adjust command palette extensions priority
2024-01-03 16:18:27 +00:00
Ashley Harrison 54369158ce Betterer: update results file (#79979)
update results file
2024-01-03 13:21:36 +00:00
Ashley Harrison 9de79fb5e9 Chore: remove react-popper-tooltip in favour of @floating-ui/react (#79465)
* use floating-ui instead of react-popper-tooltip in Tooltip

* remove useTheme2 usage

* remove escape handling logic in favour of useDismiss

* don't need this useEffect anymore

* convert Toggletip to use floating-ui

* use explicit version

* convert OperationInfoButton to use Toggletip

* convert nestedFolderPicker to use floating-ui

* convert Dropdown to use floating-ui and remove react-popper-tooltip

* fix Modal/Tooltip tests

* revert to old toggletip behaviour

* revert OperationInfoButton to not use Toggletip

* add mock for requestAnimationFrame

* remove requestAnimationFrame mock

* remove fakeTimers where they're not used

* use floating-ui in ButtonSelect

* Fix filters unit tests

* only attach description if label is different

* use 'fixed' strategy for Toggletip

* use stroke and strokeWidth

* set move: false to only show the tooltip if a hover event occurs

* update type for onClose
2024-01-03 12:42:26 +00:00
Ashley Harrison 09445e0ecc Page: Use bouncing logo instead of loading spinner for fallback (#79028)
* use bouncing logo instead of loading spinner for page loader

* translate loading text

* update unit test

* extract bouncing logo out into component
2023-12-15 13:35:42 +00:00
Ashley Harrison d60078fc90 Navigation: Update frontend and app o11y icons (#79454)
* use frontend o11y icon when docked

* update app o11y icon
2023-12-13 18:49:04 +02:00
Ashley Harrison a221ebf7cc Revert "Betterer: Add rule for gf-form (#79303)" (#79445)
This reverts commit 7a38a5ab1d.
2023-12-13 12:26:17 +01:00
Ashley Harrison 1efd21c08a Data sources: Add skeleton loader (#79016)
* refactor out DataSourcesListCard

* add skeleton

* increase gap between buttons on skeleton to match real component

* lineHeight: 1 instead of 0

* refactor out ternary
2023-12-13 09:50:27 +00:00
Ashley Harrison ffda25f4a3 Skeleton: Abstract out attach/animation logic (#79309)
* apply styles globally to skeleton

* use abstraction everywhere

* just use withSkeleton

* add comment

* update docs

* use it in News as well

* rename withSkeleton to attachSkeleton

* move to @grafana/ui/src/unstable

* rename skeletonProps to rootProps
2023-12-12 11:05:36 +00:00
Ashley Harrison 7c2b3ee1af Navigation: Update synthetics placement in IA (#79302)
* update synthetics placement in IA

* lowercase s in synthetics
2023-12-12 10:57:52 +00:00
Ashley Harrison bb4aa16b13 Navigation: Fix showing command palette when menu is docked (#79335)
* fix showing command palette when menu is docked

* separate out command palette
2023-12-11 18:54:56 +02:00
Ashley Harrison 05dcc7a441 Navigation: Independent docked state (#78954)
* initial start

* more progress

* behaviour working?

* only use media query when docked local storage state is true

* close menu when undocking

* remove unneeded animation code and fix focus when toggling between docked/undocked

* better feature toggle handling (can go back and forth)

* remove restoreFocus (for now)
2023-12-11 11:41:14 +00:00
Ashley Harrison bae9dbe418 News: Add loading skeleton (#79009)
* convert to emotion object syntax

* add news skeleton
2023-12-11 10:43:36 +00:00
Ashley Harrison 7ddcd0c961 Settings: Add skeleton loader (#79234)
* add skeleton for settings page

* go back to using style so it all overrides properly
2023-12-08 09:25:06 +00:00
Ashley Harrison cedcd977ec Service accounts: Add skeleton loader (#79224)
* use emotion object syntax

* move create button to be a page action

* create and use skeleton
2023-12-07 14:20:13 +00:00
Ashley Harrison 4a0c89a8fd Snapshots: Add loading skeleton (#79134)
* add snapshot skeleton

* add some unit tests
2023-12-07 10:48:06 +00:00
Ashley Harrison 6a02863cc9 Library panels: Add loading skeleton (#79087)
* add library panel card skeleton

* lineHeight: 1 instead of 0
2023-12-07 09:56:12 +00:00
Ashley Harrison 9ab8292949 Orgs: Add skeleton loader (#79141)
add skeleton for orgs list
2023-12-06 16:07:32 +00:00
Ashley Harrison 74cb1423c1 Teams: Add skeleton for teamlist (#79132)
add skeleton for teamlist
2023-12-06 16:07:02 +00:00
Ashley Harrison 30ead91d38 Server Stats: Add skeleton loader (#79138)
* add server stat skeleton loader

* prevent flicker
2023-12-06 16:06:30 +00:00
Ashley Harrison 7cdddb2790 PluginList: Add plugin list loading skeleton (#79012)
* add plugin skeleton

* lineHeight: 1 instead of 0
2023-12-05 16:39:23 +00:00
Ashley Harrison 568d979dd5 Chore: Improve typings (#78940)
* improve typings

* transformations typings improvements

* add bootData to window

* more grafana-data fixes

* undo window.grafanaBootData typings
2023-12-05 10:26:23 +00:00
Ashley Harrison 4a6ff8cf69 Navigation: add application-observability icon (#78935)
add application-observability icon
2023-12-02 09:51:46 +00:00
Ashley Harrisonandeledobleefe 329d0e79ec Navigation: Rearrange IA based on tree test (#78804)
* rearrange IA

* add landing page routes and subtitles

* Translate menu items

* add frontend-observability icon

* proper frontend-observability icon

---------

Co-authored-by: eledobleefe <laura.fernandez@grafana.com>
2023-11-30 15:18:05 +00:00
Ashley Harrison c70467c4c9 Chore: Convert some core components to use emotion object styles (#78607)
* convert some core components to use emotion object styles

* remove enabled: true

* use radius.default
2023-11-29 15:26:19 +00:00
Ashley Harrison 9789c0cc79 Remove type assertions in VizLegendTable (#78742)
no type assertions
2023-11-28 15:15:27 +00:00
Ashley Harrison 441d24f955 Chore: Remove some gf-form classes (#78601)
* remove some gf-form

* couple more transformations

* clean up Playlists

* review comments

* fix unit tests
2023-11-24 12:09:09 +00:00
Ashley Harrison 5355131aed Tab: Only make Tab an anchor if a href is passed (#78540)
* initial work

* only make the tab an anchor if it has a href

* move things around for smaller diff

* use content()

* eslint-disable the type assertions

* extract props into common object and add missing return statement
2023-11-23 10:51:07 +00:00
Ashley Harrison 4247696402 DockedMegaMenu: Keep undock button (#78461)
* dock undock smoothly

* handle keyboard focus

* use ref instead of state

* run i18n:extract

* undo this change

* make dock/undock first button to focus

* only focus when going to docked, add comment

* minor tweaks
2023-11-22 15:56:36 +00:00
Ashley Harrison b5d1c8874b Breadcrumbs: Only dedupe the lowest child node of sectionNav (#78279)
only dedupe sectionNav leaf node
2023-11-22 15:36:49 +00:00
Ashley Harrison 4290ed3d86 Chore: Remove newBrowseDashboards feature toggle (#78190)
* remove all the things

* fix OldFolderPicker tests

* i18n

* remove more unused code

* remove mutation of error object since it's now frozen in the redux state

* fix error handling
2023-11-22 15:22:00 +00:00
Ashley Harrison b843221730 Loading screen: Ensure bounce animation isn't blocked by main thread (#78469)
remove transform-origin to ensure animation gets put on compositor thread
2023-11-21 14:43:00 +00:00
Ashley Harrison 088f20dda0 Command Palette: Fix for chinese input and keystrokes being lost in slow environments (#78373)
update kbar to latest version
2023-11-20 11:36:49 +00:00
Ashley Harrison 7404ed66f6 Chore: Remove navAdminSubsections toggle (#78179)
* remove navAdminSubsections toggle

* missed one!
2023-11-17 10:04:34 +00:00
Ashley Harrison 2c0c51a0df Chore: improve types (#78126)
* fix some types

* more type updates

* some more fixes

* more changes

* string instead of unknown

* more like original logic

* remove outdated comment

* update betterer
2023-11-16 12:39:12 +00:00
Ashley Harrison 4ebfce8b9a Accessibility: Increase contrast of MonacoQueryField placeholder (#78176)
increase contrast of promqueryfield placeholder
2023-11-15 11:11:42 +00:00
Ashley Harrison e389ffa137 Chore: only show short commit hash in the help menu (#78038)
only show short commit hash in the help menu
2023-11-14 13:22:46 +00:00
Ashley Harrison bd85d3e25e PlaylistPage: Skeleton loading state 💀 (#77992)
* playlist skeleton poc

* refactor into PlaylistCard

* make card actions more responsive, update skeleton color to work on secondary background

* don't loop over array

* fix unit tests
2023-11-13 10:32:42 +00:00
Ashley Harrison 40fd80c46f Chore: Various type improvements (#77877)
* more datasource type fixes

* more type updates
2023-11-09 17:39:02 +00:00
Ashley Harrison 6a5de14ed1 Chore: Remove compareScreenshot + blink-diff dependency from core (#77920)
* remove compareScreenshot + blink-diff dependency from core

* missed one...
2023-11-09 13:18:12 +00:00
Ashley Harrison b6e2db7d91 Navigation: Report megamenu state when clicking a navigation item (#77705)
report megamenu state when clicking a navigation item
2023-11-06 14:32:29 +00:00
Ashley Harrison c0afa74876 QueryRows: Fix being able to reorder rows with keyboard (#77355)
* Revert "Explore: A tooltip for reorder icon in query operation (#75978)"

This reverts commit 76e102d1a3.

* update type

* CI driven development
2023-11-06 13:52:50 +00:00
Ashley Harrison d1e52d4788 Chore: type fixes (#77618)
* type fixes

* couple more

* just a couple more

* small fixes to prometheus typings

* improve some more datasource types
2023-11-06 11:28:44 +00:00
Ashley Harrison ffcaef9c17 Update navigation e2e tests (#77654)
update navigation e2e tests
2023-11-03 22:15:53 +02:00
Ashley Harrison d68d31c63c Navigation: Hide Undock menu button when docked (#76965)
* small dock menu exploration

* fix e2e tests

* revert back to web-section-alt
2023-11-03 17:07:15 +00:00
Ashley Harrison f32bc17422 Navigation: Use LoadingBar in CommandPalette (#77506)
try using LoadingBar in CommandPalette
2023-11-03 09:54:25 +00:00
Ashley Harrison 5892a64e9f CustomScrollbar: Remove chevrons from scroll indicators (#77498)
remove chevrons from scroll indicators
2023-11-02 15:21:36 +00:00
Ashley Harrison 9a905b6312 Navigation: Updates to the docs for admin subsections (#77500)
updates to the docs for admin subsections
2023-11-02 14:23:19 +00:00
Ashley Harrison 2d5e602b2d Navigation: Minor tweak to dockedMegaMenu to make it slightly tighter (#77493)
minor tweak to dockedMegaMenu to make it slightly tighter
2023-11-01 13:56:58 +02:00
Ashley Harrison 78df641b38 Navigation: Make page container automatically scroll when overflowing (#77489)
add overflow: auto to page container
2023-11-01 12:41:30 +02:00
Ashley Harrison 5f6d15d912 Chore: Update detect-breaking-changes workflow to use node 20 (#77459)
* attempt to fix levitate workflow

* add comment to force levitate to run

* update node version in levitate workflow

* change to test levitate

* remove dummy comment
2023-10-31 17:17:22 +00:00
Ashley Harrison 13c0268d6b Chore: Upgrade react-redux (#77296)
* try upgrading react-redux

* memoize getNavModel selector, don't return a new object in command palette selector

* use createSelector to memoize some alert manager selectors correctly

* memoize selectors correctly in appNotifications

* memoize some datasource selectors

* use fake timers to avoid the debounce causing flakiness

* remove duplicate import

* just use memoize-one
2023-10-31 16:24:34 +00:00
Ashley Harrison 3551f49019 Toggletip: Update background color and border (#77437)
update toggletip background + border
2023-10-31 15:11:53 +00:00
Ashley Harrison e67485de30 Chore: Add missing comma to renovate config (#77439)
add missing comma
2023-10-31 15:18:14 +02:00
Ashley Harrison dba846fe54 Chore: Some renovate config tidy up (#77275)
* update some comments, remove some things from the ignore list

* remove @mdx-js/react since storybook now directly depends on it

* add issue link to comment

* exclude @locker from grouped patch updates

* ignore grafana-e2e from renovate
2023-10-27 15:09:23 +01:00
Ashley Harrison 49f8838b62 Navigation: Improve docked auto scroll behaviour (#77117)
ensure expand works on any location change, only scroll when docked
2023-10-27 09:26:38 +01:00
Ashley Harrison 5f2fd8935d Spinner: Fix so that the size property is correctly applied (#77135)
* correctly apply spinner sizes, refactor to have standard sizes

* better prop definitions so constant values show in IDEs

* 12 is xs, not sm
2023-10-25 15:39:32 +01:00
Ashley Harrison 85468d2a67 DockedMegaMenu: Adjust docked threshold (#77139)
* adjust docked threshold to be xl instead of md and make sure it's open by default on 1440 res

* don't show dock menu button
2023-10-25 14:41:07 +01:00
Ashley Harrison 07cc7504ee Icon: Simplify and remove wrapping <div> (#76819)
* remove wrapping div

* update tests, just gotta figure out how to handle fontawesome :(

* add spinner.svg which matches the font-awesome spinner

* add mock for react-inlinesvg

* update mock and fix some tests

* fix FormField test

* fix CorrelationsPage tests

* increase timeout
2023-10-24 12:16:32 +01:00
Ashley Harrison ced065c7e9 Chore: fix some more types (#76535)
* clean up some e2e/runtime types

* fix some stories

* some more fixes

* fix route props

* update unit tests

* update more unit tests

* don't throw here
2023-10-24 11:53:22 +01:00
Ashley Harrison fbbc524cb6 Navigation: Default MegaMenu to docked when screensize > 1440 (#76960)
default megamenu to docked when screensize > 1440
2023-10-24 09:27:23 +01:00
Ashley Harrison efea86eb52 Navigation: Expand active page hierarchy and scroll into center if not visible (#76949)
* expand page hierarchy and scroll into center if not visible

* remove unnecessary id
2023-10-23 15:47:16 +01:00
Ashley Harrison f9a89e5cd2 Navigation: correctly mark a MegaMenuItem as active if it has active children (#76944)
correctly mark a MegaMenuItem as active if it has active children
2023-10-23 10:55:25 +01:00
Ashley Harrison a2921d9dfb DockedMegaMenu: More consistent spacing on active state (#76873)
* more consistent spacing on active state

* use correct secondary variant buttons
2023-10-23 09:15:39 +01:00
Ashley Harrison f5758e9f4b Navigation: Correctly highlight a SectionNavItem if it has children that are active (#76860)
correctly highlight a sectionnavitem if it has children that are active
2023-10-20 10:27:25 +01:00
d632dd672c Tooltip: Ensure tooltip text is correctly announced by screenreaders (#76683)
* add aria-describedby, tooltip role and unit tests

Co-authored-by: L-M-K-B <48948963+L-M-K-B@users.noreply.github.com>
Co-authored-by: joshhunt <josh@trtr.co>

* remove `delayShow` so tooltip text is announced correctly

* adjust IconButton, fix unit tests

* undo tooltip aria-label change

* only set aria-describedby if there's no aria-label

---------

Co-authored-by: L-M-K-B <48948963+L-M-K-B@users.noreply.github.com>
Co-authored-by: joshhunt <josh@trtr.co>
2023-10-18 16:05:20 +01:00
Ashley Harrison ed4c9bb487 Navigation: Correctly set active nested plugin pages (#76526)
* correctly set active nested plugin pages

* add recursion depth limit
2023-10-13 16:01:22 +01:00
Ashley Harrison b6fb1e52f2 Navigation: Limit SectionNav to rendering items up to 3 levels (#76478)
* only render section nav items up to 3 levels

* extract level depth into constant, apply in DockedMegaMenu as well
2023-10-13 10:38:35 +01:00
Ashley Harrison effd2a1189 Navigation: Split admin into subsections behind navAdminSubsections feature toggle (#76280)
* split admin into subsections behind feature toggle

* make authentication a section header

* add translations for subsections

* rename translation keys

* add subtitles
2023-10-11 14:37:36 +01:00
Ashley Harrison abd2c9c287 Navigation: Hide docked menu and dock button on mobile (#76334)
* hide docked menu and dock button on mobile

* add logic to handle hamburger menu button on mobile
2023-10-11 11:33:15 +01:00
Ashley Harrisonandeledobleefe 930c753340 Navigation: Implement logic for docking nav menu (#76188)
* Create a state for dockedMegaMenu and the function to manage it

* Add the dockedMenu icon and handle the status when clicking it

* Add Megamenu to section nav area when it is docked

* get logic working

* fix mobile

* refactor state + persist in localStorage

* adjust icon and don't use position absolute

* restore old rudderstack tracking

* use Flex instead

* adjust feature toggle to be experimental

* extract out localStorage handling into utils

* don't need separate file

* use store.set/get instead

---------

Co-authored-by: eledobleefe <laura.fernandez@grafana.com>
2023-10-10 14:55:52 +01:00
Ashley Harrison f56cc6fdc0 Navigation: Create navAdminSubsections feature toggle (#76248)
create feature toggle
2023-10-10 13:50:44 +03:00
Ashley Harrison 171e2c1adb Chore: Improve typings and ignore Graph (#75742)
* fix some types, ignore graph plugin as it'll be gone soon

* update comments

* more more more

* undo renderer change

* use Partial in the editor
2023-10-06 11:48:15 +01:00
Ashley Harrison 9350e8bee5 Renovate: Add yarn dedupe strategy (#75945)
add dedupe strategy
2023-10-04 13:29:10 +01:00
Ashley Harrison 18b237879d DockedMegaMenu: Refactor and rename to simplify (#75872)
* tidy up some styles

* remove NavBarMenuItemWrapper + consolidate components

* lots of renaming

* use object syntax in FeatureHighlight

* fix a couple of missing find+replace

* adjust li positioning

* fix text truncation

* bit more tidy up

* refactor indent into it's own component

* memoize styles in Indent
2023-10-03 13:03:27 +01:00
Ashley Harrison e9555d727a Drawer: remove wrapping div preventing Drawer from scrolling properly (#75823)
remove wrapping div prevent drawer from scrolling properly
2023-10-02 16:01:28 +01:00
Ashley Harrison 158e7b9977 DockedMegaMenu: Show correct breadcrumbs on dashboard settings (#75808)
need this logic when using dockedMegaMenu
2023-10-02 13:58:27 +01:00