* MM-56536 Do not update team members scheme roles if user is guest
* feedback review
---------
Co-authored-by: Mattermost Build <build@mattermost.com>
* Remove unused setFirstChannelName action
* Remove makeOnMoveHistoryIndex
* Remove selectPostFromRightHandSideSearchByPostId
* Remove selectPostAndParentChannel
* Remove searchMoreChannels
* Remove fetchRemoteListing
* Remove sendGenericPostMessage
* Remove unused version of periodic status update code
* Remove unused code around non-global items in storage
Either pre-Redux or early in our usage of Redux, I think this code was
meant to let us store things in localStorage on a per-user basis. If we
ever used it, it hasn't been for a while now.
* Remove unused loadProfilesAndStatusesInChannel action
* Remove collapseCategory and expandCategory
* Removed unused actions from mattermost-redux/actions/channels
* Remove unused getDataRetentionPolicy action and state
* Remove unused getWarnMetricsStatus action
* Remove unused getFirstAdminVisitMarketplaceStatus action
* Remove unused getReactionsForPost action
* Remove now-unused state.entities.posts.selectedPostId
* asdf marketplace stuff in general
* Remove unused makeDirectChannelVisibleIfNecessary and makeGroupMessageVisibleIfNecessary
* Remove old searchFiles action
* Remove unused search actions
* Remove non-graceful addUsersToTeam action
* Remove unused version of joinTeam action
* Remove unused updateTeamMemberRoles action
* Remove another unused verison of the periodic status update code
* Remove unused getUserAccessTokens action
* Fix linting
* Remove unit tests involving recent search results
* Fix another test
* added rctx to reuired files
* added more file changes after issues on startup
* added context to draft_store
---------
Co-authored-by: Mattermost Build <build@mattermost.com>
* limit size and number of preferences in updatePreferences
* update unit tests
* fix another location and add tests
* update utility function to return an error
* update unit tests
* fix review comments
* revert package-lock.json
* more review mods
* update number of preferences allowed
* update unit tests for new limit
* update name of config setting
* Update server/public/model/utils.go
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
* add check for error id
* use existing utility function, remove model.ObjectFromJSON()
* Update preference.go - remove blank line
---------
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
Co-authored-by: Mattermost Build <build@mattermost.com>
The optipng issue that the CPPFLAGS fix here was working around may have
already been fixed in downstream packaging by overriding CPPFLAGS, so it
should be appended to rather than replaced, this also respects any
existing CPPFLAGS the user has configured.
Also, an identical issue exists on PPC with its corresponding SIMD
extensions (VSX), so add the same workaround there in the upstream
Makefile.
Co-authored-by: matoro <matoro@users.noreply.github.com>
* [MM-56616] Changes for the DM for batch reporting
* Use requesting user's locale
* Fix lint
* Remove unnecessary test
* Move back to file attachment
* Add default API case
* Fix i18n
* Hardcode the CSV string
* [MM-54745] Fixing inconsistent styles for menu items in profile/account menu
* [MM-54745] Updating the snapshot tests
* [MM-54745] Set a custom status text made to display with full opacity
* [MM-54745] Fixing the CI pipeline lint issues
* [MM-54745] Fixing a few more linter issues blocking the build
* [MM-54745] Fixing type check issue for color parameter
* [MM-54745] ESlint issues for import statements and alignment of closing brackets
* [MM-54745] Updating snapshots and fixing minor ESLint issues on the way in the test file
---------
Co-authored-by: Mattermost Build <build@mattermost.com>
* Remove remaining usage of GenericAction in mapDispatchToProps
* Remove usage of GenericAction when testing initial state
* Remove usage of GenericAction from reducers
* Remove GenericAction
* Remove non-functional code from Login component
* Remove remaining usage of useDispatch<DispatchFunc>
* Remove usage of DispatchFunc from actions/file_actions
* actions/global_actions
* Remove usage of DispatchFunc from actions/marketplace
* Remove DispatchFunc from actions/post_actions
* Remove DispatchFunc from actions/storage
* Remove DispatchFunc from actions/user_actions
* Remove DispatchFunc from actions/views/channel
* Remove DispatchFunc from actions/views/channel_sidebar
* Remove DispatchFunc from actions/views/create_comment
* Remove DispatchFunc from actions/views/lhs.ts
* Remove DispatchFunc from actions/views/rhs.ts
* Remove DispatchFunc from actions/views/onboarding_tasks
* Remove DispatchFunc from actions/views/root
* Remove DispatchFunc from components/logged_in
* Remove DispatchFunc from components/msg_typing
* Remove DispatchFunc from components/permalink_view
* Remove DispatchFunc from components/suggestion
* Remove DispatchFunc from mattermost-redux/actions/posts
* Remove DispatchFunc from mattermost-redux/actions/roles
* Remove DispatchFunc from mattermost-redux/actions/threads
* Remove DispatchFunc from mattermost-redux/actions/timezone
* Remove DispatchFunc from plugins/products
* Make DispatchFunc into Dispatch
* Fix how dispatch is mocked in test for toggleSideBarRightMenuAction
The failure seemed to be due to incorect detection from gotestsum
itself rather than any failure in the test.
I note that from that time onwards, gotestsum has had a new release
and we are using that.
I also ran the test several times with gotestsum and could not
repro this. Let's hope that the new version of gotestsum has fixed
the issue. Otherwise, there isn't much we can do.
https://mattermost.atlassian.net/browse/MM-54264
```release-note
NONE
```
During server start, runLicenseExpirationCheckJob was being called
from a goroutine which would eventually call SetLicense and iterate
through the ps.licenseListeners.
But at the same time doElasticsearchFixChannelIndex would also
call AddLicenseListener and try to edit the ps.licenseListeners map,
leading to a race condition.
To fix this, we simply move the runLicenseExpirationCheckJob
to be synchronous. This fixes the race, and also improves
the correctness because after 1f431bf722
there was no license check being done synchronously during server boot.
So theoretically, the server might go on doing some stuff
until the Go runtime decides to run the license check goroutine.
https://mattermost.atlassian.net/browse/MM-56611
```release-note
NONE
```
* migrating team_channel_settings/group/index.js to .tsx
* fixing CI/Lint issues
* Fixed eslint issues, changed Props export and usage structure in index.ts and group_list.tsx
* Remove empty array in getData call
* Update promise to void in AbstractList and response to unknown Group | Team
* remove bindActionCreators and dispatch Type from team_channel_settings/group/index.ts
---------
Co-authored-by: Kapil Dutta <duttakapil@Kapils-MacBook-Pro.local>
Co-authored-by: Mattermost Build <build@mattermost.com>
* Only use RhsSuggestionList for RHS advanced text editor
- Prevents issues with suggestion list growing downwards on the post editor on small screen sizes
* Makes RhsSuggestionList grow using different breakpoints for mobile
- Allows RhsSuggestionList to flip directions at smaller breakpoints than desktop
- Adds new Constant MOBILE_SUGGESTION_LIST_SPACE_RHS
---------
Co-authored-by: Nathan Geist <ngeist@spiria.com>
Co-authored-by: M-ZubairAhmed <m-zubairahmed@protonmail.com>
Co-authored-by: Mattermost Build <build@mattermost.com>
