IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-01-09 23:54:09 -06:00
Code Issues Packages Projects Releases Wiki Activity
6,802 Commits 7 Branches 108 Tags 332 MiB
c8d6ff8a6d
Commit Graph

1297 Commits

Author SHA1 Message Date
Akshay Joshi
93bc1f3c57 Added support for visualise the graph using a Line chart in the query tool. Fixes #7485 2022-06-22 17:18:51 +05:30
Nikhil Mohite
2adca6bbc4 1) Added mouse over indication for breakpoint area in the Debugger. Fixes #2647 
2) Added search text option to the Debugger panel. Fixes #2648
3) Port Debugger to React. Fixes #6132
 2022-06-15 11:37:54 +05:30
Yogesh Mahajan
7e1e068370 Added capability to deploy PostgreSQL servers on Microsoft Azure. Fixes #7178 2022-06-15 11:22:42 +05:30
Akshay Joshi
3381516013 Upgrade Chartjs to the latest 3.8.0. Fixes #7469 2022-06-13 17:26:17 +05:30
Aditya Toshniwal
725726f083 Ensure that the Query Editor should be focused when switching between query tool tabs. Fixes #7441 2022-06-13 14:26:01 +05:30
Aditya Toshniwal
ea3203f466 Fixed and issue where 'Use spaces' not working in the query tool. Fixes #7443 2022-06-13 11:46:09 +05:30
Khushboo Vashi
e1c5a06bf0 Fixed some cloud deployment issues: 
- Added High Availability option
 - Server group renamed to pgAdmin server group
 - Removed the Private option from Networking otherwise, it would not be possible to connect the server from pgAdmin.
 2022-06-09 14:07:05 +05:30
Nikhil Mohite
e3225b6565 Fixed the browser tree overlapping nodes and expansion issue. Fixes #6962 2022-05-28 13:26:17 +05:30
Pradip Parkale
a5ad956088 Ensure that when Authentication buttons are disabled their text is visible in the Dark and High contrast theme. Fixes #7347 2022-05-24 17:12:37 +05:30
Khushboo Vashi
345cfd7c60 Ensure that unwanted APIs should not be getting called for BigAnimal. Fixes #7368 
Updated the BigAnimal icon.
 2022-05-24 11:34:23 +05:30
Akshay Joshi
4f7bcc2919 Added the ability to detect and warn users about bidirectional Unicode characters. Fixes #7002 2022-05-23 16:04:21 +05:30
Pradip Parkale
11cfea3860 Added the ability to resize columns on dashboard tables. Fixes #7364 2022-05-18 17:49:54 +05:30
Nikhil Mohite
ae0624ae8a Fixed an issue where Preferences are not saved when the dialog is maximized. Fixes #7383 2022-05-17 11:06:14 +05:30
Akshay Joshi
44f9ba4a57 Port connect server password dialog to React. Fixes #7337 2022-05-16 16:21:14 +05:30
Aditya Toshniwal
ca8e14455f Fixed the following issues: 
1. Feature test cases for the new query tool.
 2. Query tool panel rename is not persisting.
 2022-05-12 18:29:09 +05:30
Aditya Toshniwal
1135821870 Fix Query tool issues: 
1. Warning/Confirm dialogs should be inside the query tool.
2. The Help button in View/Edit data should open the corresponding help page.
3. Disable execute options when query tool in transaction.
4. Grid not loading more than 10000 rows. react-data-grid issue, PR sent. Use a fork till then.
5. NOTICE messages should not be part of Notifier success popups.

Fixes #7350
 2022-05-09 12:39:29 +05:30
Aditya Toshniwal
64ffed0ddb 1. Filter dialog doesn't work in edit mode (getting back end errors), reverting it back to create mode of SchemaView. 
2. Enable the copy button when a cell is selected.
3. Exclude, Include related fixes.
 2022-04-29 16:29:46 +05:30
Pradip Parkale
a0c85431dc Ensure that the Dashboard column sort order should be remembered when the refresh button is clicked. Fixes #7339 2022-04-29 10:26:24 +05:30
Aditya Toshniwal
bd799ea51a Autofocus CodeMirror SQL input to the first element of a form. 2022-04-28 14:09:27 +05:30
Pradip Parkale
7c61017f57 Fixed an issue where the Dashboard Server Activity was showing old queries as active. Fixes #7305 2022-04-28 12:10:42 +05:30
Khushboo Vashi
7d91cca14d 1) Fixed linter error. 
2) Fixed an issue where a password popup will appear on disconnecting from the server.
 2022-04-26 18:16:33 +05:30
Khushboo Vashi
5677b1e5f8 Added capability to deploy PostgreSQL servers on EDB BigAnimal. Fixes #7179 2022-04-26 16:41:10 +05:30
Aditya Toshniwal
0795b22ae6 Fixed the following issues for the new query tool: 
1) In Dark mode > Replace/Find dialogue forward & reverse buttons are stuck to each other.
 2) In Dark/High contrast mode > Checkbox is not visible for false value.
 3) Wrap toolbar when size goes very small.
 4) Replace functionality does not work when tried in sequence 2 times. Codemirror search is not cyclic. So, changes are made to always search from the start.
 5) Replace all does not work when tried in sequence 2 times. Same reason as above.
 6) Fix broken macros $SELECTION$ feature.
 7) Make query history SQL readonly.
 8) The Filter dialog save button should be disabled when opened.
 2022-04-26 16:27:53 +05:30
Aditya Toshniwal
25b89f7624 Fixed the following issues for the new query tool: 
1) Failed to fetch query history error sometimes.
 2) In copy paste row, if a copied row has [null], then those are pasted as an empty string.
 3) When Data output is empty, show an empty grid.
 4) Schema diff generates a script button resulting in an empty window. Fixes #7306.
 5) Detach the DataOutput panel > Try editing text cell > Text editor is hidden behind the data output panel

refs #6131
 2022-04-25 18:11:39 +05:30
Aditya Toshniwal
c5ca394cec 1. Add min width to panels. 
2. Fix issues related to New connection in query tool. Also fixed some existing bugs related to this.

refs #6131
 2022-04-22 18:17:01 +05:30
Aditya Toshniwal
e5ef6a7b21 Fixed following issues for Query Tool (after React Porting): 
1) Find/Replace both opens the same dialogue box.(by clicking menu option)
2) Add New Server Connection > Server options keep loading(For multiple Server groups & should have some server)
3) Fixed CSS issues of slickgrid at various places.
4) C should be captial in ’<New connection…>'
5) In pop title for New Connection, all words should be capital.(Add new connection)
6) Explain > Analaysis tab > Column heading missing ROWS PLAN with cost & In explain only.
7) Explain > Analaysis tab > with cost enabled > Upward arrow size does not match with font of number. Arrow is little bigger than number.
8) Boolean default is not considered while ading new row.(try table from feature test defaults)
9) In query history , when not query history present, warning icon size big. Match it to warning message - No history found
10) Select table/db object > Open query tool from Tools menu > NOT FOUND error is shown. Existing issue, fixed.
11) Any cell just open by clicking it > Do NOT change any thing > Click Ok > Cell is shown as edited.

refs #6131
 2022-04-20 19:02:16 +05:30
Aditya Toshniwal
9c30d983bd Fixed following issues for query tool after react porting: 
1) Add New Server Connection > Server options keep loading(For empty Server group).
 2) After clicking indent/Unindent(for all operations) for large query option left as it is till operation completes
 3) Check sign beside options in Execute Option/Copy Header is little bit big
 4) In explain > Analysis tab does not show ROWS column
 5) In explain > Explain > analysis previous explain output is NOT cleared. New rows are appended. Same applies to the statistics tab.
 6) Update new query tool connection tool tip. Fixes #7289
 7) Explain-Analyze > Loops column is empty.
 8) Explain-Analyze with Verbose & Costs > in ROW X columns upward arrows are missing.
 9) Explain-Analyze with all option checked > background colors are missing for timing.
 10) Explain-Analyze > Additional bullet is added before Hash Cond.
 11) Browser Tree > Filtered rows icon is not working.
 12) Create table with timestamp and default value as function now() > Add new row > Enter mandatory columns except column where default value is function(now()) > Click Save > New row added but column with default value has value [default]. not updated to actual value. / Default values are not considered for any column while adding a new entry.
 13) Disable execute options in View/Edit data.
 14) The Boolean column always shows null.
 15) In Query history Remove & Remove all buttons are stuck to each other.
 16) On Remove all, the right panel is empty.
 17) Create a column with boolean[]/ text[], Try to add a new entry from data grid, enter “” quotes > Click Ok > Now try edit cell > You can not change value.
 18) In query history - Select queries are suffixed by ’Save Data’ icon
 19) Edit any table with PK > Try to insert duplicate PK > Error thrown > Correct pK value > Still old error shown > Not able to add new entry (This works when focus is moved from edited cell)
 20) Clicking arrows after opening dropdown options, does not collapse dropdown.

refs #6131
 2022-04-18 12:50:51 +05:30
Pradip Parkale
131ff4de48 Ensure that sorting should be preserved on refresh for Server Activity. Fixes #7308 2022-04-14 11:11:45 +05:30
Akshay Joshi
7b0a6e7377 Rename '_aci_tree.overrides.scss' to '_tree.overrides.scss'. 2022-04-14 11:02:58 +05:30
Khushboo Vashi
0b7bde2775 Fixed an issue where the Browser panel is not completely viewable. Fixes #7026 2022-04-13 17:37:34 +05:30
Akshay Joshi
86a3696ab4 Remove aciTree and its references. 2022-04-13 17:35:01 +05:30
Akshay Joshi
3a4ff2677e 1) Fixed an issue where the Schema Diff Check icon beside filter options should not be visible if it is unselected. Fixes #7310 
2) Fixed an issue where Reset Layout did not function and the Quick Search option under the Help menu displayed bullets. Fixes #7311
 2022-04-12 16:27:24 +05:30
Aditya Toshniwal
a91762fb30 Ensure that Columns should always be visible in the import/export dialog. Fixes #7252 2022-04-11 17:25:19 +05:30
Pradip Parkale
c2f1a7bdc5 Ensure the database and schema restriction controls are not shown as a drop-down. Fixes #7255 2022-04-09 12:09:35 +05:30
Aditya Toshniwal
b5b9ee46a1 1) Port query tool to React. Fixes #6131 
2) Added status bar to the Query Tool. Fixes #3253
3) Ensure that row numbers should be visible in view when scrolling horizontally. Fixes #3989
4) Allow removing a single query history. Refs #4113
5) Partially fixed Macros usability issues. Ref #6969
6) Fixed an issue where the Query tool opens on minimum size if the user opens multiple query tool Window quickly. Fixes #6725
7) Relocate GIS Viewer Button to the Left Side of the Results Table. Fixes #6830
8) Fixed an issue where the connection bar is not visible. Fixes #7188
9) Fixed an issue where an Empty message popup after running a query. Fixes #7260
10) Ensure that Autocomplete should work after changing the connection. Fixes #7262
11) Fixed an issue where the copy and paste row does not work if the first column contains no data. Fixes #7294
 2022-04-07 17:36:56 +05:30
Akshay Joshi
7c6d34408c Corrected z-index issue, regression from the previous commit. 2022-04-05 16:31:19 +05:30
Akshay Joshi
8ce7ccb031 Fixed some issues related to z-index and color. 2022-04-05 14:26:40 +05:30
Pradip Parkale
8f8adcf71b 1 Fixed the issue where db connection was getting disconnected for dashboard, if network is slow. 
2 Fixed publication collection node properties issue which was missed during react node porting.
3 Removed unwanted variable from theme style sheet.
 2022-04-05 13:40:22 +05:30
Aditya Toshniwal
953a9d7fd1 Fixes some issues and improves the PgTable component. 2022-04-05 12:10:51 +05:30
Nikhil Mohite
56a4263a5c Fixed an issue in loading user details on the properties panel. Fixes #7287 2022-04-05 11:19:24 +05:30
Aditya Toshniwal
4fff26c571 Makes some improvements/restructurings to the PgTable component. 2022-04-04 19:06:43 +05:30
Pradip Parkale
b397ba7787 Fixed issues related to porting of properties collection and dashboard. 
refs #7132
 2022-04-04 17:42:42 +05:30
Akshay Joshi
38278c179e Ensure that the master password dialog is popped up if the crypt key is missing. Fixes #6960 2022-04-04 17:00:18 +05:30
Nikhil Mohite
07527ba69b Fixed maximize button issue on the preferences dialog. 
refs #7149
 2022-04-03 12:27:47 +05:30
Pradip Parkale
fe416c838b Fixed an issue where the browser tree state was not preserved correctly. Fixes #7176 2022-03-31 18:28:36 +05:30
Nikhil Mohite
74c620e478 Fixes the arrow key issue in the preferences tree. Fixes #7274 
Ensure that the select folder dialog should be on top when selecting the binary path. Fixes #7276
 2022-03-31 11:46:34 +05:30
Pradip Parkale
cb052f1988 1) Port Properties panel for collection node, Dashboard, and SQL panel in React. Fixes #7132 
2) Added transaction start time to Server activity sessions view. Fixes #7215
 2022-03-30 12:06:59 +05:30
Nikhil Mohite
931a399890 Fixed issues in the Preferences: 
1) Show a single note in the binary path.
  2) Resolved issue in the keyboard shortcut.

refs #7149
 2022-03-29 16:27:33 +05:30
Nikhil Mohite
08e00ccebc Fixed an issue where the newly added table is not visible under the Tables node on refresh. Fixes #7239 2022-03-29 14:40:54 +05:30
Aditya Toshniwal
903b300b9e 1) Added support for unique keys in ERD. Fixes #7249 
2) Fixed an issue where foreign key relationships do not update when the primary key is modified. Fixes #7197
 2022-03-28 16:26:43 +05:30
Nikhil Mohite
0b4a874f30 Fixed an issue where unexpected error messages are displayed when users change the language via preferences. Fixes #7267 2022-03-24 16:08:13 +05:30
Aditya Toshniwal
7f2e87b27d Fixed Jasmine test cases. 2022-03-24 12:05:59 +05:30
Nikhil Mohite
2f37f0ca51 Fixes for the preferences dialog 
1) Add server mode validation in the binary path.
  2) Updated preferences tree rendering to avoid using the ReactDOM render.
  3) Updated CSS for keyboard shortcuts checkbox border makes it consistent with input box border.
  4) Fixed jasmine test case and improved code coverage.
  5) Fixed SonarQube issues.
  6) Added validation to disable "Maximum column with" option if "Column sized by" option is set to "Column name" in Query Tool -> Result grid.
  7) Updated documentation with the latest screenshots.
  8) Correct typo in the documentation. Fixes #7261

refs #7149
 2022-03-23 13:28:35 +05:30
Nikhil Mohite
74e794b416 Port preferences dialog to React. Fixes #7149 2022-03-21 13:29:26 +05:30
Aditya Toshniwal
f9707a8bf5 Allow users to scroll and enter input when there is a validation error. Fixes #7172 2022-03-04 17:25:36 +05:30
Khushboo Vashi
69069e9af3 The following issues related to cloud deployment have been resolved: 
- Masking the credentials input fields
- The loading symbol doesn't work while reloading the options in the select control
- Reduce the wizard opening timeout
- urllib library upgrade impacts host IP fetch

refs #7177
 2022-03-02 19:04:15 +05:30
Aditya Toshniwal
44b2f49839 Enhances the modal provider to make it more reusable. 2022-02-23 14:27:48 +05:30
Khushboo Vashi
e61a1045f5 Added capability to deploy PostgreSQL servers on Amazon RDS. Fixes #7177 2022-02-14 12:13:48 +05:30
Aditya Toshniwal
bc4e8a3c82 Implemented utilities in React to make porting easier for pgAdmin tools. 2022-02-11 10:36:24 +05:30
Nikhil Mohite
4a195e7ef6 Fixed value error in the restore dialog. Fixes #7151 2022-02-03 17:44:54 +05:30
Pradip Parkale
7a2716bf77 Fixed issues related to porting of dependent, dependencies, and statistics panel. 
refs #7016
 2022-02-03 11:13:39 +05:30
Nikhil Mohite
64c419e6f8 Fixed Jasmine test cases. 
refs #7110
 2022-02-02 17:55:14 +05:30
Nikhil Mohite
b4b658c59d Ensure that cursor should be focused on the first options of the Utility dialogs. Fixes #7110 2022-02-02 14:48:35 +05:30
Akshay Joshi
aa5b1d50b9 Fixed issues introduce by SonarQube fixes. 2022-02-01 14:11:18 +05:30
Aditya Toshniwal
bc0b25d995 1) Fixed an issue where a warning message was shown after database creation/modification. Fixes #7142. 
2) Added error boundary to schema view which will improve the exception stack trace details.
3) Fixed Jasmine test cases.
 2022-01-31 13:41:22 +05:30
Khushboo Vashi
8f7b30075e Fixed SonarQube issues. 2022-01-27 17:22:19 +05:30
Akshay Joshi
0ce3434631 Fixed code smell 'Update this function so that its implementation is not identical' reported by SonarQube. 2022-01-25 20:10:31 +05:30
Pradip Parkale
094129e2be Port Dependent, dependencies, statistics panel to React. Fixes #7016 2022-01-24 14:13:02 +05:30
Akshay Joshi
343c3ee49c Fixed following code smells reported by SonarQube: 
1) Remove this redundant jump.
 2) Remove this commented out code.
 3) Variables should not be shadowed.
 2022-01-21 18:54:23 +05:30
Akshay Joshi
1013d7ccdd Fixed code smell reported by SonarQube. 2022-01-20 16:58:21 +05:30
Nikhil Mohite
d945c6f843 Fixed an issue where connections keep open to (closed) connections on the initial connection to the database server. Fixes #7035 2022-01-19 15:02:05 +05:30
Aditya Toshniwal
fbc3b1a318 Added support for grouping in input select boxes and allow setting default selected options. 2022-01-18 18:44:55 +05:30
Akshay Joshi
9f836f5433 Fixed following code smells reported by SonarQube: 
1) Immediately return this expression instead of assigning it to the temporary variable.
 2) Extract this nested ternary operation into an independent statement.
 3) Expected a `for-of` loop instead of a `for` loop with this simple iteration.
 2022-01-18 14:49:54 +05:30
Akshay Joshi
e3807ec3d6 Fixed following code smells reported by SonarQube: 
1) Boolean checks should not be inverted.
 2) Review this redundant assignment.
 3) Extract this nested ternary operation into an independent statement.
 4) Unexpected empty function.
 5) Immediately return this expression instead of assigning it to the temporary variable.
 2022-01-17 13:56:01 +05:30
Nikhil Mohite
4787de6968 CSS changes in the browser tree. 
refs #7085
 2022-01-13 12:52:55 +05:30
Akshay Joshi
3f7e921cce Fixed code smell 'Unexpected empty arrow function' reported by SonarQube. 2022-01-12 18:59:21 +05:30
Akshay Joshi
c98fb887cc Fixed code smell 'Unexpected empty arrow function' reported by SonarQube. 2022-01-12 17:32:20 +05:30
Nikhil Mohite
d2457f2a1d Ensure that Partitioned tables should be visible correctly when creating multiple partition levels. Fixes #7085 2022-01-12 16:29:13 +05:30
Akshay Joshi
e38c38cd58 Fixed following SonarQube code smells: 
1) Remove this useless assignment to a variable.
2) Remove the unused local variable.
 2022-01-12 14:53:19 +05:30
Nikhil Mohite
e43a87da09 Fixed SonarQube issue. 2022-01-10 12:10:20 +05:30
Nikhil Mohite
af6ff20020 Fixed SonarQube issues. 2022-01-07 19:58:19 +05:30
Nikhil Mohite
ad862f4084 Port Maintenance dialog to React. Fixes #7019 2022-01-07 12:07:49 +05:30
Rahul Shirsat
6528d086ba Fixed review comments: 
1. Split the restore options/backup options into 2 tabs
2. Restore icon changes
3. feature tests issues
4. restore help link broken
5. Comment section not visible

refs #7018
 2022-01-06 16:46:44 +05:30
Akshay Joshi
2786f7ac5a Update copyright notices for 2022 2022-01-04 13:54:25 +05:30
Akshay Joshi
9dd957a2aa Added support to import/export server groups and servers from GUI. Fixes #4803 2022-01-04 12:27:17 +05:30
Pradip Parkale
c1ad7d81f4 Fixed an issue where destroy method is not present for the browser tree after React porting. 2022-01-03 17:47:22 +05:30
Nikhil Mohite
e18ce2c9e3 Updates CSS and structure in Wizard, also fixed css issues in GrantWizard. 2021-12-31 14:16:50 +05:30
Nikhil Mohite
191e2b6242 Fixed an issue where an operation error message pop up showing the database object's name incorrectly. Fixes #7078 2021-12-28 13:49:04 +05:30
Rahul Shirsat
603d91be0e Port Restore dialog to React. Fixes #7018 2021-12-28 13:45:59 +05:30
Akshay Joshi
262dcdcf54 Added postion relative to show error message properly. 2021-12-24 17:37:59 +05:30
Akshay Joshi
74be3a9f52 Fixed linter error. 2021-12-24 16:52:32 +05:30
Aditya Toshniwal
5c65766ece Added a common table MUI style object which can be used on any table. 
Added a few more styling improvements.
 2021-12-24 16:15:38 +05:30
Nikhil Mohite
45179ccb8c Change logic for grant wizard, wizard component, and updated CSS. 2021-12-22 18:26:21 +05:30
Akshay Joshi
ebee7a5b72 Fixed linter errors. 2021-12-22 14:44:57 +05:30
Akshay Joshi
ae73f13812 Added beforeNext and beforeBack method in Wizard. 2021-12-22 14:25:08 +05:30
Akshay Joshi
02b83146be 1) Added spacing for message and loading spinner. 
2) Rename the GrantWizard Dialog.
3) Return the activeStep from disableNextStep function.
 2021-12-21 18:00:07 +05:30
Akshay Joshi
92a997b16a Rearrange tools menu on the basis of usability and form groups of similar sub-menus. 2021-12-16 18:29:44 +05:30
Aditya Toshniwal
6875d00e44 Fixed an issue where confirmation pop-up is hidden behind Reassign/Drop Owned Dialog. Fixes #7071 2021-12-14 16:42:06 +05:30
Akshay Joshi
f24348b2b0 Fixed an issue where notifier not working when opening query tool in a new 
window and then open it in the new tab.
 2021-12-08 18:15:13 +05:30
Akshay Joshi
fd53e4f5f9 Replace Alertify alert and confirm with React-based model dialog. Fixes #7053 2021-12-07 18:52:40 +05:30
Nikhil Mohite
950809ee55 Increase the width of the scrollbars. Fixes #6978 2021-12-06 20:11:30 +05:30
Aditya Toshniwal
dfdaf7f6d1 Implemented React based modal provider to create models on the fly. 
Also, use this to replace Alertify alert and confirm dialog.
 2021-12-03 12:50:24 +05:30
Ashesh Vashi
36c9eb3dfd Added support for Two-factor authentication for improving security. Fixes #6543 2021-12-02 16:47:18 +05:30
Ganesh Jaybhay
e30cbe2579 Fixed some accessibility issues: 
1) Focus is not visible while navigating through top navbar menu items(File, Object, Tools)
2) In preference dialog wherever access key is used for a shortcut declaration, unable to get out of the textbox.
3) Focus is not visible for the links on the dashboard

Fixes #7046
 2021-12-02 16:24:55 +05:30
Akshay Joshi
c6424e3897 Replaced alertifyjs notifiers with React-based notistack. Fixes #7004 2021-12-02 16:05:52 +05:30
Nikhil Mohite
61b440261f Ensure that sort order should be maintained when renaming a server group. Fixes #6955 2021-11-29 12:04:04 +05:30
Nikhil Mohite
3a30f27153 1. Updated notification message for the reset layout. 
2. Added notification type in alertify which was missing.

refs #6988
 2021-11-24 10:58:15 +05:30
Nikhil Mohite
3afeb8ca46 Port Backup Global, Backup Server, and Backup object dialog in React. Fixes #6984 2021-11-22 11:20:44 +05:30
Nikhil Mohite
cc91e5da94 Fixed an issue where properties of the database should not be visible after removing the database. 
Fixes #6964
 2021-11-18 12:36:39 +05:30
Khushboo Vashi
cc38bc132e Fixed scroll issue in the browser tree when navigating using the keyboard. 2021-11-15 18:26:16 +05:30
Yogesh Mahajan
e2e5a8208c 1) Fixed an issue where JSON editor preview colours have inappropriate contrast in dark mode. Fixes #6944 
2) Fixed JSON Editor scrolling issue in code mode. Fixes #6945
 2021-11-15 10:58:17 +05:30
Khushboo Vashi
aff84103d9 Fixed an issue where database nodes are not getting loaded behind a reverse 
proxy with SSL. Fixes #6905
 2021-11-10 11:47:40 +05:30
Pradip Parkale
a61a9e5b8f Fixed an issue where older server group name displayed in the confirmation 
pop-up when the user removes server group. Fixes #6939
 2021-11-10 11:17:51 +05:30
Aditya Toshniwal
1ed4d0f95e Fixed an issue where textarea should be allowed to resize and have more than 255 chars. Fixes #6976 2021-11-07 10:51:54 +05:30
Aditya Toshniwal
31849ea95f Ensure that changing themes should work on Windows when system high contrast 
mode is enabled. Fixes #6954
 2021-11-07 10:46:49 +05:30
Akshay Joshi
39992a817d Added support of Aggregate and Operator node in view-only mode. Fixes #3834 2021-10-29 16:14:33 +05:30
Aditya Toshniwal
a2f5e6ad8f Fixed an issue where the wrong SQL is generated when deleting and renaming table columns together. Fixes #6935 2021-10-19 17:13:12 +05:30
Khushboo Vashi
9e3165c0ff 1) Ensure that the master password should be prompt when MASTER_PASSWORD_REQUIRED 
is set to True and AUTHENTICATION_SOURCES is the webserver. Fixes #6928
2) Fixed an issue where the existing server group is disappeared on rename it. Fixes #6930
 2021-10-19 11:56:44 +05:30
Khushboo Vashi
a908ef7c61 Fixed browser tree sort order regression issue. Fixes #6912 2021-10-16 12:54:44 +05:30
Aditya Toshniwal
7f3c3fa6f9 Added support to allow tables to be dragged to ERD Tool. Fixes #6241 2021-10-16 12:43:39 +05:30
Nikhil Mohite
476d7c5fc9 Fixed background colour issue in the browser tree. Fixes #6890 2021-10-16 12:40:57 +05:30
Rahul Shirsat
1377244e52 Fixed the issue of editing triggers for advanced servers. Fixes #6802 2021-10-16 12:36:25 +05:30
Khushboo Vashi
2aac87569b Fixed an issue where the users are unable to load the databases behind an HTTP reverse proxy. Fixes #6905 2021-10-14 11:35:11 +05:30
Aditya Toshniwal
9ace229152 Fixed an issue where exclusion constraint cannot be created from table dialog 
if the access method name is changed once. Fixes #6900
 2021-10-13 11:35:19 +05:30
Nikhil Mohite
5b9383c880 Fixed an issue where the user is unable to create an index with concurrently keyword. Fixes #6790 2021-10-12 18:19:40 +05:30
Khushboo Vashi
9fd9ca2673 Added support for indent guides in the browser tree. Fixes #4596 2021-10-12 17:53:38 +05:30
Khushboo Vashi
ac6c6fbf97 Fixed an issue where the browser tree doesn't show all contents on changing resolution. Fixes #6881 2021-10-12 15:02:46 +05:30
Khushboo Vashi
ca40add29b Ensure that columns should be displayed in the order of creation instead of alphabetical order in the browser tree. Fixes #6882 2021-10-12 14:37:06 +05:30
Rahul Shirsat
2ced82c7b3 Ensure that query highlighting color in the query tool should be less intensive. Fixes #6754 2021-10-12 14:30:29 +05:30
Aditya Toshniwal
a92c1b43a2 1) Added support for advanced table fields like the foreign key, primary key in the ERD tool. Fixes #6081 
2) Added index creation when generating SQL in the ERD tool. Fixes #6529
 2021-10-11 17:42:14 +05:30
Khushboo Vashi
9796f50362 Fixed an issue where the tree is not scrolling to the object selected from the search result. Fixes #6828 2021-10-07 17:23:21 +05:30
Aditya Toshniwal
dce5038ffd 1. Unable to create trigger for partition table. Fixes #6867. 
2. Unable to create index, RLS policy, rules, triggers for partition. Fixes #6868.
 2021-10-06 14:54:01 +05:30
Nikhil Mohite
ea706be7fc Fixed the issue related to the privilege checkbox color in disabled mode. 2021-10-05 14:38:00 +05:30
Aditya Toshniwal
400896c563 1. Operators dropdown disabled. Fixes #6771. 
2. Vacuum options value is not considered for M-SQL when creating. Fixes #6781.
 2021-10-05 14:13:15 +05:30
Nikhil Mohite
40b8da8223 Fixed theme related issues after react porting. 2021-10-04 18:00:09 +05:30
Khushboo Vashi
8faec3e0e9 Fixed loading issue of Partitions collection node. Fixes #6844 2021-10-04 16:15:49 +05:30
Khushboo Vashi
1ec1db1ecb Fixed an issue where label is not visible on hover, while hover on icon or expand arrow. refs #6847 2021-10-04 13:15:19 +05:30
Aditya Toshniwal
038fd6ce21 Fixed Dark theme UI related issues. Fixes #6846 2021-10-04 12:41:48 +05:30
Khushboo Vashi
65af8bcc5a Fixed an issue where the label is not visible when hovering on any tree node in the High Contrast theme. Fixes #6847 2021-10-04 12:35:08 +05:30
Khushboo Vashi
44e1a405f0 1) Newly added server/server group is not visible in the tree unless pgAdmin is refreshed. Fixes #6839 
2) Internal server error displayed if disconnect the server. Fixes #6852
 2021-10-03 12:12:02 +05:30
Nikhil Mohite
5f9bb1c160 Correct the implementation of query details should be scrollable as per design. 
Fixes #3827
 2021-10-01 13:01:24 +05:30
Aditya Toshniwal
357a020828 Table node related fixes: 
1. File select control sets the value for all other to last selected file. Fixes #6814
2. Vacuum parameters-related issues. Fixes #6777
3. Exclusion removes all columns if one row is removed. Fixes #6771
 2021-10-01 12:57:04 +05:30
Khushboo Vashi
5e0c113c7b Properties panel is not updated when any object is added/deleted from the browser tree. Fixes #6833 2021-09-30 18:21:43 +05:30
Nikhil Mohite
1a25fdffbb Ensure that the 'When' field should be read-only in the properties panel. Fixes #6836 2021-09-30 16:25:27 +05:30
Aditya Toshniwal
381f5edbd5 Few more stability improvements to date time picker. 
refs #6816
 2021-09-30 15:00:32 +05:30
Nikhil Mohite
3da85f415d Fixed an issue while saving grant wizard data with user-defined functions. Fixes #6826 2021-09-30 10:56:51 +05:30
Akshay Joshi
1b6ab6b3bb 1) Fixed pgAgent related issues. Fixes #6827 
2) Added helpMessageMode parameter to hide help messages from properties panel.
 2021-09-29 19:48:43 +05:30
Khushboo Vashi
aa8854db53 1) Browser panel turns blank on connecting disconnected database & server has multiple databases. Fixes #6817 
2) The object is not selected/properties panel is not updated when the user moves to object with arrow keys. Fixes #6821
3) Object gets deselected after editing. Fixes #6824
 2021-09-29 17:18:55 +05:30
Aditya Toshniwal
332351efaf 1. Date time control not working on firefox. 
2. Replace moment with date-fns in date time control as date-fns is more maintained.

Fixes #6816
 2021-09-29 13:43:05 +05:30
Rahul Shirsat
77d0409c5b Fixed an issue where the user was not able to expand the server's on Windows. Fixes #6822 2021-09-29 13:35:54 +05:30
Akshay Joshi
7d07770244 Reverting 'Two-factor authentication' support as it cause OSX and docker build failures. 
This reverts commit 787a441343.
 2021-09-29 13:24:18 +05:30
Khushboo Vashi
24399daefe 1) Browser panel turns blank on connecting/disconnecting the database when the 
server has multiple databases. Fixes #6817
2) Use a hand pointer instead of an arrow. Fixes #6820
 2021-09-28 17:50:54 +05:30
Aditya Toshniwal
08706ba6b2 1. Make Unlogged switch in table as read only. 
2. Fix a console warning when saving node data.

Fixes #6778
 2021-09-28 17:48:09 +05:30
Ashesh Vashi
787a441343 Added support for Two-factor authentication for improving security. Fixes #6543 2021-09-28 17:47:00 +05:30
Khushboo Vashi
31c7f3eaba Fixed an error in browser tree when adding any node. 2021-09-28 15:08:59 +05:30
Aditya Toshniwal
be69470d55 Server and Database node fixes: 
1. Unable to change shared server switch.
2. DB restriction and schema restriction have an empty option.
3. File select input control does not allow manual text input.
4. In the Parameters tab if the value is a switch control, then an empty value error should not come.
5. Values for parameters should be reset on changing parameters.
6. Added a new key - helpMessageMode which can have a value similar to mode. It will show the help message if the mode is supported.

Fixes #6814
 2021-09-28 15:05:32 +05:30
Khushboo Vashi
7b6101bc6d Fixed 'Save' button issue where dialog is not getting closed. 2021-09-28 15:04:37 +05:30
Aditya Toshniwal
dc8ab7cd2a 1. Switch control and CodeMirror control UI improvements for read-only and disabled states. 
2. If a form input value changes to null, pass it as an empty string in URL params.
3. Use server_type instead of type from the server info.
 2021-09-28 10:24:25 +05:30
Khushboo Vashi
483e2ca8d0 Port browser tree to React. Fixes #6129 2021-09-27 16:44:26 +05:30
Aditya Toshniwal
0228d16990 Partition related fixes: 
1. When attaching a partition, tables were not loading in the dropdown.
2. When adding a sub partition in a partition, collations were not loading in dropdown.
3. Fix some grid column widths in table node.

Fixes #6783
 2021-09-24 16:28:55 +05:30
Aditya Toshniwal
d28f8bc7ee Fixed exclusion constraint issues: 
1. Incorrect error message.
2. Properties panel Column Section data missing
3. Operator class value is missing

Fixes #6771
 2021-09-23 19:28:35 +05:30
Akshay Joshi
8125320093 Fixed linter error. 2021-09-23 17:12:34 +05:30
Akshay Joshi
ecaaa8a1b5 Fixed scrollbar issue and used flex layout in grant wizard. 2021-09-23 16:59:59 +05:30
Akshay Joshi
b9bc628189 1. Placeholder should be inside the controlProps. Change the placeholder from 'Select...' to 'Select an item...' 
2. Updated grant wizard screenshot and documentation.
3. Remove '(Beta)' from ERD Tool and PSQL Tool.
 2021-09-23 16:17:39 +05:30
Aditya Toshniwal
9179b7464b Fixed following issues after React Porting: 
1. Unique constraint should not allow changing values for deferrable, deferred, included columns.
2. Primary keys should not allow changing values for deferrable, deferred, included columns.
3. Foreign keys should not allow changing match type. The referenced table name is empty.
4. Exclude - Column/Expression has incorrect values.
5. Save should not be enabled when Custom auto-vacuum is enabled but none of the parameters are edited.

Fixes #6777
 2021-09-23 14:46:10 +05:30
Nikhil Mohite
15a494c189 Fixed review comments for Grant Wizard. 
refs #6687
 2021-09-23 14:40:38 +05:30
Aditya Toshniwal
78c8fbbe00 Fixed an issue where the Properties panel was not loaded for catalog tables. Fixes #6778 2021-09-23 10:42:50 +05:30
Aditya Toshniwal
a1aa080956 Fixed an issue where unable to change the column properties from edit dialog. Fixes #6766 2021-09-22 18:23:40 +05:30
Aditya Toshniwal
a8c8ea69e3 Foreign Key fixes: 
1. Auto FK related fixes.
2. Properties tab not showing columns.
3. Toggle button is editable even if set to read-only.
4. Dropdown placeholder should be blank for read-only/disabled.
5. Input control help text color on a dark theme.

Fixes #6770
 2021-09-22 18:18:09 +05:30
Aditya Toshniwal
fc86faf51e Changed the layout for tables from block layout to flex layout to fix the width of the columns as per the dialog size. 2021-09-22 18:11:50 +05:30
Akshay Joshi
71d7b14320 Remove unused files. 2021-09-22 13:12:46 +05:30
Akshay Joshi
6b100b60f8 Remove word break for dialog labels. 2021-09-21 17:15:53 +05:30
Aditya Toshniwal
08009f8edc 1) Make default values column read-only for inherited columns when creating table. 
2) Default values not populated for inherited columns. The existing issue, API changed.
3) Options are not populated for Name in Column > Variable tab.
4) The empty check error message is changed from Label cannot be empty to Label in Collection cannot be empty for collections.

Fixes #6763
 2021-09-21 16:56:29 +05:30
Nikhil Mohite
d27b4831d6 Fixed the issue where password field is showing as plain text. 2021-09-20 13:05:58 +05:30
Nikhil Mohite
44e770aa0b Updated query error row selection color as per dark theme style guide. Fixes #6723 2021-09-17 21:04:49 +05:30
Aditya Toshniwal
32e97b6422 Fixed the CSS issue causing extra space at the bottom of maintenance backup dialog. 2021-09-17 20:47:03 +05:30
Yogesh Mahajan
02ed2289e6 Fixed errors thrown for empty CSS files. 
refs #6705
 2021-09-09 16:10:09 +05:30
Rahul Shirsat
55e7e481d4 Fixed an issue where collapse and expand arrows mismatch in case of nested IF. Fixes #6712 2021-09-09 16:04:59 +05:30
Aditya Toshniwal
f874276d0f Added some missing propTypes. 2021-09-09 15:57:17 +05:30
Akshay Joshi
eeff75ba20 Remove GPDB support completely. Fixes #6692 2021-09-09 13:09:53 +05:30
Aditya Toshniwal
f7b8969c72 Stability and bug fixes for the react schema view framework. 2021-09-09 13:09:53 +05:30
Aditya Toshniwal
af27af8d42 Integer and Numeric inputs fixes. 2021-09-09 13:09:44 +05:30
Aditya Toshniwal
73e1cbc0b9 Change the parse changes logic to get changes at any level of depth. 2021-09-09 13:09:42 +05:30
Aditya Toshniwal
d62fba024b - Focus on first tab and first element on reset. - Move formErr to state context. 2021-09-09 13:09:42 +05:30
Aditya Toshniwal
ae49b556ce - Properties tab should refresh if node is updated. - Error should be hierarchical and not just id based. 2021-09-09 13:09:41 +05:30
Aditya Toshniwal
2a76027cce - Fix codemirror cursor issue. - Fix foreign table jasmine test cases. 2021-09-09 13:09:30 +05:30
Aditya Toshniwal
c02705c53c - Fix all the jasmine test case failures. - Show default value column in Table->Columns grid. Fixes #4353. 2021-09-09 13:06:24 +05:30
Aditya Toshniwal
27e446a0b0 Fixed following: - Dropdown selected menu color - CodeMirror render on properties tab - Placeholders on select control - Codemirror borders 2021-09-09 13:06:24 +05:30
Akshay Joshi
4bfffa3806 Port FTS Configurations node to react. Fixes #6638 2021-09-09 13:06:24 +05:30
Aditya Toshniwal
261cec1d20 Port Table, Column, Primary key, Foreign key, Check constraint, Unique constraint, Exclusion constraint. 2021-09-09 13:05:57 +05:30
Rahul Shirsat
725d9b4bbf Port package and it’s child node to React. Fixes #6675 2021-09-09 13:04:42 +05:30
Akshay Joshi
b7105093e2 1) Port Compound Trigger node to react. Fixes #6674 2) Remove 'inSchema' method and create a generic method 'inCatalog'. 2021-09-09 13:03:54 +05:30
Aditya Toshniwal
9274df0f11 - Fix Jasmine test cases failing in framework. - More stability fixes and enhancements. 2021-09-09 13:03:54 +05:30
Nikhil Mohite
351cb3e6ca Port Triggers node to react. Fixes #6672 2021-09-09 13:03:54 +05:30
Aditya Toshniwal
bb5e2b98e9 Stability and bug fixes in schemaview react framework. 2021-09-09 13:03:54 +05:30
Akshay Joshi
1b7a77f5cb Port pgAgent and it's child nodes to react. Fixes #6645 2021-09-09 13:03:54 +05:30
Aditya Toshniwal
1ce6c2aee1 Add the plain string component forgot last time. 2021-09-09 13:03:54 +05:30
Aditya Toshniwal
314fcabbeb Add plain string control with formatter. 2021-09-09 13:03:54 +05:30
Aditya Toshniwal
0ddd053e88 Framework stability fixes. 2021-09-09 13:03:54 +05:30
Aditya Toshniwal
9bfef1f6e5 - Add feature to allow collection header form using CustomControl. - Framework stability and bug fixes. 2021-09-09 13:03:38 +05:30
Rahul Shirsat
08f2121544 Port Schema & Catalog node to react. Fixes #6655 2021-09-09 13:01:53 +05:30
Pradip Parkale
1f430227aa Port Subscriptions node to react. Fixes #6634 2021-09-09 13:01:52 +05:30
Akshay Joshi
8dac933a66 Fixed linter error in DateTimePicker control. 2021-09-09 13:01:18 +05:30
Rahul Shirsat
1e07ef13cf Port Types node to react. Fixes #6602 2021-09-09 13:01:18 +05:30
Akshay Joshi
56ef085412 Added DateTimePicker control in React. 2021-09-09 13:00:36 +05:30
Aditya Toshniwal
bcab0e3754 - Fix jasmine test cases. - Unregister listener when row removed in DataGrid. 2021-09-09 13:00:36 +05:30
Aditya Toshniwal
f6ac0d5877 Handle null in note. 2021-09-09 13:00:33 +05:30
Aditya Toshniwal
1810d810d8 Few more UI changes for Note. 2021-09-09 13:00:33 +05:30
Aditya Toshniwal
82ca5145c2 Add the note control. 2021-09-09 13:00:33 +05:30
Aditya Toshniwal
377fe80046 - Add VaccumSettings schema. - Allow collection to have fixed rows. - Changes in data change comparison and add state utils context. - Fixed jasmine test cases. 2021-09-09 13:00:33 +05:30
Akshay Joshi
eb48765a5a 1) Fixed 'Material-UI: You are providing a disabled button child to the Tooltip' 2) Fixed InputToggle value issue. 3) Fixed jasmine test for Language. 4) Remove unused code from the view node. 2021-09-09 13:00:03 +05:30
Aditya Toshniwal
09db3ddd5c Use isFullTab instead of noLabel for full space code field spec. 2021-09-09 13:00:03 +05:30
Nikhil Mohite
d9cfbf592e Port View node to react. Fixes #6637 2021-09-09 12:59:26 +05:30
Akshay Joshi
6d18842dd3 Port Domain and Domain Constraints node to react. Fixes #6330 2021-09-09 12:59:26 +05:30
Pradip Parkale
c474ca2c5f Port Publications node to react. Fixes #6610 2021-09-09 12:55:56 +05:30
Akshay Joshi
be04bea2b6 Port Resource Group node to react. Fixes #6629 2021-09-09 12:55:56 +05:30
Aditya Toshniwal
5db72a6916 - Some UI changes based on review comments. - Fix the numeric type. 2021-09-09 12:55:56 +05:30
Aditya Toshniwal
453f26817a Check if type is string for nested type changes parsing. 2021-09-09 12:55:55 +05:30
Aditya Toshniwal
51c11a21fa Fieldset changes should be included. Fix linter errors. 2021-09-09 12:54:25 +05:30
Aditya Toshniwal
cd9e37bac5 Fix typo in fieldsetview also. 2021-09-09 12:54:25 +05:30
Aditya Toshniwal
3d7450b308 - Fix typo modeSupported. - Add support for collection conditional visibility. 2021-09-09 12:54:25 +05:30
Aditya Toshniwal
48176ea986 Add support for nested-fieldset control. 2021-09-09 12:54:25 +05:30
Pradip Parkale
621426ac55 Port Language node to react. Fixes #6581 2021-09-09 12:52:54 +05:30
Aditya Toshniwal
5d8eeba0dd Fix linter issues in previous commit. 2021-09-09 12:50:32 +05:30
Aditya Toshniwal
a06f78b2d5 - Introduce deps listener context and move the old code. - Add support for deffered deps change - deferredDepChange. - Changes for canEditRow and canDeleteRow. - Select the tab again on visible if it is rendered when hidden. - It is helpful to show the error footer in SQL tab also. - Fix isEmptyString. 2021-09-09 12:50:32 +05:30
Akshay Joshi
5c1ce23780 Port Synonyms node to react. Fixes #6599 2021-09-09 12:50:32 +05:30
Akshay Joshi
4b8e655948 Port Foreign Data Wrapper, Foreign Server and User Mapping nodes to react. Fixes #6583 2021-09-09 12:48:24 +05:30
Aditya Toshniwal
79e1b0c5d8 Added field key - optionsReloadBasis to allow options to be re-loaded. Add formatters to select and input control. 2021-09-09 12:44:37 +05:30
Aditya Toshniwal
de3f3e6e61 Fix jasmine test case failures in SchemaView. 2021-09-09 12:44:37 +05:30
Nikhil Mohite
793dbc6e7f Port Event Triggers node to react. Fixes #6578 2021-09-09 12:44:37 +05:30
Aditya Toshniwal
bd5536dbf9 Fix linter errors in previous commit. 2021-09-09 12:27:42 +05:30
Aditya Toshniwal
6b9e8c3039 Fixes for expanded table row form control. 2021-09-09 12:27:42 +05:30
Aditya Toshniwal
9d33b03be9 Few more changes to core schema framework required by other nodes. 2021-09-09 12:22:05 +05:30
Akshay Joshi
351928a1e0 Fixed minor issue with merging 2021-09-09 12:20:59 +05:30
Aditya Toshniwal
b20558cb99 Some changes to the core code that will be helpful for other nodes. 2021-09-09 12:20:59 +05:30
Aditya Toshniwal
764677431f Added React framework for the properties dialog and port Server Group, Server, and Database dialogs. 
Following changes done for the framework:
 - Framework for creating React based dynamic form view out of a pre-defined UI schema. Previously, it was based on Backform/Backbone.
 - The new framework and components will use MaterialUI as the base. Previously, Bootstrap/Backform/jQuery components were used.
 - The new code uses JSS instead of CSS since material UI and most modern React libraries also use JSS. In the future, this will allow us to change the theme in real-time without refresh.
 - 90% code covered by 80-85 new jasmine test cases.
 - Server group node UI Schema migration to new, with schema test cases.
 - Server node UI Schema migration to new, with schema test cases.
 - Database node UI Schema migration to new, with schema test cases.
 - Few other UI changes.

Fixes #6130
 2021-09-09 12:20:59 +05:30
Nikhil Mohite
22f20a38ec Fixed an issue where the user can not paste the updated table header in safari 12 and 13 browsers. Fixes #4815 2021-08-30 14:46:42 +05:30
Yogesh Mahajan
51d73b1672 Fixed errors related to HTML tags shown in the error message for JSON editor. Fixes #6668 2021-08-26 14:54:51 +05:30
Nikhil Mohite
737bc6a965 Ensure that the lock panel should not be blocked for larger records. Fixes #6570 2021-08-25 11:05:28 +05:30
Yogesh Mahajan
c7fd1ae535 Enables pgAdmin to retrieve user permissions in case of nested roles which helps to terminate the session for AWS RDS. Fixes #6641 2021-08-24 17:01:06 +05:30
Aditya Toshniwal
c64eb3507c Make code folding case insensitive in the code mirror. Fixes #4264 2021-08-23 16:16:20 +05:30
Yogesh Mahajan
1b33c52eac Fixed the JSON editor issue of hiding the first record. Fixes #6684 2021-08-20 13:47:31 +05:30
Yogesh Mahajan
dc4f59e664 Handle null values more correctly. 
refs #5198
 2021-08-09 20:11:39 +05:30
Yogesh Mahajan
8d53c10643 Fixed styling for JSON Editor to match with pgAdmin4 style. 
refs #5198
 2021-08-06 18:01:50 +05:30
Yogesh Mahajan
8e214ca8fb Added support for formatted JSON viewer/editor when interacting with data in a JSON column. Fixes #5198 2021-08-03 11:36:45 +05:30
Akshay Joshi
508f97b08e Rename the "Resize by data?" to "Columns sized by" and disabled the 'Maximum column width' 
button if 'Columns sized by' is set to 'Column data'. Fixes #6622
 2021-07-27 15:17:06 +05:30
Akshay Joshi
a0b2a28ee2 1) Set the default value of the long-running threshold to 2 minutes for warning and 5 minutes for the alert. 
2) Use $color-danger for the alert threshold.
 2021-07-06 19:52:37 +05:30
Khushboo Vashi
48ca83f31d Added support for OAuth 2 authentication. Fixes #5940 
Initial patch sent by: Florian Sabonchi
 2021-07-06 13:22:58 +05:30
Akshay Joshi
ef67409d61 Highlighted long running queries on the dashboards. Fixes #1975 2021-07-01 18:10:55 +05:30
Dave Page
d90472014d Remove leading whitespace and replace it with '[...] ' in the Query Tool data grid so cells don't look empty. 
Fixes #6427
 2021-07-01 09:17:35 +01:00