NuKVM/virt-manager
3
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-02-25 18:55:27 -06:00
Code Issues Packages Projects Releases Wiki Activity
2,923 Commits 2 Branches 64 Tags 141 MiB
4ce1774d53
Commit Graph

96 Commits

Author SHA1 Message Date
Cole Robinson
4ce1774d53 VirtualDisk: Rework provisioning and validation behavior 
We separate all the provisioning bits to diskbackend.py. VirtualDisk
users now need to explicitly opt in to storage creation by using
set_create_storage().

validation is no longer done automatically, users must call the
validation() command.

__init__ drops all extra parameters.

This will eventually get us to a point where we can unify the manual
XML building and XML parsing machinery, and get consistent validation
behavior between devices.
 2013-07-13 16:37:33 -04:00
Cole Robinson
fbf2d9ee40 VirtualDisk: Convert simple props to unified parse/get/set 2013-07-12 15:26:51 -04:00
Cole Robinson
ce243314c0 tests: Verify that every new style XML prop is exercised 
coverage isn't going to help us much here, so add some hacky infrastructure
to ensure that xmlparse.py is touching every new style xmlprop.
 2013-07-12 15:19:37 -04:00
Cole Robinson
dcd632da80 XMLBuilder: Provide default fget and fset impls 
This is the first step towards unifying the XML handling split between
parsing and creating from scratch. Demonstrate it with VirtualDisk.iotune
bits.
 2013-07-12 14:41:29 -04:00
Cole Robinson
f620b317b9 tests: Make sure all XML use " for quoting 
This is what libxml outputs with, and it's going to mess up
test output with upcoming tests.
 2013-07-12 14:19:54 -04:00
Cole Robinson
b26fd8fa3e tests: Minor cleanup in xmlparse 2013-07-12 13:10:23 -04:00
Cole Robinson
f1b55090d2 VirtualDisk: Drop cache and io from __init__ 
They are barely used and can be specified separately.
 2013-07-12 13:10:23 -04:00
Cole Robinson
57d4fcab33 VirtualDisk: Drop the volName parameter, it's not needed 2013-07-12 13:10:22 -04:00
Cole Robinson
c151b75896 XMLBuilder: Remove largely unused validation helpers 
They aren't adding much value
 2013-07-12 13:10:22 -04:00
Cole Robinson
7a2caee6e1 VirtualConnection: Allow using virt-manager object caches 
So when we call into virtinst it doesn't do a whole round of object
lookup and XML fetching.
 2013-07-07 18:54:08 -04:00
Cole Robinson
c406a6433c VirtualConnection: cache version lookups 2013-07-06 15:39:00 -04:00
Cole Robinson
94f8d4cfa9 VirtualConnection: cache capabilities XML 
This means we can drop passing around the pre-parsed caps info everywhere.
 2013-07-06 14:12:13 -04:00
Cole Robinson
3005382e0d Make is_blktap_capable take a connection 
So we don't perform the check if we're using a remote connection
 2013-07-06 12:44:53 -04:00
Cole Robinson
ba3aa9ecca Drop conn_max_vcpus validation 
Let's just let libvirt throw an error in the rare occasion that we
exceed max vcpus.
 2013-07-06 12:40:24 -04:00
Cole Robinson
492a039f7d VirtualConnection: proxy virtinst.support API 
Simplifies the lives of callers, and will allow us to do caching later
 2013-07-06 12:40:24 -04:00
Cole Robinson
57e86259d8 Make conn required for all virtinst objects 
This was the way the API had been heading, this just formalizes it.
 2013-07-05 20:28:21 -04:00
Cole Robinson
be2d9ddcb4 Add base conn object and bump minimum libvirt version to 0.6.0 
This base connection object will be used to simplify the API in various
places, reduce libvirt API calls, and better share code between virtinst
and virt-manager. For now it just centralizes connection opening.

This also exposed various places where our handling for older libvirt
was busted, so raise our minimum host version to 0.6.0, the first
version that supports threaded client requests.
 2013-07-05 16:42:19 -04:00
Cole Robinson
ea2a1331cf virtinst: Guest: Simplify passing in a connection 2013-07-03 13:37:00 -04:00
Cole Robinson
e973f34c41 virtinst: Remove User module 
I'm sure the solaris support is totally broken, so just drop this
overcomplicated abstraction.

Also fix a bug where we were using usermode networking in a bunch of
places where it isn't supported.
 2013-07-02 21:17:07 -04:00
Cole Robinson
802ed1cba6 clone: Bunch of API cleanup 
Simplify imports, drop back compat stuff, drop needless property handling.
 2013-07-02 18:54:03 -04:00
Cole Robinson
771707fb9c Minor TPM UI fixups 2013-06-26 20:20:12 -04:00
Stefan Berger
2766dd5c6a Add GUI elements for TPM passthrough details 
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
 2013-06-26 19:45:16 -04:00
Stefan Berger
93718868c7 Add CLI support and CLI test cases 
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
 2013-06-26 19:43:58 -04:00
Stefan Berger
c829b55581 Add VirtualTPMDevice class to virtinst 
Add VirtualTPMDevice class and TPM test cases to xmlparse.py

Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
 2013-06-26 19:43:53 -04:00
Martin Kletzander
137134650f Allow partial address formatting 
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
 2013-06-19 18:18:32 -04:00
Cole Robinson
0283750b9d Fix USB test failures with latest libvirt 2013-06-14 14:58:52 -04:00
Cole Robinson
f625cf66d4 testdriver: Add guest using a duplicate host USB device 2013-05-11 11:44:25 -04:00
Guannan Ren
32f0781531 addhardware: differentiate duplicate usb devices by bus/addr 
When there are multiple usb devices with same vendor/product
in the host device list, the bus/addr is going to be used when
attaching one of usb devices.

Currently is_dup flag is only useful to VirtualHostDeviceUSB.

I put get_nodedevs_number() in connection.py, so the startup
hooks can use it.
 2013-05-09 13:48:18 -04:00
Guannan Ren
0802cb1add virtinst: throw error when --host-device can't specify unique device 
When there are mutiple USB devices with identical vendorId and
productId, with --host-device <vendorId:productId>, virt-install
fails to specify one.
Currently the virt-install add the first node device with
these vendorId and productId.
This fix will throw out an error when argument to --host-device
can't specify unique node device.

For example:
virt-install ${other args} \
             --host-device <vendorId:productId>
ERROR    15e1:2007 corresponds to multiple node devices
 2013-04-25 13:40:23 -04:00
Cole Robinson
6f4167a66f clone: Fix --preserve-data --file /existing/storage/vol 
We were validating storage creation in a bunch of cases where we
shouldn't, since it was all skipped anyways.
 2013-04-24 10:50:20 -04:00
Cole Robinson
8d1ad359ee Don't leave *c files around after tests 2013-04-23 17:19:27 -04:00
Cole Robinson
b2041f7399 clitest: Remove massive dict, turn test cases into objects 
This will make it easier in the future to annotate test cases with
libvirt version information, so the test suite can work across
libvirt versions.
 2013-04-23 17:18:34 -04:00
Cole Robinson
6f7fca5f2a tests: Greatly expand testdriver.xml 
Mostly comes from my own testdriver I used for manual virt-manager testing.
Add some notes to HACKING about using it.
 2013-04-21 13:34:51 -04:00
Cole Robinson
191fff8c0c tests: Make sure virtinst doesn't pull in Gtk 
Add an explicit test to warn if it inadvertently happens
 2013-04-18 16:41:02 -04:00
Cole Robinson
07e0c92b4b Remove a bunch of outdates FIXME/XXX comments 2013-04-17 09:32:00 -04:00
Cole Robinson
0f57dae8b2 virtinst: Remove not-very-useful post_install_check 
It doesn't work in a variety of cases and it's not very useful
to begin with.
 2013-04-15 12:37:36 -04:00
Hu Tao
ee7168e6f9 Add and fix test cases for cpu mode attribute 
This patch adds and fixes test cases for cpu mode attribute.

Signed-off-by: Ken ICHIKAWA <ichikawa.ken@jp.fujitsu.com>
Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>

(crobinso: Minor rebase tweaks)
 2013-04-14 13:55:26 -04:00
Cole Robinson
1771f6a300 tests: Replace 'scriptimports' with a much simpler method 2013-04-13 15:38:53 -04:00
Cole Robinson
0d243983d0 Revive pep8 and clean up the code 
autopep8 is pretty cool :)
 2013-04-13 15:22:43 -04:00
Cole Robinson
fcc680cae1 Use an RC file for pylint 
Will let use tweak things easier in the future
 2013-04-13 15:22:29 -04:00
Cole Robinson
3f79fa3919 Fix the last of the pylint messages 
If using an older pylint, there are still some complaints about hashlib
and Popen, but those aren't our problems.
 2013-04-13 13:45:08 -04:00
Cole Robinson
baf531f710 virtinst: Guest: Remove back compat static device lists 2013-04-13 13:40:45 -04:00
Cole Robinson
248a1a509f virtinst: Guest: remove legacy 'boot' handling 2013-04-13 13:40:45 -04:00
Cole Robinson
7a47465ab6 virtinst: Guest: remove back compat graphics handling 2013-04-13 13:40:45 -04:00
Cole Robinson
9359ad2bb6 virtinst: Remove ParaVirt and FullVirtGuest 
They were just around for back compat at this point, the tools
have moved on.
 2013-04-13 13:40:45 -04:00
Cole Robinson
ae471007fc Tons of misc pylint fixes 2013-04-13 13:40:29 -04:00
Cole Robinson
a386186c74 Remove most map() and filter() usage 
They aren't available on python3 so pylint complains, and list
comprehensions are usually better.
 2013-04-12 08:27:44 -04:00
Cole Robinson
c5e45ae448 Remove all relative imports 
We also drop VirtualDevice from the 'public' virtinst API, since there
are better ways to get its info.
 2013-04-12 08:27:44 -04:00
Cole Robinson
aead0135b0 setup.py: Re-add 'pylint' subcommand 
We drop our hacky shell wrappers, and just track it all in setup.py
 2013-04-12 08:27:09 -04:00
Cole Robinson
69d3f21da6 virtinst: nic: Don't check MAC collision with host 
It was:

- Slow
- Not that useful
- Only worked in the local case

If anyone cares, the proper thing to do is implement it with the iface APIs.
 2013-04-11 12:15:37 -04:00