Commit Graph
100 Commits
Author SHA1 Message Date
Magne Sjaastad 5bd492dc56 Adjustments before release
* Make sure existing project files do not filter intersection geometry by cell filters

* #10241 Temporarily revert changes to resampling changes
These fixes had unintended side effect on well flow plot and rft plots seen in regression tests
https://github.com/OPM/ResInsight/issues/10241

* Update version number
2023-06-08 09:13:22 +02:00
Magne Sjaastad 76102a8396 Maintenance issues
* Improve toggling of checked state of sub items
Toggling state is only supported for objects in an array. For example, this will ensure that faults are toggled without altering the fault result object.

* Use gray instead of black for icons

* #9719 Use delete instead of deleteLater to avoid visual artifacts
Artifacts are seen in the Property Editor related to obsolete group boxes. This seems to be related to deleteLater().

* Improve text in menu when toggling sub items

* #10011 Make sure all grid cases are visible in RFT data source

* #10354 Show more info when hovering on curves in summary plot

* #10355 Copy model text info in 3D view to clipboard

* Make sure cell filter option is propagated to new field
Make sure the previous value of  m_showFaultsOutsideFilters_obsolete is propagated into m_applyCellFilters

* Fix wrong spelling when using of stylesheet color
2023-06-06 15:45:54 +02:00
Magne Sjaastad 14311dec3b #10349 Avoid calling performUpdate() in showEvent()
When a dock widget in a dock widget tab group is activated, a show event is triggered in IumMultiPlotBook::showEvent. This causes a crash if performUpdate is called in showEvent. Make sure the performUpdate is called from RimMultiPlot::onLoadDataAndUpdate()
2023-06-06 12:51:37 +02:00
Magne Sjaastad bcc00adea1 Add edit button to grid calculation expressions
Implement add calculation from grid cell result
2023-06-05 09:07:14 +02:00
Magne Sjaastad 576156763a Add missing update to intersection box
Make sure that default values set in the Rim-object is propagated to UI
2023-06-03 15:01:06 +02:00
Magne Sjaastad 308c697feb Add missing disableIO to proxy fields 2023-06-03 15:01:06 +02:00
Magne Sjaastad 9a159cc02d Performance: Property filter on a time step difference case is slow #10339 2023-06-02 16:34:21 +02:00
Magne Sjaastad 709457f7c2 About text: Add Python version
#10224 About text: Add Python version
2023-06-02 14:04:23 +02:00
Magne Sjaastad d702b7a5d4 Use dark title bar for dark theme on Windows 2023-06-02 10:47:10 +02:00
Magne Sjaastad f091a6237f Support multiple RFT observation files
Add support for date on format yyyy-MM-dd
Support observations in multiple files
2023-06-02 09:32:47 +02:00
Magne Sjaastad fc51bf84a5 Make sure one case is loaded when both SMSPEC and ESMRY is present in same folder 2023-06-02 07:52:35 +02:00
Magne Sjaastad 24ccbf395d Adjust dark theme
- Disable custom CSS for advanced docking system
- copy and adjust stylesheet into default/dark qss
- Use #999999 for fill color in svg images
2023-06-02 07:28:45 +02:00
Magne Sjaastad 0e25f364f8 Fix build issues MSVC 17.6.2 2023-05-31 12:49:01 +02:00
Magne Sjaastad bd1fbcf45a VFP-plot: Wrong X-axis label for Gas Injection Rate
* Use text "Gas/Liquid Flow Rate" 
* Use Sm3/day as unit for Flow rate
2023-05-30 15:57:29 +02:00
Magne Sjaastad a9f412b1f6 Maintenance fixes
* Remove light mode from theme selection
The light mode is not working well, and was intended to be used when exporting to pdf from dark mode.

* Allow direct edit of summary case name
The name for a summary case can be automatically created. If the user starts to edit the name manually, set the name option to Custom. Make the descriptionField available as not read-only, then it is possible to edit the name directly in the project tree using F2 or double-click.

* Allow drag of ensembles
* Add support for drag/drop of well segments
* Add support for well segment number stepping in toolbar
2023-05-30 15:56:19 +02:00
Magne Sjaastad cca852ef1f Adjustments related to user course
* #10285 Grid Cross Plot: Fix group highlighting
* #9329 Make Show plot data more robust
* Do not show the curve color tag for grid cross plot curves
* #10310 Add tab to show plot data for well log curves
2023-05-26 11:47:26 +02:00
Magne Sjaastad b7420ebc70 Use rock type colors when "Facies" is imported 2023-05-26 11:26:22 +02:00
Magne Sjaastad 473f1bebcd #10281 Make sure missing data is marked with NULL
If an ensemble do not have data for some realizations, Show Plot Data reported wrong data when resampling was activated. Display of data for No Resampling was correct.
2023-05-24 15:01:59 +02:00
Magne Sjaastad fc8235aeca #10035 Make sure segment summary is present in plot editor 2023-05-23 19:45:45 +02:00
Magne Sjaastad 2776012bce #7134 Create modelled well path from well path
From an existing well path, find some coordinates along the geometry and create a new modelled well path based on these coordinates.
2023-05-23 12:13:53 +02:00
Magne SjaastadandJørgen Herje 40080a99de 9978 Improve UI for long drop-down lists, use tree selection more
* Improve tree selection editor
- always call defineEditorAttributes
- use heightHint in editor attributes 
- use tree selection editor as default editor for std::vector

* Use tree selection editor instead of list selection editor
List selection editor must be used when editing std::vector<cvf::vec3d> and similar. Replace other use of list selection editor with tree selection editor.

* Set checked state based on text string for integer only models
For models with only integer values, use text string to define the items to be selected. The full list will always be visible, and the checked state will be updated when editing the filter text.

Example: "1, 5-7" will set items 1, 5, 6, 7 checked and all other items unchecked

* Minor fixes
- Set placeholder text after content is added (to ensure correct data type)
- Fix check of integers. `canConvert<int>()`returns true for both QString and int. Thus convert to string and then check for int conversion.

* Activate filtering when unchecking all items in list with only integers
- Reactivate filtering when uncheck of all items for a list with only integer values (to keep consistency between filter and list)
- Update function name for clarity

---------

Co-authored-by: Jørgen Herje <jorgen.herje@ceetronsolutions.com>
2023-05-22 15:44:37 +02:00
Magne Sjaastad ee724633b5 Category legend improvements
* Show text after value in category legend
* Use integer slider for category results
* Do not allow min larger than max and max lower than min
2023-05-22 15:41:48 +02:00
Magne Sjaastad bce8177033 Delete some unused variables and disable warnings 2023-05-21 15:15:09 +02:00
Magne Sjaastad f4dd1d363d Add prefix to cmake options
Add missing RESINSIGHT_ prefix to cmake options
GHA: Fix warnings
2023-05-19 15:03:04 +02:00
Magne Sjaastad 95e3435384 Update pull request actions 2023-05-18 21:21:33 +02:00
Magne Sjaastad 873ff95c13 Disable some warnings for MSVC 2023-05-16 15:53:05 +02:00
Magne Sjaastad 451254bc84 #10273 Set default value for "Immport Advanced MSW Data" to true 2023-05-16 13:12:57 +02:00
Magne Sjaastad 54f0a832de Janitor: Remove unused includes 2023-05-15 15:43:01 +02:00
Magne Sjaastad 0c90f67dcc Change API for PdmObjectHandle and PdmFieldHandle
* Refactor interface to PdmObjectHandle and PdmFieldHandle
Return objects instead of passing in structures as parameters

* Add nodiscard to several functions
* Remove redundant this->
* Rename to ptrReferencedObjectsByType
2023-05-12 21:41:34 +02:00
Magne Sjaastad 37e29a0f68 Display all data if multiple fractures crosses a cell
- add the operator<=> for QString
- add operator<=> to fracture report item
2023-05-12 16:23:01 +02:00
Magne Sjaastad 2b0906c2ab Regression Test: Fix wrong flow diagnostics result
Fix regression introduced in 5ee764af48
2023-05-12 16:22:44 +02:00
Magne Sjaastad 5ee764af48 Refactor result definition 2023-05-11 08:37:58 +02:00
Magne Sjaastad 1c0649db77 Move caf.h/cpp to UiCore 2023-05-10 11:02:35 +02:00
Magne Sjaastad 3208abad19 Show category text in legend
Create empty string for standard legends. Show category text if present.
2023-05-09 15:07:52 +02:00
Magne Sjaastad f70d2c4949 Add result type and create and use custom legend if possible
* Update submodule
* Use postfix functions and add custom color legend

* Add type to RigEclipseResultAddress
Read types from ROFF and create default legend based on type or custom created legend.

* Use caseId to connect legend configuration to result in a case
2023-05-09 11:41:56 +02:00
Magne Sjaastad bc718db7df Regression Test: Fix parsing of string lists from command file
* Regression Test: Fix parsing of string lists from command file
The strings in a string list in a command file are quoted
2023-05-05 09:18:17 +02:00
Magne Sjaastad c55d46c080 GHA: Use precompiled opm-common
* GHA: Use precompiled opm-common
* Fix cmake logic
2023-05-02 12:32:09 +02:00
Magne Sjaastad c9839fcf93 #10191 Return ECLIPSE_UNDEFINED without crashing 2023-05-01 18:56:51 +02:00
Magne Sjaastad bb0ae9e381 Add optional download of binaries in build
* #10202 Download and use binaries as part of a build
2023-05-01 18:44:05 +02:00
Magne Sjaastad b447ff86bb Add optional support for download of geomech dependencies 2023-05-01 18:35:59 +02:00
Magne Sjaastad 3bca1507b2 Fix launch of unit tests 2023-04-28 15:20:02 +02:00
Magne Sjaastad 448e3dfcbc #10191 Read NNC data from INIT file for Intersect files 2023-04-28 11:38:23 +02:00
Magne Sjaastad f3faf4642a Avoid out of bounds value access in vector 2023-04-27 10:24:13 +02:00
Magne Sjaastad f0b28170da Copy openvds libraries to binary build folder 2023-04-27 08:44:51 +02:00
Magne Sjaastad 0907f57de9 Use target_include_directory
* Fwk: Avoid use of include_directories
* Remove target_include_directories from Commands
* Refactor cmake includes
- Avoid using include_directories, and use target_include_directories.
- Use add_subdirectory directly from main cmakefile, do not use in ApplicationLibCode.
2023-04-25 13:14:26 +02:00
Magne Sjaastad 90ccf447fb Download and use openvds package (#10153)
Download and use openvds package
2023-04-24 17:10:51 +02:00
Magne Sjaastad f8c1eebe01 Use AABB tree to speed up fault distance calculation 2023-04-24 12:40:25 +02:00
Magne Sjaastad 10adcbc082 Disable warnings on MSVC when including HDF5 2023-04-24 12:40:25 +02:00
Magne Sjaastad 48203115b1 Set python version for linting 2023-04-24 07:54:13 +02:00
Magne Sjaastad 643ccd67b8 Improve ensemble curve colors
* Use unique_ptr
* Improve default assignment of curve appearance
* Improve display of color tags in tree view items
* Select curve or ensemble instead of plot
* Only change curves connected to a Rim-object

* Improve color management for ensemble curves
Use a base color for statistics curves and set realization curves transparent
Make sure new curves are assigned a unique color
Harmonize how dropped addresses are handled

* Update all tags always
The update of tags for a subset of tree nodes is currently broken. Always update all tags.

* Add const
2023-04-19 15:36:06 +02:00
Magne Sjaastad d4f11e0f8f WBS-plot: Add optional support for maximum curve interval for UCS parameter curve (#10118)
* WBS-plot: Add optional support for maximum curve interval for UCS parameter curve
* GeoMech: Guard out-of-bound access to Pore pressure data
2023-04-19 07:16:13 +02:00
Magne Sjaastad b7f8d0e0f1 Increase warning level
* Set warning level to /W3 for MSVC to catch more warnings
* remove several excluded checks for clang
* removed several unused variables
* Hide warnings qwt
* add missing parentheses in logical expressions
* Remove double check on same logical expression
2023-04-17 15:57:39 +02:00
Magne Sjaastad 6f6dc80bc6 Added more clang-tidy checks
Improved GitHub Action to run clang-format as part of clang-tidy

* Simplify clang-tidy workflow
* Added modernize-use-using, modernize-redundant-void-arg, readability-static-accessed-through-instance
* Add nolint for libecl typedefs
2023-04-14 14:07:45 +02:00
Magne Sjaastad 952e766c2f Update clang-format.yml (#10068)
* Update to clang-format-15
Removed two custom .clang-format files in subfolders of AppFwk

* Fixes by clang-format
2023-04-13 07:05:53 +02:00
Magne Sjaastad 310b54ef93 Remove test code related to producer/injector table plots
This code caused legend config to be reset to 1 number of levels.
2023-04-11 10:16:43 +02:00
Magne Sjaastad e8f6d4819f Make sure file paths are resolved before initAfterRead() is called 2023-04-03 16:08:40 +02:00
Magne Sjaastad b2e8cc1663 Add optional max distance between curve points in WBS plots 2023-03-31 16:27:14 +02:00
Magne Sjaastad cde96a39f6 Remove test code for ccache 2023-03-31 16:01:56 +02:00
Magne Sjaastad ee1b363ae0 Add support for field of std::pair<T, U> 2023-03-31 10:21:56 +02:00
Magne Sjaastad 2509977e5a Use unity build for Windows to reduce build time 2023-03-31 10:01:57 +02:00
Magne Sjaastad 7499811564 MSVC: Move seismic libraries into "Thirdparty" 2023-03-27 13:00:26 +02:00
Magne Sjaastad 173a66a409 Fix type conversion error
Weird conversion error seen for Unity build on MSVC. Single file compile works fine.
2023-03-24 18:32:16 +01:00
Magne Sjaastad ab0b958884 Well Targets: Add scaling factor for well targets 2023-03-24 15:37:30 +01:00
Magne Sjaastad d23c6b4bb6 Janitor: Several code hygiene adjustments (#9981)
* Include all libraries in APP_FWK_LIBRARIES
* Several fixes detected by Static Code Analysis
* Remove unused code
* Add .clang.tidy
* Use QElapsedTimer
* Use horizontalAdvance
* Avoid | between enum of different classes
* Avoid illegal character
* Renaming and reorder of constructor initialization
2023-03-23 15:49:06 +01:00
Magne Sjaastad 2abfd08bd9 Fix typo
Use lowercase for function names


Use const
2023-03-23 15:46:24 +01:00
Magne Sjaastad b21c7028c2 #10002 Do not replace '.' with the current project path
When starting resinsight from a working folder, the project file paths can be relative to this folder (current working folder). If files are referenced relative to current working folder, the file references can start with either '..' or '.'  Make sure that these paths are left unchanged.
2023-03-23 15:45:45 +01:00
Magne Sjaastad 6529b1760d #10003 Use auto-value features only for RimSummaryPlot 2023-03-23 15:45:30 +01:00
Magne Sjaastad 42ea16d64b Create close-label.yml 2023-03-22 07:46:30 +01:00
Magne Sjaastad 911f260d0f Improve robustness of well flow calculator 2023-03-21 18:48:55 +01:00
Magne Sjaastad baf379701c Improve main github action for daily builds
Remove qtscript
Remove use of obsolete action
Improve cache key for vcpkg
2023-03-21 14:14:04 +01:00
Magne Sjaastad b30a8507a9 Avoid use of deprecated action 2023-03-21 14:07:16 +01:00
Magne Sjaastad c6d70a56f5 Improve AppFwk unit testing
* Get Cmake and Ninja
* Remove use of QtScript
* Run user interface test only on Windows
2023-03-21 10:22:14 +01:00
Magne Sjaastad 706c8a5266 Use clang-tidy-15
Update clang-tidy.yml to use clang-tidy-15 to be able to support c++20

Do not use OpenMP, as omp.h is not found during parsing

Remove modernize-use-nullptr, as this does not work with <=> (spaceship operator)
https://reviews.llvm.org/D95714
2023-03-21 10:02:03 +01:00
Magne Sjaastad 37abe17582 Fix multiple defined symbols for unity build 2023-03-20 12:02:23 +01:00
Magne Sjaastad 95b94a1cc7 Bump version after release 2023-03-16 15:30:45 +01:00
Magne Sjaastad f2fa0ad024 9939 Temporary fix for crash situation
Crash is seen on application exit
2023-03-16 14:09:39 +01:00
Magne Sjaastad 26c8883761 Prepare release 2023.03.0 2023-03-16 06:44:32 +01:00
Magne Sjaastad eb4ae78f36 Bump version 2023-03-15 13:40:54 +01:00
Magne Sjaastad 26416c8937 Make sure old project files loads as before 2023-03-15 10:53:08 +01:00
Magne Sjaastad 27959b9d13 Reintroduce RimGridSummaryCase to be able to read existing project files 2023-03-15 06:49:14 +01:00
Magne Sjaastad 09c04cbcd0 Improve RFT reader performance
* #9963 Rft reader: Search for DATA file when required
WSEGLINK is used to establish the branch topology for MSW wells. Search and read WSEGLINK data when segment data is requested by the user. This can be a time consuming operation.
Avoid doing this search for standard RFT plots.

* Make sure that single summary curves are displayed correctly
* Make sure single summary curves are visible in the plot
2023-03-14 13:14:40 +01:00
Magne Sjaastad 064c0adb8c #9956 Summary Plot: Fix update of operations on multiple ensembles
When multiple ensemble curve sets are toggled on/off, it is required to do a full RimSummaryPlot::loadDataAndUpdate() that will call RimEnsembleCurveSet::updateCurves() on all ensembles in the plot. This can be a heavy operation, but will happen only once.
2023-03-13 19:33:36 +01:00
Magne Sjaastad 9b4a3f663e Release adjustments
* Add CON*RAT track for tubing branch
* Set long summary vector name as default, and allow both in curve name
* Use line shift if multiple quantities are present on axis title
Insert line shift if multiple quantities are present, otherwise insert space between individual vector names and the unit text.
* Move Groups between Field and Wells
* Bump version
2023-03-13 19:01:31 +01:00
Magne Sjaastad eb5a0cf936 Add reload and delete of pressure/depth data 2023-03-13 16:09:20 +01:00
Magne Sjaastad ab44f9fa17 Add open in text editor feature 2023-03-13 16:09:20 +01:00
Magne Sjaastad 40c329f3ac Fix selection of multiple pressure/depth sources in plot
Use spaceship operator to fix issue for multiple pressure/depth curves

It was not possible to show two pressure/drop curves at the same time. This was caused by inconsistent implementation of operator< and operator==. Implement operator <=> to simplify the code.
2023-03-13 16:09:01 +01:00
Magne Sjaastad 836822c2b9 Adjustments for release
* Show segment plots in Well Log Plot collection
* Improve menu text for operations related to segment plots
* Show reservoir rates for annulus and device
* Make sure curve objects are visible in the Project Tree
* When importing the first summary case, expand case in project tree
* Bump version
2023-03-13 08:10:33 +01:00
Magne Sjaastad 74fa621332 File - Import: Add "Import Pressure Depth Data"
* #9944 Add "Import Pressure Depth Data"  to import menu
Remove obsolete *InMenuFeatures and set all actions in menu to enabled when the signal aboutToShow() is triggered. This is useful for menus where no selection/context is available.
* Use RiaApplication::enableDevelopmentFeatures() to control visibility
2023-03-10 13:20:39 +01:00
Magne Sjaastad 07a4c13dd4 #9913 Fix import of RFT pressure/depth 2023-03-10 13:20:08 +01:00
Magne Sjaastad f5171310bf Add option for word wrap in label and checkbox
* Add support for word wrap in checkbox label
* QLabelEditor: Add word wrap and support for wide label
Add support for one label widget spanning the area usually consumed by a label widget and an editor widget.
* Use word wrap in summary calculation dialog
2023-03-09 12:46:55 +01:00
Magne Sjaastad 527743a845 Adjustments for release
* Make sure text for multiple wells in same grid cell is displayed correctly
* Improve selection of result in Advanced Snapshot Export
* Restore the main window that was on top when project was saved
* Trim string to make sure '/' is exported with no space in front
* #9872 RFT-plot: Make colors stable for curves in RFT plots
* Set version to RC_02
2023-03-09 08:54:28 +01:00
Magne Sjaastad e2e239fd07 Several RFT plot adjustments
* #9923 Call loadDataAndUpdate() after visibility of curves is updated
This will ensure that all zoom ranges are recalculated based on visible curves.

* #9923 Put new segment plots in RFT Plot collection
* #9923 Add "Create Rft Sement Plot" to RFT plot collection
* #9923 Make sure the main window is displayed when required
Make sure the main window is opened and views updated when a grid model is opened from a summary case.

* #9923 Make sure fieldChanged is triggered when required
Exclude field having the target state. If these fields are included, the one and only call to setValueWithFieldChanged() can contain a field with the target state value. When setting a value to a field with the same value, nothing happens and the UI will get an inconsistent state (some curves toggled off are still visible in a plot).
2023-03-08 07:35:27 +01:00
Magne Sjaastad 51331facac Improve how wells are connected during import
When importing new wells, consider all wells when connecting multi segment wells
Make sure that import of individual well paths will give the same ordering as importing all wells in a single operation.
2023-03-07 12:51:14 +01:00
Magne Sjaastad fc7bde8d35 #9879 Add icon for calculated summary vectors 2023-03-07 07:48:12 +01:00
Magne Sjaastad bf432f8897 Set version to RC_01 2023-03-06 16:03:29 +01:00
Magne Sjaastad 70c1a2c064 Guard null pointer access 2023-03-06 15:57:20 +01:00
Magne Sjaastad c248c9fb57 RFT segment plot adjustments (#9912)
* Delete RFT plot when associated case is deleted
* Rename
* Hide track/curves with no data
2023-03-06 14:34:22 +01:00
Magne Sjaastad 8f786fed5d #9914 Fix import of single case already present in ensemble 2023-03-06 10:45:49 +01:00
Magne Sjaastad a8e131647f #9915 Fix crash when using Plot Editor 2023-03-06 10:26:22 +01:00
Magne Sjaastad 6b83662e9f Convert file path to native separators for clipboard 2023-03-06 10:00:35 +01:00