OilfieldToolsNet/opm-simulators
4
0
Fork 0
mirror of https://github.com/OPM/opm-simulators.git synced 2024-11-22 09:16:27 -06:00
Code Issues Packages Projects Releases Wiki Activity
2546d2b181
opm-simulators/examples/problems/co2injectionproblem.hh

649 lines
23 KiB
C++
Raw Normal View History

re-add the emacs and vim modelines to all source files this makes things easier and IMHO these two lines do not cause any disturbance.
2015-06-18 06:43:59 -05:00
// -*- mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*-
// vi: set et ts=4 sw=4 sts=4:
replace in-file copyright notices by OPM the standard one
2013-12-02 08:48:04 -06:00
/*
This file is part of the Open Porous Media project (OPM).
OPM is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 2 of the License, or
(at your option) any later version.
OPM is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with OPM. If not, see <http://www.gnu.org/licenses/>.
clean up the licensing preable of source files the in-file lists of authors has been removed in favor of a global list of authors in the LICENSE file. this is done because (a) maintaining a list of authors at the beginning of a file is a major pain in the a**, (b) the list of authors was not accurate in about 85% of all cases where more than one person was involved and (c) this list is not legally binding in any way (the copyright is at the person who authored a given change, if these lists had any legal relevance, one could "aquire" the copyright of the module by forking it and removing the lists...) the only exception of this is the eWoms fork of dune-istl's solvers.hh file. This is beneficial because the authors of that file do not appear in the global list. Further, carrying the fork of that file is required because we would like to use a reasonable convergence criterion for the linear solver. (the solvers from dune-istl do neither support user-defined convergence criteria not do the developers want support for it. (my patch was rejected a few years ago.))
2016-03-14 07:21:47 -05:00
Consult the COPYING file in the top-level source directory of this
module for the precise wording of the license and the list of
copyright holders.
replace in-file copyright notices by OPM the standard one
2013-12-02 08:48:04 -06:00
*/
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
/*!
* \file
*
changed: namespace Ewoms -> namespace Opm
2019-09-05 09:21:10 -05:00
* \copydoc Opm::Co2InjectionProblem
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
*/
#ifndef EWOMS_CO2_INJECTION_PROBLEM_HH
#define EWOMS_CO2_INJECTION_PROBLEM_HH
changed: ewoms/models/immiscible -> opm/models/immiscible
2019-09-16 05:07:20 -05:00
#include <opm/models/immiscible/immisciblemodel.hh>
changed: ewoms/linear -> opm/simulators/linalg
2019-09-09 02:20:08 -05:00
#include <opm/simulators/linalg/parallelamgbackend.hh>
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
#include <opm/material/fluidsystems/H2ON2FluidSystem.hpp>
#include <opm/material/fluidsystems/BrineCO2FluidSystem.hpp>
#include <opm/material/fluidstates/CompositionalFluidState.hpp>
#include <opm/material/fluidstates/ImmiscibleFluidState.hpp>
#include <opm/material/constraintsolvers/ComputeFromReferencePhase.hpp>
adapt to the changes in opm-material
2013-11-06 07:50:01 -06:00
#include <opm/material/fluidmatrixinteractions/LinearMaterial.hpp>
#include <opm/material/fluidmatrixinteractions/RegularizedBrooksCorey.hpp>
#include <opm/material/fluidmatrixinteractions/EffToAbsLaw.hpp>
#include <opm/material/fluidmatrixinteractions/MaterialTraits.hpp>
consistently rename "heat conduction" to "thermal conduction" and use "solid energy" laws according to wikipedia the term "heat" is the energy transferred due to a temperature gradient, i.e., it only makes sense if such a gradient is present and this is not necessary for the storage term. this means that technically the term "heat conductivity" is meaningful, but "thermal conductivity" is IMO more consistent. this has partially already been done in opm-material and eWoms it was pretty inconsistent, so it also requires a patch in opm-material.
2018-01-04 08:26:07 -06:00
#include <opm/material/thermal/SomertonThermalConductionLaw.hpp>
adapt to the refactoring of the thermal laws in opm-material
2017-12-11 05:58:30 -06:00
#include <opm/material/thermal/ConstantSolidHeatCapLaw.hpp>
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
#include <opm/material/binarycoefficients/Brine_CO2.hpp>
use the infrastructural code using its new locations
2015-04-28 04:58:21 -05:00
#include <opm/material/common/UniformTabulated2DFunction.hpp>
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
fix some dune 2.3 deprecation warnings also use the actual grid headers for grids, not the corresponding DGF parser header.
2013-12-01 04:51:05 -06:00
#include <dune/grid/yaspgrid.hh>
fix build by always including the DGF parser for a given grid
2014-12-16 05:39:32 -06:00
#include <dune/grid/io/file/dgfparser/dgfyasp.hh>
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
fix some dune 2.3 deprecation warnings also use the actual grid headers for grids, not the corresponding DGF parser header.
2013-12-01 04:51:05 -06:00
#include <dune/common/version.hh>
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
#include <dune/common/fvector.hh>
#include <dune/common/fmatrix.hh>
#include <sstream>
#include <iostream>
#include <string>
changed: namespace Ewoms -> namespace Opm
2019-09-05 09:21:10 -05:00
namespace Opm {
changed: move the Co2InjectionProblem parameters to Opm::Parameters
2024-07-01 07:13:14 -05:00
improve the doxygen documentation the module hierarchy should now even be mildly useful.
2015-06-18 07:18:42 -05:00
//! \cond SKIP_THIS
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
template <class TypeTag>
class Co2InjectionProblem;
improve the doxygen documentation the module hierarchy should now even be mildly useful.
2015-06-18 07:18:42 -05:00
//! \endcond
changed: move the Co2InjectionProblem parameters to Opm::Parameters
2024-07-01 07:13:14 -05:00
do explicit put properties into the the Ewoms::Properties namespace anymore instead, do it implicitly by using the BEGIN_PROPERTIES and END_PROPERTIES macros.
2018-06-14 09:06:05 -05:00
}
[properties] replace BEGIN/END_PROPERTIES macro calls
2020-06-08 10:11:48 -05:00
namespace Opm::Properties {
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
[properties] replace remaining macro calls
2020-06-10 06:07:19 -05:00
namespace TTag {
struct Co2InjectionBaseProblem {};
}
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
// Set the grid type
[properties] replace macro calls by native C++
2020-06-08 09:41:02 -05:00
template<class TypeTag>
struct Grid<TypeTag, TTag::Co2InjectionBaseProblem> { using type = Dune::YaspGrid<2>; };
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
// Set the problem property
[properties] replace remaining macro calls
2020-06-10 06:07:19 -05:00
template<class TypeTag>
struct Problem<TypeTag, TTag::Co2InjectionBaseProblem>
{ using type = Opm::Co2InjectionProblem<TypeTag>; };
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
// Set fluid configuration
[properties] replace macro calls by native C++
2020-06-08 09:41:02 -05:00
template<class TypeTag>
struct FluidSystem<TypeTag, TTag::Co2InjectionBaseProblem>
reformat the source code this was done semi-automatically. The line length has been set to 80 characters, but with a quite low penalty for crossing this limit.
2013-11-29 09:33:46 -06:00
{
private:
[cleanup] replace typedef by using
2020-06-10 06:49:42 -05:00
using Scalar = GetPropType<TypeTag, Properties::Scalar>;
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
public:
adjust to upstream CO2Table encapsulation
2022-12-15 07:03:35 -06:00
using type = Opm::BrineCO2FluidSystem<Scalar>;
[cleanup] replace typedef by using
2020-06-10 06:49:42 -05:00
//using type = Opm::H2ON2FluidSystem<Scalar, /*useComplexRelations=*/false>;
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
};
// Set the material Law
[properties] replace macro calls by native C++
2020-06-08 09:41:02 -05:00
template<class TypeTag>
struct MaterialLaw<TypeTag, TTag::Co2InjectionBaseProblem>
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
{
private:
[cleanup] replace typedef by using
2020-06-10 06:49:42 -05:00
using FluidSystem = GetPropType<TypeTag, Properties::FluidSystem>;
adapt to the recent renames of the phase indices in opm-material
2014-04-03 09:59:48 -05:00
enum { liquidPhaseIdx = FluidSystem::liquidPhaseIdx };
enum { gasPhaseIdx = FluidSystem::gasPhaseIdx };
Implement the element centered finite volume spatial discretization This makes eWoms multi-discretization capable. Along the way, this fixes some bugs and does a medium sized reorganization of the source tree. This is a squashed patch of the following commits: -------- 1st commit message: add initial version of the element centered finite volume discretization currently, it is a misnomer as it is just a copy of the vertex centered discretization plus some renames... -------- 2nd commit message: rename [VE]cfvModel -> [VE]cfvDiscretization -------- 3rd commit message: ecfv: prelimary changes required to make it compile but not work yet... -------- 4th commit message: Rename *FvElementGeometry to *Stencil "Stencil" seems to be the standard expression for this concept... (also, it is not specific to finite volume methods and is shorter.) -------- 5th commit message: refactor the stencil class for the element centered finite volume discretization -------- 6th commit message: ECFV: some work on the stencil class -------- 7th commit message: ECFV: make the boundary handling code compile -------- 8th commit message: rename elemContext() to elementContext() -------- 9th commit message: ECFV: make the VTK output modules compile -------- 10th commit message: stencil: introduce the concept of primary DOFs also save an vector of all element pointers in the stencil. -------- 11th commit message: ECFV: try to fix assembly; add missing timeIdx arguments to the num*() methods -------- 12th commit message: ECFV: fix stupid mistake in the assembler -------- 13th commit message: ECFV: remove a few implicit DOF == vertex assumptions the black-oil example now runs without valgrind complaints until it encounters a negative oil mole fraction. -------- 14th commit message: VCFV: make everything compile again all vertex centered FV examples should now work again... -------- 15th commit message: rename [ev]cfvmodel.hh to [ev]cfvdiscretization.hh the classes have already been renamed. -------- 16th commit message: ECFV: make it work to the point where it can write out the initial solution. -------- 17th commit message: ECFV: make it work the local residual/jacobian needed some work in distinguishing primary and secondary DOFs and there was an minor issue with the serialization code. for some reason, it seems still not correct. (-> convergence is too slow.) -------- 18th commit message: VCFV: make it compile for the black oil model again -------- 19th commit message: VCFV: make it compile with the remaining models again -------- 20th commit message: flash model: make it work with ECFV although this breaks its compatibility with VCFV. (-> next commit) -------- 21st commit message: adapt the VCFV to make it compatible with the flash model again -------- 22nd commit message: make all models compile with VCFV again -------- 23rd commit message: VCFV: more cleanups of the stencil VcfvStencil now does not have any public attributes anymore. TODO: do not export attributes in the SubControlVolume and SubControlVolumeFace classes. -------- 24th commit message: VCFV: actually update the element pointer -------- 25th commit message: change the blackoil model back to ECFV -------- 26th commit message: immiscible model: make it compatible with the ECFV discretization -------- 27th commit message: PVS model: make it work with ECFV -------- 28th commit message: NCP model: make it work with ECFV -------- 29th commit message: rename Vcfv*VelocityModule to *VelocityModule -------- 30th commit message: richards model: make it work with ECFV -------- 31st commit message: unify the ECFV and the VCFV VTK output modules and other cleanups -------- 32nd commit message: unify the common code of the VCFV and the ECFV disctretizations -------- 33rd commit message: unify the element contexts between element and vertex centered finite volumes -------- 34th commit message: unify the local jacobian class of the finite volume discretizations -------- 35th commit message: replace [VE]vcf(LocalResidual|ElementContext|BoundaryContext|ConstraintsContext) by generic code -------- 36th commit message: replace the [EV]cfvLocalResidual by generic code -------- 37th commit message: unify the MultiPhaseProblem and Problem classes, introduce NullBorderListCreator -------- 38th commit message: remove the discretization specific boundary context -------- 39th commit message: unify the [EV]cfvDiscretization classes -------- 40th commit message: Unify [EV]cfvMultiPhaseFluxVariables -------- 41st commit message: Unify the [EC]cfvNewton* classes -------- 42nd commit message: Unify [EV]cfvVolumeVariables -------- 43rd commit message: unify [EV]cfvAssembler -------- 44th commit message: unified flux variables: fix stupid mistake when calculating pressure gradients -------- 45th commit message: unify what's to unify for the [EV]CFV properties -------- 46th commit message: make the method to calculate gradients and values at flux approximation points changeable Currently, this is used by the vertex centered finite volume method to be able to use P1-finite element gradients instead of two-point ones... -------- 47th commit message: make the restart code work correctly, use the correct DofMapper for VCFV -------- 48th commit message: actually use the gradient calculator in a model the immiscible model in this case -------- 49th commit message: move some files around to where they belong, use the new gradient calculation code in all models TODO: proper handling of boundary gradients -------- 50th commit message: fix the stokes model currently it only works with the vertex centered finite volume discretization, but the plan is to soon move it to a staggered grid scheme anyway... -------- 51st commit message: move all models back to using the vertex centered finite volume discretization by default -------- 52nd commit message: models: some variable renames and documentation fixes - scv -> dof - vert -> dof - vertex -> dof - replace 'VCFV' - fix some typos -------- 53rd commit message: don't expect UG anymore since it is quite non-free and hard to get. we now use ALUGrid instead! -------- 54th commit message: temporarily disable jacobian recycling -------- 55th commit message: fix writing/reading restart files using the generic code -------- 56th commit message: fix bug where fluxes were only counted once in the stencil this only affected the vertex centered finite volumes discretization... -------- 57th commit message: boundary gradients: use the center of the sub-control volume adjacent to a boundary segment -------- 58th commit message: make it compile on GCC -------- 59th commit message: get rid of most hacks for this, partial reassemble and jacobian recycling was brought back. For the this and the remaining stuff the main trick is the introduction of the GridCommHandleFactory concept which constructs communication handles suited for the respective spatial discretization... -------- 60th commit message: fix a few annoying bugs first, default the convergence criterion for the linear solver did not honor the initial residual which lead to linear solver breakdowns, then some debugging code was left in the discrete fracture model and then there was a bug in the TP gradient approximation class... this has the consequence that we need a new reference solution for the discrete fracture problem... -------- 61st commit message: iterative linear solver: remove the code for the non-default convergence criteria -------- 62nd commit message: provide the FE cache instead of the local FE this fixes a segfault in the stokes model caused by the fact that the local FE was not initialized at this point. -------- 63rd commit message: (Navier-)Stokes: fix bug due to the transition to unit normals now, all tests pass for this branch. The only things which need to be fixed are some annoying performance regressions compared to master and some bug in the splices feature of the property system... -------- 64th commit message: some fix for the local residual of the immiscible model -------- 65th commit message: Navier-Stokes: implement SCV center gradients There seems to be a bug in the previous implementation (the jacobian inverse transposed is evaluated using the local, not the global geometry), so the reference solution for the stokes2c test problem has also been updated... -------- 66th commit message: remove the ALUGrid specialization of the LensGridCreator and the YaspGrid one for the fingerproblem using different grid seems to sometimes cause a different vertex order, which in turn causes the respective test to fail if the reference solution was computed using the other grid... -------- 67th commit message: VCFV: use the correct BorderListCreator this makes MPI parallel computations work again. apart from performance regressions, this branch does not exhibit any known regressions compared to master anymore... -------- 68th commit message: make verything compile with the element centered finite volume discretization except the Navier-Stokes and the two-phase DFM models, of course... -------- 69th commit message: minor fixes - make the navier-stokes model slighly more generic by using the proper (in,ex)teriorIndex() methods on sub-control volumes - make the signature of the calculateValue() template method of the common two-point gradient approximator match the one of the vertex centered finite volume one -------- 70th commit message: fix fallout from the Big Rebase -------- 71st commit message: ECFV: some bugs in the boundary -------- 72nd commit message: make computeFlux() compute area-specific quantities -------- 73rd commit message: fix more bugs in the element centered FV discretization now eWoms should match Dumux pretty closely... -------- 74th commit message: coalesce the common code of the multi phase porous medium models into "MultiPhaseBaseModel" -------- 75th commit message: update reference solutions these were changed because of the screw-up with the area of boundary segments... -------- 76th commit message: rename "ImplicitBase" to "FvBase" because in eWoms, everything is implicit and these are currently the base classes for all finite volume discretizations. -------- 77th commit message: make the spatial discretization selectable using a splice This requires an opm-core with a the patches from https://github.com/OPM/opm-core/pull/446 merged... -------- 78th commit message: rename the properties used for splices to *Splice -------- 79th commit message: move the files in 'tests/models' to 'tests' since 'tests' was empty except for the 'models' subdirectory... -------- 80th commit message: improve and fix the tutorial -------- 81st commit message: remove the -fno-strict-aliasing flag from the provided option files seems like recent versions of Dune have been adapted... -------- 82nd commit message: also compile all CO2 injection simulations using the element centered finite volume discretization -------- 83rd commit message: PVS model: make it work properly with the element-centered finite volume discretiation because DOF != number of vertices
2013-12-12 05:52:44 -06:00
[cleanup] replace typedef by using
2020-06-10 06:49:42 -05:00
using Scalar = GetPropType<TypeTag, Properties::Scalar>;
using Traits = Opm::TwoPhaseMaterialTraits<Scalar,
/*wettingPhaseIdx=*/FluidSystem::liquidPhaseIdx,
/*nonWettingPhaseIdx=*/FluidSystem::gasPhaseIdx>;
adapt to the changes in opm-material
2013-11-06 07:50:01 -06:00
// define the material law which is parameterized by effective
// saturations
[cleanup] replace typedef by using
2020-06-10 06:49:42 -05:00
using EffMaterialLaw = Opm::RegularizedBrooksCorey<Traits>;
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
public:
adapt to the changes in opm-material
2013-11-06 07:50:01 -06:00
// define the material law parameterized by absolute saturations
[cleanup] replace typedef by using
2020-06-10 06:49:42 -05:00
using type = Opm::EffToAbsLaw<EffMaterialLaw>;
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
};
consistently rename "heat conduction" to "thermal conduction" and use "solid energy" laws according to wikipedia the term "heat" is the energy transferred due to a temperature gradient, i.e., it only makes sense if such a gradient is present and this is not necessary for the storage term. this means that technically the term "heat conductivity" is meaningful, but "thermal conductivity" is IMO more consistent. this has partially already been done in opm-material and eWoms it was pretty inconsistent, so it also requires a patch in opm-material.
2018-01-04 08:26:07 -06:00
// Set the thermal conduction law
[properties] replace macro calls by native C++
2020-06-08 09:41:02 -05:00
template<class TypeTag>
struct ThermalConductionLaw<TypeTag, TTag::Co2InjectionBaseProblem>
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
{
private:
[cleanup] replace typedef by using
2020-06-10 06:49:42 -05:00
using Scalar = GetPropType<TypeTag, Properties::Scalar>;
using FluidSystem = GetPropType<TypeTag, Properties::FluidSystem>;
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
public:
// define the material law parameterized by absolute saturations
[cleanup] replace typedef by using
2020-06-10 06:49:42 -05:00
using type = Opm::SomertonThermalConductionLaw<FluidSystem, Scalar>;
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
};
consistently rename "heat conduction" to "thermal conduction" and use "solid energy" laws according to wikipedia the term "heat" is the energy transferred due to a temperature gradient, i.e., it only makes sense if such a gradient is present and this is not necessary for the storage term. this means that technically the term "heat conductivity" is meaningful, but "thermal conductivity" is IMO more consistent. this has partially already been done in opm-material and eWoms it was pretty inconsistent, so it also requires a patch in opm-material.
2018-01-04 08:26:07 -06:00
// set the energy storage law for the solid phase
[properties] replace remaining macro calls
2020-06-10 06:07:19 -05:00
template<class TypeTag>
struct SolidEnergyLaw<TypeTag, TTag::Co2InjectionBaseProblem>
{ using type = Opm::ConstantSolidHeatCapLaw<GetPropType<TypeTag, Properties::Scalar>>; };
adapt to the refactoring of the thermal laws in opm-material
2017-12-11 05:58:30 -06:00
use BiCGStab-ILU0 as the linear solver for the lens problem ... and use the parallel AMG solver for the CO2 injection problem. this makes performance comparisions with Dumux much easier as the solver performance should be more similar.
2014-12-21 11:36:59 -06:00
// Use the algebraic multi-grid linear solver for this problem
[properties] replace SET_TAG_PROP calls
2020-06-09 03:55:25 -05:00
template<class TypeTag>
struct LinearSolverSplice<TypeTag, TTag::Co2InjectionBaseProblem> { using type = TTag::ParallelAmgLinearSolver; };
use BiCGStab-ILU0 as the linear solver for the lens problem ... and use the parallel AMG solver for the CO2 injection problem. this makes performance comparisions with Dumux much easier as the solver performance should be more similar.
2014-12-21 11:36:59 -06:00
changed: move the Co2InjectionProblem parameters to Opm::Parameters
2024-07-01 07:13:14 -05:00
} // namespace Opm::Properties
namespace Opm::Parameters {
move Co2InjectionProblem parameters to TypeTag-free parameter system
2024-07-05 10:49:51 -05:00
struct FluidSystemNumPressure { static constexpr unsigned value = 100; };
struct FluidSystemNumTemperature { static constexpr unsigned value = 100; };
changed: move the Co2InjectionProblem parameters to Opm::Parameters
2024-07-01 07:13:14 -05:00
move Co2InjectionProblem parameters to TypeTag-free parameter system
2024-07-05 10:49:51 -05:00
template<class Scalar>
struct FluidSystemPressureHigh { static constexpr Scalar value = 4e7; };
changed: move the Co2InjectionProblem parameters to Opm::Parameters
2024-07-01 07:13:14 -05:00
move Co2InjectionProblem parameters to TypeTag-free parameter system
2024-07-05 10:49:51 -05:00
template<class Scalar>
struct FluidSystemPressureLow { static constexpr Scalar value = 3e7; };
changed: move the Co2InjectionProblem parameters to Opm::Parameters
2024-07-01 07:13:14 -05:00
move Co2InjectionProblem parameters to TypeTag-free parameter system
2024-07-05 10:49:51 -05:00
template<class Scalar>
struct FluidSystemTemperatureHigh { static constexpr Scalar value = 500.0; };
changed: move the Co2InjectionProblem parameters to Opm::Parameters
2024-07-01 07:13:14 -05:00
move Co2InjectionProblem parameters to TypeTag-free parameter system
2024-07-05 10:49:51 -05:00
template<class Scalar>
struct FluidSystemTemperatureLow { static constexpr Scalar value = 290.0; };
changed: move the Co2InjectionProblem parameters to Opm::Parameters
2024-07-01 07:13:14 -05:00
move Co2InjectionProblem parameters to TypeTag-free parameter system
2024-07-05 10:49:51 -05:00
template<class Scalar>
struct MaxDepth { static constexpr Scalar value = 2500.0; };
changed: move the Co2InjectionProblem parameters to Opm::Parameters
2024-07-01 07:13:14 -05:00
move Co2InjectionProblem parameters to TypeTag-free parameter system
2024-07-05 10:49:51 -05:00
struct SimulationName { static constexpr auto value = "co2injection"; };
changed: move the Co2InjectionProblem parameters to Opm::Parameters
2024-07-01 07:13:14 -05:00
move Co2InjectionProblem parameters to TypeTag-free parameter system
2024-07-05 10:49:51 -05:00
template<class Scalar>
struct Temperature { static constexpr Scalar value = 293.15; };
changed: move the Co2InjectionProblem parameters to Opm::Parameters
2024-07-01 07:13:14 -05:00
changed: move the NewtonWriteConvergence parameter to Opm::Parameters
2024-07-01 03:20:05 -05:00
} // namespace Opm::Parameters
changed: namespace Ewoms -> namespace Opm
2019-09-05 09:21:10 -05:00
namespace Opm {
move NewtonTolerance to TypeTag-free parameter system
2024-07-05 10:49:51 -05:00
double Co2InjectionTolerance = 1e-8;
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
/*!
replace a few now-incorrect "Vcfv" prefixes in the comments
2014-07-17 10:24:48 -05:00
* \ingroup TestProblems
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
*
* \brief Problem where \f$CO_2\f$ is injected under a low permeable
* layer at a depth of 2700m.
*
* The domain is sized 60m times 40m and consists of two layers, one
* which is moderately permeable (\f$K = 10^{-12}\;m^2\f$) for \f$ y >
* 22\; m\f$ and one with a lower intrinsic permeablility (\f$
* K=10^{-13}\;m^2\f$) in the rest of the domain.
*
* \f$CO_2\f$ gets injected by means of a forced-flow boundary
* condition into water-filled aquifer, which is situated 2700m below
* sea level, at the lower-right boundary (\f$5m<y<15m\f$) and
* migrates upwards due to buoyancy. It accumulates and eventually
* enters the lower permeable aquitard.
*
* The boundary conditions applied by this problem are no-flow
* conditions on the top bottom and right boundaries and a free-flow
* boundary condition on the left. For the free-flow condition,
* hydrostatic pressure is assumed.
*/
template <class TypeTag>
[properties] replace macro calls by native C++
2020-06-08 09:41:02 -05:00
class Co2InjectionProblem : public GetPropType<TypeTag, Properties::BaseProblem>
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
{
[cleanup] replace typedef by using
2020-06-10 06:49:42 -05:00
using ParentType = GetPropType<TypeTag, Properties::BaseProblem>;
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
[cleanup] replace typedef by using
2020-06-10 06:49:42 -05:00
using Scalar = GetPropType<TypeTag, Properties::Scalar>;
using Evaluation = GetPropType<TypeTag, Properties::Evaluation>;
using GridView = GetPropType<TypeTag, Properties::GridView>;
using FluidSystem = GetPropType<TypeTag, Properties::FluidSystem>;
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
reformat the source code this was done semi-automatically. The line length has been set to 80 characters, but with a quite low penalty for crossing this limit.
2013-11-29 09:33:46 -06:00
enum { dim = GridView::dimension };
enum { dimWorld = GridView::dimensionworld };
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
// copy some indices for convenience
[cleanup] replace typedef by using
2020-06-10 06:49:42 -05:00
using Indices = GetPropType<TypeTag, Properties::Indices>;
reformat the source code this was done semi-automatically. The line length has been set to 80 characters, but with a quite low penalty for crossing this limit.
2013-11-29 09:33:46 -06:00
enum { numPhases = FluidSystem::numPhases };
adapt to the recent renames of the phase indices in opm-material
2014-04-03 09:59:48 -05:00
enum { gasPhaseIdx = FluidSystem::gasPhaseIdx };
enum { liquidPhaseIdx = FluidSystem::liquidPhaseIdx };
reformat the source code this was done semi-automatically. The line length has been set to 80 characters, but with a quite low penalty for crossing this limit.
2013-11-29 09:33:46 -06:00
enum { CO2Idx = FluidSystem::CO2Idx };
enum { BrineIdx = FluidSystem::BrineIdx };
enum { conti0EqIdx = Indices::conti0EqIdx };
enum { contiCO2EqIdx = conti0EqIdx + CO2Idx };
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
[cleanup] replace typedef by using
2020-06-10 06:49:42 -05:00
using PrimaryVariables = GetPropType<TypeTag, Properties::PrimaryVariables>;
using RateVector = GetPropType<TypeTag, Properties::RateVector>;
using BoundaryRateVector = GetPropType<TypeTag, Properties::BoundaryRateVector>;
using MaterialLaw = GetPropType<TypeTag, Properties::MaterialLaw>;
using Simulator = GetPropType<TypeTag, Properties::Simulator>;
using Model = GetPropType<TypeTag, Properties::Model>;
using MaterialLawParams = GetPropType<TypeTag, Properties::MaterialLawParams>;
using ThermalConductionLaw = GetPropType<TypeTag, Properties::ThermalConductionLaw>;
using SolidEnergyLawParams = GetPropType<TypeTag, Properties::SolidEnergyLawParams>;
using ThermalConductionLawParams = typename ThermalConductionLaw::Params;
using Toolbox = Opm::MathToolbox<Evaluation>;
using CoordScalar = typename GridView::ctype;
using GlobalPosition = Dune::FieldVector<CoordScalar, dimWorld>;
using DimMatrix = Dune::FieldMatrix<Scalar, dimWorld, dimWorld>;
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
public:
/*!
* \copydoc Doxygen::defaultProblemConstructor
*/
fix most pedantic compiler warnings in the basic infrastructure i.e., using clang 3.8 to compile the test suite with the following flags: ``` -Weverything -Wno-documentation -Wno-documentation-unknown-command -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undef -Wno-padded -Wno-global-constructors -Wno-exit-time-destructors -Wno-weak-vtables -Wno-float-equal ``` should not produce any warnings anymore. In my opinion the only flag which would produce beneficial warnings is -Wdocumentation. This has not been fixed in this patch because writing documentation is left for another day (or, more likely, year). note that this patch consists of a heavy dose of the OPM_UNUSED macro and plenty of static_casts (to fix signedness issues). Fixing the singedness issues were quite a nightmare and the fact that the Dune API is quite inconsistent in that regard was not exactly helpful. :/ Finally this patch includes quite a few formatting changes (e.g., all occurences of 'T &t' should be changed to `T& t`) and some fixes for minor issues which I've found during the excercise. I've made sure that all unit tests the test suite still pass successfully and I've made sure that flow_ebos still works for Norne and that it did not regress w.r.t. performance. (Note that this patch does not fix compiler warnings triggered `ebos` and `flow_ebos` but only those caused by the basic infrastructure or the unit tests.) v2: fix the warnings that occur if the dune-localfunctions module is not available. thanks to [at]atgeirr for testing. v3: fix dune 2.3 build issue
2016-11-07 08:14:07 -06:00
Co2InjectionProblem(Simulator& simulator)
refactoring: extend the TimeManager to become the Simulator this also comes with moving responsibilities around and some smaller cleanups for the grid creation. (although grid creation could be possibly done by the simulator now, the GridCreator concept has not been abandoned, yet...)
2014-04-14 13:32:30 -05:00
: ParentType(simulator)
use finishInit() properly for all problems this means that all code which could potentially throw an exception is moved to this method(). (In particular FluidSystem::init() proved troublesome in the past.) Besides avoiding segmentation the faults which stem from exceptions thrown in constructors, this also has the advantage that simulations which spend a noticable amount of time to initialize stop at the "correct" place, i.e. after the "Finish init of the problem" message was printed by the simulator...
2014-08-06 09:31:48 -05:00
{ }
/*!
* \copydoc FvBaseProblem::finishInit
*/
void finishInit()
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
{
use finishInit() properly for all problems this means that all code which could potentially throw an exception is moved to this method(). (In particular FluidSystem::init() proved troublesome in the past.) Besides avoiding segmentation the faults which stem from exceptions thrown in constructors, this also has the advantage that simulations which spend a noticable amount of time to initialize stop at the "correct" place, i.e. after the "Finish init of the problem" message was printed by the simulator...
2014-08-06 09:31:48 -05:00
ParentType::finishInit();
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
eps_ = 1e-6;
move Co2InjectionProblem parameters to TypeTag-free parameter system
2024-07-05 10:49:51 -05:00
temperatureLow_ = Parameters::Get<Parameters::FluidSystemTemperatureLow<Scalar>>();
temperatureHigh_ = Parameters::Get<Parameters::FluidSystemTemperatureHigh<Scalar>>();
nTemperature_ = Parameters::Get<Parameters::FluidSystemNumTemperature>();
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
move Co2InjectionProblem parameters to TypeTag-free parameter system
2024-07-05 10:49:51 -05:00
pressureLow_ = Parameters::Get<Parameters::FluidSystemPressureLow<Scalar>>();
pressureHigh_ = Parameters::Get<Parameters::FluidSystemPressureHigh<Scalar>>();
nPressure_ = Parameters::Get<Parameters::FluidSystemNumPressure>();
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
move Co2InjectionProblem parameters to TypeTag-free parameter system
2024-07-05 10:49:51 -05:00
maxDepth_ = Parameters::Get<Parameters::MaxDepth<Scalar>>();
temperature_ = Parameters::Get<Parameters::Temperature<Scalar>>();
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
// initialize the tables of the fluid system
reformat the source code this was done semi-automatically. The line length has been set to 80 characters, but with a quite low penalty for crossing this limit.
2013-11-29 09:33:46 -06:00
// FluidSystem::init();
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
FluidSystem::init(/*Tmin=*/temperatureLow_,
/*Tmax=*/temperatureHigh_,
/*nT=*/nTemperature_,
/*pmin=*/pressureLow_,
/*pmax=*/pressureHigh_,
/*np=*/nPressure_);
fineLayerBottom_ = 22.0;
// intrinsic permeabilities
fineK_ = this->toDimMatrix_(1e-13);
coarseK_ = this->toDimMatrix_(1e-12);
// porosities
finePorosity_ = 0.3;
coarsePorosity_ = 0.3;
// residual saturations
adapt to the recent renames of the phase indices in opm-material
2014-04-03 09:59:48 -05:00
fineMaterialParams_.setResidualSaturation(liquidPhaseIdx, 0.2);
fineMaterialParams_.setResidualSaturation(gasPhaseIdx, 0.0);
coarseMaterialParams_.setResidualSaturation(liquidPhaseIdx, 0.2);
coarseMaterialParams_.setResidualSaturation(gasPhaseIdx, 0.0);
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
// parameters for the Brooks-Corey law
adapt to the changes in opm-material
2013-11-06 07:50:01 -06:00
fineMaterialParams_.setEntryPressure(1e4);
coarseMaterialParams_.setEntryPressure(5e3);
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
fineMaterialParams_.setLambda(2.0);
coarseMaterialParams_.setLambda(2.0);
adapt to the changes in opm-material
2013-11-06 07:50:01 -06:00
fineMaterialParams_.finalize();
coarseMaterialParams_.finalize();
consistently rename "heat conduction" to "thermal conduction" and use "solid energy" laws according to wikipedia the term "heat" is the energy transferred due to a temperature gradient, i.e., it only makes sense if such a gradient is present and this is not necessary for the storage term. this means that technically the term "heat conductivity" is meaningful, but "thermal conductivity" is IMO more consistent. this has partially already been done in opm-material and eWoms it was pretty inconsistent, so it also requires a patch in opm-material.
2018-01-04 08:26:07 -06:00
// parameters for the somerton law thermal conduction
computeThermalCondParams_(fineThermalCondParams_, finePorosity_);
computeThermalCondParams_(coarseThermalCondParams_, coarsePorosity_);
adapt to the refactoring of the thermal laws in opm-material
2017-12-11 05:58:30 -06:00
consistently rename "heat conduction" to "thermal conduction" and use "solid energy" laws according to wikipedia the term "heat" is the energy transferred due to a temperature gradient, i.e., it only makes sense if such a gradient is present and this is not necessary for the storage term. this means that technically the term "heat conductivity" is meaningful, but "thermal conductivity" is IMO more consistent. this has partially already been done in opm-material and eWoms it was pretty inconsistent, so it also requires a patch in opm-material.
2018-01-04 08:26:07 -06:00
// assume constant heat capacity and granite
solidEnergyLawParams_.setSolidHeatCapacity(790.0 // specific heat capacity of granite [J / (kg K)]
* 2700.0); // density of granite [kg/m^3]
solidEnergyLawParams_.finalize();
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
}
/*!
Implement the element centered finite volume spatial discretization This makes eWoms multi-discretization capable. Along the way, this fixes some bugs and does a medium sized reorganization of the source tree. This is a squashed patch of the following commits: -------- 1st commit message: add initial version of the element centered finite volume discretization currently, it is a misnomer as it is just a copy of the vertex centered discretization plus some renames... -------- 2nd commit message: rename [VE]cfvModel -> [VE]cfvDiscretization -------- 3rd commit message: ecfv: prelimary changes required to make it compile but not work yet... -------- 4th commit message: Rename *FvElementGeometry to *Stencil "Stencil" seems to be the standard expression for this concept... (also, it is not specific to finite volume methods and is shorter.) -------- 5th commit message: refactor the stencil class for the element centered finite volume discretization -------- 6th commit message: ECFV: some work on the stencil class -------- 7th commit message: ECFV: make the boundary handling code compile -------- 8th commit message: rename elemContext() to elementContext() -------- 9th commit message: ECFV: make the VTK output modules compile -------- 10th commit message: stencil: introduce the concept of primary DOFs also save an vector of all element pointers in the stencil. -------- 11th commit message: ECFV: try to fix assembly; add missing timeIdx arguments to the num*() methods -------- 12th commit message: ECFV: fix stupid mistake in the assembler -------- 13th commit message: ECFV: remove a few implicit DOF == vertex assumptions the black-oil example now runs without valgrind complaints until it encounters a negative oil mole fraction. -------- 14th commit message: VCFV: make everything compile again all vertex centered FV examples should now work again... -------- 15th commit message: rename [ev]cfvmodel.hh to [ev]cfvdiscretization.hh the classes have already been renamed. -------- 16th commit message: ECFV: make it work to the point where it can write out the initial solution. -------- 17th commit message: ECFV: make it work the local residual/jacobian needed some work in distinguishing primary and secondary DOFs and there was an minor issue with the serialization code. for some reason, it seems still not correct. (-> convergence is too slow.) -------- 18th commit message: VCFV: make it compile for the black oil model again -------- 19th commit message: VCFV: make it compile with the remaining models again -------- 20th commit message: flash model: make it work with ECFV although this breaks its compatibility with VCFV. (-> next commit) -------- 21st commit message: adapt the VCFV to make it compatible with the flash model again -------- 22nd commit message: make all models compile with VCFV again -------- 23rd commit message: VCFV: more cleanups of the stencil VcfvStencil now does not have any public attributes anymore. TODO: do not export attributes in the SubControlVolume and SubControlVolumeFace classes. -------- 24th commit message: VCFV: actually update the element pointer -------- 25th commit message: change the blackoil model back to ECFV -------- 26th commit message: immiscible model: make it compatible with the ECFV discretization -------- 27th commit message: PVS model: make it work with ECFV -------- 28th commit message: NCP model: make it work with ECFV -------- 29th commit message: rename Vcfv*VelocityModule to *VelocityModule -------- 30th commit message: richards model: make it work with ECFV -------- 31st commit message: unify the ECFV and the VCFV VTK output modules and other cleanups -------- 32nd commit message: unify the common code of the VCFV and the ECFV disctretizations -------- 33rd commit message: unify the element contexts between element and vertex centered finite volumes -------- 34th commit message: unify the local jacobian class of the finite volume discretizations -------- 35th commit message: replace [VE]vcf(LocalResidual|ElementContext|BoundaryContext|ConstraintsContext) by generic code -------- 36th commit message: replace the [EV]cfvLocalResidual by generic code -------- 37th commit message: unify the MultiPhaseProblem and Problem classes, introduce NullBorderListCreator -------- 38th commit message: remove the discretization specific boundary context -------- 39th commit message: unify the [EV]cfvDiscretization classes -------- 40th commit message: Unify [EV]cfvMultiPhaseFluxVariables -------- 41st commit message: Unify the [EC]cfvNewton* classes -------- 42nd commit message: Unify [EV]cfvVolumeVariables -------- 43rd commit message: unify [EV]cfvAssembler -------- 44th commit message: unified flux variables: fix stupid mistake when calculating pressure gradients -------- 45th commit message: unify what's to unify for the [EV]CFV properties -------- 46th commit message: make the method to calculate gradients and values at flux approximation points changeable Currently, this is used by the vertex centered finite volume method to be able to use P1-finite element gradients instead of two-point ones... -------- 47th commit message: make the restart code work correctly, use the correct DofMapper for VCFV -------- 48th commit message: actually use the gradient calculator in a model the immiscible model in this case -------- 49th commit message: move some files around to where they belong, use the new gradient calculation code in all models TODO: proper handling of boundary gradients -------- 50th commit message: fix the stokes model currently it only works with the vertex centered finite volume discretization, but the plan is to soon move it to a staggered grid scheme anyway... -------- 51st commit message: move all models back to using the vertex centered finite volume discretization by default -------- 52nd commit message: models: some variable renames and documentation fixes - scv -> dof - vert -> dof - vertex -> dof - replace 'VCFV' - fix some typos -------- 53rd commit message: don't expect UG anymore since it is quite non-free and hard to get. we now use ALUGrid instead! -------- 54th commit message: temporarily disable jacobian recycling -------- 55th commit message: fix writing/reading restart files using the generic code -------- 56th commit message: fix bug where fluxes were only counted once in the stencil this only affected the vertex centered finite volumes discretization... -------- 57th commit message: boundary gradients: use the center of the sub-control volume adjacent to a boundary segment -------- 58th commit message: make it compile on GCC -------- 59th commit message: get rid of most hacks for this, partial reassemble and jacobian recycling was brought back. For the this and the remaining stuff the main trick is the introduction of the GridCommHandleFactory concept which constructs communication handles suited for the respective spatial discretization... -------- 60th commit message: fix a few annoying bugs first, default the convergence criterion for the linear solver did not honor the initial residual which lead to linear solver breakdowns, then some debugging code was left in the discrete fracture model and then there was a bug in the TP gradient approximation class... this has the consequence that we need a new reference solution for the discrete fracture problem... -------- 61st commit message: iterative linear solver: remove the code for the non-default convergence criteria -------- 62nd commit message: provide the FE cache instead of the local FE this fixes a segfault in the stokes model caused by the fact that the local FE was not initialized at this point. -------- 63rd commit message: (Navier-)Stokes: fix bug due to the transition to unit normals now, all tests pass for this branch. The only things which need to be fixed are some annoying performance regressions compared to master and some bug in the splices feature of the property system... -------- 64th commit message: some fix for the local residual of the immiscible model -------- 65th commit message: Navier-Stokes: implement SCV center gradients There seems to be a bug in the previous implementation (the jacobian inverse transposed is evaluated using the local, not the global geometry), so the reference solution for the stokes2c test problem has also been updated... -------- 66th commit message: remove the ALUGrid specialization of the LensGridCreator and the YaspGrid one for the fingerproblem using different grid seems to sometimes cause a different vertex order, which in turn causes the respective test to fail if the reference solution was computed using the other grid... -------- 67th commit message: VCFV: use the correct BorderListCreator this makes MPI parallel computations work again. apart from performance regressions, this branch does not exhibit any known regressions compared to master anymore... -------- 68th commit message: make verything compile with the element centered finite volume discretization except the Navier-Stokes and the two-phase DFM models, of course... -------- 69th commit message: minor fixes - make the navier-stokes model slighly more generic by using the proper (in,ex)teriorIndex() methods on sub-control volumes - make the signature of the calculateValue() template method of the common two-point gradient approximator match the one of the vertex centered finite volume one -------- 70th commit message: fix fallout from the Big Rebase -------- 71st commit message: ECFV: some bugs in the boundary -------- 72nd commit message: make computeFlux() compute area-specific quantities -------- 73rd commit message: fix more bugs in the element centered FV discretization now eWoms should match Dumux pretty closely... -------- 74th commit message: coalesce the common code of the multi phase porous medium models into "MultiPhaseBaseModel" -------- 75th commit message: update reference solutions these were changed because of the screw-up with the area of boundary segments... -------- 76th commit message: rename "ImplicitBase" to "FvBase" because in eWoms, everything is implicit and these are currently the base classes for all finite volume discretizations. -------- 77th commit message: make the spatial discretization selectable using a splice This requires an opm-core with a the patches from https://github.com/OPM/opm-core/pull/446 merged... -------- 78th commit message: rename the properties used for splices to *Splice -------- 79th commit message: move the files in 'tests/models' to 'tests' since 'tests' was empty except for the 'models' subdirectory... -------- 80th commit message: improve and fix the tutorial -------- 81st commit message: remove the -fno-strict-aliasing flag from the provided option files seems like recent versions of Dune have been adapted... -------- 82nd commit message: also compile all CO2 injection simulations using the element centered finite volume discretization -------- 83rd commit message: PVS model: make it work properly with the element-centered finite volume discretiation because DOF != number of vertices
2013-12-12 05:52:44 -06:00
* \copydoc FvBaseMultiPhaseProblem::registerParameters
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
*/
static void registerParameters()
{
ParentType::registerParameters();
move Co2InjectionProblem parameters to TypeTag-free parameter system
2024-07-05 10:49:51 -05:00
Parameters::Register<Parameters::FluidSystemTemperatureLow<Scalar>>
drop macro EWOMS_REGISTER_PARAM
2024-04-04 05:49:01 -05:00
("The lower temperature [K] for tabulation of the fluid system");
move Co2InjectionProblem parameters to TypeTag-free parameter system
2024-07-05 10:49:51 -05:00
Parameters::Register<Parameters::FluidSystemTemperatureHigh<Scalar>>
drop macro EWOMS_REGISTER_PARAM
2024-04-04 05:49:01 -05:00
("The upper temperature [K] for tabulation of the fluid system");
move Co2InjectionProblem parameters to TypeTag-free parameter system
2024-07-05 10:49:51 -05:00
Parameters::Register<Parameters::FluidSystemNumTemperature>
drop macro EWOMS_REGISTER_PARAM
2024-04-04 05:49:01 -05:00
("The number of intervals between the lower and upper temperature");
move Co2InjectionProblem parameters to TypeTag-free parameter system
2024-07-05 10:49:51 -05:00
Parameters::Register<Parameters::FluidSystemPressureLow<Scalar>>
drop macro EWOMS_REGISTER_PARAM
2024-04-04 05:49:01 -05:00
("The lower pressure [Pa] for tabulation of the fluid system");
move Co2InjectionProblem parameters to TypeTag-free parameter system
2024-07-05 10:49:51 -05:00
Parameters::Register<Parameters::FluidSystemPressureHigh<Scalar>>
drop macro EWOMS_REGISTER_PARAM
2024-04-04 05:49:01 -05:00
("The upper pressure [Pa] for tabulation of the fluid system");
move Co2InjectionProblem parameters to TypeTag-free parameter system
2024-07-05 10:49:51 -05:00
Parameters::Register<Parameters::FluidSystemNumPressure>
drop macro EWOMS_REGISTER_PARAM
2024-04-04 05:49:01 -05:00
("The number of intervals between the lower and upper pressure");
move Co2InjectionProblem parameters to TypeTag-free parameter system
2024-07-05 10:49:51 -05:00
Parameters::Register<Parameters::Temperature<Scalar>>
drop macro EWOMS_REGISTER_PARAM
2024-04-04 05:49:01 -05:00
("The temperature [K] in the reservoir");
move Co2InjectionProblem parameters to TypeTag-free parameter system
2024-07-05 10:49:51 -05:00
Parameters::Register<Parameters::MaxDepth<Scalar>>
drop macro EWOMS_REGISTER_PARAM
2024-04-04 05:49:01 -05:00
("The maximum depth [m] of the reservoir");
move Co2InjectionProblem parameters to TypeTag-free parameter system
2024-07-05 10:49:51 -05:00
Parameters::Register<Parameters::SimulationName>
drop macro EWOMS_REGISTER_PARAM
2024-04-04 05:49:01 -05:00
("The name of the simulation used for the output files");
move GridFile to TypeTag-free parameter system
2024-07-05 10:49:51 -05:00
Parameters::SetDefault<Parameters::GridFile>("data/co2injection.dgf");
move EndTime to TypeTag-free parameter system
2024-07-05 10:49:51 -05:00
Parameters::SetDefault<Parameters::EndTime<Scalar>>(1e4);
move InitialTimeStepSize to TypeTag-free parameter system
2024-07-05 10:49:51 -05:00
Parameters::SetDefault<Parameters::InitialTimeStepSize<Scalar>>(250);
move NewtonTolerance to TypeTag-free parameter system
2024-07-05 10:49:51 -05:00
Parameters::SetDefault<Parameters::NewtonTolerance<Scalar>>(Scalar{Co2InjectionTolerance});
move EnableGravity to TypeTag-free parameter system
2024-07-05 10:49:51 -05:00
Parameters::SetDefault<Parameters::EnableGravity>(true);
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
}
/*!
* \name Problem parameters
*/
//! \{
/*!
replace a few now-incorrect "Vcfv" prefixes in the comments
2014-07-17 10:24:48 -05:00
* \copydoc FvBaseProblem::name
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
*/
make the name() method of problems non-static again this allows to easily specify the problem name at runtime.
2014-04-25 10:22:28 -05:00
std::string name() const
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
{
std::ostringstream oss;
move Co2InjectionProblem parameters to TypeTag-free parameter system
2024-07-05 10:49:51 -05:00
oss << Parameters::Get<Parameters::SimulationName>()
problems: make the name() methods static this allows to retrieve the name of the problem before it is instantiated. this is required to be able to print the "Initializing problem" message at the correct point (i.e., before instantiating the problem).
2014-03-07 04:34:55 -06:00
<< "_" << Model::name();
[properties] replace macro calls by native C++
2020-06-08 09:41:02 -05:00
if (getPropValue<TypeTag, Properties::EnableEnergy>())
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
oss << "_ni";
problems: make the name() methods static this allows to retrieve the name of the problem before it is instantiated. this is required to be able to print the "Initializing problem" message at the correct point (i.e., before instantiating the problem).
2014-03-07 04:34:55 -06:00
oss << "_" << Model::discretizationName();
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
return oss.str();
}
/*!
replace a few now-incorrect "Vcfv" prefixes in the comments
2014-07-17 10:24:48 -05:00
* \copydoc FvBaseProblem::endTimeStep
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
*/
problems: fix some rename-fallout for the postTimeStep() to endTimeStep() drive
2014-07-17 09:54:05 -05:00
void endTimeStep()
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
{
use the checkConservativeness() method in all appropriate test problems "appropriate" basically means "does not use constraints", as constraints do not care about the conservation quantities...
2014-07-22 05:41:56 -05:00
#ifndef NDEBUG
co2injection problem: increase tolerance for conservativeness check this fixes a few test failures in debug mode with quadruple precision math enabled.
2016-11-02 09:45:19 -05:00
Scalar tol = this->model().newtonMethod().tolerance()*1e5;
use the checkConservativeness() method in all appropriate test problems "appropriate" basically means "does not use constraints", as constraints do not care about the conservation quantities...
2014-07-22 05:41:56 -05:00
this->model().checkConservativeness(tol);
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
// Calculate storage terms
PrimaryVariables storageL, storageG;
this->model().globalPhaseStorage(storageL, /*phaseIdx=*/0);
this->model().globalPhaseStorage(storageG, /*phaseIdx=*/1);
// Write mass balance information for rank 0
if (this->gridView().comm().rank() == 0) {
reformat the source code this was done semi-automatically. The line length has been set to 80 characters, but with a quite low penalty for crossing this limit.
2013-11-29 09:33:46 -06:00
std::cout << "Storage: liquid=[" << storageL << "]"
add more flushs for output this should make output less confusing if the stream caches some data...
2014-03-06 12:32:04 -06:00
<< " gas=[" << storageG << "]\n" << std::flush;
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
}
use the checkConservativeness() method in all appropriate test problems "appropriate" basically means "does not use constraints", as constraints do not care about the conservation quantities...
2014-07-22 05:41:56 -05:00
#endif // NDEBUG
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
}
/*!
Implement the element centered finite volume spatial discretization This makes eWoms multi-discretization capable. Along the way, this fixes some bugs and does a medium sized reorganization of the source tree. This is a squashed patch of the following commits: -------- 1st commit message: add initial version of the element centered finite volume discretization currently, it is a misnomer as it is just a copy of the vertex centered discretization plus some renames... -------- 2nd commit message: rename [VE]cfvModel -> [VE]cfvDiscretization -------- 3rd commit message: ecfv: prelimary changes required to make it compile but not work yet... -------- 4th commit message: Rename *FvElementGeometry to *Stencil "Stencil" seems to be the standard expression for this concept... (also, it is not specific to finite volume methods and is shorter.) -------- 5th commit message: refactor the stencil class for the element centered finite volume discretization -------- 6th commit message: ECFV: some work on the stencil class -------- 7th commit message: ECFV: make the boundary handling code compile -------- 8th commit message: rename elemContext() to elementContext() -------- 9th commit message: ECFV: make the VTK output modules compile -------- 10th commit message: stencil: introduce the concept of primary DOFs also save an vector of all element pointers in the stencil. -------- 11th commit message: ECFV: try to fix assembly; add missing timeIdx arguments to the num*() methods -------- 12th commit message: ECFV: fix stupid mistake in the assembler -------- 13th commit message: ECFV: remove a few implicit DOF == vertex assumptions the black-oil example now runs without valgrind complaints until it encounters a negative oil mole fraction. -------- 14th commit message: VCFV: make everything compile again all vertex centered FV examples should now work again... -------- 15th commit message: rename [ev]cfvmodel.hh to [ev]cfvdiscretization.hh the classes have already been renamed. -------- 16th commit message: ECFV: make it work to the point where it can write out the initial solution. -------- 17th commit message: ECFV: make it work the local residual/jacobian needed some work in distinguishing primary and secondary DOFs and there was an minor issue with the serialization code. for some reason, it seems still not correct. (-> convergence is too slow.) -------- 18th commit message: VCFV: make it compile for the black oil model again -------- 19th commit message: VCFV: make it compile with the remaining models again -------- 20th commit message: flash model: make it work with ECFV although this breaks its compatibility with VCFV. (-> next commit) -------- 21st commit message: adapt the VCFV to make it compatible with the flash model again -------- 22nd commit message: make all models compile with VCFV again -------- 23rd commit message: VCFV: more cleanups of the stencil VcfvStencil now does not have any public attributes anymore. TODO: do not export attributes in the SubControlVolume and SubControlVolumeFace classes. -------- 24th commit message: VCFV: actually update the element pointer -------- 25th commit message: change the blackoil model back to ECFV -------- 26th commit message: immiscible model: make it compatible with the ECFV discretization -------- 27th commit message: PVS model: make it work with ECFV -------- 28th commit message: NCP model: make it work with ECFV -------- 29th commit message: rename Vcfv*VelocityModule to *VelocityModule -------- 30th commit message: richards model: make it work with ECFV -------- 31st commit message: unify the ECFV and the VCFV VTK output modules and other cleanups -------- 32nd commit message: unify the common code of the VCFV and the ECFV disctretizations -------- 33rd commit message: unify the element contexts between element and vertex centered finite volumes -------- 34th commit message: unify the local jacobian class of the finite volume discretizations -------- 35th commit message: replace [VE]vcf(LocalResidual|ElementContext|BoundaryContext|ConstraintsContext) by generic code -------- 36th commit message: replace the [EV]cfvLocalResidual by generic code -------- 37th commit message: unify the MultiPhaseProblem and Problem classes, introduce NullBorderListCreator -------- 38th commit message: remove the discretization specific boundary context -------- 39th commit message: unify the [EV]cfvDiscretization classes -------- 40th commit message: Unify [EV]cfvMultiPhaseFluxVariables -------- 41st commit message: Unify the [EC]cfvNewton* classes -------- 42nd commit message: Unify [EV]cfvVolumeVariables -------- 43rd commit message: unify [EV]cfvAssembler -------- 44th commit message: unified flux variables: fix stupid mistake when calculating pressure gradients -------- 45th commit message: unify what's to unify for the [EV]CFV properties -------- 46th commit message: make the method to calculate gradients and values at flux approximation points changeable Currently, this is used by the vertex centered finite volume method to be able to use P1-finite element gradients instead of two-point ones... -------- 47th commit message: make the restart code work correctly, use the correct DofMapper for VCFV -------- 48th commit message: actually use the gradient calculator in a model the immiscible model in this case -------- 49th commit message: move some files around to where they belong, use the new gradient calculation code in all models TODO: proper handling of boundary gradients -------- 50th commit message: fix the stokes model currently it only works with the vertex centered finite volume discretization, but the plan is to soon move it to a staggered grid scheme anyway... -------- 51st commit message: move all models back to using the vertex centered finite volume discretization by default -------- 52nd commit message: models: some variable renames and documentation fixes - scv -> dof - vert -> dof - vertex -> dof - replace 'VCFV' - fix some typos -------- 53rd commit message: don't expect UG anymore since it is quite non-free and hard to get. we now use ALUGrid instead! -------- 54th commit message: temporarily disable jacobian recycling -------- 55th commit message: fix writing/reading restart files using the generic code -------- 56th commit message: fix bug where fluxes were only counted once in the stencil this only affected the vertex centered finite volumes discretization... -------- 57th commit message: boundary gradients: use the center of the sub-control volume adjacent to a boundary segment -------- 58th commit message: make it compile on GCC -------- 59th commit message: get rid of most hacks for this, partial reassemble and jacobian recycling was brought back. For the this and the remaining stuff the main trick is the introduction of the GridCommHandleFactory concept which constructs communication handles suited for the respective spatial discretization... -------- 60th commit message: fix a few annoying bugs first, default the convergence criterion for the linear solver did not honor the initial residual which lead to linear solver breakdowns, then some debugging code was left in the discrete fracture model and then there was a bug in the TP gradient approximation class... this has the consequence that we need a new reference solution for the discrete fracture problem... -------- 61st commit message: iterative linear solver: remove the code for the non-default convergence criteria -------- 62nd commit message: provide the FE cache instead of the local FE this fixes a segfault in the stokes model caused by the fact that the local FE was not initialized at this point. -------- 63rd commit message: (Navier-)Stokes: fix bug due to the transition to unit normals now, all tests pass for this branch. The only things which need to be fixed are some annoying performance regressions compared to master and some bug in the splices feature of the property system... -------- 64th commit message: some fix for the local residual of the immiscible model -------- 65th commit message: Navier-Stokes: implement SCV center gradients There seems to be a bug in the previous implementation (the jacobian inverse transposed is evaluated using the local, not the global geometry), so the reference solution for the stokes2c test problem has also been updated... -------- 66th commit message: remove the ALUGrid specialization of the LensGridCreator and the YaspGrid one for the fingerproblem using different grid seems to sometimes cause a different vertex order, which in turn causes the respective test to fail if the reference solution was computed using the other grid... -------- 67th commit message: VCFV: use the correct BorderListCreator this makes MPI parallel computations work again. apart from performance regressions, this branch does not exhibit any known regressions compared to master anymore... -------- 68th commit message: make verything compile with the element centered finite volume discretization except the Navier-Stokes and the two-phase DFM models, of course... -------- 69th commit message: minor fixes - make the navier-stokes model slighly more generic by using the proper (in,ex)teriorIndex() methods on sub-control volumes - make the signature of the calculateValue() template method of the common two-point gradient approximator match the one of the vertex centered finite volume one -------- 70th commit message: fix fallout from the Big Rebase -------- 71st commit message: ECFV: some bugs in the boundary -------- 72nd commit message: make computeFlux() compute area-specific quantities -------- 73rd commit message: fix more bugs in the element centered FV discretization now eWoms should match Dumux pretty closely... -------- 74th commit message: coalesce the common code of the multi phase porous medium models into "MultiPhaseBaseModel" -------- 75th commit message: update reference solutions these were changed because of the screw-up with the area of boundary segments... -------- 76th commit message: rename "ImplicitBase" to "FvBase" because in eWoms, everything is implicit and these are currently the base classes for all finite volume discretizations. -------- 77th commit message: make the spatial discretization selectable using a splice This requires an opm-core with a the patches from https://github.com/OPM/opm-core/pull/446 merged... -------- 78th commit message: rename the properties used for splices to *Splice -------- 79th commit message: move the files in 'tests/models' to 'tests' since 'tests' was empty except for the 'models' subdirectory... -------- 80th commit message: improve and fix the tutorial -------- 81st commit message: remove the -fno-strict-aliasing flag from the provided option files seems like recent versions of Dune have been adapted... -------- 82nd commit message: also compile all CO2 injection simulations using the element centered finite volume discretization -------- 83rd commit message: PVS model: make it work properly with the element-centered finite volume discretiation because DOF != number of vertices
2013-12-12 05:52:44 -06:00
* \copydoc FvBaseMultiPhaseProblem::temperature
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
*/
template <class Context>
fix most pedantic compiler warnings in the basic infrastructure i.e., using clang 3.8 to compile the test suite with the following flags: ``` -Weverything -Wno-documentation -Wno-documentation-unknown-command -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undef -Wno-padded -Wno-global-constructors -Wno-exit-time-destructors -Wno-weak-vtables -Wno-float-equal ``` should not produce any warnings anymore. In my opinion the only flag which would produce beneficial warnings is -Wdocumentation. This has not been fixed in this patch because writing documentation is left for another day (or, more likely, year). note that this patch consists of a heavy dose of the OPM_UNUSED macro and plenty of static_casts (to fix signedness issues). Fixing the singedness issues were quite a nightmare and the fact that the Dune API is quite inconsistent in that regard was not exactly helpful. :/ Finally this patch includes quite a few formatting changes (e.g., all occurences of 'T &t' should be changed to `T& t`) and some fixes for minor issues which I've found during the excercise. I've made sure that all unit tests the test suite still pass successfully and I've made sure that flow_ebos still works for Norne and that it did not regress w.r.t. performance. (Note that this patch does not fix compiler warnings triggered `ebos` and `flow_ebos` but only those caused by the basic infrastructure or the unit tests.) v2: fix the warnings that occur if the dune-localfunctions module is not available. thanks to [at]atgeirr for testing. v3: fix dune 2.3 build issue
2016-11-07 08:14:07 -06:00
Scalar temperature(const Context& context, unsigned spaceIdx, unsigned timeIdx) const
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
{
fix most pedantic compiler warnings in the basic infrastructure i.e., using clang 3.8 to compile the test suite with the following flags: ``` -Weverything -Wno-documentation -Wno-documentation-unknown-command -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undef -Wno-padded -Wno-global-constructors -Wno-exit-time-destructors -Wno-weak-vtables -Wno-float-equal ``` should not produce any warnings anymore. In my opinion the only flag which would produce beneficial warnings is -Wdocumentation. This has not been fixed in this patch because writing documentation is left for another day (or, more likely, year). note that this patch consists of a heavy dose of the OPM_UNUSED macro and plenty of static_casts (to fix signedness issues). Fixing the singedness issues were quite a nightmare and the fact that the Dune API is quite inconsistent in that regard was not exactly helpful. :/ Finally this patch includes quite a few formatting changes (e.g., all occurences of 'T &t' should be changed to `T& t`) and some fixes for minor issues which I've found during the excercise. I've made sure that all unit tests the test suite still pass successfully and I've made sure that flow_ebos still works for Norne and that it did not regress w.r.t. performance. (Note that this patch does not fix compiler warnings triggered `ebos` and `flow_ebos` but only those caused by the basic infrastructure or the unit tests.) v2: fix the warnings that occur if the dune-localfunctions module is not available. thanks to [at]atgeirr for testing. v3: fix dune 2.3 build issue
2016-11-07 08:14:07 -06:00
const auto& pos = context.pos(spaceIdx, timeIdx);
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
if (inHighTemperatureRegion_(pos))
return temperature_ + 100;
return temperature_;
}
/*!
Implement the element centered finite volume spatial discretization This makes eWoms multi-discretization capable. Along the way, this fixes some bugs and does a medium sized reorganization of the source tree. This is a squashed patch of the following commits: -------- 1st commit message: add initial version of the element centered finite volume discretization currently, it is a misnomer as it is just a copy of the vertex centered discretization plus some renames... -------- 2nd commit message: rename [VE]cfvModel -> [VE]cfvDiscretization -------- 3rd commit message: ecfv: prelimary changes required to make it compile but not work yet... -------- 4th commit message: Rename *FvElementGeometry to *Stencil "Stencil" seems to be the standard expression for this concept... (also, it is not specific to finite volume methods and is shorter.) -------- 5th commit message: refactor the stencil class for the element centered finite volume discretization -------- 6th commit message: ECFV: some work on the stencil class -------- 7th commit message: ECFV: make the boundary handling code compile -------- 8th commit message: rename elemContext() to elementContext() -------- 9th commit message: ECFV: make the VTK output modules compile -------- 10th commit message: stencil: introduce the concept of primary DOFs also save an vector of all element pointers in the stencil. -------- 11th commit message: ECFV: try to fix assembly; add missing timeIdx arguments to the num*() methods -------- 12th commit message: ECFV: fix stupid mistake in the assembler -------- 13th commit message: ECFV: remove a few implicit DOF == vertex assumptions the black-oil example now runs without valgrind complaints until it encounters a negative oil mole fraction. -------- 14th commit message: VCFV: make everything compile again all vertex centered FV examples should now work again... -------- 15th commit message: rename [ev]cfvmodel.hh to [ev]cfvdiscretization.hh the classes have already been renamed. -------- 16th commit message: ECFV: make it work to the point where it can write out the initial solution. -------- 17th commit message: ECFV: make it work the local residual/jacobian needed some work in distinguishing primary and secondary DOFs and there was an minor issue with the serialization code. for some reason, it seems still not correct. (-> convergence is too slow.) -------- 18th commit message: VCFV: make it compile for the black oil model again -------- 19th commit message: VCFV: make it compile with the remaining models again -------- 20th commit message: flash model: make it work with ECFV although this breaks its compatibility with VCFV. (-> next commit) -------- 21st commit message: adapt the VCFV to make it compatible with the flash model again -------- 22nd commit message: make all models compile with VCFV again -------- 23rd commit message: VCFV: more cleanups of the stencil VcfvStencil now does not have any public attributes anymore. TODO: do not export attributes in the SubControlVolume and SubControlVolumeFace classes. -------- 24th commit message: VCFV: actually update the element pointer -------- 25th commit message: change the blackoil model back to ECFV -------- 26th commit message: immiscible model: make it compatible with the ECFV discretization -------- 27th commit message: PVS model: make it work with ECFV -------- 28th commit message: NCP model: make it work with ECFV -------- 29th commit message: rename Vcfv*VelocityModule to *VelocityModule -------- 30th commit message: richards model: make it work with ECFV -------- 31st commit message: unify the ECFV and the VCFV VTK output modules and other cleanups -------- 32nd commit message: unify the common code of the VCFV and the ECFV disctretizations -------- 33rd commit message: unify the element contexts between element and vertex centered finite volumes -------- 34th commit message: unify the local jacobian class of the finite volume discretizations -------- 35th commit message: replace [VE]vcf(LocalResidual|ElementContext|BoundaryContext|ConstraintsContext) by generic code -------- 36th commit message: replace the [EV]cfvLocalResidual by generic code -------- 37th commit message: unify the MultiPhaseProblem and Problem classes, introduce NullBorderListCreator -------- 38th commit message: remove the discretization specific boundary context -------- 39th commit message: unify the [EV]cfvDiscretization classes -------- 40th commit message: Unify [EV]cfvMultiPhaseFluxVariables -------- 41st commit message: Unify the [EC]cfvNewton* classes -------- 42nd commit message: Unify [EV]cfvVolumeVariables -------- 43rd commit message: unify [EV]cfvAssembler -------- 44th commit message: unified flux variables: fix stupid mistake when calculating pressure gradients -------- 45th commit message: unify what's to unify for the [EV]CFV properties -------- 46th commit message: make the method to calculate gradients and values at flux approximation points changeable Currently, this is used by the vertex centered finite volume method to be able to use P1-finite element gradients instead of two-point ones... -------- 47th commit message: make the restart code work correctly, use the correct DofMapper for VCFV -------- 48th commit message: actually use the gradient calculator in a model the immiscible model in this case -------- 49th commit message: move some files around to where they belong, use the new gradient calculation code in all models TODO: proper handling of boundary gradients -------- 50th commit message: fix the stokes model currently it only works with the vertex centered finite volume discretization, but the plan is to soon move it to a staggered grid scheme anyway... -------- 51st commit message: move all models back to using the vertex centered finite volume discretization by default -------- 52nd commit message: models: some variable renames and documentation fixes - scv -> dof - vert -> dof - vertex -> dof - replace 'VCFV' - fix some typos -------- 53rd commit message: don't expect UG anymore since it is quite non-free and hard to get. we now use ALUGrid instead! -------- 54th commit message: temporarily disable jacobian recycling -------- 55th commit message: fix writing/reading restart files using the generic code -------- 56th commit message: fix bug where fluxes were only counted once in the stencil this only affected the vertex centered finite volumes discretization... -------- 57th commit message: boundary gradients: use the center of the sub-control volume adjacent to a boundary segment -------- 58th commit message: make it compile on GCC -------- 59th commit message: get rid of most hacks for this, partial reassemble and jacobian recycling was brought back. For the this and the remaining stuff the main trick is the introduction of the GridCommHandleFactory concept which constructs communication handles suited for the respective spatial discretization... -------- 60th commit message: fix a few annoying bugs first, default the convergence criterion for the linear solver did not honor the initial residual which lead to linear solver breakdowns, then some debugging code was left in the discrete fracture model and then there was a bug in the TP gradient approximation class... this has the consequence that we need a new reference solution for the discrete fracture problem... -------- 61st commit message: iterative linear solver: remove the code for the non-default convergence criteria -------- 62nd commit message: provide the FE cache instead of the local FE this fixes a segfault in the stokes model caused by the fact that the local FE was not initialized at this point. -------- 63rd commit message: (Navier-)Stokes: fix bug due to the transition to unit normals now, all tests pass for this branch. The only things which need to be fixed are some annoying performance regressions compared to master and some bug in the splices feature of the property system... -------- 64th commit message: some fix for the local residual of the immiscible model -------- 65th commit message: Navier-Stokes: implement SCV center gradients There seems to be a bug in the previous implementation (the jacobian inverse transposed is evaluated using the local, not the global geometry), so the reference solution for the stokes2c test problem has also been updated... -------- 66th commit message: remove the ALUGrid specialization of the LensGridCreator and the YaspGrid one for the fingerproblem using different grid seems to sometimes cause a different vertex order, which in turn causes the respective test to fail if the reference solution was computed using the other grid... -------- 67th commit message: VCFV: use the correct BorderListCreator this makes MPI parallel computations work again. apart from performance regressions, this branch does not exhibit any known regressions compared to master anymore... -------- 68th commit message: make verything compile with the element centered finite volume discretization except the Navier-Stokes and the two-phase DFM models, of course... -------- 69th commit message: minor fixes - make the navier-stokes model slighly more generic by using the proper (in,ex)teriorIndex() methods on sub-control volumes - make the signature of the calculateValue() template method of the common two-point gradient approximator match the one of the vertex centered finite volume one -------- 70th commit message: fix fallout from the Big Rebase -------- 71st commit message: ECFV: some bugs in the boundary -------- 72nd commit message: make computeFlux() compute area-specific quantities -------- 73rd commit message: fix more bugs in the element centered FV discretization now eWoms should match Dumux pretty closely... -------- 74th commit message: coalesce the common code of the multi phase porous medium models into "MultiPhaseBaseModel" -------- 75th commit message: update reference solutions these were changed because of the screw-up with the area of boundary segments... -------- 76th commit message: rename "ImplicitBase" to "FvBase" because in eWoms, everything is implicit and these are currently the base classes for all finite volume discretizations. -------- 77th commit message: make the spatial discretization selectable using a splice This requires an opm-core with a the patches from https://github.com/OPM/opm-core/pull/446 merged... -------- 78th commit message: rename the properties used for splices to *Splice -------- 79th commit message: move the files in 'tests/models' to 'tests' since 'tests' was empty except for the 'models' subdirectory... -------- 80th commit message: improve and fix the tutorial -------- 81st commit message: remove the -fno-strict-aliasing flag from the provided option files seems like recent versions of Dune have been adapted... -------- 82nd commit message: also compile all CO2 injection simulations using the element centered finite volume discretization -------- 83rd commit message: PVS model: make it work properly with the element-centered finite volume discretiation because DOF != number of vertices
2013-12-12 05:52:44 -06:00
* \copydoc FvBaseMultiPhaseProblem::intrinsicPermeability
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
*/
template <class Context>
fix most pedantic compiler warnings in the basic infrastructure i.e., using clang 3.8 to compile the test suite with the following flags: ``` -Weverything -Wno-documentation -Wno-documentation-unknown-command -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undef -Wno-padded -Wno-global-constructors -Wno-exit-time-destructors -Wno-weak-vtables -Wno-float-equal ``` should not produce any warnings anymore. In my opinion the only flag which would produce beneficial warnings is -Wdocumentation. This has not been fixed in this patch because writing documentation is left for another day (or, more likely, year). note that this patch consists of a heavy dose of the OPM_UNUSED macro and plenty of static_casts (to fix signedness issues). Fixing the singedness issues were quite a nightmare and the fact that the Dune API is quite inconsistent in that regard was not exactly helpful. :/ Finally this patch includes quite a few formatting changes (e.g., all occurences of 'T &t' should be changed to `T& t`) and some fixes for minor issues which I've found during the excercise. I've made sure that all unit tests the test suite still pass successfully and I've made sure that flow_ebos still works for Norne and that it did not regress w.r.t. performance. (Note that this patch does not fix compiler warnings triggered `ebos` and `flow_ebos` but only those caused by the basic infrastructure or the unit tests.) v2: fix the warnings that occur if the dune-localfunctions module is not available. thanks to [at]atgeirr for testing. v3: fix dune 2.3 build issue
2016-11-07 08:14:07 -06:00
const DimMatrix& intrinsicPermeability(const Context& context, unsigned spaceIdx,
make most indices unsigned (instead of using 'int'.) This triggered quite a few compiler warnings which are also dealt-with by this patch.
2015-11-18 04:54:35 -06:00
unsigned timeIdx) const
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
{
fix most pedantic compiler warnings in the basic infrastructure i.e., using clang 3.8 to compile the test suite with the following flags: ``` -Weverything -Wno-documentation -Wno-documentation-unknown-command -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undef -Wno-padded -Wno-global-constructors -Wno-exit-time-destructors -Wno-weak-vtables -Wno-float-equal ``` should not produce any warnings anymore. In my opinion the only flag which would produce beneficial warnings is -Wdocumentation. This has not been fixed in this patch because writing documentation is left for another day (or, more likely, year). note that this patch consists of a heavy dose of the OPM_UNUSED macro and plenty of static_casts (to fix signedness issues). Fixing the singedness issues were quite a nightmare and the fact that the Dune API is quite inconsistent in that regard was not exactly helpful. :/ Finally this patch includes quite a few formatting changes (e.g., all occurences of 'T &t' should be changed to `T& t`) and some fixes for minor issues which I've found during the excercise. I've made sure that all unit tests the test suite still pass successfully and I've made sure that flow_ebos still works for Norne and that it did not regress w.r.t. performance. (Note that this patch does not fix compiler warnings triggered `ebos` and `flow_ebos` but only those caused by the basic infrastructure or the unit tests.) v2: fix the warnings that occur if the dune-localfunctions module is not available. thanks to [at]atgeirr for testing. v3: fix dune 2.3 build issue
2016-11-07 08:14:07 -06:00
const GlobalPosition& pos = context.pos(spaceIdx, timeIdx);
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
if (isFineMaterial_(pos))
return fineK_;
return coarseK_;
}
/*!
Implement the element centered finite volume spatial discretization This makes eWoms multi-discretization capable. Along the way, this fixes some bugs and does a medium sized reorganization of the source tree. This is a squashed patch of the following commits: -------- 1st commit message: add initial version of the element centered finite volume discretization currently, it is a misnomer as it is just a copy of the vertex centered discretization plus some renames... -------- 2nd commit message: rename [VE]cfvModel -> [VE]cfvDiscretization -------- 3rd commit message: ecfv: prelimary changes required to make it compile but not work yet... -------- 4th commit message: Rename *FvElementGeometry to *Stencil "Stencil" seems to be the standard expression for this concept... (also, it is not specific to finite volume methods and is shorter.) -------- 5th commit message: refactor the stencil class for the element centered finite volume discretization -------- 6th commit message: ECFV: some work on the stencil class -------- 7th commit message: ECFV: make the boundary handling code compile -------- 8th commit message: rename elemContext() to elementContext() -------- 9th commit message: ECFV: make the VTK output modules compile -------- 10th commit message: stencil: introduce the concept of primary DOFs also save an vector of all element pointers in the stencil. -------- 11th commit message: ECFV: try to fix assembly; add missing timeIdx arguments to the num*() methods -------- 12th commit message: ECFV: fix stupid mistake in the assembler -------- 13th commit message: ECFV: remove a few implicit DOF == vertex assumptions the black-oil example now runs without valgrind complaints until it encounters a negative oil mole fraction. -------- 14th commit message: VCFV: make everything compile again all vertex centered FV examples should now work again... -------- 15th commit message: rename [ev]cfvmodel.hh to [ev]cfvdiscretization.hh the classes have already been renamed. -------- 16th commit message: ECFV: make it work to the point where it can write out the initial solution. -------- 17th commit message: ECFV: make it work the local residual/jacobian needed some work in distinguishing primary and secondary DOFs and there was an minor issue with the serialization code. for some reason, it seems still not correct. (-> convergence is too slow.) -------- 18th commit message: VCFV: make it compile for the black oil model again -------- 19th commit message: VCFV: make it compile with the remaining models again -------- 20th commit message: flash model: make it work with ECFV although this breaks its compatibility with VCFV. (-> next commit) -------- 21st commit message: adapt the VCFV to make it compatible with the flash model again -------- 22nd commit message: make all models compile with VCFV again -------- 23rd commit message: VCFV: more cleanups of the stencil VcfvStencil now does not have any public attributes anymore. TODO: do not export attributes in the SubControlVolume and SubControlVolumeFace classes. -------- 24th commit message: VCFV: actually update the element pointer -------- 25th commit message: change the blackoil model back to ECFV -------- 26th commit message: immiscible model: make it compatible with the ECFV discretization -------- 27th commit message: PVS model: make it work with ECFV -------- 28th commit message: NCP model: make it work with ECFV -------- 29th commit message: rename Vcfv*VelocityModule to *VelocityModule -------- 30th commit message: richards model: make it work with ECFV -------- 31st commit message: unify the ECFV and the VCFV VTK output modules and other cleanups -------- 32nd commit message: unify the common code of the VCFV and the ECFV disctretizations -------- 33rd commit message: unify the element contexts between element and vertex centered finite volumes -------- 34th commit message: unify the local jacobian class of the finite volume discretizations -------- 35th commit message: replace [VE]vcf(LocalResidual|ElementContext|BoundaryContext|ConstraintsContext) by generic code -------- 36th commit message: replace the [EV]cfvLocalResidual by generic code -------- 37th commit message: unify the MultiPhaseProblem and Problem classes, introduce NullBorderListCreator -------- 38th commit message: remove the discretization specific boundary context -------- 39th commit message: unify the [EV]cfvDiscretization classes -------- 40th commit message: Unify [EV]cfvMultiPhaseFluxVariables -------- 41st commit message: Unify the [EC]cfvNewton* classes -------- 42nd commit message: Unify [EV]cfvVolumeVariables -------- 43rd commit message: unify [EV]cfvAssembler -------- 44th commit message: unified flux variables: fix stupid mistake when calculating pressure gradients -------- 45th commit message: unify what's to unify for the [EV]CFV properties -------- 46th commit message: make the method to calculate gradients and values at flux approximation points changeable Currently, this is used by the vertex centered finite volume method to be able to use P1-finite element gradients instead of two-point ones... -------- 47th commit message: make the restart code work correctly, use the correct DofMapper for VCFV -------- 48th commit message: actually use the gradient calculator in a model the immiscible model in this case -------- 49th commit message: move some files around to where they belong, use the new gradient calculation code in all models TODO: proper handling of boundary gradients -------- 50th commit message: fix the stokes model currently it only works with the vertex centered finite volume discretization, but the plan is to soon move it to a staggered grid scheme anyway... -------- 51st commit message: move all models back to using the vertex centered finite volume discretization by default -------- 52nd commit message: models: some variable renames and documentation fixes - scv -> dof - vert -> dof - vertex -> dof - replace 'VCFV' - fix some typos -------- 53rd commit message: don't expect UG anymore since it is quite non-free and hard to get. we now use ALUGrid instead! -------- 54th commit message: temporarily disable jacobian recycling -------- 55th commit message: fix writing/reading restart files using the generic code -------- 56th commit message: fix bug where fluxes were only counted once in the stencil this only affected the vertex centered finite volumes discretization... -------- 57th commit message: boundary gradients: use the center of the sub-control volume adjacent to a boundary segment -------- 58th commit message: make it compile on GCC -------- 59th commit message: get rid of most hacks for this, partial reassemble and jacobian recycling was brought back. For the this and the remaining stuff the main trick is the introduction of the GridCommHandleFactory concept which constructs communication handles suited for the respective spatial discretization... -------- 60th commit message: fix a few annoying bugs first, default the convergence criterion for the linear solver did not honor the initial residual which lead to linear solver breakdowns, then some debugging code was left in the discrete fracture model and then there was a bug in the TP gradient approximation class... this has the consequence that we need a new reference solution for the discrete fracture problem... -------- 61st commit message: iterative linear solver: remove the code for the non-default convergence criteria -------- 62nd commit message: provide the FE cache instead of the local FE this fixes a segfault in the stokes model caused by the fact that the local FE was not initialized at this point. -------- 63rd commit message: (Navier-)Stokes: fix bug due to the transition to unit normals now, all tests pass for this branch. The only things which need to be fixed are some annoying performance regressions compared to master and some bug in the splices feature of the property system... -------- 64th commit message: some fix for the local residual of the immiscible model -------- 65th commit message: Navier-Stokes: implement SCV center gradients There seems to be a bug in the previous implementation (the jacobian inverse transposed is evaluated using the local, not the global geometry), so the reference solution for the stokes2c test problem has also been updated... -------- 66th commit message: remove the ALUGrid specialization of the LensGridCreator and the YaspGrid one for the fingerproblem using different grid seems to sometimes cause a different vertex order, which in turn causes the respective test to fail if the reference solution was computed using the other grid... -------- 67th commit message: VCFV: use the correct BorderListCreator this makes MPI parallel computations work again. apart from performance regressions, this branch does not exhibit any known regressions compared to master anymore... -------- 68th commit message: make verything compile with the element centered finite volume discretization except the Navier-Stokes and the two-phase DFM models, of course... -------- 69th commit message: minor fixes - make the navier-stokes model slighly more generic by using the proper (in,ex)teriorIndex() methods on sub-control volumes - make the signature of the calculateValue() template method of the common two-point gradient approximator match the one of the vertex centered finite volume one -------- 70th commit message: fix fallout from the Big Rebase -------- 71st commit message: ECFV: some bugs in the boundary -------- 72nd commit message: make computeFlux() compute area-specific quantities -------- 73rd commit message: fix more bugs in the element centered FV discretization now eWoms should match Dumux pretty closely... -------- 74th commit message: coalesce the common code of the multi phase porous medium models into "MultiPhaseBaseModel" -------- 75th commit message: update reference solutions these were changed because of the screw-up with the area of boundary segments... -------- 76th commit message: rename "ImplicitBase" to "FvBase" because in eWoms, everything is implicit and these are currently the base classes for all finite volume discretizations. -------- 77th commit message: make the spatial discretization selectable using a splice This requires an opm-core with a the patches from https://github.com/OPM/opm-core/pull/446 merged... -------- 78th commit message: rename the properties used for splices to *Splice -------- 79th commit message: move the files in 'tests/models' to 'tests' since 'tests' was empty except for the 'models' subdirectory... -------- 80th commit message: improve and fix the tutorial -------- 81st commit message: remove the -fno-strict-aliasing flag from the provided option files seems like recent versions of Dune have been adapted... -------- 82nd commit message: also compile all CO2 injection simulations using the element centered finite volume discretization -------- 83rd commit message: PVS model: make it work properly with the element-centered finite volume discretiation because DOF != number of vertices
2013-12-12 05:52:44 -06:00
* \copydoc FvBaseMultiPhaseProblem::porosity
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
*/
template <class Context>
fix most pedantic compiler warnings in the basic infrastructure i.e., using clang 3.8 to compile the test suite with the following flags: ``` -Weverything -Wno-documentation -Wno-documentation-unknown-command -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undef -Wno-padded -Wno-global-constructors -Wno-exit-time-destructors -Wno-weak-vtables -Wno-float-equal ``` should not produce any warnings anymore. In my opinion the only flag which would produce beneficial warnings is -Wdocumentation. This has not been fixed in this patch because writing documentation is left for another day (or, more likely, year). note that this patch consists of a heavy dose of the OPM_UNUSED macro and plenty of static_casts (to fix signedness issues). Fixing the singedness issues were quite a nightmare and the fact that the Dune API is quite inconsistent in that regard was not exactly helpful. :/ Finally this patch includes quite a few formatting changes (e.g., all occurences of 'T &t' should be changed to `T& t`) and some fixes for minor issues which I've found during the excercise. I've made sure that all unit tests the test suite still pass successfully and I've made sure that flow_ebos still works for Norne and that it did not regress w.r.t. performance. (Note that this patch does not fix compiler warnings triggered `ebos` and `flow_ebos` but only those caused by the basic infrastructure or the unit tests.) v2: fix the warnings that occur if the dune-localfunctions module is not available. thanks to [at]atgeirr for testing. v3: fix dune 2.3 build issue
2016-11-07 08:14:07 -06:00
Scalar porosity(const Context& context, unsigned spaceIdx, unsigned timeIdx) const
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
{
fix most pedantic compiler warnings in the basic infrastructure i.e., using clang 3.8 to compile the test suite with the following flags: ``` -Weverything -Wno-documentation -Wno-documentation-unknown-command -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undef -Wno-padded -Wno-global-constructors -Wno-exit-time-destructors -Wno-weak-vtables -Wno-float-equal ``` should not produce any warnings anymore. In my opinion the only flag which would produce beneficial warnings is -Wdocumentation. This has not been fixed in this patch because writing documentation is left for another day (or, more likely, year). note that this patch consists of a heavy dose of the OPM_UNUSED macro and plenty of static_casts (to fix signedness issues). Fixing the singedness issues were quite a nightmare and the fact that the Dune API is quite inconsistent in that regard was not exactly helpful. :/ Finally this patch includes quite a few formatting changes (e.g., all occurences of 'T &t' should be changed to `T& t`) and some fixes for minor issues which I've found during the excercise. I've made sure that all unit tests the test suite still pass successfully and I've made sure that flow_ebos still works for Norne and that it did not regress w.r.t. performance. (Note that this patch does not fix compiler warnings triggered `ebos` and `flow_ebos` but only those caused by the basic infrastructure or the unit tests.) v2: fix the warnings that occur if the dune-localfunctions module is not available. thanks to [at]atgeirr for testing. v3: fix dune 2.3 build issue
2016-11-07 08:14:07 -06:00
const GlobalPosition& pos = context.pos(spaceIdx, timeIdx);
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
if (isFineMaterial_(pos))
return finePorosity_;
return coarsePorosity_;
}
/*!
Implement the element centered finite volume spatial discretization This makes eWoms multi-discretization capable. Along the way, this fixes some bugs and does a medium sized reorganization of the source tree. This is a squashed patch of the following commits: -------- 1st commit message: add initial version of the element centered finite volume discretization currently, it is a misnomer as it is just a copy of the vertex centered discretization plus some renames... -------- 2nd commit message: rename [VE]cfvModel -> [VE]cfvDiscretization -------- 3rd commit message: ecfv: prelimary changes required to make it compile but not work yet... -------- 4th commit message: Rename *FvElementGeometry to *Stencil "Stencil" seems to be the standard expression for this concept... (also, it is not specific to finite volume methods and is shorter.) -------- 5th commit message: refactor the stencil class for the element centered finite volume discretization -------- 6th commit message: ECFV: some work on the stencil class -------- 7th commit message: ECFV: make the boundary handling code compile -------- 8th commit message: rename elemContext() to elementContext() -------- 9th commit message: ECFV: make the VTK output modules compile -------- 10th commit message: stencil: introduce the concept of primary DOFs also save an vector of all element pointers in the stencil. -------- 11th commit message: ECFV: try to fix assembly; add missing timeIdx arguments to the num*() methods -------- 12th commit message: ECFV: fix stupid mistake in the assembler -------- 13th commit message: ECFV: remove a few implicit DOF == vertex assumptions the black-oil example now runs without valgrind complaints until it encounters a negative oil mole fraction. -------- 14th commit message: VCFV: make everything compile again all vertex centered FV examples should now work again... -------- 15th commit message: rename [ev]cfvmodel.hh to [ev]cfvdiscretization.hh the classes have already been renamed. -------- 16th commit message: ECFV: make it work to the point where it can write out the initial solution. -------- 17th commit message: ECFV: make it work the local residual/jacobian needed some work in distinguishing primary and secondary DOFs and there was an minor issue with the serialization code. for some reason, it seems still not correct. (-> convergence is too slow.) -------- 18th commit message: VCFV: make it compile for the black oil model again -------- 19th commit message: VCFV: make it compile with the remaining models again -------- 20th commit message: flash model: make it work with ECFV although this breaks its compatibility with VCFV. (-> next commit) -------- 21st commit message: adapt the VCFV to make it compatible with the flash model again -------- 22nd commit message: make all models compile with VCFV again -------- 23rd commit message: VCFV: more cleanups of the stencil VcfvStencil now does not have any public attributes anymore. TODO: do not export attributes in the SubControlVolume and SubControlVolumeFace classes. -------- 24th commit message: VCFV: actually update the element pointer -------- 25th commit message: change the blackoil model back to ECFV -------- 26th commit message: immiscible model: make it compatible with the ECFV discretization -------- 27th commit message: PVS model: make it work with ECFV -------- 28th commit message: NCP model: make it work with ECFV -------- 29th commit message: rename Vcfv*VelocityModule to *VelocityModule -------- 30th commit message: richards model: make it work with ECFV -------- 31st commit message: unify the ECFV and the VCFV VTK output modules and other cleanups -------- 32nd commit message: unify the common code of the VCFV and the ECFV disctretizations -------- 33rd commit message: unify the element contexts between element and vertex centered finite volumes -------- 34th commit message: unify the local jacobian class of the finite volume discretizations -------- 35th commit message: replace [VE]vcf(LocalResidual|ElementContext|BoundaryContext|ConstraintsContext) by generic code -------- 36th commit message: replace the [EV]cfvLocalResidual by generic code -------- 37th commit message: unify the MultiPhaseProblem and Problem classes, introduce NullBorderListCreator -------- 38th commit message: remove the discretization specific boundary context -------- 39th commit message: unify the [EV]cfvDiscretization classes -------- 40th commit message: Unify [EV]cfvMultiPhaseFluxVariables -------- 41st commit message: Unify the [EC]cfvNewton* classes -------- 42nd commit message: Unify [EV]cfvVolumeVariables -------- 43rd commit message: unify [EV]cfvAssembler -------- 44th commit message: unified flux variables: fix stupid mistake when calculating pressure gradients -------- 45th commit message: unify what's to unify for the [EV]CFV properties -------- 46th commit message: make the method to calculate gradients and values at flux approximation points changeable Currently, this is used by the vertex centered finite volume method to be able to use P1-finite element gradients instead of two-point ones... -------- 47th commit message: make the restart code work correctly, use the correct DofMapper for VCFV -------- 48th commit message: actually use the gradient calculator in a model the immiscible model in this case -------- 49th commit message: move some files around to where they belong, use the new gradient calculation code in all models TODO: proper handling of boundary gradients -------- 50th commit message: fix the stokes model currently it only works with the vertex centered finite volume discretization, but the plan is to soon move it to a staggered grid scheme anyway... -------- 51st commit message: move all models back to using the vertex centered finite volume discretization by default -------- 52nd commit message: models: some variable renames and documentation fixes - scv -> dof - vert -> dof - vertex -> dof - replace 'VCFV' - fix some typos -------- 53rd commit message: don't expect UG anymore since it is quite non-free and hard to get. we now use ALUGrid instead! -------- 54th commit message: temporarily disable jacobian recycling -------- 55th commit message: fix writing/reading restart files using the generic code -------- 56th commit message: fix bug where fluxes were only counted once in the stencil this only affected the vertex centered finite volumes discretization... -------- 57th commit message: boundary gradients: use the center of the sub-control volume adjacent to a boundary segment -------- 58th commit message: make it compile on GCC -------- 59th commit message: get rid of most hacks for this, partial reassemble and jacobian recycling was brought back. For the this and the remaining stuff the main trick is the introduction of the GridCommHandleFactory concept which constructs communication handles suited for the respective spatial discretization... -------- 60th commit message: fix a few annoying bugs first, default the convergence criterion for the linear solver did not honor the initial residual which lead to linear solver breakdowns, then some debugging code was left in the discrete fracture model and then there was a bug in the TP gradient approximation class... this has the consequence that we need a new reference solution for the discrete fracture problem... -------- 61st commit message: iterative linear solver: remove the code for the non-default convergence criteria -------- 62nd commit message: provide the FE cache instead of the local FE this fixes a segfault in the stokes model caused by the fact that the local FE was not initialized at this point. -------- 63rd commit message: (Navier-)Stokes: fix bug due to the transition to unit normals now, all tests pass for this branch. The only things which need to be fixed are some annoying performance regressions compared to master and some bug in the splices feature of the property system... -------- 64th commit message: some fix for the local residual of the immiscible model -------- 65th commit message: Navier-Stokes: implement SCV center gradients There seems to be a bug in the previous implementation (the jacobian inverse transposed is evaluated using the local, not the global geometry), so the reference solution for the stokes2c test problem has also been updated... -------- 66th commit message: remove the ALUGrid specialization of the LensGridCreator and the YaspGrid one for the fingerproblem using different grid seems to sometimes cause a different vertex order, which in turn causes the respective test to fail if the reference solution was computed using the other grid... -------- 67th commit message: VCFV: use the correct BorderListCreator this makes MPI parallel computations work again. apart from performance regressions, this branch does not exhibit any known regressions compared to master anymore... -------- 68th commit message: make verything compile with the element centered finite volume discretization except the Navier-Stokes and the two-phase DFM models, of course... -------- 69th commit message: minor fixes - make the navier-stokes model slighly more generic by using the proper (in,ex)teriorIndex() methods on sub-control volumes - make the signature of the calculateValue() template method of the common two-point gradient approximator match the one of the vertex centered finite volume one -------- 70th commit message: fix fallout from the Big Rebase -------- 71st commit message: ECFV: some bugs in the boundary -------- 72nd commit message: make computeFlux() compute area-specific quantities -------- 73rd commit message: fix more bugs in the element centered FV discretization now eWoms should match Dumux pretty closely... -------- 74th commit message: coalesce the common code of the multi phase porous medium models into "MultiPhaseBaseModel" -------- 75th commit message: update reference solutions these were changed because of the screw-up with the area of boundary segments... -------- 76th commit message: rename "ImplicitBase" to "FvBase" because in eWoms, everything is implicit and these are currently the base classes for all finite volume discretizations. -------- 77th commit message: make the spatial discretization selectable using a splice This requires an opm-core with a the patches from https://github.com/OPM/opm-core/pull/446 merged... -------- 78th commit message: rename the properties used for splices to *Splice -------- 79th commit message: move the files in 'tests/models' to 'tests' since 'tests' was empty except for the 'models' subdirectory... -------- 80th commit message: improve and fix the tutorial -------- 81st commit message: remove the -fno-strict-aliasing flag from the provided option files seems like recent versions of Dune have been adapted... -------- 82nd commit message: also compile all CO2 injection simulations using the element centered finite volume discretization -------- 83rd commit message: PVS model: make it work properly with the element-centered finite volume discretiation because DOF != number of vertices
2013-12-12 05:52:44 -06:00
* \copydoc FvBaseMultiPhaseProblem::materialLawParams
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
*/
template <class Context>
fix most pedantic compiler warnings in the basic infrastructure i.e., using clang 3.8 to compile the test suite with the following flags: ``` -Weverything -Wno-documentation -Wno-documentation-unknown-command -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undef -Wno-padded -Wno-global-constructors -Wno-exit-time-destructors -Wno-weak-vtables -Wno-float-equal ``` should not produce any warnings anymore. In my opinion the only flag which would produce beneficial warnings is -Wdocumentation. This has not been fixed in this patch because writing documentation is left for another day (or, more likely, year). note that this patch consists of a heavy dose of the OPM_UNUSED macro and plenty of static_casts (to fix signedness issues). Fixing the singedness issues were quite a nightmare and the fact that the Dune API is quite inconsistent in that regard was not exactly helpful. :/ Finally this patch includes quite a few formatting changes (e.g., all occurences of 'T &t' should be changed to `T& t`) and some fixes for minor issues which I've found during the excercise. I've made sure that all unit tests the test suite still pass successfully and I've made sure that flow_ebos still works for Norne and that it did not regress w.r.t. performance. (Note that this patch does not fix compiler warnings triggered `ebos` and `flow_ebos` but only those caused by the basic infrastructure or the unit tests.) v2: fix the warnings that occur if the dune-localfunctions module is not available. thanks to [at]atgeirr for testing. v3: fix dune 2.3 build issue
2016-11-07 08:14:07 -06:00
const MaterialLawParams& materialLawParams(const Context& context,
make most indices unsigned (instead of using 'int'.) This triggered quite a few compiler warnings which are also dealt-with by this patch.
2015-11-18 04:54:35 -06:00
unsigned spaceIdx, unsigned timeIdx) const
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
{
fix most pedantic compiler warnings in the basic infrastructure i.e., using clang 3.8 to compile the test suite with the following flags: ``` -Weverything -Wno-documentation -Wno-documentation-unknown-command -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undef -Wno-padded -Wno-global-constructors -Wno-exit-time-destructors -Wno-weak-vtables -Wno-float-equal ``` should not produce any warnings anymore. In my opinion the only flag which would produce beneficial warnings is -Wdocumentation. This has not been fixed in this patch because writing documentation is left for another day (or, more likely, year). note that this patch consists of a heavy dose of the OPM_UNUSED macro and plenty of static_casts (to fix signedness issues). Fixing the singedness issues were quite a nightmare and the fact that the Dune API is quite inconsistent in that regard was not exactly helpful. :/ Finally this patch includes quite a few formatting changes (e.g., all occurences of 'T &t' should be changed to `T& t`) and some fixes for minor issues which I've found during the excercise. I've made sure that all unit tests the test suite still pass successfully and I've made sure that flow_ebos still works for Norne and that it did not regress w.r.t. performance. (Note that this patch does not fix compiler warnings triggered `ebos` and `flow_ebos` but only those caused by the basic infrastructure or the unit tests.) v2: fix the warnings that occur if the dune-localfunctions module is not available. thanks to [at]atgeirr for testing. v3: fix dune 2.3 build issue
2016-11-07 08:14:07 -06:00
const GlobalPosition& pos = context.pos(spaceIdx, timeIdx);
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
if (isFineMaterial_(pos))
return fineMaterialParams_;
return coarseMaterialParams_;
}
/*!
adapt to the refactoring of the thermal laws in opm-material
2017-12-11 05:58:30 -06:00
* \brief Return the parameters for the heat storage law of the rock
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
*
* In this case, we assume the rock-matrix to be granite.
*/
template <class Context>
adapt to the refactoring of the thermal laws in opm-material
2017-12-11 05:58:30 -06:00
const SolidEnergyLawParams&
remove use of Unused.hpp
2022-08-02 03:40:48 -05:00
solidEnergyLawParams(const Context& /*context*/,
unsigned /*spaceIdx*/,
unsigned /*timeIdx*/) const
consistently rename "heat conduction" to "thermal conduction" and use "solid energy" laws according to wikipedia the term "heat" is the energy transferred due to a temperature gradient, i.e., it only makes sense if such a gradient is present and this is not necessary for the storage term. this means that technically the term "heat conductivity" is meaningful, but "thermal conductivity" is IMO more consistent. this has partially already been done in opm-material and eWoms it was pretty inconsistent, so it also requires a patch in opm-material.
2018-01-04 08:26:07 -06:00
{ return solidEnergyLawParams_; }
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
/*!
consistently rename "heat conduction" to "thermal conduction" and use "solid energy" laws according to wikipedia the term "heat" is the energy transferred due to a temperature gradient, i.e., it only makes sense if such a gradient is present and this is not necessary for the storage term. this means that technically the term "heat conductivity" is meaningful, but "thermal conductivity" is IMO more consistent. this has partially already been done in opm-material and eWoms it was pretty inconsistent, so it also requires a patch in opm-material.
2018-01-04 08:26:07 -06:00
* \copydoc FvBaseMultiPhaseProblem::thermalConductionParams
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
*/
template <class Context>
consistently rename "heat conduction" to "thermal conduction" and use "solid energy" laws according to wikipedia the term "heat" is the energy transferred due to a temperature gradient, i.e., it only makes sense if such a gradient is present and this is not necessary for the storage term. this means that technically the term "heat conductivity" is meaningful, but "thermal conductivity" is IMO more consistent. this has partially already been done in opm-material and eWoms it was pretty inconsistent, so it also requires a patch in opm-material.
2018-01-04 08:26:07 -06:00
const ThermalConductionLawParams &
thermalConductionLawParams(const Context& context,
adapt to the refactoring of the thermal laws in opm-material
2017-12-11 05:58:30 -06:00
unsigned spaceIdx,
unsigned timeIdx) const
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
{
fix most pedantic compiler warnings in the basic infrastructure i.e., using clang 3.8 to compile the test suite with the following flags: ``` -Weverything -Wno-documentation -Wno-documentation-unknown-command -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undef -Wno-padded -Wno-global-constructors -Wno-exit-time-destructors -Wno-weak-vtables -Wno-float-equal ``` should not produce any warnings anymore. In my opinion the only flag which would produce beneficial warnings is -Wdocumentation. This has not been fixed in this patch because writing documentation is left for another day (or, more likely, year). note that this patch consists of a heavy dose of the OPM_UNUSED macro and plenty of static_casts (to fix signedness issues). Fixing the singedness issues were quite a nightmare and the fact that the Dune API is quite inconsistent in that regard was not exactly helpful. :/ Finally this patch includes quite a few formatting changes (e.g., all occurences of 'T &t' should be changed to `T& t`) and some fixes for minor issues which I've found during the excercise. I've made sure that all unit tests the test suite still pass successfully and I've made sure that flow_ebos still works for Norne and that it did not regress w.r.t. performance. (Note that this patch does not fix compiler warnings triggered `ebos` and `flow_ebos` but only those caused by the basic infrastructure or the unit tests.) v2: fix the warnings that occur if the dune-localfunctions module is not available. thanks to [at]atgeirr for testing. v3: fix dune 2.3 build issue
2016-11-07 08:14:07 -06:00
const GlobalPosition& pos = context.pos(spaceIdx, timeIdx);
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
if (isFineMaterial_(pos))
consistently rename "heat conduction" to "thermal conduction" and use "solid energy" laws according to wikipedia the term "heat" is the energy transferred due to a temperature gradient, i.e., it only makes sense if such a gradient is present and this is not necessary for the storage term. this means that technically the term "heat conductivity" is meaningful, but "thermal conductivity" is IMO more consistent. this has partially already been done in opm-material and eWoms it was pretty inconsistent, so it also requires a patch in opm-material.
2018-01-04 08:26:07 -06:00
return fineThermalCondParams_;
return coarseThermalCondParams_;
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
}
//! \}
/*!
* \name Boundary conditions
*/
//! \{
/*!
replace a few now-incorrect "Vcfv" prefixes in the comments
2014-07-17 10:24:48 -05:00
* \copydoc FvBaseProblem::boundary
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
*/
template <class Context>
fix most pedantic compiler warnings in the basic infrastructure i.e., using clang 3.8 to compile the test suite with the following flags: ``` -Weverything -Wno-documentation -Wno-documentation-unknown-command -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undef -Wno-padded -Wno-global-constructors -Wno-exit-time-destructors -Wno-weak-vtables -Wno-float-equal ``` should not produce any warnings anymore. In my opinion the only flag which would produce beneficial warnings is -Wdocumentation. This has not been fixed in this patch because writing documentation is left for another day (or, more likely, year). note that this patch consists of a heavy dose of the OPM_UNUSED macro and plenty of static_casts (to fix signedness issues). Fixing the singedness issues were quite a nightmare and the fact that the Dune API is quite inconsistent in that regard was not exactly helpful. :/ Finally this patch includes quite a few formatting changes (e.g., all occurences of 'T &t' should be changed to `T& t`) and some fixes for minor issues which I've found during the excercise. I've made sure that all unit tests the test suite still pass successfully and I've made sure that flow_ebos still works for Norne and that it did not regress w.r.t. performance. (Note that this patch does not fix compiler warnings triggered `ebos` and `flow_ebos` but only those caused by the basic infrastructure or the unit tests.) v2: fix the warnings that occur if the dune-localfunctions module is not available. thanks to [at]atgeirr for testing. v3: fix dune 2.3 build issue
2016-11-07 08:14:07 -06:00
void boundary(BoundaryRateVector& values, const Context& context,
make most indices unsigned (instead of using 'int'.) This triggered quite a few compiler warnings which are also dealt-with by this patch.
2015-11-18 04:54:35 -06:00
unsigned spaceIdx, unsigned timeIdx) const
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
{
fix most pedantic compiler warnings in the basic infrastructure i.e., using clang 3.8 to compile the test suite with the following flags: ``` -Weverything -Wno-documentation -Wno-documentation-unknown-command -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undef -Wno-padded -Wno-global-constructors -Wno-exit-time-destructors -Wno-weak-vtables -Wno-float-equal ``` should not produce any warnings anymore. In my opinion the only flag which would produce beneficial warnings is -Wdocumentation. This has not been fixed in this patch because writing documentation is left for another day (or, more likely, year). note that this patch consists of a heavy dose of the OPM_UNUSED macro and plenty of static_casts (to fix signedness issues). Fixing the singedness issues were quite a nightmare and the fact that the Dune API is quite inconsistent in that regard was not exactly helpful. :/ Finally this patch includes quite a few formatting changes (e.g., all occurences of 'T &t' should be changed to `T& t`) and some fixes for minor issues which I've found during the excercise. I've made sure that all unit tests the test suite still pass successfully and I've made sure that flow_ebos still works for Norne and that it did not regress w.r.t. performance. (Note that this patch does not fix compiler warnings triggered `ebos` and `flow_ebos` but only those caused by the basic infrastructure or the unit tests.) v2: fix the warnings that occur if the dune-localfunctions module is not available. thanks to [at]atgeirr for testing. v3: fix dune 2.3 build issue
2016-11-07 08:14:07 -06:00
const auto& pos = context.pos(spaceIdx, timeIdx);
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
if (onLeftBoundary_(pos)) {
Opm::CompositionalFluidState<Scalar, FluidSystem> fs;
initialFluidState_(fs, context, spaceIdx, timeIdx);
fs.checkDefined();
// impose an freeflow boundary condition
values.setFreeFlow(context, spaceIdx, timeIdx, fs);
}
else if (onInlet_(pos)) {
RateVector massRate(0.0);
massRate[contiCO2EqIdx] = -1e-3; // [kg/(m^3 s)]
[cleanup] replace typedef by using
2020-06-10 06:49:42 -05:00
using FluidState = Opm::ImmiscibleFluidState<Scalar, FluidSystem>;
adapt to the recent opm-material API change w.r.t. the ParameterCache this is necessary to allow non-trivial ParameterCache objects with Local-AD evaluations. So far, the only fluid system in opm-material which needs this is the Spe5 fluid system (which is unused by eWoms), but sooner or later this change would have been required anyway. Note that it is possible that this patch is errornous if Evaluation != Scalar for a fluid system that uses a non-trivial ParameterCache object, but the errors should be relatively easy to fix...
2016-04-13 06:32:15 -05:00
FluidState fs;
adapt to the recent renames of the phase indices in opm-material
2014-04-03 09:59:48 -05:00
fs.setSaturation(gasPhaseIdx, 1.0);
make the CO2 injection problem usable with AD and use automatic differentiation for the simulator of the non-isothermal immiscible co2 injection problem.
2015-05-21 09:18:40 -05:00
const auto& pg =
context.intensiveQuantities(spaceIdx, timeIdx).fluidState().pressure(gasPhaseIdx);
fs.setPressure(gasPhaseIdx, Toolbox::value(pg));
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
fs.setTemperature(temperature(context, spaceIdx, timeIdx));
adapt to the recent opm-material API change w.r.t. the ParameterCache this is necessary to allow non-trivial ParameterCache objects with Local-AD evaluations. So far, the only fluid system in opm-material which needs this is the Spe5 fluid system (which is unused by eWoms), but sooner or later this change would have been required anyway. Note that it is possible that this patch is errornous if Evaluation != Scalar for a fluid system that uses a non-trivial ParameterCache object, but the errors should be relatively easy to fix...
2016-04-13 06:32:15 -05:00
typename FluidSystem::template ParameterCache<Scalar> paramCache;
adapt to the recent renames of the phase indices in opm-material
2014-04-03 09:59:48 -05:00
paramCache.updatePhase(fs, gasPhaseIdx);
adapt to the recent opm-material API change w.r.t. the ParameterCache this is necessary to allow non-trivial ParameterCache objects with Local-AD evaluations. So far, the only fluid system in opm-material which needs this is the Spe5 fluid system (which is unused by eWoms), but sooner or later this change would have been required anyway. Note that it is possible that this patch is errornous if Evaluation != Scalar for a fluid system that uses a non-trivial ParameterCache object, but the errors should be relatively easy to fix...
2016-04-13 06:32:15 -05:00
Scalar h = FluidSystem::template enthalpy<FluidState, Scalar>(fs, paramCache, gasPhaseIdx);
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
make the CO2 injection problem usable with AD and use automatic differentiation for the simulator of the non-isothermal immiscible co2 injection problem.
2015-05-21 09:18:40 -05:00
// impose an forced inflow boundary condition for pure CO2
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
values.setMassRate(massRate);
values.setEnthalpyRate(massRate[contiCO2EqIdx] * h);
}
else
// no flow on top and bottom
values.setNoFlow();
}
// \}
/*!
rename "(Volume|Flux)Variables" to "(In|Ex)tensiveQuantities" "intensive" means that the value of these quantities at a given spatial location does not depend on any value of the neighboring intensive quantities. In contrast, "extensive" quantities depend in the intensive quantities of the environment of the spatial location. this change is necessary is because the previous nomenclature was very specific to finite volume discretizations, but the models themselves were already rather generic. (i.e., "volume variables" are the intensive quantities of finite volume methods and "flux variables" are the extensive ones.)
2014-06-24 07:54:32 -05:00
* \name Volumetric terms
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
*/
//! \{
/*!
replace a few now-incorrect "Vcfv" prefixes in the comments
2014-07-17 10:24:48 -05:00
* \copydoc FvBaseProblem::initial
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
*/
template <class Context>
fix most pedantic compiler warnings in the basic infrastructure i.e., using clang 3.8 to compile the test suite with the following flags: ``` -Weverything -Wno-documentation -Wno-documentation-unknown-command -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undef -Wno-padded -Wno-global-constructors -Wno-exit-time-destructors -Wno-weak-vtables -Wno-float-equal ``` should not produce any warnings anymore. In my opinion the only flag which would produce beneficial warnings is -Wdocumentation. This has not been fixed in this patch because writing documentation is left for another day (or, more likely, year). note that this patch consists of a heavy dose of the OPM_UNUSED macro and plenty of static_casts (to fix signedness issues). Fixing the singedness issues were quite a nightmare and the fact that the Dune API is quite inconsistent in that regard was not exactly helpful. :/ Finally this patch includes quite a few formatting changes (e.g., all occurences of 'T &t' should be changed to `T& t`) and some fixes for minor issues which I've found during the excercise. I've made sure that all unit tests the test suite still pass successfully and I've made sure that flow_ebos still works for Norne and that it did not regress w.r.t. performance. (Note that this patch does not fix compiler warnings triggered `ebos` and `flow_ebos` but only those caused by the basic infrastructure or the unit tests.) v2: fix the warnings that occur if the dune-localfunctions module is not available. thanks to [at]atgeirr for testing. v3: fix dune 2.3 build issue
2016-11-07 08:14:07 -06:00
void initial(PrimaryVariables& values, const Context& context, unsigned spaceIdx,
make most indices unsigned (instead of using 'int'.) This triggered quite a few compiler warnings which are also dealt-with by this patch.
2015-11-18 04:54:35 -06:00
unsigned timeIdx) const
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
{
Opm::CompositionalFluidState<Scalar, FluidSystem> fs;
initialFluidState_(fs, context, spaceIdx, timeIdx);
fix most pedantic compiler warnings in the basic infrastructure i.e., using clang 3.8 to compile the test suite with the following flags: ``` -Weverything -Wno-documentation -Wno-documentation-unknown-command -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undef -Wno-padded -Wno-global-constructors -Wno-exit-time-destructors -Wno-weak-vtables -Wno-float-equal ``` should not produce any warnings anymore. In my opinion the only flag which would produce beneficial warnings is -Wdocumentation. This has not been fixed in this patch because writing documentation is left for another day (or, more likely, year). note that this patch consists of a heavy dose of the OPM_UNUSED macro and plenty of static_casts (to fix signedness issues). Fixing the singedness issues were quite a nightmare and the fact that the Dune API is quite inconsistent in that regard was not exactly helpful. :/ Finally this patch includes quite a few formatting changes (e.g., all occurences of 'T &t' should be changed to `T& t`) and some fixes for minor issues which I've found during the excercise. I've made sure that all unit tests the test suite still pass successfully and I've made sure that flow_ebos still works for Norne and that it did not regress w.r.t. performance. (Note that this patch does not fix compiler warnings triggered `ebos` and `flow_ebos` but only those caused by the basic infrastructure or the unit tests.) v2: fix the warnings that occur if the dune-localfunctions module is not available. thanks to [at]atgeirr for testing. v3: fix dune 2.3 build issue
2016-11-07 08:14:07 -06:00
// const auto& matParams = this->materialLawParams(context, spaceIdx,
reformat the source code this was done semi-automatically. The line length has been set to 80 characters, but with a quite low penalty for crossing this limit.
2013-11-29 09:33:46 -06:00
// timeIdx);
// values.assignMassConservative(fs, matParams, /*inEquilibrium=*/true);
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
values.assignNaive(fs);
}
/*!
replace a few now-incorrect "Vcfv" prefixes in the comments
2014-07-17 10:24:48 -05:00
* \copydoc FvBaseProblem::source
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
*
* For this problem, the source term of all components is 0
* everywhere.
*/
template <class Context>
fix most pedantic compiler warnings in the basic infrastructure i.e., using clang 3.8 to compile the test suite with the following flags: ``` -Weverything -Wno-documentation -Wno-documentation-unknown-command -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undef -Wno-padded -Wno-global-constructors -Wno-exit-time-destructors -Wno-weak-vtables -Wno-float-equal ``` should not produce any warnings anymore. In my opinion the only flag which would produce beneficial warnings is -Wdocumentation. This has not been fixed in this patch because writing documentation is left for another day (or, more likely, year). note that this patch consists of a heavy dose of the OPM_UNUSED macro and plenty of static_casts (to fix signedness issues). Fixing the singedness issues were quite a nightmare and the fact that the Dune API is quite inconsistent in that regard was not exactly helpful. :/ Finally this patch includes quite a few formatting changes (e.g., all occurences of 'T &t' should be changed to `T& t`) and some fixes for minor issues which I've found during the excercise. I've made sure that all unit tests the test suite still pass successfully and I've made sure that flow_ebos still works for Norne and that it did not regress w.r.t. performance. (Note that this patch does not fix compiler warnings triggered `ebos` and `flow_ebos` but only those caused by the basic infrastructure or the unit tests.) v2: fix the warnings that occur if the dune-localfunctions module is not available. thanks to [at]atgeirr for testing. v3: fix dune 2.3 build issue
2016-11-07 08:14:07 -06:00
void source(RateVector& rate,
remove use of Unused.hpp
2022-08-02 03:40:48 -05:00
const Context& /*context*/,
unsigned /*spaceIdx*/,
unsigned /*timeIdx*/) const
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
{ rate = Scalar(0.0); }
//! \}
private:
template <class Context, class FluidState>
fix most pedantic compiler warnings in the basic infrastructure i.e., using clang 3.8 to compile the test suite with the following flags: ``` -Weverything -Wno-documentation -Wno-documentation-unknown-command -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undef -Wno-padded -Wno-global-constructors -Wno-exit-time-destructors -Wno-weak-vtables -Wno-float-equal ``` should not produce any warnings anymore. In my opinion the only flag which would produce beneficial warnings is -Wdocumentation. This has not been fixed in this patch because writing documentation is left for another day (or, more likely, year). note that this patch consists of a heavy dose of the OPM_UNUSED macro and plenty of static_casts (to fix signedness issues). Fixing the singedness issues were quite a nightmare and the fact that the Dune API is quite inconsistent in that regard was not exactly helpful. :/ Finally this patch includes quite a few formatting changes (e.g., all occurences of 'T &t' should be changed to `T& t`) and some fixes for minor issues which I've found during the excercise. I've made sure that all unit tests the test suite still pass successfully and I've made sure that flow_ebos still works for Norne and that it did not regress w.r.t. performance. (Note that this patch does not fix compiler warnings triggered `ebos` and `flow_ebos` but only those caused by the basic infrastructure or the unit tests.) v2: fix the warnings that occur if the dune-localfunctions module is not available. thanks to [at]atgeirr for testing. v3: fix dune 2.3 build issue
2016-11-07 08:14:07 -06:00
void initialFluidState_(FluidState& fs,
const Context& context,
unsigned spaceIdx,
unsigned timeIdx) const
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
{
fix most pedantic compiler warnings in the basic infrastructure i.e., using clang 3.8 to compile the test suite with the following flags: ``` -Weverything -Wno-documentation -Wno-documentation-unknown-command -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undef -Wno-padded -Wno-global-constructors -Wno-exit-time-destructors -Wno-weak-vtables -Wno-float-equal ``` should not produce any warnings anymore. In my opinion the only flag which would produce beneficial warnings is -Wdocumentation. This has not been fixed in this patch because writing documentation is left for another day (or, more likely, year). note that this patch consists of a heavy dose of the OPM_UNUSED macro and plenty of static_casts (to fix signedness issues). Fixing the singedness issues were quite a nightmare and the fact that the Dune API is quite inconsistent in that regard was not exactly helpful. :/ Finally this patch includes quite a few formatting changes (e.g., all occurences of 'T &t' should be changed to `T& t`) and some fixes for minor issues which I've found during the excercise. I've made sure that all unit tests the test suite still pass successfully and I've made sure that flow_ebos still works for Norne and that it did not regress w.r.t. performance. (Note that this patch does not fix compiler warnings triggered `ebos` and `flow_ebos` but only those caused by the basic infrastructure or the unit tests.) v2: fix the warnings that occur if the dune-localfunctions module is not available. thanks to [at]atgeirr for testing. v3: fix dune 2.3 build issue
2016-11-07 08:14:07 -06:00
const GlobalPosition& pos = context.pos(spaceIdx, timeIdx);
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
//////
// set temperature
//////
fs.setTemperature(temperature(context, spaceIdx, timeIdx));
//////
// set saturations
//////
adapt to the recent renames of the phase indices in opm-material
2014-04-03 09:59:48 -05:00
fs.setSaturation(FluidSystem::liquidPhaseIdx, 1.0);
fs.setSaturation(FluidSystem::gasPhaseIdx, 0.0);
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
//////
// set pressures
//////
make the CO2 injection problem usable with AD and use automatic differentiation for the simulator of the non-isothermal immiscible co2 injection problem.
2015-05-21 09:18:40 -05:00
Scalar densityL = FluidSystem::Brine::liquidDensity(temperature_, Scalar(1e5));
reformat the source code this was done semi-automatically. The line length has been set to 80 characters, but with a quite low penalty for crossing this limit.
2013-11-29 09:33:46 -06:00
Scalar depth = maxDepth_ - pos[dim - 1];
Scalar pl = 1e5 - densityL * this->gravity()[dim - 1] * depth;
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
Scalar pC[numPhases];
fix most pedantic compiler warnings in the basic infrastructure i.e., using clang 3.8 to compile the test suite with the following flags: ``` -Weverything -Wno-documentation -Wno-documentation-unknown-command -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undef -Wno-padded -Wno-global-constructors -Wno-exit-time-destructors -Wno-weak-vtables -Wno-float-equal ``` should not produce any warnings anymore. In my opinion the only flag which would produce beneficial warnings is -Wdocumentation. This has not been fixed in this patch because writing documentation is left for another day (or, more likely, year). note that this patch consists of a heavy dose of the OPM_UNUSED macro and plenty of static_casts (to fix signedness issues). Fixing the singedness issues were quite a nightmare and the fact that the Dune API is quite inconsistent in that regard was not exactly helpful. :/ Finally this patch includes quite a few formatting changes (e.g., all occurences of 'T &t' should be changed to `T& t`) and some fixes for minor issues which I've found during the excercise. I've made sure that all unit tests the test suite still pass successfully and I've made sure that flow_ebos still works for Norne and that it did not regress w.r.t. performance. (Note that this patch does not fix compiler warnings triggered `ebos` and `flow_ebos` but only those caused by the basic infrastructure or the unit tests.) v2: fix the warnings that occur if the dune-localfunctions module is not available. thanks to [at]atgeirr for testing. v3: fix dune 2.3 build issue
2016-11-07 08:14:07 -06:00
const auto& matParams = this->materialLawParams(context, spaceIdx, timeIdx);
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
MaterialLaw::capillaryPressures(pC, matParams, fs);
adapt to the recent renames of the phase indices in opm-material
2014-04-03 09:59:48 -05:00
fs.setPressure(liquidPhaseIdx, pl + (pC[liquidPhaseIdx] - pC[liquidPhaseIdx]));
fs.setPressure(gasPhaseIdx, pl + (pC[gasPhaseIdx] - pC[liquidPhaseIdx]));
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
//////
// set composition of the liquid phase
//////
adapt to the recent renames of the phase indices in opm-material
2014-04-03 09:59:48 -05:00
fs.setMoleFraction(liquidPhaseIdx, CO2Idx, 0.005);
fs.setMoleFraction(liquidPhaseIdx, BrineIdx,
1.0 - fs.moleFraction(liquidPhaseIdx, CO2Idx));
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
adapt to the recent opm-material API change w.r.t. the ParameterCache this is necessary to allow non-trivial ParameterCache objects with Local-AD evaluations. So far, the only fluid system in opm-material which needs this is the Spe5 fluid system (which is unused by eWoms), but sooner or later this change would have been required anyway. Note that it is possible that this patch is errornous if Evaluation != Scalar for a fluid system that uses a non-trivial ParameterCache object, but the errors should be relatively easy to fix...
2016-04-13 06:32:15 -05:00
typename FluidSystem::template ParameterCache<Scalar> paramCache;
[cleanup] replace typedef by using
2020-06-10 06:49:42 -05:00
using CFRP = Opm::ComputeFromReferencePhase<Scalar, FluidSystem>;
reformat the source code this was done semi-automatically. The line length has been set to 80 characters, but with a quite low penalty for crossing this limit.
2013-11-29 09:33:46 -06:00
CFRP::solve(fs, paramCache,
adapt to the recent renames of the phase indices in opm-material
2014-04-03 09:59:48 -05:00
/*refPhaseIdx=*/liquidPhaseIdx,
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
/*setViscosity=*/true,
/*setEnthalpy=*/true);
}
fix most pedantic compiler warnings in the basic infrastructure i.e., using clang 3.8 to compile the test suite with the following flags: ``` -Weverything -Wno-documentation -Wno-documentation-unknown-command -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undef -Wno-padded -Wno-global-constructors -Wno-exit-time-destructors -Wno-weak-vtables -Wno-float-equal ``` should not produce any warnings anymore. In my opinion the only flag which would produce beneficial warnings is -Wdocumentation. This has not been fixed in this patch because writing documentation is left for another day (or, more likely, year). note that this patch consists of a heavy dose of the OPM_UNUSED macro and plenty of static_casts (to fix signedness issues). Fixing the singedness issues were quite a nightmare and the fact that the Dune API is quite inconsistent in that regard was not exactly helpful. :/ Finally this patch includes quite a few formatting changes (e.g., all occurences of 'T &t' should be changed to `T& t`) and some fixes for minor issues which I've found during the excercise. I've made sure that all unit tests the test suite still pass successfully and I've made sure that flow_ebos still works for Norne and that it did not regress w.r.t. performance. (Note that this patch does not fix compiler warnings triggered `ebos` and `flow_ebos` but only those caused by the basic infrastructure or the unit tests.) v2: fix the warnings that occur if the dune-localfunctions module is not available. thanks to [at]atgeirr for testing. v3: fix dune 2.3 build issue
2016-11-07 08:14:07 -06:00
bool onLeftBoundary_(const GlobalPosition& pos) const
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
{ return pos[0] < eps_; }
fix most pedantic compiler warnings in the basic infrastructure i.e., using clang 3.8 to compile the test suite with the following flags: ``` -Weverything -Wno-documentation -Wno-documentation-unknown-command -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undef -Wno-padded -Wno-global-constructors -Wno-exit-time-destructors -Wno-weak-vtables -Wno-float-equal ``` should not produce any warnings anymore. In my opinion the only flag which would produce beneficial warnings is -Wdocumentation. This has not been fixed in this patch because writing documentation is left for another day (or, more likely, year). note that this patch consists of a heavy dose of the OPM_UNUSED macro and plenty of static_casts (to fix signedness issues). Fixing the singedness issues were quite a nightmare and the fact that the Dune API is quite inconsistent in that regard was not exactly helpful. :/ Finally this patch includes quite a few formatting changes (e.g., all occurences of 'T &t' should be changed to `T& t`) and some fixes for minor issues which I've found during the excercise. I've made sure that all unit tests the test suite still pass successfully and I've made sure that flow_ebos still works for Norne and that it did not regress w.r.t. performance. (Note that this patch does not fix compiler warnings triggered `ebos` and `flow_ebos` but only those caused by the basic infrastructure or the unit tests.) v2: fix the warnings that occur if the dune-localfunctions module is not available. thanks to [at]atgeirr for testing. v3: fix dune 2.3 build issue
2016-11-07 08:14:07 -06:00
bool onRightBoundary_(const GlobalPosition& pos) const
rename "bbox" to "boundingBox"
2013-12-27 11:25:54 -06:00
{ return pos[0] > this->boundingBoxMax()[0] - eps_; }
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
fix most pedantic compiler warnings in the basic infrastructure i.e., using clang 3.8 to compile the test suite with the following flags: ``` -Weverything -Wno-documentation -Wno-documentation-unknown-command -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undef -Wno-padded -Wno-global-constructors -Wno-exit-time-destructors -Wno-weak-vtables -Wno-float-equal ``` should not produce any warnings anymore. In my opinion the only flag which would produce beneficial warnings is -Wdocumentation. This has not been fixed in this patch because writing documentation is left for another day (or, more likely, year). note that this patch consists of a heavy dose of the OPM_UNUSED macro and plenty of static_casts (to fix signedness issues). Fixing the singedness issues were quite a nightmare and the fact that the Dune API is quite inconsistent in that regard was not exactly helpful. :/ Finally this patch includes quite a few formatting changes (e.g., all occurences of 'T &t' should be changed to `T& t`) and some fixes for minor issues which I've found during the excercise. I've made sure that all unit tests the test suite still pass successfully and I've made sure that flow_ebos still works for Norne and that it did not regress w.r.t. performance. (Note that this patch does not fix compiler warnings triggered `ebos` and `flow_ebos` but only those caused by the basic infrastructure or the unit tests.) v2: fix the warnings that occur if the dune-localfunctions module is not available. thanks to [at]atgeirr for testing. v3: fix dune 2.3 build issue
2016-11-07 08:14:07 -06:00
bool onInlet_(const GlobalPosition& pos) const
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
{ return onRightBoundary_(pos) && (5 < pos[1]) && (pos[1] < 15); }
fix most pedantic compiler warnings in the basic infrastructure i.e., using clang 3.8 to compile the test suite with the following flags: ``` -Weverything -Wno-documentation -Wno-documentation-unknown-command -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undef -Wno-padded -Wno-global-constructors -Wno-exit-time-destructors -Wno-weak-vtables -Wno-float-equal ``` should not produce any warnings anymore. In my opinion the only flag which would produce beneficial warnings is -Wdocumentation. This has not been fixed in this patch because writing documentation is left for another day (or, more likely, year). note that this patch consists of a heavy dose of the OPM_UNUSED macro and plenty of static_casts (to fix signedness issues). Fixing the singedness issues were quite a nightmare and the fact that the Dune API is quite inconsistent in that regard was not exactly helpful. :/ Finally this patch includes quite a few formatting changes (e.g., all occurences of 'T &t' should be changed to `T& t`) and some fixes for minor issues which I've found during the excercise. I've made sure that all unit tests the test suite still pass successfully and I've made sure that flow_ebos still works for Norne and that it did not regress w.r.t. performance. (Note that this patch does not fix compiler warnings triggered `ebos` and `flow_ebos` but only those caused by the basic infrastructure or the unit tests.) v2: fix the warnings that occur if the dune-localfunctions module is not available. thanks to [at]atgeirr for testing. v3: fix dune 2.3 build issue
2016-11-07 08:14:07 -06:00
bool inHighTemperatureRegion_(const GlobalPosition& pos) const
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
{ return (pos[0] > 20) && (pos[0] < 30) && (pos[1] > 5) && (pos[1] < 35); }
consistently rename "heat conduction" to "thermal conduction" and use "solid energy" laws according to wikipedia the term "heat" is the energy transferred due to a temperature gradient, i.e., it only makes sense if such a gradient is present and this is not necessary for the storage term. this means that technically the term "heat conductivity" is meaningful, but "thermal conductivity" is IMO more consistent. this has partially already been done in opm-material and eWoms it was pretty inconsistent, so it also requires a patch in opm-material.
2018-01-04 08:26:07 -06:00
void computeThermalCondParams_(ThermalConductionLawParams& params, Scalar poro)
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
{
Scalar lambdaWater = 0.6;
Scalar lambdaGranite = 2.8;
reformat the source code this was done semi-automatically. The line length has been set to 80 characters, but with a quite low penalty for crossing this limit.
2013-11-29 09:33:46 -06:00
Scalar lambdaWet = std::pow(lambdaGranite, (1 - poro))
* std::pow(lambdaWater, poro);
Scalar lambdaDry = std::pow(lambdaGranite, (1 - poro));
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
adapt to the recent renames of the phase indices in opm-material
2014-04-03 09:59:48 -05:00
params.setFullySaturatedLambda(gasPhaseIdx, lambdaDry);
params.setFullySaturatedLambda(liquidPhaseIdx, lambdaWet);
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
params.setVacuumLambda(lambdaDry);
}
fix most pedantic compiler warnings in the basic infrastructure i.e., using clang 3.8 to compile the test suite with the following flags: ``` -Weverything -Wno-documentation -Wno-documentation-unknown-command -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undef -Wno-padded -Wno-global-constructors -Wno-exit-time-destructors -Wno-weak-vtables -Wno-float-equal ``` should not produce any warnings anymore. In my opinion the only flag which would produce beneficial warnings is -Wdocumentation. This has not been fixed in this patch because writing documentation is left for another day (or, more likely, year). note that this patch consists of a heavy dose of the OPM_UNUSED macro and plenty of static_casts (to fix signedness issues). Fixing the singedness issues were quite a nightmare and the fact that the Dune API is quite inconsistent in that regard was not exactly helpful. :/ Finally this patch includes quite a few formatting changes (e.g., all occurences of 'T &t' should be changed to `T& t`) and some fixes for minor issues which I've found during the excercise. I've made sure that all unit tests the test suite still pass successfully and I've made sure that flow_ebos still works for Norne and that it did not regress w.r.t. performance. (Note that this patch does not fix compiler warnings triggered `ebos` and `flow_ebos` but only those caused by the basic infrastructure or the unit tests.) v2: fix the warnings that occur if the dune-localfunctions module is not available. thanks to [at]atgeirr for testing. v3: fix dune 2.3 build issue
2016-11-07 08:14:07 -06:00
bool isFineMaterial_(const GlobalPosition& pos) const
reformat the source code this was done semi-automatically. The line length has been set to 80 characters, but with a quite low penalty for crossing this limit.
2013-11-29 09:33:46 -06:00
{ return pos[dim - 1] > fineLayerBottom_; }
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
DimMatrix fineK_;
DimMatrix coarseK_;
Scalar fineLayerBottom_;
Scalar finePorosity_;
Scalar coarsePorosity_;
MaterialLawParams fineMaterialParams_;
MaterialLawParams coarseMaterialParams_;
consistently rename "heat conduction" to "thermal conduction" and use "solid energy" laws according to wikipedia the term "heat" is the energy transferred due to a temperature gradient, i.e., it only makes sense if such a gradient is present and this is not necessary for the storage term. this means that technically the term "heat conductivity" is meaningful, but "thermal conductivity" is IMO more consistent. this has partially already been done in opm-material and eWoms it was pretty inconsistent, so it also requires a patch in opm-material.
2018-01-04 08:26:07 -06:00
ThermalConductionLawParams fineThermalCondParams_;
ThermalConductionLawParams coarseThermalCondParams_;
SolidEnergyLawParams solidEnergyLawParams_;
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
Scalar temperature_;
Scalar maxDepth_;
Scalar eps_;
fix most pedantic compiler warnings in the basic infrastructure i.e., using clang 3.8 to compile the test suite with the following flags: ``` -Weverything -Wno-documentation -Wno-documentation-unknown-command -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undef -Wno-padded -Wno-global-constructors -Wno-exit-time-destructors -Wno-weak-vtables -Wno-float-equal ``` should not produce any warnings anymore. In my opinion the only flag which would produce beneficial warnings is -Wdocumentation. This has not been fixed in this patch because writing documentation is left for another day (or, more likely, year). note that this patch consists of a heavy dose of the OPM_UNUSED macro and plenty of static_casts (to fix signedness issues). Fixing the singedness issues were quite a nightmare and the fact that the Dune API is quite inconsistent in that regard was not exactly helpful. :/ Finally this patch includes quite a few formatting changes (e.g., all occurences of 'T &t' should be changed to `T& t`) and some fixes for minor issues which I've found during the excercise. I've made sure that all unit tests the test suite still pass successfully and I've made sure that flow_ebos still works for Norne and that it did not regress w.r.t. performance. (Note that this patch does not fix compiler warnings triggered `ebos` and `flow_ebos` but only those caused by the basic infrastructure or the unit tests.) v2: fix the warnings that occur if the dune-localfunctions module is not available. thanks to [at]atgeirr for testing. v3: fix dune 2.3 build issue
2016-11-07 08:14:07 -06:00
unsigned nTemperature_;
unsigned nPressure_;
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
Scalar pressureLow_, pressureHigh_;
Scalar temperatureLow_, temperatureHigh_;
};
changed: move the Co2InjectionProblem parameters to Opm::Parameters
2024-07-01 07:13:14 -05:00
changed: namespace Ewoms -> namespace Opm
2019-09-05 09:21:10 -05:00
} // namespace Opm
some renames to draw the eWoms directory structure nearer to the the one of the remaining OPM modules this renames the 'test' directory to 'tests' and 'test/implicit' to 'tests/models'. the latter change reflects the fact that in eWoms all models are implicit since the IMPET models have been removed.
2013-09-23 11:56:30 -05:00
#endif
Reference in New Issue Copy Permalink