OilfieldToolsNet/opm-simulators
4
0
Fork 0
mirror of https://github.com/OPM/opm-simulators.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity
16,897 Commits 24 Branches 102 Tags 90 MiB
91fdded473
Commit Graph

16897 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Markus Blatt
31ab752ae6 [fix] Parallel try-catch also added for updateWellControls for groups. 
Not sure whether this is needed, but better safe than sorry.
 2023-11-25 21:04:13 +01:00
Markus Blatt
50c25ead52 [bugfix] Expect singular matrices and terminate updateWellControls. 
We are experiencing singular matrices when solving mulisegment wells
sometimes. In that case (here during
BlackoilModelEbos::assembleReservoir <-
BlackoilModelEbos::initialLinerization <-
BlackoilModelEbos:::nonlinearIterationNewton ) an exception is thrown
when updating the controls of a well.

The problem here is that this exception only happens on one
process. That one goes to the catch block in
NonLinearSolverEbos::step, marks the nonlinear solve as failed and
cuts the time step. The others move to the collective communication
below. Somehow and somewhen all end up in a non-matching collective
communication with different data types and we get an MPI Error that
the message was truncated.

Now all processes will throw, terminate the nonlinear solver and cut
the timestep as it should be.
 2023-11-25 19:32:11 +01:00
Bård Skaflestad
a6d583b9d0
Merge pull request #5024 from blattms/not-warn-loadStep-OutputDir 
Do not warn about OutputDir when combined with LoadStep.
 2023-11-24 19:03:52 +01:00
Bård Skaflestad
6b78dd4ad4
Merge pull request #5021 from atgeirr/nldd-refinements 
Nldd refinements
 2023-11-24 16:40:39 +01:00
Atgeirr Flø Rasmussen
6945b927ec Minor refactoring of domain ordering for NLDD. 2023-11-24 14:57:45 +01:00
Markus Blatt
fa10546c0a Do not warn about OutputDir when combined with LoadStep. 
Both can safely be used together.
 2023-11-24 13:28:20 +01:00
Markus Blatt
24408862ff
Merge pull request #5008 from aritorto/compressedLevelZero 
compressedLevelZero used to read relative permeability
 2023-11-24 13:21:23 +01:00
Bård Skaflestad
cd94ac3a7c
Merge pull request #5023 from totto82/wpimult 
Adapt wdfac to wpimult
 2023-11-23 16:28:32 +01:00
Bård Skaflestad
7343aca2be
Merge pull request #5018 from blattms/parallel-well-fixes 
[fix] Do parallel sums with int instead of bool.
 2023-11-23 16:24:36 +01:00
Bård Skaflestad
4aa1cac099
Merge pull request #5015 from GitPaean/no_explicit_updating 
not updating connection pressure for StandardWell early in computeWellRatesWithBhpIterations.
 2023-11-23 16:20:18 +01:00
Tor Harald Sandve
e1aa233026 Adapt wdfac to wpimult 2023-11-23 15:22:51 +01:00
Atgeirr Flø Rasmussen
6f04c31c7c Use string to enum helper. 2023-11-23 14:06:39 +01:00
Atgeirr Flø Rasmussen
7578fbf144 Change nldd default approach to gauss-seidel. 
Also adjust local CNV tolerance scaling to 0.1 instead of 0.01.
 2023-11-23 14:06:39 +01:00
Atgeirr Flø Rasmussen
94554ea4f2 Change default nldd number of domains to one per 1000 cells. 2023-11-23 14:06:39 +01:00
Atgeirr Flø Rasmussen
8acc8af2a4 Add MaxPressure NLDD domain ordering option, make it default. 2023-11-23 14:06:39 +01:00
Kai Bao
3aed0b9501 not updating the connection pressure for StandardWell 
at the early stage of computeWellRatesWithBhpIterations. The perforation rates are not updated,
and it is not sensible to update based on the inconsistent well rates and perforation rates.

Better to keep the original explicit quantities for better consistency.

Furthermore, it can be dangerous to update the explicit quantities based on the
irrelevant perforation rates, since the ratios can be very undesirable due to crossflow.
 2023-11-23 09:13:57 +01:00
Bård Skaflestad
8f6b2b99e7
Merge pull request #5014 from bska/fix_shut_in_for_non_operable_wells 
Fix shut-in logic for wells with shut-instructions (revised)
 2023-11-22 19:41:56 +01:00
Bård Skaflestad
6f64388f1e Reduce Timestep for Certain Sensitive Tests 
This increases the cost of those tests, but in return we get
improved determinism and stability of the tests.
 2023-11-22 16:53:48 +01:00
Stein Krogstad
b08bc029e6 Fix shut-in logic for wells with shut-intructions 2023-11-22 16:53:48 +01:00
Markus Blatt
6a866ac8d2 [fix] Do parallel sums with int instead of bool. 
Using bool here is at least frowned upon. To be honest, I have no idea
what happens underneath here if we pass a bool. In contrast to other
pod types we do not associate it with a builtin type of MPI (not even
sure what to use). Hence we probably create a custom type for sending
and receiving. That should work. But I have no idea what will be used
for summation.

BTW: I am debugging a case that previously crashed and now suddenly
works and this seems to be the only relevant change I made in the
meantime.
 2023-11-22 16:50:57 +01:00
Bård Skaflestad
82a83d04e2
Merge pull request #5017 from akva2/missing_include 
add missing include
 2023-11-22 15:26:14 +01:00
Bård Skaflestad
8dca5a931e
Merge pull request #5005 from totto82/fixWDFACCOR 
dont scale d factor from wdfaccor with connection factor
 2023-11-22 14:55:51 +01:00
Tor Harald Sandve
be06132702 remove trans multiplier from dake 2023-11-22 13:59:06 +01:00
Tor Harald Sandve
5a6af752e3
Merge pull request #4912 from totto82/fix_bccon 
fix issue when BCPROP is not set initially
 2023-11-22 13:41:19 +01:00
Arne Morten Kvarving
f2a2fc2938 add missing include 2023-11-22 13:18:56 +01:00
Bård Skaflestad
3a01da0a12
Merge pull request #5010 from totto82/cgfrf 
Add output of connection dissolved gas and vaporized oil
 2023-11-22 12:54:33 +01:00
Bård Skaflestad
925d5685a1
Merge pull request #5016 from akva2/fix_gen_headers_superbuild_ninja 
fixed: also add dependency with ninja generator
 2023-11-22 12:51:05 +01:00
Arne Morten Kvarving
0157385668 fixed: also add dependency with ninja generator 2023-11-22 12:27:31 +01:00
Arne Morten Kvarving
06d0e7f877
Merge pull request #4967 from multitalentloes/parallelize_cpu_dilu 
OpenMP parallelize DILU with matrix reordering
 2023-11-22 11:19:23 +01:00
Tobias Meyer Andersen
ee95223b27 Use std::optional to only allocate reordered matrix when using multiple threads 2023-11-22 10:10:29 +01:00
Tor Harald Sandve
4879896789 adapt to refactoring of getDFactor 2023-11-22 09:17:28 +01:00
Tobias Meyer Andersen
e22f4399a0 fix typo 2023-11-22 09:16:43 +01:00
Arne Morten Kvarving
b761b3f08b
Merge pull request #5012 from akva2/vendor_libfmt 
vendor libfmt using FetchContent
 2023-11-22 09:06:38 +01:00
Arne Morten Kvarving
2829ee1f9b
Merge pull request #5013 from akva2/janitoring 
Some janitoring
 2023-11-22 08:33:19 +01:00
Tor Harald Sandve
ecd9930225 dont scale d factor from wdfaccor 2023-11-21 17:51:36 +01:00
Tobias Meyer Andersen
5f6c97ff3b add OpenMP parallelized version of DILU. 
Implement graphcoloring to expose rows in level sets that that can be
executed in parallel during the sparse triangular solves.
Add copy of A matrix that is reordered to ensure continuous memory reads
when traversing the matrix in level set order.
TODO: add number of threads available as constructor argument in DILU
 2023-11-21 15:41:53 +01:00
Arne Morten Kvarving
842af08276 test_graphcoloring: cosmetics 2023-11-21 15:20:07 +01:00
Arne Morten Kvarving
3932cce392 fixed: never include config.h in a header 2023-11-21 15:12:48 +01:00
Arne Morten Kvarving
32dfa0b473 vendor libfmt using FetchContent 2023-11-21 15:10:26 +01:00
Tor Harald Sandve
ee77d30fe5 Add output of connection dissolved gas and vapporized oil 2023-11-21 14:29:40 +01:00
Arne Morten Kvarving
b00d3ca4bb
Merge pull request #5009 from multitalentloes/add_graphcoloring 
add graph coloring
 2023-11-21 10:57:03 +01:00
Tobias Meyer Andersen
e2a531dd65 replace loop with std function, remove print from test 2023-11-21 09:52:48 +01:00
Tobias Meyer Andersen
3cd1873771 add graph coloring 2023-11-20 16:57:56 +01:00
Bård Skaflestad
518df3fa7e
Merge pull request #5007 from akva2/fix_loghelper_test_logger 
fixed: we need to initialize logger before parsing
 2023-11-20 16:30:58 +01:00
Antonella Ritorto
6d180a7f91 compressedLevelZero added in AluCartIdxMapper, used in RelpermDiags 2023-11-20 15:56:17 +01:00
Arne Morten Kvarving
9af3a2f790 fixed: we need to initialize logger before parsing 
parsing logs some errors which meant using uninitialized values
if no logger has been set
 2023-11-20 15:06:52 +01:00
Arne Morten Kvarving
4ccc5cddc7
Merge pull request #5006 from akva2/janitoring 
Some janitoring
 2023-11-20 14:29:45 +01:00
Tobias Meyer Andersen
6ca84a16e1 test_dilu: cosmetics 2023-11-20 13:06:44 +01:00
Tobias Meyer Andersen
54b7f9c44f GraphColoring.hpp: cosmetics 2023-11-20 13:06:40 +01:00
Tobias Meyer Andersen
9309f96d8f GraphColoring.hpp: reorder headers 2023-11-20 13:06:34 +01:00