Commit Graph

24755 Commits

Author SHA1 Message Date
John Ralls
824b515430 Fix qoflog's comments to reflect a preference for the macros over GLib functions. 2021-09-14 15:59:01 -07:00
John Ralls
74d0630867 Bug 798237 - Logging during XML file loading degrades performance...
significantly

Modify the DEBUG and PINFO macros to return unless qof_log_check is
true. Replace almost all direct calls to g_debug and g_message with
DEBUG and PINFO respectively.

Track the highest logging level sent to qof_log_set_level to provide a
short-circuit return in qof_log_check. Remove setting GNC_MOD_TESTS to
QOF_LOG_DEBUG so that the short-circuit threshold isn't defeated by
always being DEBUG.

Net result: 33% improvement in xml load times.
2021-09-14 15:15:11 -07:00
John Ralls
574f567b62 Refactor GncXmlBackend::get_file_lock.
Moving all of the error-handling to it for better clarity and
simplicity. Drop the unnecessary stat call, open will fail with
EEXIST if there's already a lock file. Provide specific messages
for file system failures.
2021-09-14 09:32:12 -07:00
John Ralls
d7eae0664f [gz_open] Use compress and write consistent with calling functions. 2021-09-14 08:29:11 -07:00
John Ralls
8e4c4948cc Put version back to 4.6 2021-09-14 08:28:49 -07:00
Frank H. Ellenberger
3659c2a6a7 L10N:pt: update to PO-Revision-Date: 2021-09-14 06:55+0100 fom TP
5362 translated messages.
2021-09-14 10:36:44 +02:00
Frank H. Ellenberger
41c94e9409 L10N🇬🇧 update to PO-Revision-Date: 2021-09-13 19:25+0300 fom TP
5362 translated messages.
2021-09-14 10:35:09 +02:00
Milo Ivir
36797c1d0a
Translation update by Milo Ivir <mail@milotype.de> using Weblate
po/hr.po: 99.9% (5361 of 5362 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Croatian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hr/

Co-authored-by: Milo Ivir <mail@milotype.de>
2021-09-14 01:29:11 +02:00
Avi Markovitz
7e2111f6f9
Translation update by Avi Markovitz <avi.markovitz@gmail.com> using Weblate
po/he.po: 99.9% (5360 of 5362 strings; 2 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Hebrew)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/he/

Co-authored-by: Avi Markovitz <avi.markovitz@gmail.com>
2021-09-14 01:29:11 +02:00
Yaron Shahrabani
33d780080a
Translation update by Yaron Shahrabani <sh.yaron@gmail.com> using Weblate
po/he.po: 99.9% (5359 of 5362 strings; 2 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Hebrew)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/he/

Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com>
2021-09-14 01:29:10 +02:00
Eric
e43df5a804
Translation update by Eric <spice2wolf@gmail.com> using Weblate
po/zh_CN.po: 99.9% (5358 of 5362 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Chinese (Simplified))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/

Co-authored-by: Eric <spice2wolf@gmail.com>
2021-09-14 01:29:10 +02:00
Christopher Lam
15852031d4 [utest-account.cpp] increase test coverage
adds getter/setter tests for

xaccAccountSetLastNum
xaccAccountSetTaxUSCode
xaccAccountSetTaxUSPayerNameSource
2021-09-14 07:12:15 +08:00
John Ralls
c3f8daaf7d Bug 798250 - Gnucash permanent hang on save while loading report
Prevent WebKit's fork from getting a copy of the pipe's file descriptors
and so keeping the pipe from closing.

Thanks to Simon Arlott for recognizing the FD duplication.
2021-09-13 13:18:10 -07:00
Frank H. Ellenberger
c1525f78bc L10N: 4.7-pre1 msgmerge 2021-09-13 09:34:07 +02:00
John Ralls
edad194389 Bug 798180 - Update to macOS Big Sur 11.3 breaks Finance Quote
Added new dependency Test2 to gnc-fq-update. This is a second-order
dependency of Finanance::Quote that CPAN doesn't seem to recognize
on its own.
2021-09-11 16:09:55 -07:00
John Ralls
b9deb5ea2a Bug 798303 - account list is sorted wrong by amount
Use balances converted to the default currency when sorting columns on
the accounts page.
2021-09-11 10:11:36 -07:00
Christopher Lam
d0f7daf4cf Revert "[engine.i] QofQueryParamList * args must be freed"
This reverts commit 72a3ebbba3. Freeing
does not apply to all qof_query_* calls.
2021-09-11 15:45:32 +08:00
Christopher Lam
72a3ebbba3 [engine.i] QofQueryParamList * args must be freed 2021-09-11 14:59:18 +08:00
John Ralls
b8552a8070 Fix python transaction test_date on Ubuntu-81.04.
Python3 there is too old for fromisoformat, use direct construction
instead.
2021-09-10 17:01:38 -07:00
TianXing_Yi
a310b72b37
Translation update by TianXing_Yi <ytx.cash@gmail.com> using Weblate
po/zh_CN.po: 99.9% (5361 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Chinese (Simplified))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/

Co-authored-by: TianXing_Yi <ytx.cash@gmail.com>
2021-09-10 22:28:34 +02:00
John Ralls
fcab298245 Add test for Transaction GetDate() in python bindings.
Pursuant to Bug 798284.
2021-09-10 13:26:59 -07:00
John Ralls
cd0d50aac1 Deprecate date options with a time of day setting.
Removing the only use, an example in hello-world.scm. GnuCash doesn't
use this value in any of its own report options and the feature will
be removed in GnuCash 5.

Related to bug 798297 Pref "Use 24-hour clock" obsolete?.
2021-09-10 12:21:46 -07:00
jean
34bd7b49b2 Restore previous behavior when the user cancels 2021-09-09 21:38:47 -07:00
John Ralls
ff26b71a91 Bug 798256 - Crash in recnFinishCB
Make the action_group not sensitive in the recn_destroy_cb so that
the action callbacks won't be called after the recnData is freed.
2021-09-09 18:03:18 -07:00
John Ralls
8ab8642e76 Fix leak of trading_splits list in xaccTransClearTradingSplits 2021-09-09 16:32:43 -07:00
John Ralls
1387d5f960 Fix unchecked ptr dereference.
First crash in Bug 798225.
2021-09-09 16:32:43 -07:00
John Ralls
d4bd600596 Fix free-of-unallocated-address crash due to uninitialized ptr. 2021-09-09 16:32:43 -07:00
jean
248a8504b7 Add code to handle ofx files that include transfers between accounts 2021-09-09 11:00:55 -07:00
Christopher Lam
140922a37e QofQuery args must be destroyed after qof_query_merge
qof_query_merge returns a new QofQuery; the two merged QofQueries are
not explicitly destroyed.
2021-09-09 19:19:44 +08:00
cjh
d398a359ca
Translation update by cjh <cjh@cjh0613.com> using Weblate
po/zh_CN.po: 99.9% (5361 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Chinese (Simplified))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/

Co-authored-by: cjh <cjh@cjh0613.com>
2021-09-07 21:21:57 +02:00
John Ralls
e657366468 Merge Yi TianXing's 'remove_FindCustomerDialog_Parameter_ShippingContact' into maint. 2021-09-07 12:20:47 -07:00
John Ralls
ab24c34660 Merge Simon Arlott's 'free-template-root' into maint. 2021-09-07 12:14:41 -07:00
Simon Arlott
4a8acf3fb2 Free template root accounts on book end
The template root should be unset so that it's destroyed when the book is
ending. This is required to free all the template accounts and referenced
strings.

The scheduled transactions themselves need to be freed first so reverse
the order that SXRegister and gnc_sxtt_register are called in
cashobjects_register: The list resulting from that function is traversed
from the bottom up.
2021-09-07 12:11:05 -07:00
Geert Janssens
ae559089d3 Prep early splash screen messages for translation 2021-09-07 12:02:46 +02:00
Robert Fewell
4488568b45 Change text for SX preference option
Change the text of 'Review created transactions' to better align with
existing SX text so use "since last run".
2021-09-07 10:34:10 +01:00
goodvibes2
fa31855640 Rename 2 non public functions to remove leading gnc_
gnc_start_recn_update_cb is now amount_edit_focus_out_cb and
gnc_start_recn_date_changed is now recn_date_changed_cb.
Also add Doxygen comments for amount_edit_focus_out_cb and convert
recn_date_changed_cb comments to Doxygen format.
2021-09-07 10:15:36 +10:00
John Ralls
901fea158f Merge Simon Arlott's 'xml-locking-fixes' into maint. 2021-09-06 15:22:49 -07:00
John Ralls
38cd06e54a Remove the lock-file-link-count test from the XML backend.
This was an effort of somewhat dubious value to detect if a process
on another ocmputer had a hsrd-link to a lockfile on an NFS share.
NFS is rarely used now and SMB doesn't support hard links so this check
adds complexity with no real value.
2021-09-06 15:18:34 -07:00
John Ralls
079a900300 Bug 798298 - Re-imported transactions no longer ignored
Merges Jean Laroche's '798298_reimport_ofx' into maint.
2021-09-06 13:51:26 -07:00
Mike Alexander
068a5d2fa8 Fix xaccSplitGetOtherSplit which was broken by 028bf9826, don't
count splits that aren't really in the transaction.

The rewrite left out one test.  This was most obvious in the dummy
transaction used to enter a new transaction into an account.
xaccSplitGetOtherSplit never returned an "other split" for this
transaction.  It turns out the old code was broken too, but
it worked for this case by coincidence.
2021-09-06 02:45:37 -04:00
jean
4e9fe0a4d1 Add missing function to mock account 2021-09-05 17:52:34 -07:00
Christian Wehling
4afe5d83cf
Translation update by Christian Wehling <christian.wehling@web.de> using Weblate
po/de.po: 99.8% (5358 of 5364 strings; 6 fuzzy)
250 failing checks (4.6%)
Translation: GnuCash/Program (German)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/de/

Co-authored-by: Christian Wehling <christian.wehling@web.de>
2021-09-05 23:35:18 +02:00
jean
d3a056d1ca During transaction import, ignore splits whose account is not the destination account 2021-09-05 10:35:32 -07:00
jean
429a080699 Revert be6fb1abe2 2021-09-04 11:00:42 -07:00
Christian Wehling
82f70ffe00
Translation update by Christian Wehling <christian.wehling@web.de> using Weblate
po/de.po: 99.8% (5357 of 5364 strings; 7 fuzzy)
250 failing checks (4.6%)
Translation: GnuCash/Program (German)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/de/

Co-authored-by: Christian Wehling <christian.wehling@web.de>
2021-09-02 22:34:01 +02:00
TianXing_Yi
849fdd59bc
Translation update by TianXing_Yi <ytx.cash@gmail.com> using Weblate
po/zh_CN.po: 99.7% (5353 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Chinese (Simplified))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/

Co-authored-by: TianXing_Yi <ytx.cash@gmail.com>
2021-09-02 22:34:01 +02:00
Geert Janssens
047673a493 Small refactoring of scm config loading.
- Remove and cleanup duplicate code
- C++-ify
- Run code in gnucash-cli commands related to reports.
  Users may want to load modified report code via
  config-user.scm which they want to access while
  executing cli commands
2021-09-02 16:35:20 +02:00
goodvibes2
d667cf14ad Bug 798235 Reconciliation Ending Balance not recalculated the 2nd and
subsequent times Statement Date is updated.
This was because at end of gnc_start_recn_date_changed(),
gnc_start_recn_update_cb() was called when it should not have been.

This caused the user_set_value flag to be set True (indicating statement
end amount was manually entered - which it wasn't) after the date is
changed. This causes the ending balance to NOT be recalculated when the
end date is subsequently changed.
2021-09-02 11:39:15 +10:00
TianXing_Yi
881d3dcd23
Translation update by TianXing_Yi <ytx.cash@gmail.com> using Weblate
po/zh_CN.po: 99.7% (5353 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Chinese (Simplified))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/

Translation update  by TianXing_Yi <ytx.cash@gmail.com> using Weblate

po/zh_CN.po: 99.7% (5353 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Chinese (Simplified))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/

Co-authored-by: TianXing_Yi <ytx.cash@gmail.com>
2021-08-31 21:56:45 +02:00
John Ralls
9b30a2327b Merge Chris Good's 'MaintGenTrnImpMatFixCrash' into maint. 2021-08-31 12:54:53 -07:00